Commit Graph

48 Commits

Author SHA1 Message Date
Sunny Shao
befb192cb2 Fix the color-check-baseline checker error while repo upload
Fixes: 162044633
Test: pass color-check-baseline verification
Change-Id: Idca9db26db4b73d4b99d73e1b14b2953fc5dc754
2020-07-24 13:25:30 +08:00
Sunny Shao
b4a5f16b2f Workaround for Recent app icon disappear
- Use the ic_home_xxxx.xml to replace the original icon.

Bug: 157623047
Test: manual review
Change-Id: I7a78ba47a0383a5e4c65bd461a15a8425beb1acb
2020-06-16 16:54:21 +08:00
Grace Jia
4fdc471d14 Change SIM colors to follow GAR standards in dark mode in SIM rename
dialog.

Add a color map to map SIM colors in light mode to dark mode. Check
current system dark mode and set the SIM icon color to proper color when
get the view.

Bug: 144693819
Test: Manually set SIM colors to all 6 possibilities and switch from
light mode to dark mode.

Change-Id: I5b947d1d9c949bc6b8cc669d71cd3f5d66ddecb1
2020-05-18 18:00:20 -07:00
Stanley Wang
24863f02bc Update the lint color check file.
Fixes: 147341852
Test: manual
Change-Id: I84a07a7decac27d6e8b447b6734c4f7c296c480e
2020-01-08 19:16:00 +08:00
Raff Tsai
91d9942494 Fix focus on wrong tab
Fixes: 146594840
Test: Robolectric
Change-Id: I14c6d5a4055bee5d0aa413479fb9893e9dfc41df
2019-12-20 12:18:27 +08:00
joshmccloskey
10576db765 Updating colors for dark theme
Bug: 133277663
Test: Verified colors are correct for dark & light themes.
Change-Id: If1aa5f22286d15918cfec3cd4a6436760bf304b2
2019-06-06 16:48:29 -07:00
Fan Zhang
b4b7725937 Revert "Revert "Make subsettings display edge-to-edge""
This reverts commit 9e98b8cf0f.

We have to set clipToPadding false on scrollView to make it extend below
navbar. But the side effect is it stops clipping to padding. So it
overlaps with sibling views. In this case anything pinned on top of
screen (switchbar, pinned header for most UIs, and preview indicator for
font size page).

To fix them:
1. in preview pages, just revert back to clipTo*. Their UI doesn't scroll
   so it they don't need to special clip flag to begin with.
2. For pinned to top headers, we need to change the "z-order" by setting
   elevation and make sure background is not transparent.

Fixes: 132182711
Fixes: 132672399
Test: visually on normal screen, font size scree, wifi main setting UI,
      wifi data usage screen

Reason for revert: Rollforward with fix.

Change-Id: Ib6f7c4167b9a680a336f2a7310d82340094d3aac
2019-05-14 13:48:12 -07:00
Julia Reynolds
c3f7ba9167 Make the selected importance more prominent
Fixes: 129507563
Test: manual
Change-Id: Ic8280eb369d687385cff3a7122ce91d7051fa76c
2019-05-03 19:31:19 +00:00
Julia Reynolds
fc5f111bb9 Update colors
For night mode and a11y

Test: manual
Fixes: 129507563
Change-Id: Ic675cbe0aaf0ccbb18d57729c26b5b55ca907910
2019-05-03 13:33:54 +00:00
Yi-Ling Chuang
db237a6ade Fix the break of repo hook color check.
Add the missing color for notification importance button

Fixes: 130850328
Test: manual
Change-Id: I6c070fad42d5fb0e6d5e3aa00d66b32708dde605
2019-04-19 14:02:35 +08:00
Mill Chen
0c63de2612 Update magnification icon in Accessibility
Also, delete unused png files

Fixes: 129995155
Test: visual
Change-Id: Ie392abea4281beb4799c87d264548369c28940e1
2019-04-10 11:20:14 -07:00
jackqdyulei
36ce63dcb5 Add fp icon with background shape
Fixes: 126425211
Test: RunSettingsRoboTests

Change-Id: I779f76f597b80d73b6dd6eb9e43a96abc9fee0bb
2019-03-22 12:06:36 -07:00
TreeHugger Robot
c48cdcd5f9 Merge "Make BT icon colorful" 2019-03-20 18:51:28 +00:00
Yanting Yang
522b634f98 Update About phone icon background color
Fixes:120810263
Test: visual
Change-Id: I8b91a0ef7ba66ff0f4fbd84c765119266119a4a6
2019-03-20 12:52:18 +08:00
jackqdyulei
7fb5e75752 Make BT icon colorful
Add new method to get rainbow bt icon and also refactor
AdaptiveHomepageIcon:
1. Rename
2. Add ConstantState

Bug: 126425211
Test: RunSettingsRoboTests

Change-Id: Idb8aaf253d0d9e2ab33d8852f093e6689ebadde4
2019-03-19 12:22:38 -07:00
tmfang
0b73c29993 Fix color lint check error
Test: We can upload CL.
Change-Id: Iabe1d918a98167048b86dae1b61d450fb2e8bd97
2019-03-18 11:43:28 +08:00
Doris Ling
c5a1b4f666 Remove all reference to settings_side_margin.
- since the overlay of the value for bigger screen has been removed,
the side margin is now always 0dp. Remove this dimen value and all
reference to it.

Fixes: 124526984
Test: rebuild and visual
Change-Id: I68ff42513a379111042cab9b34594822544e246e
2019-02-21 10:18:00 -08:00
tmfang
af517d51cc Make status bar become 80% of white in homepage.
Test: visual
Change-Id: I005b49306e4c397d9f1fc5062da721709f303a1d
Fixes: 116346521
2019-01-03 11:44:43 +08:00
Johnson Lu
0b0dec957d Refine decorate view of QR Code scanner
1.Draw rounded corner line.
2.Paint 70% white transparency background.

Bug: 118797380
Test: make RunSettingsRoboTests
Change-Id: I1192e32cf4ec801a3efcad4287c2e547deeac3bf
2019-01-02 03:14:12 +00:00
Fan Zhang
5663d5e3bb Merge "Refined the Search Bar layout" 2018-11-30 22:41:41 +00:00
TreeHugger Robot
e78e2061f1 Merge "Fix Wifi-Detail page colors" 2018-11-30 21:45:20 +00:00
Sunny Shao
86b1c7d0b1 Refined the Search Bar layout
Removed the background color of the search bar.
Set the background of the AppBarLayout as transparent.
Set the app bar height.

Bug: 118886724
Test: manual review
Change-Id: I7faedc693ce61d5a5237e8a72909b77b56268a4c
2018-11-30 12:00:15 -08:00
Fan Zhang
8e14ca0058 Remove obsolete logic in SettingsActivity.
mIsShowingDashboard is always false, it used to be true when we are
displaying homepage, but now homepage is hosted in a entirely different
activity.

so all related logic can now be removed.

Test: robotests

Misc clean up: remove unused colors

Test: rebuild, color-lint
Change-Id: I1e1628c1e9606c2b7dc40ef3c21d4ed1391a8c03
2018-11-29 11:37:00 -08:00
Salvador Martinez
807d3d98ec Fix Wifi-Detail page colors
There were some hardcoded colors in this page that should have
been using colorControlNormal. This CL just updates it to use those.

Test: Visual inspection
Fixes: 37628554
Change-Id: I431744e7613eeb0ac751cf1505bcf2ef9e19d95d
2018-11-29 11:17:38 -08:00
Edgar Wang
133c73f5f7 Update icon color for "Accessibility" and "Support & Tips" for Dark mode
Change-Id: I874354f3eb669b36822a3fac7e9160ac19d65d35
Fixes: 119785748
Test: robotests & visual
2018-11-29 15:48:11 +08:00
Fan Zhang
a60652a973 Visual update: remove card elevation for homepage cards.
- Replace CardView with MaterialCardView
- Add strokeColor and strokeWidth to MaterialCardView
- Set cardElevation to 0dp.

And remove a few unused layout, clean up color lint whitelist.

Test: rebuild, visual
Change-Id: I34a4b9a985cb85c212e123b8af5353d8c548923a
2018-11-28 10:42:00 -08:00
Edgar Wang
78e8be5815 Update icon color for "Accessibility" and "Support & Tips"
Change-Id: I8cc9f5fcb6d4ba53cebdc7b580390b0f61194c75
Fixes: 119785748
Test: robotests & visual
2018-11-27 10:13:32 +08:00
Raff Tsai
b92e9d4239 Add BatteryFix Slice
Change-Id: I504df1e9caadced71cc37f8be9207ab9fd26f9ab
Fixes: 114807643
Test: manual
2018-11-21 12:25:06 +08:00
Salvador Martinez
2bb9930866 Update Settings components for dark theme
This CL updates the colors and properties of various themes and
widgets to make them follow dark theme UI. Specifically, it changes
the color accent and uses true black for the background.

Test: manual inspection
Bug: 111397440
Change-Id: I15214a4c5d4864244af856312d2fc3e3a7e7ce36
2018-11-15 15:00:44 -08:00
tmfang
80d03d1d20 Create a new top level Privacy entry
This CL focuses on building up Privacy entry in
Settings homepage.

And also reuse some preferences in here.
-App permission
-Show password

Test: robotest, visual
Change-Id: I724ba4b4845fac933df0fca23a4e1c6afeb73362
Fixes: 116628158
2018-11-12 10:49:10 +08:00
Edgar Wang
992b5038a1 Move "About Phone" to bottom of Settings main IA, above "Tips & Support"
Bug: 118168552
Test: robotests
Change-Id: I0a0f03bdb27d9eea48eb758496eefeebcbc57b6c
2018-11-08 00:56:21 +08:00
tmfang
54a5d37190 Move LocationSettings to top level page.
- Create some location icons for different scenario.
- Remove Location in Security page.
- Move Location Setting to top level page.

Test: robotest, visual
Bug: 116628158
Change-Id: I3f57ef49a396877bfbeaefea7dc4f4051e0ccc65
2018-11-05 11:24:41 +08:00
Doris Ling
8e208c6516 Remove obsolete chart view widgets.
ChartDataUsageView and ChartNetworkSeriesView are no longer being used.
Remove them to avoid the need to maintain obsolete codes.

Bug: 117433810
Test: rebuild and make RunSettingsRoboTests
Change-Id: I0c99725500926083bee693c102a323d563647c3a
2018-10-08 14:18:50 -07:00
Raff Tsai
43a7b18f21 Modify Settings homepage layout
- Add BottomNavigationView which has two tabs
- Remove BottomSheet in layout files

Change-Id: I493290fa9dee0566c73c5c9d7fbba10b71b4e2b4
Fixes: 113266753
Test: visual
2018-09-05 11:55:16 +08:00
Kevin Chyn
520befff01 Add colors to whitelist
export ANDROID_LINT_JARS=$(gettop)/prebuilts/checkcolor/checkcolor.jar
lint --check HardCodedColor --xml color-check-baseline.xml .

Bug: 112005540

Test: builds
Change-Id: Ibac23dda42e797fc01141cbe85d232ba5ea63139
2018-08-15 17:04:42 -07:00
Fan Zhang
a122be1c35 Move non-theme styles to styles.xml
1. Move SUW related themes into its own theme file.
2. Move non-theme styles into styles.xml
3. Move theme styles to themes.xml
4. Group all TextAppearence together in styles.xml
5. And remove some unused resources

Bug: 111454230
Test: manual
Change-Id: I1067a01cf1960bc72ec92528177ac5fcbd4faa3a
2018-07-16 17:59:07 -07:00
Fan Zhang
95c8c89fee Fix color lint baseline. am: 76a0ef6adb
am: 11c9f97a2f

Change-Id: I541566eda1a225d096c8a1210cfff114cef08a05
2018-05-18 14:39:57 -07:00
Fan Zhang
76a0ef6adb Fix color lint baseline.
This is broken by some automerge.

Change-Id: I520eff408ef2d071893b0ed4de3c4e58916bf9fc
Fixes: 79954469
Test: repo preupload
2018-05-18 20:33:45 +00:00
Ching-Sung Li
7c0c7a0626 Update color whitelist for color repohook (caused by auto-merge)
It's blocking CLs to be uploaded to git server becuase inconsistent code
by auto-merge

Test: Can build and upload CLs
Bug: 79954469
Change-Id: I8dfc2cb8d660c6ddc97b3e1c8f06db7db2e15cfb
2018-05-18 12:54:39 -07:00
Salvador Martinez
38c4b38740 Update color whitelist for check color repohook
It is blocking cl's being uploaded due to someone skipping the
repo-hooks.

Test: Can build and upload CL's
Bug: 77478756
Change-Id: I3ae4212fb06a5b82c0afe57dcd839f5a55583cce
2018-04-02 11:32:06 -07:00
Maurice Lam
3e3b8a9618 Make GLIF theme default for confirm lock screen
Use GLIF theme as the default for confirm lock screen, even for
"external" launches of the screen. Renamed the theme from "internal"
to "normal" to reflect this change.
Dark theme code will be cleaned up later.

Test: Existing tests pass
Bug: 62573742
Change-Id: I86958eb3a440d7274807f1cf453c3e53c16c23e7
2018-03-21 18:21:04 -07:00
Andrew Sapperstein
0ff942e5de Delete unused layout: preference_importance_slider.
And its associated colors.

Test: builds
Change-Id: Ibe3f4399b15d97f976a598553b04d92296067a74
2018-02-25 17:05:01 -08:00
Maurice Lam
f5b42777c1 Support GLIF v3 for lock screen settings
Also removed setup_divider_color because it's unused and is causing
a lint error.

Test: cd tests/robotests && mma
Bug: 72702989
Change-Id: I81894be6458439f688c0144d1136d3d7f75afa25
2018-01-30 21:01:42 -08:00
Fan Zhang
d62835a5d4 Add a generic blue background on some homepage tiles
If a homepage tile is injected from external packages, we can't
control what their icons look like, so we put a generic blue circular
background to make it consistent with the other icons.

Change-Id: I2a935db37fff097ae15540262bff94efea55179a
Fixes: 69314641
Test: robotests
2018-01-25 14:18:55 -08:00
Fan Zhang
925a4f8f79 Make homepage icons more colorful!
Change-Id: I84b4744abf8a2955e2a0c54cdfc9261ddd88d3bd
Fixes: 69314641
Test: visual
2018-01-24 10:36:44 -08:00
Fan Zhang
46b5474be4 Update master switch style
- When off, background grey
- When on, background accent
- Switch toggle always white, only change the slider color during on/off

Change-Id: I0ca49439f4e20e75517d503f28cc3068930591e8
Bug: 69462439
Test: robotests
2018-01-10 15:52:20 -08:00
Phil Weaver
0db26b3a87 Add icons for color inversion and daltonizer
For accessibilty settings, both on the main page
and the shortcut picker.

Also now observing settings that could be toggled
by the shortcut, so changes can be reflected immediately
in the settings ui.

Bug: 34621067
Fixes: 70335904
Test: Observe icons in settings and shortcut picker.
Toggling color inversion and color correction now changes
the setting ui immediately.

Change-Id: Id27b6471376059288ff971e5aea72d76078bef36
2017-12-11 10:59:34 -08:00
jackqdyulei
5024a38965 Hook up lint color check to settings
After this cl, settings will run hardcoded color check
(go/color-check-guideline) for all the cls in pre-upload.

This check will prompt error message if cl contains hardcoded color.

Bug: 32750778
Test: repo upload .
Change-Id: Id35ded5199094a14fcc4eeebc470164d052e278e
2017-09-15 11:45:21 -07:00