Commit Graph

49467 Commits

Author SHA1 Message Date
Nathan Harold
7aacdc2c13 Merge "Fix BandMode Dialog Crash on Open due to Style"
am: 7588ef1518

Change-Id: I0dd365652f4deac7b69b181317b0dd86610400a7
2019-01-07 17:16:52 -08:00
Nathan Harold
7588ef1518 Merge "Fix BandMode Dialog Crash on Open due to Style" 2019-01-08 00:18:21 +00:00
Daniel Solomon
60418b4de8 Hide display white balance setting depending on color mode
Display white balance relies on a linear color transform matrix to work
as intended. When the current color mode is COLOR_MODE_SATURATED, this
condition is not guaranteed to be satisfied. In this case, hide the
display white balance setting.

Bug: 116516917

make ROBOTEST_FILTER=DisplayWhiteBalancePreferenceControllerTest
RunSettingsRoboTests -j32

Change-Id: I1fe1eb907485766888832db8b9c342339cc80ea7
2019-01-07 14:44:21 -08:00
Salvador Martinez
1517be0b7f Remove logging for ssids
This is potentially PII so we should not log this. This change
simply removes the lines of logging code.

Test: changing preference does not result in logging
Bug: 117637133
Change-Id: I620ac4cc4eaaf8227b0694e6cc5f9a85d54bc0e8
2019-01-07 14:35:31 -08:00
TreeHugger Robot
2dbdc888c3 Merge "Fix TODO for mobile network settings" 2019-01-07 20:24:13 +00:00
TreeHugger Robot
af2c9b2646 Merge "Fix ConcurrentModificationException in SliceBackgroundWorker" 2019-01-07 20:11:17 +00:00
Jason Chiu
e19658ac36 Fix ConcurrentModificationException in SliceBackgroundWorker
- Two different threads could call SliceBackgroundWorker.getInstance()
  at the same time and caused ConcurrentModificationException
- Add a new API overloading getInstance for each slice to get a nullable
  worker since there is no result data then
- Only slice provider can create a new worker instance in main thread

Test: robotest
Change-Id: I560529bb6034ec22263418adeb7f3ccebf879196
Fixes: 121043385
2019-01-07 20:10:49 +00:00
TreeHugger Robot
8a98decbd6 Merge "Refine the conditionals layout" 2019-01-07 16:52:27 +00:00
TreeHugger Robot
a3d5cd403e Merge "Make filter appear floating in ManagerApplication." 2019-01-07 14:23:57 +00:00
Mill Chen
2ac24f2ceb Refine the conditionals layout
1. Add the minWidth for a button in the condition full tile and adjust
the start margin of the button.
2. Decrease the start padding of the conditional header layout.

Bug: 113451905
Test: visual
Change-Id: I4864730b35154c0bd4b0a806815aa912b19ca3d7
2019-01-07 21:34:07 +08:00
tmfang
5c1d3e96a1 Make filter appear floating in ManagerApplication.
Using new layouts to make filter component appear
floating on top of the page.

The layouts contain the NestedScollView and AppBarLayout.
The NestedScrollView was given a layout_behavior which
defined the behavior of AppBarLayout.

Test: visual
Change-Id: Ia76104f80c6b60ac6c8f5937ebface8e9a7238b5
Fixes: 121148001
2019-01-07 19:23:35 +08:00
Mill Chen
58ae38572a Merge "Implement slice half card" 2019-01-07 08:17:47 +00:00
Mill Chen
6b34d81f36 Merge "Build a way to decide card width" 2019-01-07 08:17:47 +00:00
TreeHugger Robot
577f89deb7 Merge "Refactor slice renderer to handle different card width" 2019-01-07 06:55:31 +00:00
Mill Chen
3559450789 Implement slice half card
To display slice in half width form needs to bind slice, extract the
title and the icon from slice, and finally put the title and the icon
into half card layout.

Bug: 119655434
Test: visual, robotests
Change-Id: Ib390f9a45f0ee609eb9e3499bff74136c7616ac3
2019-01-07 13:39:09 +08:00
Mill Chen
497b3529dc Refactor slice renderer to handle different card width
- Refactor SliceContextualCardRenderer to support for displaying slice
in half/full width card.
- Add two helper classes to separately deal with different card width.

Only the skeleton of the half card helper is put in this CL, the
implementation hasn't been filled in yet. Will implement the detail in
next CL.

Bug: 119655434
Test: visual, robotests
Change-Id: Iacdc90c23bf41cfa7ccae3c0c70a3b663e89307d
2019-01-07 13:34:03 +08:00
TreeHugger Robot
94563cd08b Merge "Improve visual - Collapse the conditionals in all cases" 2019-01-07 05:29:31 +00:00
Mill Chen
8a1bccbc30 Improve visual - Collapse the conditionals in all cases
Changing the threshold value to make collapsing mechanism of conditionals
work in all cases, where the threshold value is changed to 0 from 2.

Bug: 122310542
Test: robotests
Change-Id: I227114acdc6770baa0c133397d08e3ad77f6c572
2019-01-07 05:28:24 +00:00
TreeHugger Robot
d8b3fd3869 Merge "GUP: Add stub UI" 2019-01-05 02:26:04 +00:00
jackqdyulei
b5ce3cd9b0 Fix TODO for mobile network settings
1. Add intent filter to MobileNetworkActivity(new page)
2. Add metrics id
3. Remove obsolete TODOs

Bug: 114749736
Test: Manual
Change-Id: I36f41983dc8cc36ccdf548174fc494044ec1b241
2019-01-04 15:55:09 -08:00
TreeHugger Robot
4e0d53bac8 Merge "Unit test for AppLocationPermissionPreferenceController" 2019-01-04 23:53:38 +00:00
TreeHugger Robot
7a38a2689e Merge "Unit test for RecentLocationAccessPreferenceController" 2019-01-04 23:00:43 +00:00
Ruchi Kandoi
8925004b51 Merge "Add support for FEATURE_NFC_ANDROID_BEAM" am: 6827785e52 am: 39845367ab
am: a7c886925f

Change-Id: I08ff3b1bd80e913aeec9800b1c5ddce69543ba3c
2019-01-04 14:19:23 -08:00
Ruchi Kandoi
a7c886925f Merge "Add support for FEATURE_NFC_ANDROID_BEAM" am: 6827785e52
am: 39845367ab

Change-Id: Ia7fc968221a6eb314a9ee384e0dd84d3aa0e84b4
2019-01-04 14:07:48 -08:00
Ruchi Kandoi
39845367ab Merge "Add support for FEATURE_NFC_ANDROID_BEAM"
am: 6827785e52

Change-Id: I7c71bad831892bf9a853ca5d4777e42c1b3a9171
2019-01-04 13:58:22 -08:00
Yiwei Zhang
c81a03b60e GUP: Add stub UI
Bug: 119221883
Test: make RunSettingsRoboTests ROBOTEST_FILTER=GupDashboardTest

Change-Id: I1f7cc66790e1d1e1de5113e28a055ec5d1679013
2019-01-05 05:55:39 +08:00
Treehugger Robot
6827785e52 Merge "Add support for FEATURE_NFC_ANDROID_BEAM" 2019-01-04 21:49:14 +00:00
Lifu Tang
8b769125bf Unit test for RecentLocationAccessPreferenceController
Bug: 120910747
Test: run unit test
Change-Id: I5a3e4eb3dd9519f0fa1fe1e3f90612ee1cd5762d
2019-01-04 12:46:05 -08:00
Lifu Tang
769a9fb04c Unit test for AppLocationPermissionPreferenceController
Bug: 120910747
Test: build and run the unit test
Change-Id: Id5f79d0f6b143d1ef5e37d75c27a64b4e1dcd9e0
2019-01-04 11:24:06 -08:00
Beverly Tai
5585d5e9d7 Merge "Prevent ringing gesture uses master switch" 2019-01-04 18:36:56 +00:00
TreeHugger Robot
fbe1ddeeae Merge "Fix notification widget's alerting logs" 2019-01-04 17:44:37 +00:00
Philip P. Moltmann
2a65b60e95 Merge "RuntimePermissionPresenter was renamed to PermissionControllerManager" 2019-01-04 17:32:43 +00:00
Julia Reynolds
8ddeb521ec Fix notification widget's alerting logs
- Use last alerted time if available
- Read from channel

Test: manual
Change-Id: I5e3ab7e234c9c6766a1a4dffb5636a633f6b5f2e
Fixes: 74495461
2019-01-04 11:09:35 -05:00
Yanting Yang
7eade17c85 Merge "Update the icon in BluetoothDevicesSlice" 2019-01-04 14:04:27 +00:00
TreeHugger Robot
fca9d221a3 Merge "Centerize contents of contextual cards and remove white space." 2019-01-04 09:26:28 +00:00
Arc Wang
ad9874e14e Merge "Add more Wi-Fi DPP UI features." 2019-01-04 08:55:53 +00:00
Yanting Yang
ca77c76bf9 Update the icon in BluetoothDevicesSlice
- By request from UX team, to update the settings icon of end item.
- Also correct the icon to ic_menu_add in pair new device slice action.

Bug: 114807655
Test: visual, robotests
Change-Id: I5e9f533eec953c415cffea1860608291a3c408a5
2019-01-04 16:49:27 +08:00
Yi-Ling Chuang
1f320fa346 Centerize contents of contextual cards and remove white space.
Decrease the minHeight of the two buttons in the dismissal view and have
the contents centered.

Change-Id: I806e8ccae88e693dc222a13940597fd33684ee70
Fixes: 120086509
Test: visual
2019-01-04 15:43:58 +08:00
Arc Wang
c8cd5d3834 Add more Wi-Fi DPP UI features.
1. Update strings and icons.
2. Add more UI features in WifiDppAddDeviceFragment &
   WifiDppChooseSavedWifiNetworkFragment.

Bug: 118794978
Test: manual test
Change-Id: I2bee3f66732a1083fb13c113695899272e98c23e
2019-01-04 12:17:02 +08:00
TreeHugger Robot
6be224a919 Merge "Change action WIFI_DPP_CONFIGURATOR_CHOOSE_SAVED_WIFI_NETWORK to PROCESS_WIFI_DPP_QR_CODE for more intuitive naming." 2019-01-04 03:29:07 +00:00
TreeHugger Robot
f07a7bd684 Merge changes from topic "status_bar_80%_white"
* changes:
  Fine tune items position of homepage
  Make status bar become 80% of white in homepage.
2019-01-04 03:08:44 +00:00
pastychang
79614823cb Rename prefix from suw to sud
Bug: 120805516
Test: RunSettingsRoboTests
Change-Id: I44a399b586671c100cb9d85c97effbfb1a379413
2019-01-04 10:46:20 +08:00
Stanley Wang
df495130c9 Merge "Fix WiFi calling option is showing in search result regardless the carrier supports VoWiFi or not" 2019-01-04 02:12:54 +00:00
Arc Wang
8e580952c3 Change action WIFI_DPP_CONFIGURATOR_CHOOSE_SAVED_WIFI_NETWORK to
PROCESS_WIFI_DPP_QR_CODE for more intuitive naming.

This change also caches the Wi-Fi DPP QR code in activity for
fragment to use.

Bug: 118794978
Test: manual test
Change-Id: I4bdb021883cb21ce7cc56edf656d1eee079359e5
2019-01-04 09:59:40 +08:00
TreeHugger Robot
fea78b800c Merge "Rename updatable graphics driver to Game Update Package." 2019-01-03 23:06:35 +00:00
TreeHugger Robot
45ae063526 Merge "Update battery dashboard based on spec" 2019-01-03 22:17:19 +00:00
Lei Yu
f1f0cd1f27 Merge "Display BT device even without legal name" 2019-01-03 22:14:50 +00:00
TreeHugger Robot
656c300e94 Merge "Add title support for SlicePreference" 2019-01-03 21:37:41 +00:00
jackqdyulei
fd0f48df86 Update battery dashboard based on spec
Following CL will change "battery suggestion" to card layout.

Bug: 119618813
Test: Screenshot
Change-Id: If71e5c0e4a4e230358aa0c8aa584028082f31d2e
2019-01-03 12:59:12 -08:00
TreeHugger Robot
1b1c2c2209 Merge "Release the media player when the video preference is not visible." 2019-01-03 20:15:33 +00:00