Commit Graph

27005 Commits

Author SHA1 Message Date
TreeHugger Robot
421ca22a58 Merge "Disable Mobile settings in one condition." into qt-dev 2019-04-16 18:20:11 +00:00
TreeHugger Robot
3b8a0b82bf Merge "Change dark theme screen to toggle" into qt-dev 2019-04-16 18:16:54 +00:00
Yanting Yang
d264cd1f78 Merge "Clean up NotificationChannelSlice" into qt-dev am: 1fa45975eb
am: 18e0119391

Change-Id: I5a50640acd53ec59cf3b271800e150e19ac5abf0
2019-04-16 11:12:28 -07:00
TreeHugger Robot
03c461b3ee Merge "Hide filter spinner when data is loading." into qt-dev 2019-04-16 18:07:24 +00:00
Raff Tsai
26bc6a9137 Merge "Tint battery fix icon" into qt-dev am: 77c56714ed
am: fbab258c8b

Change-Id: Ide2f6aacf48b85bac8cd77d02b8e496bba8e8117
2019-04-16 10:53:05 -07:00
Alex Salo
c821ae1ee6 Check for attention permissions
If attention package does not have sufficient permissions - disable the
setting.

Bug: 130246574, 130350903
Test: make RunSettingsRoboTests and manually confirmed
Change-Id: Ia7a86c940522e72f7e895d6aec7500f1ef6f9889
2019-04-16 17:43:15 +00:00
Yanting Yang
18e0119391 Merge "Clean up NotificationChannelSlice" into qt-dev
am: 1fa45975eb

Change-Id: I26f2b0423f60e42a6e34e115426961037abe7768
2019-04-16 10:25:53 -07:00
Raff Tsai
fbab258c8b Merge "Tint battery fix icon" into qt-dev
am: 77c56714ed

Change-Id: I83eb7c34907ebe1b0d4fa953a04bd85b374330b2
2019-04-16 10:13:51 -07:00
TreeHugger Robot
1fa45975eb Merge "Clean up NotificationChannelSlice" into qt-dev 2019-04-16 16:31:22 +00:00
lindatseng
fadedb321c Enforce min value on panel slices slider
We did not set the min value on slider slices when converting them
from preference to slices, which makes the slices all have min 0.
However, there are some slider which should have min value greater
than 0, for example, call and alarm.

We should get the min value and apply it to slider slice to make it
consistent with what we have in settings pref.

Test: Manual verification
Test: make -j40 RunSettingRobotests
Test: atest VolumeSeekBarPreferenceControllerTest
Fixes: 130439216
Fixes: 130358208
Change-Id: Ib4399c36c7da3ac41a6d46a6c150f0ec1b9b0b0f
2019-04-16 16:30:08 +00:00
Matthew Fritze
b6fdd25c23 Add entry animation to Settings Panels.
Settings Panels as a dialog have a default animation for entering the
screen, but Slices complicate the animation. While the dialog enters the
screen, Slices begin to bind, thus changing the height of the dialog as
it enters, causing perceived bounce / jank in the animation.

This CL is cherry-picked/based on ag/6671083 but do the following modification:
(See the original commit message for the whole concept)

When trying to load all the Slices, there are few possible situations:
1. Slice starts loading slowly, starting at state LOADED_NONE
2. Slice is loading in progress, having state LOADED_PARTIAL
3. Slice is loaded, but there's error return from the Slice data (We don't
need to show the Slice in this case)
4. Slice is loaded, progress to state LOADED_ALL
5. Slice starts from state LOADED_NONE, but never progress to the next state
because it crashes at setting backend.

Notice that there are two cases that the state will stay at LOADED_NONE and
we can't distinguish them.

Hence, we decide to do the following:

If Slice is with error (case 3) we remove the slice from the list and mark it
loaded.

If Slice is loaded with LOADED_ALL (case 4, which is the ideal case), we mark
it as loaded.

In the other cases, we fire a handler to mark the slice loaded anyway after
250ms timeout.

When all the slices are marked loaded (which should happen after 250ms timeout,
we will animate the panel out.  Although there might be slices which are still
partial loaded, we can still have the slice in the panel once it is ready.
The panel might bounce/jank in this case, but at least it will still showing
correctly, and should show up smoothly in most cases.

The solution to this problem is twofold:
1. Load all Slices first
2. Create a custom animation to draw the panel once the recyclerview has
been laid out.

Test: Manual/Visual inspection
Test: make -j40 RunSettingsRobotests
Bug: 123942159

Change-Id: I639a707aa4ba3f906bd6f9752c92727aaba28142
2019-04-16 16:29:04 +00:00
TreeHugger Robot
77c56714ed Merge "Tint battery fix icon" into qt-dev 2019-04-16 16:25:34 +00:00
Fan Zhang
4c0cf18c4d Merge "Correct the state when prevent ringing page is launched." into qt-dev am: 957da73a7d
am: 7f7b9e7736

Change-Id: I3eb05af8cb241aa079cdef46855ba4bef3feef6b
2019-04-16 08:45:18 -07:00
Amin Shaikh
f1cf5a684f Merge "Create TintDrawable in Settings." into qt-dev am: c4e7cf594c
am: 900d8c9e12

Change-Id: Ia7d264a229cf2d0d8e65091e604bb24680676857
2019-04-16 08:38:38 -07:00
Fan Zhang
7f7b9e7736 Merge "Correct the state when prevent ringing page is launched." into qt-dev
am: 957da73a7d

Change-Id: I541d0c22788678fc0e9249e35f6aeae1f1ea0e0b
2019-04-16 08:33:30 -07:00
Amin Shaikh
900d8c9e12 Merge "Create TintDrawable in Settings." into qt-dev
am: c4e7cf594c

Change-Id: I8a04a3924d17712b17798109b418c0d4748cf737
2019-04-16 08:28:24 -07:00
Fan Zhang
957da73a7d Merge "Correct the state when prevent ringing page is launched." into qt-dev 2019-04-16 15:22:26 +00:00
TreeHugger Robot
c4e7cf594c Merge "Create TintDrawable in Settings." into qt-dev 2019-04-16 15:16:26 +00:00
Yanting Yang
ce3359f4d4 Clean up NotificationChannelSlice
- Remove unused variable.
- Change function interface.

Bug: 123065955
Test: visual, robotests
Change-Id: I39c0a92539d45cdbc11bd9090a3ab97a72482632
2019-04-16 23:08:40 +08:00
Lei Yu
4ee2e00c18 Merge "Add remote volume slider conditionally." into qt-dev am: ee6825fd5b
am: 65628c28a9

Change-Id: Ie439c23772df2021089bbca3f9bb3c6914ed0ae1
2019-04-16 06:15:00 -07:00
Lei Yu
65628c28a9 Merge "Add remote volume slider conditionally." into qt-dev
am: ee6825fd5b

Change-Id: I030b19ae8d2d843cdb2db93b8900de785bb28a40
2019-04-16 05:58:13 -07:00
TreeHugger Robot
ee6825fd5b Merge "Add remote volume slider conditionally." into qt-dev 2019-04-16 12:46:55 +00:00
Chandan Nath
1e89e94ad8 Merge "If backup service is not available, remove Settings->Backup and Backup->"Backup is disabled by admin" from search results." into qt-dev am: 2ec2c6330e
am: 552c951808

Change-Id: I2b8e38c1e7d5fb291d432f83b3631f3cfaa534e5
2019-04-16 04:51:48 -07:00
Chandan Nath
552c951808 Merge "If backup service is not available, remove Settings->Backup and Backup->"Backup is disabled by admin" from search results." into qt-dev
am: 2ec2c6330e

Change-Id: Ie6744ff497919670f69833cfaa838a526ab3c904
2019-04-16 04:41:54 -07:00
Chandan Nath
2ec2c6330e Merge "If backup service is not available, remove Settings->Backup and Backup->"Backup is disabled by admin" from search results." into qt-dev 2019-04-16 11:21:10 +00:00
Raff Tsai
006582b48e Tint battery fix icon
Fixes: 129492004
Test: manual
Change-Id: I161284619bc47e342d78f1507ae291f7c23ad3ff
2019-04-16 17:05:52 +08:00
Yi-Ling Chuang
9a7ead8962 Hide filter spinner when data is loading.
When the filter spinner is initialized, set GONE to its visibility.
Only make it visible after network cycle data finishes loading to
avoid presenting an empty filter spinner.

Fixes: 130397929
Test: robotests
Change-Id: I740fdad35ec82bc0be386c24e53348917bf6bfba
2019-04-16 16:53:32 +08:00
Arc Wang
994929ecc7 Hide 'Share' button and 'Add device' preference for a Passpoint Wi-Fi network
Passpoint provisioning is much different from other Wi-Fi networks and ZXing
does not support a QR code format to share a passpoint Wi-Fi network. We
should not show any button to share a passpoint Wi-Fi network.

Bug: 130609037
Test: manual
Change-Id: Ie2538ed9e030e5aa2e88452b50b6592223ca46a8
2019-04-16 16:51:04 +08:00
Antony Sargent
70c15513d0 Merge "Fix problem of multiple stacked copies of "Select SIM" dialog" into qt-dev am: 01b633275a
am: eb16066b90

Change-Id: I9b459f89192765b8862d8532a0606c8a4a620534
2019-04-16 01:44:44 -07:00
Antony Sargent
eb16066b90 Merge "Fix problem of multiple stacked copies of "Select SIM" dialog" into qt-dev
am: 01b633275a

Change-Id: Ica76aedb924014e2ed79159ad2e9616a9b93b2a3
2019-04-16 01:40:47 -07:00
TreeHugger Robot
01b633275a Merge "Fix problem of multiple stacked copies of "Select SIM" dialog" into qt-dev 2019-04-16 08:30:30 +00:00
TreeHugger Robot
164bad59e5 Merge "[Network Connection] Show full SSID on list item" 2019-04-16 07:48:02 +00:00
cosmohsieh
faede7ceb9 Implement context menu for ConnectedAccessPointPreference
1) User wants to long press ConnectedAccessPointPreference to forget network if this
is a captive portal network.
2) Change context menu string

Bug: 113756562
Test: make RunSettingsRoboTests -j32 ROBOTEST_FILTER=com.android.settings.wifi
Change-Id: If5c45c45fe126f627eeb53a6c1873a070ad23ae8
(cherry picked from commit 9f8522565a)
2019-04-16 07:35:36 +00:00
Raff Tsai
1bb6c9bfd7 Merge "Remove error slice from Settings in rendering time" into qt-dev am: e128d27a7a
am: 22606bcfdd

Change-Id: I27a1209cd33aadb5b7e45b9e10645746a5f758f5
2019-04-15 23:01:32 -07:00
Edgar Wang
fd42fe1c8f Merge ""Disallow adjust volume" restricted dialog didn't show" into qt-dev am: 83fcc3582e
am: 515d30f819

Change-Id: I514f789d2f96cdbf8806df1d185cf2430b702aa3
2019-04-15 22:37:48 -07:00
Pasty Chang
88569d3469 Merge "Set WifiDialog to light theme in setup flow" into qt-dev am: 997128ee91
am: 686fe46e78

Change-Id: If4070e54092b8e122f937676af39d8dc4dcf4aa6
2019-04-15 22:36:41 -07:00
Raff Tsai
22606bcfdd Merge "Remove error slice from Settings in rendering time" into qt-dev
am: e128d27a7a

Change-Id: I41eb5123dec7ffd7b6b085b2d67ad89033cda742
2019-04-15 22:26:48 -07:00
TreeHugger Robot
e128d27a7a Merge "Remove error slice from Settings in rendering time" into qt-dev 2019-04-16 05:20:58 +00:00
Fan Zhang
5a9173f5ca Merge "Clean up DND slice in search." into qt-dev am: 12ee53f122
am: e2a3670672

Change-Id: I15691e0657ef0e7f54f7b3bce35aeff3dd8f4a9e
2019-04-15 21:56:52 -07:00
Colin Cross
0ff1b6cb01 Merge "Update Settings for guava 27.1" into qt-dev-plus-aosp
am: 2e7a226e65

Change-Id: I94a0ac1545fc0084e895567831ca52217fe53598
2019-04-15 21:33:49 -07:00
Edgar Wang
515d30f819 Merge ""Disallow adjust volume" restricted dialog didn't show" into qt-dev
am: 83fcc3582e

Change-Id: I1a1bb7aa2243b4440bd66b00484bcbddae23ade2
2019-04-15 20:46:16 -07:00
Pasty Chang
686fe46e78 Merge "Set WifiDialog to light theme in setup flow" into qt-dev
am: 997128ee91

Change-Id: Idef21e3f81305fc79de860836d617f041e6353e0
2019-04-15 20:45:25 -07:00
Fan Zhang
e2a3670672 Merge "Clean up DND slice in search." into qt-dev
am: 12ee53f122

Change-Id: Idfa60999ed1202bab9f6f9a737f461f0bbb2e39f
2019-04-15 20:43:50 -07:00
cosmohsieh
151d5a3c83 [Network Connection] Show full SSID on list item
Long SSID will be cut off, because ellipsized. Show full SSID to gain
better UX.

Bug: 130198869
Test: manual
Change-Id: I14376ff7fb922439a2d664433a94740cc06cd99a
2019-04-16 11:38:25 +08:00
Colin Cross
2e7a226e65 Merge "Update Settings for guava 27.1" into qt-dev-plus-aosp 2019-04-16 03:35:51 +00:00
TreeHugger Robot
83fcc3582e Merge ""Disallow adjust volume" restricted dialog didn't show" into qt-dev 2019-04-16 03:12:41 +00:00
Pasty Chang
997128ee91 Merge "Set WifiDialog to light theme in setup flow" into qt-dev 2019-04-16 02:53:29 +00:00
Salvador Martinez
ef7ce46657 Change dark theme screen to toggle
The dark theme screen has been removed in favor of a simple
toggle with a dialog that shows up the first time a user
tries to enable dark theme when in light theme.

Test: robotests pass
Bug: 130251804
Change-Id: I48f8e24a2b2a117e5a8054c5bc0b240ba68fe1ad
2019-04-15 19:52:49 -07:00
Fan Zhang
12ee53f122 Merge "Clean up DND slice in search." into qt-dev 2019-04-16 02:50:10 +00:00
Edgar Wang
73454f2607 "Disallow adjust volume" restricted dialog didn't show
root casue: VolumeSeekBarPreference & SeekBarPreference will return
false when call isSelectable() then this preference won't perform Click

Fixes: 123745455
Test: Manual & robotest
Change-Id: Iba27b503e8a272260c80bd41aecdd5cdbc39f962
2019-04-16 09:41:07 +08:00