Commit Graph

6675 Commits

Author SHA1 Message Date
Hongming Jin
41fb813614 Merge "Migrate emegency default app to role manager." 2019-02-21 20:37:53 +00:00
TreeHugger Robot
7e80e3cabf Merge "Fix test cases for Privacy package" 2019-02-21 19:31:32 +00:00
TreeHugger Robot
c37171f1eb Merge "Dynamically return the uri of WifiSlice." 2019-02-21 18:55:40 +00:00
TreeHugger Robot
f66882f1e1 Merge "developer-options: avoid oem-unlock preference controller crash" 2019-02-21 18:00:23 +00:00
bohu
9bc365febd developer-options: avoid oem-unlock preference controller crash
If there is no FEATURE_TELEPHONY_CARRIERLOCK.

BUG: 123583878

Test: lunch sdk_phone_x86-eng
make -j
emulator
the Settings->System->Developer options should not crash

Test:
make RunSettingsRoboTests ROBOTEST_FILTER=OemUnlockPreferenceControllerTest
should all pass (12 tests: 11 existing and 1 new)

Change-Id: I18c08c1ff1a7860616b0081ede4eb19dcfa8814b
2019-02-21 08:08:12 -08:00
Yi-Ling Chuang
45ee7c2aac Dynamically return the uri of WifiSlice.
WifiSlice is used by both ContextualWifiSlice and WifiSlice itself.
In contextual homepage, we provide contextual_wifi slice for the
homepage. So in our slice pre-check, contextual_wifi slice will gets
pinned and bound. But when it comes to the state where wifi is on but
not connected, it actually returns wifi slice instead of contextual_wifi
slice, which will hit slice not pinned exception as wifi slice never
gets pinned.

Thus, we have to dynamically return the corresponding uri to  avoid this.

Fixes: 124627340
Test: robotests
Change-Id: I54ba255871628bb8eb814442f990a5d1149461e0
2019-02-21 16:14:29 +08:00
Yi-Ling Chuang
dde76e6d5c Make slices precheck executes in parallel.
Slice binding takes up sometime which may cause latency.
Thus, making it run in parallel instead of sequentially to improve the
performance and avoid hitting the timeout problem.

Bug: 124366297
Fixes: 123668403
Test: robotests, unit tests
Change-Id: I5d9fa4605f59e2acef65aadf6fce85df36d8fff1
2019-02-21 15:24:28 +08:00
tmfang
f9cdc3e963 Fix test cases for Privacy package
Test: robotest
Fixes: 124970652
Change-Id: I165a1658a4a40499e0b9ec6dd03ada86b9631b06
2019-02-21 15:19:59 +08:00
Yi-Ling Chuang
daa8ff36cc Use a better way to bind slice for slice precheck.
Calling Slice.bindSlice() directly will cause the exception stating that
slices are not pinned, which sometimes leads to crash. Hence, change the
way we bind slices which handles pinSlice() for us before onBindSlice().

Bug: 120552892
Test: robotests, unit tests
Change-Id: I3e65c6b79876dbee5db6f19387bc6b675f734161
2019-02-21 14:18:01 +08:00
TreeHugger Robot
1de49122d3 Merge "Use MATCH_ALL to query available browsers." 2019-02-20 21:31:21 +00:00
Hongming Jin
6c728dc924 Migrate emegency default app to role manager.
Bug: 123293861
Test: atest DefaultEmergencyPickerTest
Change-Id: I7bd9e2655b22a35fc3268091d38c6770911d4046
2019-02-20 11:46:02 -08:00
Hai Zhang
7bd98d2519 Use MATCH_ALL to query available browsers.
Browser intent resolution has been special for a long time, and we
need to pass MATCH_ALL to get all the candidates, then do manual
filtering later.

Bug: 116216651
Test: manual
Change-Id: I5e9b7b907005f73b7c54c3253c872d85ef7c4863
2019-02-20 11:28:01 -08:00
TreeHugger Robot
8febd82f34 Merge "Add pref for notification swipe direction" 2019-02-20 19:06:42 +00:00
Julia Reynolds
14289bd356 Add pref for notification swipe direction
And move that and other settings under an 'advanced' category

Test: robotests
Fixes: 124099692
Change-Id: I89df276a8bc1cd56ce8530239ca02b2c4b43fa65
2019-02-20 10:36:50 -05:00
TreeHugger Robot
0acd013f03 Merge "Add developer menu to enable/disable ART verifier." 2019-02-20 03:55:40 +00:00
Xiangyu/Malcolm Chen
e67344a5c5 Merge "Correct behavior of "Mobile data" button on opportunistic subscriptions." 2019-02-19 21:04:01 +00:00
Malcolm Chen
5506e0c732 Correct behavior of "Mobile data" button on opportunistic subscriptions.
A check was added earlier to make sure in DSDS mode only one sub
shows data on, which is not true for opportunistic subscriptions. For
them, it should always be on (enforced by Telephony) and be disabled
as it shouldn't be turned off.

Bug: 124331860
Bug: 124683219
Test: manual, robolectric
Change-Id: I53c8d881ff71ad25c418085d3eee63e55c786b8f
2019-02-19 21:03:42 +00:00
TreeHugger Robot
7646786cd3 Merge "Add a util method of creating Icon with Drawable" 2019-02-19 12:25:17 +00:00
Jason Chiu
c78c54a9c6 Add a util method of creating Icon with Drawable
- Add a util method to help create Icon with Drawable so that
users don't need to handle bitmaps
- Add support for creating with ColorDrawable

Test: robotest
Fixes: 124407373
Change-Id: I1897256821cc804a5e599d967feb84a3bcd689a9
2019-02-19 15:51:38 +08:00
TreeHugger Robot
de08e6e901 Merge "Fix janky in App info screen" 2019-02-19 03:48:53 +00:00
Alex Buynytskyy
787a92c983 Add developer menu to enable/disable ART verifier.
The new developer option modifies the global setting "art_verifier_verify_debuggable"; it allows to check if the bytecode of the Debuggable Apps is correct, e.g. if it's using the correct APIs.

Test: make RunSettingsRoboTests ROBOTEST_FILTER=development
Bug: 124403695
Change-Id: I8e721d62c5ca6fb5f26d9b989a8242eece8f55ab
2019-02-18 12:01:25 -08:00
tmfang
7fb266f30b Fix janky in App info screen
If a Recycle view inside in a NestedScrollView,
The times of calling recyclerView#onCreateViewHolder()
is requal to its data set.

When there are large set of apps need to be shown,
RecyclerView will need to take many time to call
onCreateViewHolder for each item.

So, it causes the screen is janky or freeze UI when page
is loading large data set.

For now, we get rid of NestedScrollView, just use RecycleView
and AppBarLayout to have same bahavior for spinner.

Fixes: 124384314
Fixes: 123036231
Fixes: 122964660
Fixes: 123088178

Test: 1. Select show system in App info screen. Observe whether there
is any janky.
2. Select show system in App info screen, and then change device
orientation. Observer whether there is any janky.
3. Go to Settings > Apps & notifications> Advanced > Special app access >
Select "battery optimization", and then Tap drop down and select "all
apps". Observe whether ther is any janky.

Change-Id: Icd65e91eec3b32476d80cc12e9c4baa71151306a
2019-02-18 17:52:03 +08:00
TreeHugger Robot
c53f53c9ed Merge "[Network Connection] Implement "show all" button for NetworkRequestDialog" 2019-02-18 06:19:41 +00:00
TreeHugger Robot
70e97d29ef Merge "[Mac Randomization] Fix MAC randomization option does not work when ephemeral newtork" 2019-02-18 04:29:26 +00:00
cosmohsieh
1e687606dd [Network Connection] Implement "show all" button for
NetworkRequestDialog

Add "show all" button to NetworkRequest dialog to let user be able to
show all AccessPoints of onMatch() callback.

Bug: 117985692
Test: atest NetworkRequestDialogFragmentTest
Change-Id: I604083fd0f3ea98208d860a327733699cd4664d7
2019-02-18 11:42:59 +08:00
TreeHugger Robot
9e9dc49cb8 Merge "Add progress bar for Privacy screen" 2019-02-18 03:04:05 +00:00
cosmohsieh
5cbd97f4ea [Mac Randomization] Fix MAC randomization option does not work when
ephemeral newtork

WifiConfiguration is only available when saved network. So ephemeral
newtork could not have wifi config to config wifi setting. In this
situation, making option be not selectable.

Bug: 122919564
Test: atest WifiPrivacyPreferenceControllerTest
Change-Id: I8a2a1c36ec6d41a6f912da29a8b17bc2e43d9a27
2019-02-18 10:55:42 +08:00
Yanting Yang
29934110dd Merge "Hide "Pair new device" from connected device slice" 2019-02-18 02:46:04 +00:00
Fan Zhang
9859b8b0b0 Fix failing robotest
Fixes: 124531152
Test: robotests
Change-Id: I4442ae543b062ef17b4bfd828134ede879d2b22d
2019-02-15 16:15:39 -08:00
TreeHugger Robot
3f95dfefd5 Merge "Check flag to see whether to show accessibility usage dialog." 2019-02-15 19:09:08 +00:00
Lei Yu
755a7d5b65 Merge "Update battery summary" 2019-02-15 18:26:56 +00:00
Joel Galenson
858fa64d4a Check flag to see whether to show accessibility usage dialog.
Test: Manually set/unset flag, see/don't see dialog.
Test: atest AccessibilityUsagePreferenceControllerTest
Change-Id: I214cf0bf4c67889f48e43fdf774a943dd11e6c34
2019-02-15 08:16:33 -08:00
TreeHugger Robot
9232a4a147 Merge "Update the summary for DND conditional" 2019-02-15 15:42:35 +00:00
Yanting Yang
53656a1749 Hide "Pair new device" from connected device slice
Fixes:124460897
Test: visual, robotests
Change-Id: Id702bf77eacf29d831e00f56d0b1ab9c1f945fbb
2019-02-15 21:03:54 +08:00
Mill Chen
09fedbf7ec Update the summary for DND conditional
Since original string is too long for DND conditional subtext, separate
DND conditional to two different states, one is for "Phone muted" state,
the othe is for "With exceptions" state.

Also, clean up the strings of other product variants for the conditional.

Bug: 122929205
Test: visual
Change-Id: Icb156ff9a4858a26355d92e6d4fb82ad1927b278
2019-02-15 18:37:25 +08:00
TreeHugger Robot
2f6de9967b Merge "Add null check for CarrierConfig" 2019-02-15 03:41:25 +00:00
jackqdyulei
ef3b364728 Update battery summary
When it is charging, show "5% - charging"(not only "5%")

Bug: 112013485
Test: RunSettingsRoboTests
Change-Id: If2299cc4929d8fc40d63669b74590fafe39122dc
2019-02-14 19:11:10 -08:00
tmfang
64f5b796c2 Add progress bar for Privacy screen
We show up top linear progress bar
when Settings is querying permission usage data.

Test: visual, robotest
Fixes: 123539793
Change-Id: I350068856d1708eb054d2a205d9ca857214891ce
2019-02-15 11:01:10 +08:00
TreeHugger Robot
2bd74f7e50 Merge "Add accessibility usage preference to the Privacy screen." 2019-02-14 21:04:32 +00:00
jackqdyulei
26a5023d7f Add null check for CarrierConfig
CarrierConfig maybe null when config loader is not ready, so we need
to add null check here.

Bug: 124447166
Test: RunSettingsRoboTests
Change-Id: I3c104f1ca44bb0bcacad460c68084163c758746a
2019-02-14 12:39:36 -08:00
Brad Ebinger
09285d72bd Merge "Close Wi-Fi Calling screen if provisioning status changes to disallow" 2019-02-14 18:54:55 +00:00
TreeHugger Robot
2f76f51300 Merge "Fix only one "active" HA showing under Accessibility Settings" 2019-02-14 18:03:19 +00:00
Malcolm Chen
0a36e91a49 Don't show hidden subscriptions.
Replace getAvailableSubscriptionInfoList with getSelectableSubscriptionInfoList
so that hidden subscriptions won't show up.

Bug: 121396526
Test: manual
Change-Id: I73c41a6605b68011ba5b619f9d6e8d41d18a9dcd
2019-02-14 02:54:31 +00:00
TreeHugger Robot
57b076fa76 Merge "Add logging for SettingsPanels" 2019-02-14 01:36:30 +00:00
timhypeng
23233700e5 Fix only one "active" HA showing under Accessibility Settings
-return main device on getConnectedHearingAidDevice()
-add test case

Bug: 123777253
Test: make -j42 RunSettingsRoboTests
Change-Id: I63522311b2248df983f200864b5465c0055056da
2019-02-14 01:31:03 +00:00
TreeHugger Robot
cf3c895835 Merge "Robotest fix." 2019-02-14 01:25:39 +00:00
Matthew Fritze
b197110f71 Add logging for SettingsPanels
The 3 main categories are:
- Panel Opened
- Panel Closed
- Panel Slice interaction

There are 3 close events:
- See more button
- Done button
- Clicking outside the panel

Slice interactions will log the Uri of the Slice and the ActionType,
such as Toggle, Slider, Content (intent).

Change-Id: Iecad948f39f50dd12ae1bcb23a5d523e0df8bb98
Fixes: 117804231
Test: robotests
2019-02-13 16:06:24 -08:00
Alex Buynytskyy
0be46defa6 Robotest fix.
Repro: m dist RunSettingsRoboTests ROBOTEST_FILTER=widget

Test: Robolectric test
Change-Id: I4bd4be29ac28d7532bba8aa26d70758c58bd9a0e
2019-02-13 15:57:09 -08:00
TreeHugger Robot
d4fafc0c1f Merge "Make WakeScreen conditionally avaialable" 2019-02-13 23:42:22 +00:00
Lei Yu
bd06923f2f Merge "Update search for mobile network" 2019-02-13 22:43:22 +00:00