Commit Graph

570 Commits

Author SHA1 Message Date
menghanli
6eb3912f31 Accessibility Service & Shortcut Redesign - Primary action - toggle button design
Implements DividerSwitchPreference to replace ToggleSwitch

Bug: 142528112
Test: Manual test

Change-Id: I0d80d16bfa941f7ee333a2c5680a25a26c42809d
2020-02-07 20:49:13 +08:00
TreeHugger Robot
ee1bdcc010 Merge "Support autoclick secondary action (2/n)" 2020-02-07 12:25:10 +00:00
ChenJean
62aab02fc5 Support autoclick secondary action (2/n)
Add LayoutPreference to support new seekbar design.

Bug: 146019277
Test: manual
Change-Id: I8bfe3ca1ccee833fb941076ff33e7536392b90f4
2020-02-07 19:16:10 +08:00
Menghan Li
da645144e0 Merge "Update the shortcut design strings." 2020-02-07 10:42:00 +00:00
Menghan Li
203b9e974f Merge "Fix “Magnify” functionality broken from Vision Settings." 2020-02-07 09:41:15 +00:00
menghanli
4a7734eca3 Fix “Magnify” functionality broken from Vision Settings.
Root cause: Settings items are removed from magnification, so can not call its API in SUW. Will lead to NPE.

Bug: 149071325
Test: Manual Test
Change-Id: Icc75758ddbf330fa6b68d39699a473ac94f97fa3
2020-02-07 08:39:22 +00:00
menghanli
4705d87c4a Update the shortcut design strings.
Bug: 148837311
Test: Manual test

Change-Id: Iac96b3f36e4298aea36bbde5632f701ad1e9572d
2020-02-07 14:23:22 +08:00
Edgar Wang
0934babbfc Make the fragment title can’t searchable
we shouldn't take users so deep into the settings IA because it's easy
to feel lost in settings after clicking on a result without additional
context.

Bug: 143055215
Test: robotest & manual
Change-Id: I337cb5ead31e1e4e7bf9be78132e90630f83ee43
2020-02-06 19:07:11 +08:00
Yiwen Chen
950023fc36 Device config flag clean up.
Test: built and tested on device
Change-Id: I4e64cceca629c0b4c0a5d0a5ec23bc2d75f4aead
2020-02-05 16:15:35 -08:00
Menghan Li
0a832ffe10 Merge "Fix Startup fails when click "Color correction" of the selection menu in "Color correction" page" 2020-02-05 09:47:51 +00:00
Minche Li
bdba2a0427 Merge "Remove the entrance of magnification settings" 2020-02-05 09:46:20 +00:00
Menghan Li
497a736e5a Merge "Change the Settings to app name with settings" 2020-02-05 09:44:02 +00:00
mincheli
02ee1e1715 Remove the entrance of magnification settings
The feature will not be landed in R. So remove the settings UI.

Bug: 146473544
Test: make RunSettingsRoboTests
Change-Id: I602d175d616c4ba1bb9f003a1dc349f58268898f
2020-02-05 08:03:30 +00:00
menghanli
1869e01f3e Fix Startup fails when click "Color correction" of the selection menu in "Color correction" page
Setting provider observar is register onResume() and release of onPause().
The selection menu is activity-base dialog to cause the app does not to monitor the value change.

Bug: 148832544
Test: Manual test
Change-Id: I01354d5096c00ba39336e27aa45169d8768f8594
2020-02-04 17:44:40 +08:00
menghanli
6287ee027c Dynamic Select-To-Speak and Talkback setFragment style on SUW Welcome Screen.
Check the APK target SDK to use corresponding fragment to avoid wrong
status before these app release to R.

Bug: 147997595
Bug: 148394224
Bug: 148438898
Test: Manual test
Change-Id: I3a4ca6b8566f3f731b651e1f785f4fc18319ca89
2020-02-04 17:17:00 +08:00
menghanli
30e5fea655 Change the Settings to app name with settings
Bug: 148837311
Test: Manual test
Change-Id: Ib27fd840c1a33378d9b301658b5d6c9ef148c615
2020-02-04 17:13:18 +08:00
menghanli
c240b27862 Add back "Tapping Stop will stop x" dialog while turning off an accessibility service
Bug: 146539308
Test: make RunSettingsRoboTests2
Change-Id: Ic572f9245db016bd79a272030f97004a21f4b672
2020-02-03 19:17:34 +08:00
menghanli
8e881181a8 Fix "Cannot get activity context when service off".
1. Unify getPrefContext() usage in Accessibility Settings
2. Correct the dialog emuns order

Test: local test
Change-Id: Idc51f7b15b5813bbae7b32e1ae3c7f00c71cea50
2020-02-03 07:13:31 +00:00
menghanli
b82931520f Support accessibility shortcut secondary action (11/n)
Refactor current shortcut design to base fragment and provide
protected function to customize the legacy design,
magnification or no need shortcut app.

Bug: 142530063
Bug: 142531156
Test: make RunSettingsRoboTests2

Change-Id: I51c951ef8f819a1940ddfe33b009b40ed5ec0530
2020-02-02 10:51:44 +08:00
Menghan Li
8003ea4c4c Merge "Support accessibility shortcut secondary action (10/n)" 2020-01-21 10:55:53 +00:00
menghanli
b010a9f9fd Remove select-to-speak toogle button from Vision Settings.
Integrate with shortcut design to to make the UI of Select to
Speak consistent in SUW and general Accessibility settings.

Bug: 148042379
Test: local test
Change-Id: I53fdac604e717303fef9526230b20e9901d55915
2020-01-21 09:08:12 +00:00
menghanli
bf46032074 Support accessibility shortcut secondary action (10/n)
Integrate with Talkback enabled and change the behavior as below:
1. Show 3-finger swipe up from bottom summary
2. Show 3-finger icons for edit shortcut dialog
3. Dismiss the running the edit shortcut dialog

Bug: 142530063
Bug: 142531156
Bug: 147989432
Test: make RunSettingsRoboTests2
Change-Id: I2f34b8eebfdc5a385d72402e95a8b1d0bde4a428
2020-01-21 15:58:43 +08:00
menghanli
c53e60fb80 Remove magnification settings screen from Vision Settings.
Bug: 147468783
Test: local test
Change-Id: I39f8de5d4bc4feaf0f913c07fb802b350f969125
2020-01-20 14:01:21 +00:00
Menghan Li
9fbf51d450 Merge "Support accessibility shortcut secondary action (9/n)" 2020-01-20 13:51:13 +00:00
menghanli
756d819c42 Color correction improvement (5/n)
"Use Color correction" should be replaced by "Correct colors"

Bug: 145968068
Bug: 147988288
Test: make RunSettingsRoboTests2
Change-Id: I90ef36a99b34a82eb9f29f8b79d9aaa8d56441d1
2020-01-20 14:29:30 +08:00
menghanli
87147f55f0 Support accessibility shortcut secondary action (9/n)
Reorder layout and add title for each category block.

Bug: 142530063
Bug: 142531156
Test: make RunSettingsRoboTests2
Change-Id: I0f4067aaf9c42c3ce065eebd0e75ad4153f7e9dc
2020-01-18 00:24:20 +08:00
Menghan Li
8e3ea9d1cf Merge "Talkback shouldn't speak action for description." 2020-01-17 16:10:29 +00:00
Menghan Li
fa240f6cfc Merge "Support autoclick secondary action (1/n)" 2020-01-17 14:13:47 +00:00
ChenJean
7afc1fa6fb Support autoclick secondary action (1/n)
Added radio button preference and control to handle user update value.

Bug: 146019277
Test: Manual
Change-Id: Ie9136f942eec43fc378e7f39d8c2eb7534c531c9
2020-01-17 10:31:07 +00:00
menghanli
097472fc4a Talkback shouldn't speak action for description.
Fix for Select-To-Speak, Talkback, and Magify app.

Bug: 147793421
Bug: 147709365
Bug: 147708796
Test: Manual test
Change-Id: Id7b62c96df869cbd35f2ffbb442b0a4eb7e0393d
2020-01-17 16:10:21 +08:00
TreeHugger Robot
4a70204f51 Merge "Accessibility shortcut secondary action - fix permission dialog did not pop up" 2020-01-17 07:44:02 +00:00
TreeHugger Robot
846f739465 Merge "Support accessibility shortcut secondary action (8/n)" 2020-01-17 01:10:53 +00:00
Menghan Li
f70d04ea0a Merge "Create palette preview for color correction (2/n)." 2020-01-16 15:12:26 +00:00
menghanli
5d0f336fec Support accessibility shortcut secondary action (8/n)
Integrate with the multiple shortcut selections and change the behavior as below:
- Get the shortcut type from system provider or shared_prefs if this is first time to use.
- Update the shared_prefs for what user seen.

Bug: 142530063
Bug: 142531156
Test: make RunSettingsRoboTests2
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AccessibilityUtilTest
Change-Id: I58aeb960e2c4aa0bc2432be34c1372c0de89117a
2020-01-16 22:57:11 +08:00
TreeHugger Robot
bc6bd74228 Merge "Color correction improvement (4/n)" 2020-01-16 14:24:46 +00:00
TreeHugger Robot
7fd5b23da4 Merge "Accessibility shortcut secondary action - fix magnification triple tap logic" 2020-01-16 14:22:55 +00:00
jasonwshsu
c602ceb5ea Accessibility shortcut secondary action - fix permission dialog did not pop up
- Need to set EXTRA_CHECKED after shortcutPreference's checkbox is unchecked

Bug: 142530063
Test: manual
Change-Id: I7f1ea5a9d4b12ac958ac8a074cf7a267faddb4ad
2020-01-16 21:18:21 +08:00
TreeHugger Robot
244afa02d2 Merge "Revert "Settings search - Navigate user to exact page"" 2020-01-16 13:06:24 +00:00
jasonwshsu
620aec5f8c Accessibility shortcut secondary action - fix magnification triple tap logic
- triple tap in settings is boolean status, not string.

Bug: 142530063
Test: make RunSettingsRoboTests -j52 ROBOTEST_FILTER=ToggleScreenMagnificationPreferenceFragmentTest
Change-Id: Ieec9879f7ef55b694245c6f9143575ba933855e5
2020-01-16 18:21:48 +08:00
menghanli
35931974eb Create palette preview for color correction (2/n).
Limit the preview measure for one time to avoid unnecessary
measure and draw performance.

Bug: 145968068
Test: make RunSettingsRoboTests ROBOTEST_FILTER=PaletteListViewTest
Test: make RunSettingsRoboTests2
Change-Id: Ib8ea13e511351c71babcbd1376817cea3a47cac4
2020-01-16 17:55:52 +08:00
Edgar Wang
e19ee9a01f Revert "Settings search - Navigate user to exact page"
This reverts commit 08f2a58459.

Reason for revert: design changed, we decide to take the user to
the entry after clicking on a search result.
It's opposite with what we did, so we revert related CL first.

Test: robotest

Change-Id: Iadb9a94a7ef7838be34a54499e2d934d6396c336
2020-01-16 14:07:38 +08:00
menghanli
cb718d7d25 Color correction improvement (4/n)
Integrate with the multiple shortcut selections and change the behavior as below:
- Register a setting content observer to monitor the service on/off
status to update switch toggle UI.

Bug: 145968068
Test: make RunSettingsRoboTests2
Change-Id: Ib195aab720d965a7a3047070999783fe9525bfd9
2020-01-16 10:35:42 +08:00
jasonwshsu
4605005374 Accessibility shortcut secondary action - correct invisible type fragment checkbox logic
- checkbox logic need to follow shortcutPreference checked status

Bug: 142530063
Test: manual
Change-Id: Ibc079f116c16b6e1c32b573de693b4a23388858c
2020-01-15 20:29:23 +08:00
Minche Li
8b1bf8a477 Merge "Create settings for window magnification (3/n)" 2020-01-15 11:00:04 +00:00
mincheli
5b59e62ecb Create settings for window magnification (3/n)
This change is for internal test.
Add a switch preference for magnification enable mode.

Bug: 146019459
Bug: 146473544
Test: make RunSettingsRoboTests ROBOTEST_FILTER=MagnificationEnablePreferenceControllerTest -j64
Change-Id: I85fdbb5b0efc106d5301d95802b8d6b7dbe8145d
2020-01-15 16:11:38 +08:00
jasonwshsu
64426cc868 Accessibility shortcut secondary action - correct magnification shortcut logic
- correct magnification shortcut logic
- add magnification tests

Bug: 142530063
Test: make RunSettingsRoboTests -j52 ROBOTEST_FILTER=ToggleScreenMagnificationPreferenceFragmentTest
Change-Id: I15f8bccde63570e93e28399bc1730fb1afdb1242
2020-01-15 15:15:38 +08:00
Jason Hsu
d53cbefcc0 Merge "Accessibility shortcut secondary action - handle all preferred shortcut type key" 2020-01-14 05:53:38 +00:00
Jason Hsu
d5095abc91 Merge "Accessibility shortcut secondary action - legacy type fragment only have hardware shortcut" 2020-01-14 05:53:19 +00:00
Jason Hsu
d8e3fbc5f7 Merge "Accessibility shortcut secondary action - Settings view status link with checkbox" 2020-01-14 04:30:10 +00:00
jasonwshsu
fb576356aa Accessibility shortcut secondary action - handle all preferred shortcut type key
- save and restore all preferredShortcutType: SOFTWARE, HARDWARE, TRIPLETAP

Bug: 142530063
Test: manual
Change-Id: I7dd714d1516f49e89c42822241f9cb2b41ae2d2e
2020-01-14 12:15:14 +08:00