Commit Graph

40333 Commits

Author SHA1 Message Date
Daniel Nishi
fb302de0d6 Cache storage values for fast loading.
If the user moves away from the storage fragment and returns, this
allows us to use cached data from the previous calculation. If the data
is > 1 minute old, we consider it stale. Otherwise, we can bypass the
loading screen.

Fixes: 37923463
Test: Settings Robotest

Change-Id: I7650d4d742852f8d447878c077b9190bc0a0bb22
2017-09-05 14:46:14 -07:00
Fan Zhang
657286112f Pre-set initial state to wifi tether switches.
The preset initial state helps eliminating animation jank when first
landing on the page.

Change-Id: Ia7ba83983f18409b1c653cc1ebb0f3aad281358c
Fixes: 64811322
Test: robotests
2017-09-05 13:57:14 -07:00
Stephen Chen
8ffcbccbce Make auto Wi-Fi summary text consistent with feature availability.
"Turn Wi-Fi on automatically" feature is disabled when airplane mode or
battery saver mode is enabled, when Wi-Fi scanning is disabled, or when
network recommendations are disabled / scorer unset. This change
captures these negative cases in the summary text.

Bug: 65085700
Test: make ROBOTEST_FILTER=WifiWakeupPreferenceControllerTest
RunSettingsRoboTests -j40
Change-Id: I2f2d22b5bef3ad03a28d34e79a27e6545cac557f
2017-09-05 13:51:58 -07:00
Alison Cichowlas
eaabcfaa78 Reorder "on the lock screen" options.
Fixes: 62872287
Change-Id: I7b2755e7a33fa1a31cebd18d93d268d330d87794
Test: RunSettingsRoboTests, manual
2017-09-05 19:04:29 +00:00
Adrian Roos
b1758afdf0 Merge "FRP: Use SUW theme for factory reset protection flow" into oc-mr1-dev am: d57edb708f
am: 2faa5e7ac5

Change-Id: I011b521869406bd5db74686bd7c15496a03f54c4
2017-09-05 18:58:22 +00:00
Adrian Roos
2faa5e7ac5 Merge "FRP: Use SUW theme for factory reset protection flow" into oc-mr1-dev
am: d57edb708f

Change-Id: I385acf93d60bfbc98f39aa0178018e3976a39974
2017-09-05 18:55:47 +00:00
TreeHugger Robot
d57edb708f Merge "FRP: Use SUW theme for factory reset protection flow" into oc-mr1-dev 2017-09-05 18:43:30 +00:00
Antony Sargent
c626fcc028 Fix Bluetooth switch status in Connected devices screen
The symptom observed is that the Bluetooth master switch on the
Connected devices page doesn't properly respond to Bluetooth turning off
via quicksettings - either turning on airplane mode or just toggling
Bluetooth.

The root cause was that MasterSwitchPreference's isChecked method would
not return the true value of whether the switch was checked - if the
control is disabled, it always just returns false. This interacts badly
with code in BluetoothEnabler - we disable the switch when the Bluetooth
state is in transition (eg becomes STATE_TURNING_OFF), and we also
attempt to avoid calling setChecked if the switch is already in the
desired state. So the switch would be checked but disabled, and we'd
avoid ever calling setChecked(false) on it.

A thorough fix would be to remove the code from MasterSwitchPreference's
isChecked method that looks at the enabled state, since enabled and
checked really should be treated as separate concerns. But given the
timeframe of MR1, we're opting for a more conservative fix of directly
accessing the switch and checking it's state, to avoid introducing bugs
in other consumers that might be depending on the current
behavior. We'll then do the thorough fix on the master branch which will
give a lot more time for any unexpected issues to be found (I audited
other usages and none seemed likely to be a problem, but it's better to
be safe than sorry).

Change-Id: I19a6c6b71e74595be3ef32a9718a430b67a89d53
Bug: 64940731
Test: make RunSettingsRoboTests
2017-09-05 17:10:30 +00:00
Adrian Roos
1262f39600 FRP: Use SUW theme for factory reset protection flow
Bug: 37224506
Test: adb shell settings put global device_provisioned 0 && adb shell am start -a android.app.action.CONFIRM_FRP_CREDENTIAL com.android.settings; verify it uses correct theme
Change-Id: I237d8d84840398ebfdc97bf99dce07447042b349
2017-09-05 13:52:26 +02:00
edgar.huang
ab6f11f47f Settings is crashed high probability when doing follow steps
Enter into the fingerprint list screen and delete and identification of operation at the same time, when the item of the fingerprint verification was deleted, highlighting the item to be deleted, just so NullPointerException occurred.
Test: manual - enrolling a fingerprint and do above steps.
2017-09-05 06:35:27 +00:00
Daniel Nishi
09ed020f13 Merge "Make photos/videos storage preference normal." into oc-mr1-dev am: 3d1f6abd6f
am: 5467aed58d

Change-Id: Ic5218a18aa0ea099a113a4c45737baf6bfc05e3a
2017-09-02 03:58:04 +00:00
Daniel Nishi
5467aed58d Merge "Make photos/videos storage preference normal." into oc-mr1-dev
am: 3d1f6abd6f

Change-Id: Ic944357091b2cd16115fd4b0f3ff0459090a3e27
2017-09-02 03:39:51 +00:00
TreeHugger Robot
3d1f6abd6f Merge "Make photos/videos storage preference normal." into oc-mr1-dev 2017-09-02 03:29:52 +00:00
Daniel Nishi
9be0ce09c9 Make photos/videos storage preference normal.
We had special behavior for it in the past, but this defines new
behavior that is much closer to what the other storage preferences do.
A photo app filter is used and a photos/video files preference exists on
it which intents over to the gallery app.

Fixes: 64147318
Test: Settings robotests

Change-Id: I47284515fe2dfcc924ae61a44bc47051e9f5fda6
2017-09-01 17:51:56 -07:00
Doris Ling
87ca13d446 Merge "Set drawable for the entity header app preference button." into oc-mr1-dev am: 5fe8e76b36
am: c905662743

Change-Id: Iea22293c41c88fbd9c0a20e71bcfc3972fba17c0
2017-09-02 00:46:36 +00:00
Doris Ling
c905662743 Merge "Set drawable for the entity header app preference button." into oc-mr1-dev
am: 5fe8e76b36

Change-Id: I02625057fd4636f8ce61d5772f7ce4083fb7f81f
2017-09-02 00:41:28 +00:00
TreeHugger Robot
5fe8e76b36 Merge "Set drawable for the entity header app preference button." into oc-mr1-dev 2017-09-02 00:17:08 +00:00
Daniel Nishi
2e47a32605 Merge "Show work profile apps only on app list." into oc-mr1-dev am: 8618b8649f
am: d3e0d745a8

Change-Id: Ieb84a6732af3eacb9d576ecc9cb685cff38b8e20
2017-09-01 23:37:21 +00:00
Amit Mahajan
933a4f062d Merge "Change to disable mvno data field in ApnEditor if needed." into oc-mr1-dev am: cf11e21d47
am: f161b63c2a

Change-Id: I10c73c2b94d521860d569d3fb7ef5560dde4393b
2017-09-01 23:35:35 +00:00
Daniel Nishi
d3e0d745a8 Merge "Show work profile apps only on app list." into oc-mr1-dev
am: 8618b8649f

Change-Id: I8757ff64193dc0754b01aa769e55a355464e2d01
2017-09-01 23:17:06 +00:00
Amit Mahajan
f161b63c2a Merge "Change to disable mvno data field in ApnEditor if needed." into oc-mr1-dev
am: cf11e21d47

Change-Id: Ica848195898e8d88e3882091c2a06ff4e79e55ca
2017-09-01 23:15:59 +00:00
Daniel Nishi
8618b8649f Merge "Show work profile apps only on app list." into oc-mr1-dev 2017-09-01 22:49:21 +00:00
Amit Mahajan
cf11e21d47 Merge "Change to disable mvno data field in ApnEditor if needed." into oc-mr1-dev 2017-09-01 22:42:09 +00:00
Doris Ling
a7b40995de Set drawable for the entity header app preference button.
In the entity header layout, the action buttons resource is set to null by
default. When we bind the button with the app preference action, we
should also set the drawable to the settings icon as well.

Change-Id: Ic259b4c538f529671ca5a9c67664ef32fbbb25ae
Fixes: 64826061
Test: make RunSettingsRoboTests
2017-09-01 14:52:30 -07:00
Daniel Nishi
83ceab82e4 Show work profile apps only on app list.
For the work profile drilldown, we used to show all apps when the user
drilled down into the categories. This makes it so that the drill down
only shows the work apps when that deep.

Change-Id: I492cd3e9b9b923b87b68645a871dcfb2b91b4f95
Fixes: 62963093
Test: Settings robotest
2017-09-01 13:08:48 -07:00
TreeHugger Robot
f4dc03184b Merge "Removed deprecated BIND_AUTOFILL permission." 2017-09-01 15:11:50 +00:00
Julia Reynolds
0e497230d9 Merge "Add settings page for notification channel groups" 2017-09-01 12:49:39 +00:00
Doris Ling
100e8a3891 Update accessibility preference icon. am: f664c77f31
am: c413dd167d

Change-Id: Iccbd479e32a7abdd8e8fbf16274825354dbe5805
2017-09-01 01:15:08 +00:00
Doris Ling
c413dd167d Update accessibility preference icon.
am: f664c77f31

Change-Id: I53d15d3a850f5f0bdae9add3003a00b6e7c80009
2017-09-01 00:47:41 +00:00
TreeHugger Robot
650faa3ace Merge "Fix ClassScanner and re-enable CodeInspectionTest tests" 2017-08-31 23:26:51 +00:00
Colin Cross
c19d2bccbf Merge "Fix errorprone build" am: 0bed3cacd7 -s ours am: a1bcb02184 -s ours am: 450f423a21 -s ours
am: bfab966085  -s ours

Change-Id: I53491f4186ffcdd48c6dc0184018fc982a75d549
2017-08-31 22:43:03 +00:00
Colin Cross
bfab966085 Merge "Fix errorprone build" am: 0bed3cacd7 -s ours am: a1bcb02184 -s ours
am: 450f423a21  -s ours

Change-Id: I4a0aff24c589b0a1eefa97b9f1c9dd144e395303
2017-08-31 22:35:19 +00:00
Colin Cross
450f423a21 Merge "Fix errorprone build" am: 0bed3cacd7 -s ours
am: a1bcb02184  -s ours

Change-Id: Ic3b3ce30a29b967189fae95ec53f52569350fa82
2017-08-31 22:27:59 +00:00
Colin Cross
a1bcb02184 Merge "Fix errorprone build"
am: 0bed3cacd7  -s ours

Change-Id: I3c6b80920db044b842946e373dbc1efddd260de8
2017-08-31 22:24:00 +00:00
Treehugger Robot
0bed3cacd7 Merge "Fix errorprone build" 2017-08-31 22:16:52 +00:00
Doris Ling
f664c77f31 Update accessibility preference icon.
Change-Id: I84fb84e0a8bb422b9e453bd9b94e99bfb8a73be3
Fixes: 65256821
Test: visual
2017-08-31 14:58:15 -07:00
Felipe Leme
b628d1ed53 Removed deprecated BIND_AUTOFILL permission.
Test: make -j100 RunSettingsRoboTests

Bug: 37563972

Change-Id: I423f9c6234e8c1898ed66b22e1078c6f91c58422
2017-08-31 14:28:39 -07:00
Amit Mahajan
a00af97ab1 Change to disable mvno data field in ApnEditor if needed.
Test: manual
Bug: 65243262
Change-Id: I4b3dec6d9dc7fecf0b0a8131dccc349c7daffe48
2017-08-31 21:01:25 +00:00
Antony Sargent
ec452e58a5 Fix ClassScanner and re-enable CodeInspectionTest tests
This fixes the code in ClassScanner for finding all classes in a given
package to not depend on directory entries in the .jar files generated
by the build system. This dependency caused our tests in
CodeInspepectionTest.java to fail when this CL:

https://android-review.googlesource.com/#/c/platform/build/+/456418/

stopped adding directory entries in the .jar files generated by the
build process. Instead of depending on directories being present in the
list of resources provided by the classloader, this CL switches to using
Guava's ClassPath class to enumerate all loadable classes and filter
them to the ones in the package of interest.

Change-Id: I583919096450b61d4816256be280e2f5f1ce2316
Fixes: 64840107
Test: make RunSettingsRoboTests
2017-08-31 14:00:15 -07:00
Alison Cichowlas
3e5c6f718a Merge "Legacy channels say "allow sound" instead of "let the app decide". We had this string already translated from use in previous ux revs." into oc-mr1-dev am: 49d25a0506
am: 4010eb294f

Change-Id: Iaa85e2d06431bd92886aafc8b94b36c20de46eef
2017-08-31 20:23:27 +00:00
Alison Cichowlas
4010eb294f Merge "Legacy channels say "allow sound" instead of "let the app decide". We had this string already translated from use in previous ux revs." into oc-mr1-dev
am: 49d25a0506

Change-Id: I3cd8b74fd35dbbdb73512a15f368a527119a9c20
2017-08-31 20:10:19 +00:00
Jack He
0921319824 Merge "Bluetooth: do not dimiss fragment when Activity.finish() is called" into oc-mr1-dev am: bf66bf30b1
am: 4dddaf18e1

Change-Id: I249a0a3fc1a8c030041cfca8b3dbd49bc2badf07
2017-08-31 19:54:20 +00:00
TreeHugger Robot
49d25a0506 Merge "Legacy channels say "allow sound" instead of "let the app decide". We had this string already translated from use in previous ux revs." into oc-mr1-dev 2017-08-31 19:51:50 +00:00
Jack He
4dddaf18e1 Merge "Bluetooth: do not dimiss fragment when Activity.finish() is called" into oc-mr1-dev
am: bf66bf30b1

Change-Id: Id5f413c21eb39e540d2417f9c19b7553f57d6b6a
2017-08-31 19:25:33 +00:00
TreeHugger Robot
bf66bf30b1 Merge "Bluetooth: do not dimiss fragment when Activity.finish() is called" into oc-mr1-dev 2017-08-31 19:16:50 +00:00
Phil Weaver
c0f77c7e6f resolve merge conflicts of 94c5202965 to oc-dr1-dev am: f65e790ba0 -s ours am: 8d9e305d84 -s ours
am: 60a0a021d1  -s ours

Change-Id: Ic5166d81882bcb5b03cdd6ee072dc7855b40e3aa
2017-08-31 19:08:18 +00:00
Daniel Nishi
cdab0de21f Merge "Tint the work icon." into oc-mr1-dev am: 260ec8b9ea
am: 270f217c9f

Change-Id: I918a29fb927ddb578933f64cc989b321e81376e0
2017-08-31 18:19:33 +00:00
Phil Weaver
37e0c1f3cc resolve merge conflicts of 94c5202965 to oc-dr1-dev am: f65e790ba0 am: f8a7b8aff0 -s ours
am: d88b7364d8  -s ours

Change-Id: I81d6961428e04f5751a479525756fae14fe5a503
2017-08-31 18:18:44 +00:00
Phil Weaver
60a0a021d1 resolve merge conflicts of 94c5202965 to oc-dr1-dev am: f65e790ba0 -s ours
am: 8d9e305d84  -s ours

Change-Id: I97f195764e77daba922c7b855d50e41f29e512c9
2017-08-31 18:06:49 +00:00
Daniel Nishi
270f217c9f Merge "Tint the work icon." into oc-mr1-dev
am: 260ec8b9ea

Change-Id: I4315981fab4efde7197e1026f2a2ba140647252b
2017-08-31 17:46:01 +00:00