Commit Graph

49587 Commits

Author SHA1 Message Date
TreeHugger Robot
6498d8f621 Merge "use android:textAppearanceListItem to replace Preference subhead" 2019-01-09 17:58:44 +00:00
TreeHugger Robot
9881395ccf Merge "Implement an "Advance" button on Privacy page." 2019-01-09 12:18:22 +00:00
TreeHugger Robot
c0fb9deff2 Merge "Update the layout of half width suggestion cards." 2019-01-09 11:40:24 +00:00
TreeHugger Robot
61e0424ab9 Merge "Update the background colour for dismissal view." 2019-01-09 11:21:20 +00:00
Arc Wang
8eda83d071 Add more Wi-Fi DPP UI features.
1. Use ConstraintLayout to fix footer buttons at bottom
2. ScrollViews have all other UI components excepts footer buttons
3. Use style/SuwGlifButton for buttons
4. Fix scan fragment crash when rotating screen

Bug: 118794978
Test: manual test
Change-Id: I509b0156c4835c75da75fb7ac4c82f55a0b506a1
2019-01-09 18:25:31 +08:00
Sunny Shao
1447f2652b use android:textAppearanceListItem to replace Preference subhead
Use android:attr/textAppearanceListItem to replace style/Preference_TextAppearanceMaterialSubhead
in the time_zone_search_item.xml

Bug: 122043378
Test: compilation
Change-Id: I8a19e6aa662b01fd4d8c2a0a139c787438d6d11c
2019-01-09 17:59:07 +08:00
Yi-Ling Chuang
26127c6271 Update the layout of half width suggestion cards.
When switching to the dismissal view, the background color of suggestion
cards that were built as half cards with only 1 line text in it won't
fully cover the whole card. The alignments are not consistent as well.

Make layout_height of ViewFlipper and the main content to be
match_parent.

Change-Id: If345d00d21150e184614029a34e79b3210ec52ff
Fixes: 122559038
Test: visual
2019-01-09 15:12:21 +08:00
tmfang
bb42ce2608 Implement an "Advance" button on Privacy page.
- Also rearrange the order for "show password".

Test: visual
Fixes: 122556325

Change-Id: Iac15baa83a2ba863ad75c0a309a0e4c6deaa522e
2019-01-09 15:05:56 +08:00
Cosmo Hsieh
1cb7e12fab Merge "Implement persisting time for onUserSelectionConnectSuccess." 2019-01-09 02:28:09 +00:00
Johnson Lu
9c092dda62 Merge "Implement Wi-Fi DPP flow" 2019-01-09 01:59:01 +00:00
TreeHugger Robot
532c3d7200 Merge "Make Network & internet v2 feature flag be persistent" 2019-01-09 01:18:21 +00:00
TreeHugger Robot
d7195194e2 Merge "Charging sounds toggle now includes vibration" 2019-01-08 22:34:02 +00:00
Antony Sargent
0a830d4f48 Make Network & internet v2 feature flag be persistent
In ag/5386198 we added a flag to turn on the new features of the network
and internet settings page, but that flag resets to the default value
(currently false) every time you reboot, which is annoying and hostile
for dogfooders. This CL makes the flag persistent.

Bug: 116349402
Test: manual / should be covered by existing tests
Change-Id: I098073e81feb199751e967a9652bec6a6445b95e
2019-01-08 14:17:39 -08:00
Beverly
0b6402ab3a Charging sounds toggle now includes vibration
Add text to indicate the charging sounds toggle also
includes vibration

Test: manual, builds
Bug: 29737261
Change-Id: I55e35ea63b8e80aa5573ef676fdde4b28bc0f654
2019-01-08 09:44:30 -05:00
Console Chen
ce16d7ad63 Adding the ability to customize the subtitle on an unavailable slice
When a slice is depending on some setting and the setting is off,
it shows "depends on another setting".
Add an new attribute for Preference to customize the subtitle when
a slice is unavailable.

Bug: 118399193
Test: Robo test on com.android.settings.slices, com.android.settings.core
Change-Id: I84a8400295b36abb357e5baf98e9be3a8d6ea897
2019-01-08 19:23:04 +08:00
Yi-Ling Chuang
7c91342ffa Update the background colour for dismissal view.
Change-Id: I14cfa176c80581ea8f4de099015e4ff148acf59a
Fixes: 119170360
Test: visual
2019-01-08 18:53:49 +08:00
Johnson Lu
7bdf8b3d37 Implement Wi-Fi DPP flow
1. As DPP configurator initiator.
2. As DPP enrollee initiator.
3. Pass whole DPP url to DPP API due to API cahnged.

Bug: 122331217
Test: manual test
Change-Id: I8005b78b82453badf253dbde8022ff20722b39fd
2019-01-08 13:42:42 +08:00
cosmohsieh
c1854cae9a Implement persisting time for onUserSelectionConnectSuccess.
When onUserSelectionConnectSuccess callbacks, holding a second for user
to be aware of success connection. Then, go to destory network request dialog.

Bug: 117399926
Test: make RunSettingsRoboTests -j32 ROBOTEST_FILTER=com.android.settings.wifi.NetworkRequestDialogFragmentTest
Change-Id: I12d8fb2e8955cf24ddad43d1fe8b863682b6ae32
2019-01-08 12:08:11 +08:00
Nathan Harold
e5e94b95dc Merge "Fix BandMode Dialog Crash on Open due to Style" am: 7588ef1518 am: 7aacdc2c13
am: c015a1bac0

Change-Id: I5d1f931b9b5a6dae87d4effd20ec91d6f9114989
2019-01-07 17:50:20 -08:00
Nathan Harold
c015a1bac0 Merge "Fix BandMode Dialog Crash on Open due to Style" am: 7588ef1518
am: 7aacdc2c13

Change-Id: I50588e17f07d89daa3a989a72080a4fe695b4729
2019-01-07 17:31:14 -08:00
Nathan Harold
7aacdc2c13 Merge "Fix BandMode Dialog Crash on Open due to Style"
am: 7588ef1518

Change-Id: I0dd365652f4deac7b69b181317b0dd86610400a7
2019-01-07 17:16:52 -08:00
Nathan Harold
7588ef1518 Merge "Fix BandMode Dialog Crash on Open due to Style" 2019-01-08 00:18:21 +00:00
Daniel Solomon
60418b4de8 Hide display white balance setting depending on color mode
Display white balance relies on a linear color transform matrix to work
as intended. When the current color mode is COLOR_MODE_SATURATED, this
condition is not guaranteed to be satisfied. In this case, hide the
display white balance setting.

Bug: 116516917

make ROBOTEST_FILTER=DisplayWhiteBalancePreferenceControllerTest
RunSettingsRoboTests -j32

Change-Id: I1fe1eb907485766888832db8b9c342339cc80ea7
2019-01-07 14:44:21 -08:00
Salvador Martinez
1517be0b7f Remove logging for ssids
This is potentially PII so we should not log this. This change
simply removes the lines of logging code.

Test: changing preference does not result in logging
Bug: 117637133
Change-Id: I620ac4cc4eaaf8227b0694e6cc5f9a85d54bc0e8
2019-01-07 14:35:31 -08:00
TreeHugger Robot
2dbdc888c3 Merge "Fix TODO for mobile network settings" 2019-01-07 20:24:13 +00:00
TreeHugger Robot
af2c9b2646 Merge "Fix ConcurrentModificationException in SliceBackgroundWorker" 2019-01-07 20:11:17 +00:00
Jason Chiu
e19658ac36 Fix ConcurrentModificationException in SliceBackgroundWorker
- Two different threads could call SliceBackgroundWorker.getInstance()
  at the same time and caused ConcurrentModificationException
- Add a new API overloading getInstance for each slice to get a nullable
  worker since there is no result data then
- Only slice provider can create a new worker instance in main thread

Test: robotest
Change-Id: I560529bb6034ec22263418adeb7f3ccebf879196
Fixes: 121043385
2019-01-07 20:10:49 +00:00
TreeHugger Robot
8a98decbd6 Merge "Refine the conditionals layout" 2019-01-07 16:52:27 +00:00
TreeHugger Robot
a3d5cd403e Merge "Make filter appear floating in ManagerApplication." 2019-01-07 14:23:57 +00:00
Mill Chen
2ac24f2ceb Refine the conditionals layout
1. Add the minWidth for a button in the condition full tile and adjust
the start margin of the button.
2. Decrease the start padding of the conditional header layout.

Bug: 113451905
Test: visual
Change-Id: I4864730b35154c0bd4b0a806815aa912b19ca3d7
2019-01-07 21:34:07 +08:00
tmfang
5c1d3e96a1 Make filter appear floating in ManagerApplication.
Using new layouts to make filter component appear
floating on top of the page.

The layouts contain the NestedScollView and AppBarLayout.
The NestedScrollView was given a layout_behavior which
defined the behavior of AppBarLayout.

Test: visual
Change-Id: Ia76104f80c6b60ac6c8f5937ebface8e9a7238b5
Fixes: 121148001
2019-01-07 19:23:35 +08:00
Mill Chen
58ae38572a Merge "Implement slice half card" 2019-01-07 08:17:47 +00:00
Mill Chen
6b34d81f36 Merge "Build a way to decide card width" 2019-01-07 08:17:47 +00:00
TreeHugger Robot
577f89deb7 Merge "Refactor slice renderer to handle different card width" 2019-01-07 06:55:31 +00:00
Mill Chen
3559450789 Implement slice half card
To display slice in half width form needs to bind slice, extract the
title and the icon from slice, and finally put the title and the icon
into half card layout.

Bug: 119655434
Test: visual, robotests
Change-Id: Ib390f9a45f0ee609eb9e3499bff74136c7616ac3
2019-01-07 13:39:09 +08:00
Mill Chen
497b3529dc Refactor slice renderer to handle different card width
- Refactor SliceContextualCardRenderer to support for displaying slice
in half/full width card.
- Add two helper classes to separately deal with different card width.

Only the skeleton of the half card helper is put in this CL, the
implementation hasn't been filled in yet. Will implement the detail in
next CL.

Bug: 119655434
Test: visual, robotests
Change-Id: Iacdc90c23bf41cfa7ccae3c0c70a3b663e89307d
2019-01-07 13:34:03 +08:00
TreeHugger Robot
94563cd08b Merge "Improve visual - Collapse the conditionals in all cases" 2019-01-07 05:29:31 +00:00
Mill Chen
8a1bccbc30 Improve visual - Collapse the conditionals in all cases
Changing the threshold value to make collapsing mechanism of conditionals
work in all cases, where the threshold value is changed to 0 from 2.

Bug: 122310542
Test: robotests
Change-Id: I227114acdc6770baa0c133397d08e3ad77f6c572
2019-01-07 05:28:24 +00:00
TreeHugger Robot
d8b3fd3869 Merge "GUP: Add stub UI" 2019-01-05 02:26:04 +00:00
jackqdyulei
b5ce3cd9b0 Fix TODO for mobile network settings
1. Add intent filter to MobileNetworkActivity(new page)
2. Add metrics id
3. Remove obsolete TODOs

Bug: 114749736
Test: Manual
Change-Id: I36f41983dc8cc36ccdf548174fc494044ec1b241
2019-01-04 15:55:09 -08:00
TreeHugger Robot
4e0d53bac8 Merge "Unit test for AppLocationPermissionPreferenceController" 2019-01-04 23:53:38 +00:00
TreeHugger Robot
7a38a2689e Merge "Unit test for RecentLocationAccessPreferenceController" 2019-01-04 23:00:43 +00:00
Ruchi Kandoi
8925004b51 Merge "Add support for FEATURE_NFC_ANDROID_BEAM" am: 6827785e52 am: 39845367ab
am: a7c886925f

Change-Id: I08ff3b1bd80e913aeec9800b1c5ddce69543ba3c
2019-01-04 14:19:23 -08:00
Ruchi Kandoi
a7c886925f Merge "Add support for FEATURE_NFC_ANDROID_BEAM" am: 6827785e52
am: 39845367ab

Change-Id: Ia7fc968221a6eb314a9ee384e0dd84d3aa0e84b4
2019-01-04 14:07:48 -08:00
Ruchi Kandoi
39845367ab Merge "Add support for FEATURE_NFC_ANDROID_BEAM"
am: 6827785e52

Change-Id: I7c71bad831892bf9a853ca5d4777e42c1b3a9171
2019-01-04 13:58:22 -08:00
Yiwei Zhang
c81a03b60e GUP: Add stub UI
Bug: 119221883
Test: make RunSettingsRoboTests ROBOTEST_FILTER=GupDashboardTest

Change-Id: I1f7cc66790e1d1e1de5113e28a055ec5d1679013
2019-01-05 05:55:39 +08:00
Treehugger Robot
6827785e52 Merge "Add support for FEATURE_NFC_ANDROID_BEAM" 2019-01-04 21:49:14 +00:00
Lifu Tang
8b769125bf Unit test for RecentLocationAccessPreferenceController
Bug: 120910747
Test: run unit test
Change-Id: I5a3e4eb3dd9519f0fa1fe1e3f90612ee1cd5762d
2019-01-04 12:46:05 -08:00
Lifu Tang
769a9fb04c Unit test for AppLocationPermissionPreferenceController
Bug: 120910747
Test: build and run the unit test
Change-Id: Id5f79d0f6b143d1ef5e37d75c27a64b4e1dcd9e0
2019-01-04 11:24:06 -08:00
Beverly Tai
5585d5e9d7 Merge "Prevent ringing gesture uses master switch" 2019-01-04 18:36:56 +00:00