Commit Graph

17982 Commits

Author SHA1 Message Date
Haijie Hong
2e3d477a3f Merge "Add ring indicator for battery level" into main 2024-07-09 08:44:48 +00:00
Matías Hernández
bb41777f87 Merge "Add mode: Choose name and icon for new custom modes" into main 2024-07-09 02:20:07 +00:00
Treehugger Robot
d12a36466d Merge "Fix test failures in deviceinfo" into main 2024-07-08 08:35:05 +00:00
Yiling Chuang
e24c5f37d2 Fix test failures in deviceinfo
Fixes: 315267179
Flag: EXEMPT bugfix
Test: atest SettingsRoboTests
Change-Id: I9858374fe101ee5908e16104ed7b4ca6af0308cd
2024-07-08 07:43:49 +00:00
Matías Hernández
574fcaf1b2 Add mode: Choose name and icon for new custom modes
This also unifies the "icon picker" screen with the new "add mode" screen since in both cases we want to edit name and icon together (and not save updates until the user confirms).

Bug: 326442408
Bug: 346278854
Test: atest com.android.settings.notification.modes
Flag: android.app.modes_ui
Change-Id: I8a9d07ba0b6c55f3abc1b9884f278d51d178dc83
2024-07-06 22:12:58 +00:00
Matías Hernández
606f9b1727 Merge "Use a temporary summary in the "Apps that can interrupt" preference" into main 2024-07-06 10:42:23 +00:00
Matías Hernández
ec376bcfce Use a temporary summary in the "Apps that can interrupt" preference
We load the list of apps in a background thread, so getting that string later was causing the preference to increase in height, with an annoyingly noticeable animation. Having a placeholder test ensures this doesn't happen (and actually loading is pretty fast, so this text lkely won't even be visible).

Fixes: 347744856
Test: atest ZenModeAppsLinkPreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: I4f9f60104fb8b0abbc7c4279b87daafac481e98a
2024-07-05 17:36:47 +02:00
Treehugger Robot
476323f0b0 Merge "Disable "Add network" if DISALLOW_ADD_WIFI_CONFIG" into main 2024-07-05 06:58:17 +00:00
Weng Su
a7b13c11cd Disable "Add network" if DISALLOW_ADD_WIFI_CONFIG
- When DISALLOW_ADD_WIFI_CONFIG is not restricted by Admin
  - Disable the preference directly

Bug: 335387874
Flag: EXEMPT bugfix
Test: Manual testing
atest -c AddWifiNetworkPreferenceTest

Change-Id: I0bb08656971107c73d7632a395a820d03723620b
2024-07-05 06:52:36 +08:00
YK Hung
8d5d69d62f Merge "Avoid dump BatteryReattributeDatabaseHist if the feature is disabled" into main 2024-07-04 06:12:53 +00:00
Haijie Hong
5d96249d6e Add ring indicator for battery level
Bug: 343317785
Test: atest AdvancedBluetoothDetailsHeaderControllerTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: Ib657db60be8d377ea990674c4d2438ea8a6854d0
2024-07-04 13:26:48 +08:00
YK Hung
e15e2397af Avoid dump BatteryReattributeDatabaseHist if the feature is disabled
Fix: 346706894
Fix: 350798552
Test: atest SettingsRoboTests:com.android.settings.fuelgauge.batteryusage
Flag: EXEMPT bug fix
Change-Id: I1670e2769bc71fe91a752efeea18074d53c5a017
2024-07-04 04:59:34 +00:00
Wilson Wu
2ae9ed0297 Merge "Clean up the keyboard vibration config" into main 2024-07-04 02:45:29 +00:00
Alina Zaidi
903976cd34 Merge "Update OWNERS for DesktopModePreferenceController" into main am: ed9bccb0b3 am: 7b4fcc6006
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3159736

Change-Id: Ibb60677d29ad574c106f95391f4572b0e142864b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-03 17:52:03 +00:00
Alina Zaidi
7b4fcc6006 Merge "Update OWNERS for DesktopModePreferenceController" into main am: ed9bccb0b3
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3159736

Change-Id: I79c2dd015ce63fa0fe658daf486971f48917f0ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-03 17:37:22 +00:00
Alina Zaidi
a059eabdb3 Update OWNERS for DesktopModePreferenceController
Change-Id: I446525a06480a27f80e530c65181fd31f43a9ef8
Test: N/A
Flag: EXEMPT Ownership cannot be flagged
2024-07-03 16:22:23 +00:00
Jayant Chowdhary
8569d2ade0 Merge "Exclude webcam and MIDI USB preferences from requiring auth challenge" into main 2024-07-03 04:55:58 +00:00
Treehugger Robot
a56866ddaa Merge "Add mandatory biometric prompt to platform surfaces (2/N)" into main 2024-07-03 02:39:11 +00:00
Julia Reynolds
ce4f2e9db6 Merge "Show bundles separately from other channels" into main 2024-07-03 00:02:33 +00:00
Diya Bera
606bfb3057 Add mandatory biometric prompt to platform surfaces (2/N)
1. Factory reset

Flag: android.hardware.biometrics.Flags.MANDATORY_BIOMETRICS
Bug: 339910718
Test: atest MainClearTest

Change-Id: I7216f991a2550197c520af860da67f8452cff323
2024-07-02 20:57:43 +00:00
Jayant Chowdhary
cf9eee0bb5 Exclude webcam and MIDI USB preferences from requiring auth challenge
Webcam / MIDI don't transfer any persistent data to the host device,
so it is okay to not guard it by an auth challenge. Auth challenge for
webcam use increases friction and reduces usability.

Bug: 349370229

Flag: com.android.settings.flags.exclude_webcam_auth_challenge

Test: Check when the flag is enabled, webcam / MIDI doesn't require auth
Test: Settings robolectric tests

Change-Id: Id4c97a635a4c0a9ed14f88fbdda2743e2371dd10
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2024-07-02 18:36:51 +00:00
Matías Hernández
0037dfe9a9 Merge changes from topics "add-mode-dialog", "nicer-icon-header" into main
* changes:
  Icon picker: Styling improvements
  Add mode: Support for app-provided modes
2024-07-02 12:26:42 +00:00
Treehugger Robot
c2c6c5d058 Merge "Update the conditions of power plugged determination." into main 2024-07-02 11:56:53 +00:00
Yiling Chuang
318636d51b Update the conditions of power plugged determination.
Under charging optimization mode, use ADAPTIVE_LONGLIFE as the additional condition to check whether a device is plugged.

Bug: 349949603
Flag: EXEMPT bugfix
Test: atest SettingsRoboTests
Change-Id: Idbdfaaa1d5c54be325b6182bcda81d4282c21ba0
2024-07-02 10:54:36 +00:00
Matías Hernández
45f1e819d3 Icon picker: Styling improvements
Instead of a the plain appearance of a EntityHeaderController, make the top icon bigger and use the same circled style as the choices in the list. Also highlight the current icon in the list as selected, even if it is the default for the mode type.

Also cleaned up controllers that don't need a ZenModesBackend to not receive it.

(Both of these changes also line up with the "new mode" fragment that is incoming).

Bug: 333901673
Bug: 326442408
Test: atest com.android.settings.notification.modes
Flag: android.app.modes_ui
Change-Id: I0c9f3e34019a1a6c48658933dde545ad8d7399ae
2024-07-02 12:12:02 +02:00
Matías Hernández
2639c19474 Add mode: Support for app-provided modes
(This completes the add-mode flow except for the choose-a-name-and-icon step for custom modes).

Bug: 326442408
Flag: android.app.modes_ui
Test: atest com.android.settings.notification.modes
Change-Id: I7aceec01ed54d804bcac53d932277c243c1f81bf
2024-07-02 12:09:40 +02:00
Treehugger Robot
62db4b3a4d Merge "Add mandatory biometric prompt to platform surfaces (1/N)" into main 2024-07-02 02:50:08 +00:00
Diya Bera
049de84f2d Add mandatory biometric prompt to platform surfaces (1/N)
1. Face settings
2. Fingerprint settings
3. Change device credential

Flag: android.hardware.biometrics.Flags.MANDATORY_BIOMETRICS
Bug: 339910718
Test: atest UtilsTest

Change-Id: I69778d1733ea9fb312e7c26ae0fa23b6008dde5d
2024-07-01 21:35:19 +00:00
Alina Zaidi
50e0a53b1c Merge "[Dev option] Add a dev option to enable DW." into main 2024-07-01 19:54:09 +00:00
Alina Zaidi
d98058c4b7 [Dev option] Add a dev option to enable DW.
Default value of this dev options solely depends on
enable_desktop_windowing_mode, which is intended

Toggle is shown only if DW is eligible on device

Currently this option only overrides features guarded by
enable_desktop_windowing_mode, later on it will be used to override a
few other DW features

Test: Added tests. Locally tested CUJs
Bug: 348186127
Bug: 348193756
Flag: com.android.window.flags.show_desktop_windowing_dev_option

Change-Id: I1c1f946b586a5ca0440b29879925ba1a624717aa
2024-07-01 17:23:20 +00:00
Julia Reynolds
2956baaf51 Show bundles separately from other channels
Fixes: 346612561
Test: BundleListPreferenceControllerTest
Flag: android.service.notification.notification_classification
Change-Id: I2371219822f6a777788147e8249ca1e3b29d40ba
2024-07-01 12:56:41 -04:00
Yuri Lin
3731d3e8ee Merge "Link to app-provided configuration intent for app-owned rules." into main 2024-07-01 16:22:16 +00:00
Yuri Lin
21539cd2be Link to app-provided configuration intent for app-owned rules.
If there is no valid intent, the automatic trigger preference is disabled.

Flag: android.app.modes_ui
Bug: 341961712
Test: manual (for Bedtime & Driving modes), ZenModeSetTriggerLinkPreferenceControllerTest

Change-Id: I673792effb3cfdcaaa7cf85adfb55a93b44dcc86
2024-07-01 14:50:35 +00:00
mxyyiyi
a954e914dd Add a flag to protect overwrite app optimization mode to restricted mode.
- Skip set app optimization mode to restricted if the flag disabled.

Bug: 348192536
Fix: 348192536
Test: atest
Flag: EXEMPT bug fix
Change-Id: I92d320ce1edfe9b7044afdcd058651b0d54bd6bd
2024-07-01 17:38:50 +08:00
Wilson Wu
789aacf499 Clean up the keyboard vibration config
-. Remove the device config in Settings
-. Use the new config in frameworks/base

Flag: EXEMPT refactor
Bug: 332661307
Test: atest KeyboardVibrationTogglePreferenceControllerTest
Change-Id: I2fe70d830d55ec6f33597fbe0ed107b41eb3bdd7
2024-07-01 03:09:56 +00:00
Chaohui Wang
6afb2f3006 Merge "Not use SubscriptionInfoEntity in DataUsageList" into main 2024-06-28 05:14:06 +00:00
Chaohui Wang
e25c208277 Merge "Migrate SearchFeatureProviderImpl to Kotlin" into main 2024-06-28 02:39:20 +00:00
Pajace Chen
b83151f324 Merge "[Bug Fix] "Dock defend string and tips in settings are incorrectly" issue" into main 2024-06-28 00:39:12 +00:00
Treehugger Robot
bdd205e1b4 Merge "fix TrustAgentsPreferenceControllerTest" into main 2024-06-27 20:15:46 +00:00
Billy Huang
dd0ae72eb9 fix TrustAgentsPreferenceControllerTest
Removed non-platform Robolectric shadow in favor of setting up fake
package/services directly with ShadowApplicationPackageManager.

Bug: 313612480
Test: atest "SettingsRoboTests:TrustAgentsPreferenceControllerTest" --host
Flag: TEST_ONLY
Change-Id: Iadcb5bcb977201e2f394b699621bfb34657a7820
2024-06-27 19:21:22 +00:00
Yuri Lin
978cba142a Merge "Migrate "duration for quick settings" to new modes page." into main 2024-06-27 18:22:39 +00:00
Yuri Lin
c1a4abbc51 Migrate "duration for quick settings" to new modes page.
This mostly continues to use the existing dialogs in settingslib (ZenDurationDialog, SettingsEnableZenModeDialog) and creates a controller to read from the settings value.

Also updates the "turn on / turn off" button to respect the preferred duration.

Flag: android.app.modes_ui
Bug: 343444249
Test: ZenModeButtonPreferenceControllerTest, ManualDurationPreferenceControllerTest
Change-Id: I2fd49a79d9a5807fefdd7ec310a6cc60d70f9bb1
2024-06-27 12:48:27 -04:00
pajacechen
daeb06c3b0 [Bug Fix] "Dock defend string and tips in settings are incorrectly" issue
Symptom: After the dock defend was triggered, the battery tips still
show "Future-Bypass" dock defend mode. It should be the "Active" dock
defend mode.

Root Cause: The original `BatteryInfo.isBatteryDefender` was implemented
by using `longlife`, due to the charging limit also reuse `longlife`
issue, we replace the implementation of `BatteryInfo.isBatteryDefender`
with HAL API call `isTempDefend` and `isDwellDefend`. However, the
dock defend also needs `longlife`, the original
`BatteryInfo.isBatteryDefender`. So the dock defend checking failed
after replacing the implementation of `BatteryInfo.isBatteryDefender`

Solution:
- Add new property isLonglife in BatteryInfo
- Replace all isBatteryDefender reference that needs isLonglife

Bug: 348563863
Test: Manual Test and robotest
Test: http://ab/I08300010291126076 (unit test)
Test: http://ab/I67800010291096764 (robo test)
Flag: EXEMPT bugfix
Change-Id: I58424927522acc29dc49261a2c24829a5b34ef85
2024-06-27 23:19:08 +08:00
Chaohui Wang
75a382fc46 Migrate SearchFeatureProviderImpl to Kotlin
This is no-op.

Bug: 346776183
Flag: EXEMPT refactor
Test: manual - do settings search
Change-Id: I5c113f6ed5db1401e1d237f0022ab6dccde8d060
2024-06-27 14:11:02 +00:00
Chelsea Hao
94cfea7ed1 Merge "[Audiosharing] onDestroy() is not guaranteed to be called after stopSelf(). In this case callbacks are not unregistered timely and the notification kept being brought up again if any callback is received." into main 2024-06-27 11:13:13 +00:00
Yiyi Shen
9c5ac400a0 Merge "[Audiosharing] Fix IllegalStateException at getChildFragmentManager" into main 2024-06-27 10:53:15 +00:00
chelseahao
c49658d154 [Audiosharing] onDestroy() is not guaranteed to be called after stopSelf(). In this case callbacks are not unregistered timely and the notification kept being brought up again if any callback is received.
This CL also moved some binder calls to bg thread.

Test: atest -c com.android.settings.connecteddevice.audiosharing.audiostream
Flag: com.android.settingslib.flags.enable_le_audio_qr_code_private_broadcast_sharing
Bug: 347605485
Change-Id: I1a3a3db88178a43f27cac74cf743bdb75cdfb60e
2024-06-27 09:57:37 +00:00
Chelsea Hao
f647356d62 Merge "[Audiosharing] Increase test coverage." into main 2024-06-27 08:36:02 +00:00
chelseahao
7529e1bea7 [Audiosharing] Increase test coverage.
Test: atest -c com.android.settings.connecteddevice.audiosharing.audiostream
Flag: com.android.settingslib.flags.enable_le_audio_qr_code_private_broadcast_sharing
Bug: 345686602
Change-Id: I668df463ec1c6e994d2dcaa363a20aa06f69f199
2024-06-27 07:11:37 +00:00
Roy Chou
5d5392d48e Merge "chore(onefingerpan): update onefingerpan preference summary and magnification settings page footer description" into main 2024-06-27 01:11:31 +00:00