Commit Graph

72521 Commits

Author SHA1 Message Date
Jason Chiu
092f612ab2 Merge "Workaround of Slice not pinned bug when using SliceCallback" into rvc-dev am: c548288a51 am: 1bb216e35e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931349

Change-Id: I1e73dd84798698d03c7fdb3ec4ed79702f0018cb
2020-06-22 08:25:05 +00:00
Jason Chiu
e7a9baaf8f Merge "Workaround of Slice not pinned bug when using SliceCallback" into rvc-dev am: c548288a51 am: c13f549973
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931349

Change-Id: Ib2bcfe75f1ed54a3c9b4ab898d163ab1adab43ee
2020-06-22 08:24:48 +00:00
Jason Chiu
16b830e465 Merge "Workaround of Slice not pinned bug when using SliceCallback" into rvc-dev am: c548288a51 am: c13f549973
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931349

Change-Id: I15f115cacf0d233c5337d3e59242e545f877b368
2020-06-22 08:24:48 +00:00
Stanley Wang
1117895745 Merge "Add log to capture the hardware status." into rvc-dev 2020-06-22 08:19:36 +00:00
Jason Chiu
1bb216e35e Merge "Workaround of Slice not pinned bug when using SliceCallback" into rvc-dev am: c548288a51
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931349

Change-Id: I572e26bd5148fe6823095272bf5cea57104def1c
2020-06-22 08:12:05 +00:00
Jason Chiu
ce9bc8d866 Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a am: 07081ae34e am: 0d96af8cea am: c3e54f569c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: Ic7080a33c3a10b28e35746c505de58cfa43793de
2020-06-22 08:12:02 +00:00
Jason Chiu
63a9803d3c Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a am: 5d37336eb3 am: 81d612d5fa am: 34e5c36ce7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: I113d0390512617b96b0e0c1675de72e63ec67212
2020-06-22 08:11:54 +00:00
Jason Chiu
c13f549973 Merge "Workaround of Slice not pinned bug when using SliceCallback" into rvc-dev am: c548288a51
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931349

Change-Id: Ia202ea7899f8ebb8770db91ea676b28f29cbef64
2020-06-22 08:11:49 +00:00
Jason Chiu
19af1f7293 Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a am: 07081ae34e am: d1056becc2 am: 4aa3003ecf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: Ibd03164d2257881addd18a93cb06f7c479bef9fb
2020-06-22 08:11:46 +00:00
Jason Chiu
c548288a51 Merge "Workaround of Slice not pinned bug when using SliceCallback" into rvc-dev 2020-06-22 07:58:25 +00:00
Jason Chiu
c3e54f569c Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a am: 07081ae34e am: 0d96af8cea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: Ib4d007afa377615a445ee6c97d89813927a48b8f
2020-06-22 07:41:28 +00:00
Jason Chiu
34e5c36ce7 Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a am: 5d37336eb3 am: 81d612d5fa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: I3a0fdbbbbad03659c0329803a2a9224d15e51c28
2020-06-22 07:41:18 +00:00
Jason Chiu
4aa3003ecf Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a am: 07081ae34e am: d1056becc2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: I60a5eaedf38db9d36cadd6f568f131b8d58a9101
2020-06-22 07:41:05 +00:00
Jason Chiu
73afb042dc Workaround of Slice not pinned bug when using SliceCallback
When a client registers a SliceCallback, it starts to observe Slice
changes. The observer is running in the main looper and binds Slice
in AsyncTask.

However, when the client unregisters the callback, it unpins the Slice
in the client's thread. Thus, if the AsyncTask has pinned the slice but
hasn't bound it yet, it may be unpinned by the client, and an exception
occurs.

This fix is to unpin the Slice in the same SerialExecutor of AsyncTask,
which is to ensure bindSlice() and unpinSlice() are called in the same
thread one after another without the race condition.

Bug: 157387583
Test: robotest
Change-Id: If5f4b4bc0d8c5a2800cad8ff2afd7084426a6c96
2020-06-22 07:38:50 +00:00
Jason Chiu
0d96af8cea Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a am: 07081ae34e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: I222b266722c726c8346491a87107aace2168615a
2020-06-22 07:27:48 +00:00
Jason Chiu
81d612d5fa Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a am: 5d37336eb3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: I2ea7f182efc44bbdc0a6e8c05dcc0dcebd45834a
2020-06-22 07:27:48 +00:00
Jason Chiu
d1056becc2 Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a am: 07081ae34e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: I342f57b7adb215835fcebd9dff0b3e51cd0f3e7c
2020-06-22 07:27:19 +00:00
Jason Chiu
5d37336eb3 Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: I1913715e1ecddf6f39fd8a3357a7db3125add0b8
2020-06-22 07:15:04 +00:00
Jason Chiu
07081ae34e Merge "Decrease memory usage for sleep idle test" into rvc-dev am: f1a65df04a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11931351

Change-Id: Ia422444a14e73076de14098a612794d4c0909ddc
2020-06-22 07:14:46 +00:00
Automerger Merge Worker
335f0184df Merge "Merge "Fix homepage cards show up problem after first launch" into rvc-dev am: 64dbdebfbf am: 7ebe511104 am: 23c1016d6d" into rvc-qpr-dev-plus-aosp am: 009b00a6bc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11897739

Change-Id: If01903e9e098e628aead1fd9aa186f9a0c9e52f8
2020-06-22 07:11:30 +00:00
Jason Chiu
9f81a4eeab Merge "Fix homepage cards show up problem after first launch" into rvc-dev am: 64dbdebfbf am: eb50dcaac5 am: aecb321beb am: faee522b97
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11897739

Change-Id: I5c08253075b003dd86f3c26267c273954d96cb56
2020-06-22 07:11:19 +00:00
Jason Chiu
1dded75614 Merge "Fix homepage cards show up problem after first launch" into rvc-dev am: 64dbdebfbf am: 7ebe511104 am: 2e67b3f645 am: 031062198e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11897739

Change-Id: I7984416dc4b9ac8368938780684e3106bf7aa20d
2020-06-22 07:11:10 +00:00
Jason Chiu
f1a65df04a Merge "Decrease memory usage for sleep idle test" into rvc-dev 2020-06-22 07:05:38 +00:00
Automerger Merge Worker
009b00a6bc Merge "Merge "Fix homepage cards show up problem after first launch" into rvc-dev am: 64dbdebfbf am: 7ebe511104 am: 23c1016d6d" into rvc-qpr-dev-plus-aosp 2020-06-22 06:56:32 +00:00
Jason Chiu
c8996cf552 Merge "Fix homepage cards show up problem after first launch" into rvc-dev am: 64dbdebfbf am: 7ebe511104 am: 23c1016d6d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11897739

Change-Id: If481e8ea8b54b41339603c6c7b9f8908c5e1ba70
2020-06-22 06:56:28 +00:00
Jason Chiu
faee522b97 Merge "Fix homepage cards show up problem after first launch" into rvc-dev am: 64dbdebfbf am: eb50dcaac5 am: aecb321beb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11897739

Change-Id: I5e3168de6e4be79db1d86ce88705b19636781447
2020-06-22 06:56:26 +00:00
Jason Chiu
031062198e Merge "Fix homepage cards show up problem after first launch" into rvc-dev am: 64dbdebfbf am: 7ebe511104 am: 2e67b3f645
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11897739

Change-Id: Ic3ba82a08f20fa035075c3b3af0ae043be55504e
2020-06-22 06:56:21 +00:00
Yi-Ling Chuang
b54f9b4921 Disable the defulat animation of the RecyclerView to avoid UI jank.
When users go to a sub page in Settings and come back to the homepage
again, those sticky cards flicker which makes the UI janky. This is
because we rebind sticky cards to ensure it's always up-to-date, where
the recyclerView has its default animation while notifyItemInserted(),
ane thus introduce the jank.

Fixes: 158627602
Test: Open Settings -> go to sub pages -> back to the homepage -> cards
are not flickering.

Change-Id: I2104dbe0bed8b2486c35521bcc0b5c8b54efb995
2020-06-22 14:53:10 +08:00
Jason Chiu
aecb321beb Merge "Fix homepage cards show up problem after first launch" into rvc-dev am: 64dbdebfbf am: eb50dcaac5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11897739

Change-Id: I4cab18be801fde340503f369f3ee478fc8e5e0f7
2020-06-22 06:45:05 +00:00
Jason Chiu
23c1016d6d Merge "Fix homepage cards show up problem after first launch" into rvc-dev am: 64dbdebfbf am: 7ebe511104
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11897739

Change-Id: I99dec7ad62d2fbe5cfd2f8058517bc36d393f4e9
2020-06-22 06:44:58 +00:00
Jason Chiu
2e67b3f645 Merge "Fix homepage cards show up problem after first launch" into rvc-dev am: 64dbdebfbf am: 7ebe511104
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11897739

Change-Id: Ib6f924bc21c9199c05a2374753ad6b8391d2eec9
2020-06-22 06:44:57 +00:00
Jason Chiu
eb50dcaac5 Merge "Fix homepage cards show up problem after first launch" into rvc-dev am: 64dbdebfbf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11897739

Change-Id: Ie317b7ef7d733ec635773bf5af587f4016329261
2020-06-22 06:33:05 +00:00
Jason Chiu
7ebe511104 Merge "Fix homepage cards show up problem after first launch" into rvc-dev am: 64dbdebfbf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11897739

Change-Id: I1f30b105bcad02f13661b4d7a3652165a328fa13
2020-06-22 06:32:58 +00:00
Jason Chiu
64dbdebfbf Merge "Fix homepage cards show up problem after first launch" into rvc-dev 2020-06-22 06:20:08 +00:00
Alex Li
dfcdeb8147 Merge "[Settings] Avoids disabled component when page start from setup wizard." into rvc-dev am: 3f8d40bd95 am: 0567bb7834 am: 22f3f4f157 am: 91650720d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11900662

Change-Id: I72adda4345232e110179e04b610752ee3b8edfc5
2020-06-22 04:51:12 +00:00
Alex Li
d8c48ebb9f Merge "[Settings] Avoids disabled component when page start from setup wizard." into rvc-dev am: 3f8d40bd95 am: 49df46ef59 am: 953e87a578 am: 21caf00d4a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11900662

Change-Id: Ib717da9afd1d12db45b606dcd3bbdbfae15173c2
2020-06-22 04:51:06 +00:00
Alex Li
c8184bbae9 Merge "[Settings] Avoids disabled component when page start from setup wizard." into rvc-dev am: 3f8d40bd95 am: 0567bb7834 am: d5f6a66682 am: 8dc66ef820
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11900662

Change-Id: I8b61d4f39dc18a105850f5c6e55da25c09019275
2020-06-22 04:50:55 +00:00
Alex Li
91650720d4 Merge "[Settings] Avoids disabled component when page start from setup wizard." into rvc-dev am: 3f8d40bd95 am: 0567bb7834 am: 22f3f4f157
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11900662

Change-Id: I98eca56f9147ffe00e274ea1cf9b5a24bd2d80bd
2020-06-22 04:36:33 +00:00
Alex Li
21caf00d4a Merge "[Settings] Avoids disabled component when page start from setup wizard." into rvc-dev am: 3f8d40bd95 am: 49df46ef59 am: 953e87a578
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11900662

Change-Id: Ib8df2bd4f85743d0f8194c56a60f2490fe12732c
2020-06-22 04:36:13 +00:00
Alex Li
8dc66ef820 Merge "[Settings] Avoids disabled component when page start from setup wizard." into rvc-dev am: 3f8d40bd95 am: 0567bb7834 am: d5f6a66682
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11900662

Change-Id: I83c51cebcfe071939b1da0e01a1eba871b5723f6
2020-06-22 04:36:07 +00:00
Alex Li
22f3f4f157 Merge "[Settings] Avoids disabled component when page start from setup wizard." into rvc-dev am: 3f8d40bd95 am: 0567bb7834
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11900662

Change-Id: I4f3823469f74ef6e13104695b8dcc59405de9ddf
2020-06-22 04:25:08 +00:00
Alex Li
953e87a578 Merge "[Settings] Avoids disabled component when page start from setup wizard." into rvc-dev am: 3f8d40bd95 am: 49df46ef59
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11900662

Change-Id: I81caf8c8e01ebbf956ed81d6034f3cc594a78279
2020-06-22 04:25:06 +00:00
TreeHugger Robot
c158204e82 Merge "Make Telephony related PreferenceController un-sliceable" into rvc-dev am: fbabf8f251 am: 11018b11c1 am: 46383f190a am: d98079a0e8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11862423

Change-Id: I3c34f0fdba231160b283fdac004c814bebc3bb37
2020-06-22 04:25:05 +00:00
Automerger Merge Worker
05428ae28a Merge "Merge "Make Telephony related PreferenceController un-sliceable" into rvc-dev am: fbabf8f251 am: 2b697fac94 am: 009de48ded" into rvc-qpr-dev-plus-aosp am: c19a4eb78a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11862423

Change-Id: Ic21a42ff758055f441913f154db7a34fbf1c534b
2020-06-22 04:24:58 +00:00
Alex Li
d5f6a66682 Merge "[Settings] Avoids disabled component when page start from setup wizard." into rvc-dev am: 3f8d40bd95 am: 0567bb7834
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11900662

Change-Id: I905797e8477a4d0ea86bb57b8c02bfac95cfb001
2020-06-22 04:24:46 +00:00
TreeHugger Robot
3ab6e990ab Merge "Make Telephony related PreferenceController un-sliceable" into rvc-dev am: fbabf8f251 am: 2b697fac94 am: c758384eec am: f339f5a25d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11862423

Change-Id: Ic02e9129f844255524ba8f9f00e3902562b68882
2020-06-22 04:24:46 +00:00
TreeHugger Robot
d98079a0e8 Merge "Make Telephony related PreferenceController un-sliceable" into rvc-dev am: fbabf8f251 am: 11018b11c1 am: 46383f190a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11862423

Change-Id: Ib1f2f88fd8f4f347a231ea7a8ba34ec93498c281
2020-06-22 04:11:07 +00:00
Automerger Merge Worker
c19a4eb78a Merge "Merge "Make Telephony related PreferenceController un-sliceable" into rvc-dev am: fbabf8f251 am: 2b697fac94 am: 009de48ded" into rvc-qpr-dev-plus-aosp 2020-06-22 04:11:04 +00:00
TreeHugger Robot
d25b321f3a Merge "Make Telephony related PreferenceController un-sliceable" into rvc-dev am: fbabf8f251 am: 2b697fac94 am: 009de48ded
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11862423

Change-Id: I4668510c6c1720f111f39cd510f655cd9d37a53d
2020-06-22 04:11:00 +00:00
TreeHugger Robot
f339f5a25d Merge "Make Telephony related PreferenceController un-sliceable" into rvc-dev am: fbabf8f251 am: 2b697fac94 am: c758384eec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/11862423

Change-Id: Id2c6a16fe7318f2627c309b95609eacdc453cfdb
2020-06-22 04:10:58 +00:00