Commit Graph

8 Commits

Author SHA1 Message Date
Daniel Sandler
2c917847f5 Redesign vibration settings.
Under the hood there remain three axes:
 1. Are we in silent mode now?      | RINGER_MODE_{VIBRATE,SILENT}
 2. Do we vibrate in silent mode?   | VIBRATE_IN_SILENT == 1
 3. Do calls vibrate:     | getVibrateSetting(VIBRATE_TYPE_RINGER)
    - always              |    == VIBRATE_SETTING_ON
    - never               |    == VIBRATE_SETTING_OFF
    - only in silent      |    == VIBRATE_SETTING_ONLY_SILENT

We now expose this to the user much more simply by
collapsing (2) and (3) above, and discarding states that
don't make sense:
  - VIBRATE_SETTING_OFF + VIBRATE_IN_SILENT
  - VIBRATE_SETTING_ONLY_SILENT + !VIBRATE_IN_SILENT

Now we offer the user four choices:

    Phone vibrate:
    * "Never"
        --> VIBRATE_IN_SILENT=0, VIBRATE_SETTING_OFF
    * "Always"
        --> VIBRATE_IN_SILENT=1, VIBRATE_SETTING_ON
    * "Only in silent mode"
        --> VIBRATE_IN_SILENT=1, VIBRATE_SETTING_ONLY_SILENT
    * "Only when not in silent mode"
        --> VIBRATE_IN_SILENT=0, VIBRATE_SETTING_ON

This should make it easier to choose exactly the behavior
the user wants as well as avoid nonsensical combinations of
settings.

Bug: 2598014
Change-Id: I9244d25ec97a3e2b572b71b521049debd22fa4e0
2010-04-21 15:29:34 -04:00
Daniel Sandler
00290356b4 Ensure "vibrate in silent" box is never disabled.
Should complete the decoupling work started in change
I724c43aa4f5b1a12b95097381844a47c5dcf1e0d.

Change-Id: I3bad426534533149879fb098533a223cdcdb4d72
2010-03-10 10:56:23 -05:00
Daniel Sandler
4ce4f759bd Fix vibrate settings for incoming calls.
Bug: 2489593
Change-Id: Id0347bada808f604febc51c3d69d30442c3d51c4
2010-03-08 15:10:02 -05:00
Daniel Sandler
58cf8299d3 Support new vibrate/silent behavior.
The updated settings tree looks like this:

	[ ] Silent mode (unchanged)
	[ ] Allow vibration in silent mode (new)
		Phone vibrate: (changed from boolean)
		( ) Always
		( ) Only in silent mode
		( ) Never

See change I14cf91b0 for explanation & framework support.

Change-Id: I22ba7bcfa5ddf4e545800083c6e80fb655f211e5
2010-02-26 21:01:59 -05:00
Daniel Sandler
231d880df3 Checkbox (in Sound settings) to control new lockscreen sfx. 2010-02-17 16:41:26 -05:00
San Mehat
1e60c9603e Settings: Refactor for new API and remove some unused references / imports
Signed-off-by: San Mehat <san@google.com>
2010-02-08 16:26:16 -08:00
San Mehat
4a3d713f3a Settings: Refactor for new API & remove obsolete setting
Signed-off-by: San Mehat <san@google.com>
2010-02-02 11:24:29 -08:00
Amith Yamasani
992f10240d Refactor settings hierarchy and clump all volumes in one dialog.
Bug:2362077 Bug:2312836 Bug:2166486

Split Sound and Display into separate top-level settings.
All volume settings (including Alarm volume) now in one Volume dialog.
Remove some sub-texts to reduce clutter.
2010-01-25 14:58:34 -08:00