Commit Graph

42934 Commits

Author SHA1 Message Date
Doris Ling
f6b5dad77c Unregister broadcast receiver from AppInfoDashboardFragment.
- onDestroy() call is missing from the fragment. Added it to unregister
the receiver that listens to the package remover.

Change-Id: I27c67a19e11824116849b769f0a7951b80c40f84
Fixes: 72879457
Test: make RunSettingsRoboTests
2018-02-02 16:13:47 -08:00
TreeHugger Robot
6a4c3301ec Merge "Fix NPE when instantiating SettingsPreferenceFragment" 2018-02-02 23:38:21 +00:00
TreeHugger Robot
e07e8cc423 Merge "Introduce boolean flags to show/hide battery/memory in App info." 2018-02-02 22:20:09 +00:00
Doris Ling
72489725c6 Change superclass to InstrumentedFragment.
- for fragments that do not implement the preference screen, change them
to inherit from InstrumentedFragment instead.

Change-Id: I791c2634024bd2c248efea955be5c680180d735c
Fixes: 68277111
Test: make RunSettingsRoboTests
2018-02-02 13:41:16 -08:00
TreeHugger Robot
36952523bb Merge "Update suggestion UI" 2018-02-02 21:23:24 +00:00
TreeHugger Robot
7bd80f15fe Merge "Fix VisibleForTesting annotation in AppStateAppOpsBridge" 2018-02-02 20:51:32 +00:00
Ben Lin
3bf23ff59e Introduce boolean flags to show/hide battery/memory in App info.
This adds two flags:
config_show_app_info_settings_memory
config_show_app_info_settings_battery

Which when individually set to false, will hide them item from "App
info" which is accessed from clicking on an application in Apps &
notifications -> App info.

Bug: 62379413
Test: make RunSettingsRoboTests
ROBOTEST_FILTER=com.android.settings.applications

Change-Id: Ifb3b644901728dc7ea04d13198abddaa7b230538
2018-02-02 12:18:47 -08:00
Fan Zhang
a10004661c Fix NPE when instantiating SettingsPreferenceFragment
Change-Id: I3997d6436f358b802dff9be307c36031f4351ab4
Fixes: 72868191
Test: robotests
2018-02-02 12:18:39 -08:00
TreeHugger Robot
4d869f2859 Merge "Support GLIF v3 for lock screen settings" 2018-02-02 20:12:43 +00:00
TreeHugger Robot
1297029728 Merge "Always show wifi wake setting." 2018-02-02 19:44:23 +00:00
Doris Ling
7fa083ece9 Update suggestion UI
- reduce space above and below the suggestion header
- reduce space around the suggestion cardview
- set the font family for the suggestion header and title.

Change-Id: Ief6247005f1e69fe5025af60f3c9627d357d94a4
Fixes: 72710227
Test: visual
2018-02-02 11:34:03 -08:00
Tony Mantler
fb9e3afc84 Fix VisibleForTesting annotation in AppStateAppOpsBridge
Should be PRIVATE (the default) and not NONE since it's called from the
regular constructor for the object.

Bug: Clean-up
Test: Compiles
Change-Id: I9eb8881ed03dcddd1b478e313f5a314b338fccd7
2018-02-02 10:48:03 -08:00
TreeHugger Robot
d1afc3e42e Merge "Add ability to show/hide different device information." 2018-02-02 18:41:39 +00:00
yuemingw
a1416d2849 Rename DISALLOW_CONFIG_LOCATION_MODE to DISALLOW_CONFIG_LOCATION.
Bug: 72732481
Test: CtsVerifier test already in
Change-Id: I12a0593eba270727808588efc4c42c4e066c9446
2018-02-02 16:48:15 +00:00
Beverly Tai
7142be5630 Merge "Zen Condition text and primary click changes" 2018-02-02 15:27:04 +00:00
Jin Dong
bdcd50328f Merge "Fix memory leak of page "Languages & input"" am: f94ff6ce6f am: 6d55e0633e
am: dd91556778

Change-Id: I5fb3f956aab62b5500bfa5d753061980371b41b5
2018-02-02 14:52:58 +00:00
Jin Dong
dd91556778 Merge "Fix memory leak of page "Languages & input"" am: f94ff6ce6f
am: 6d55e0633e

Change-Id: I841c0d095c15849c409b1c1ebb9d47b79b438788
2018-02-02 07:09:00 +00:00
Jin Dong
6d55e0633e Merge "Fix memory leak of page "Languages & input""
am: f94ff6ce6f

Change-Id: Ie22f77eff353807e5a24cb6a2317b688f9b70193
2018-02-02 03:55:08 +00:00
TreeHugger Robot
7262d37c53 Merge "Highlight row (instead of ripple) when come from search." 2018-02-02 01:15:36 +00:00
TreeHugger Robot
abf3b8ad88 Merge "Fixes crash from selecting uninstalled app info from recents." 2018-02-02 00:35:42 +00:00
Joe LaPenna
3810036691 Always show wifi wake setting.
Remove WIFI_WAKEUP_AVAILABLE config setting its available by default.
Remove check for NETWORK_RECOMMENDATIONS_ENABLED, the feature no longer
uses the recommender.

Test: make RunSettingsRoboTests RunSettingsLibRoboTests;
Test: atest SettingsBackupTest; manual/exploratory
Bug: 69624403
Bug: 67952636
Change-Id: Ia65f7f9349e77a13ad4af1dbd992b28a5cb16368
2018-02-01 16:08:55 -08:00
Treehugger Robot
f94ff6ce6f Merge "Fix memory leak of page "Languages & input"" 2018-02-01 23:41:43 +00:00
Doris Ling
e679e9b1b4 Fixes crash from selecting uninstalled app info from recents.
- when the package is uninstalled, also remove it from the recent tasks
- move retrieveAppEntry() from onCreate() to getPreferenceControllers()
so that if the package info is invalid, do not create any controllers,
as the activity will be finished anyway.

Change-Id: Ibbfa16e3d1f941a0a200e78ec73a06ca8511f82b
Fixes: 72656345
Test: make RunSettingsRoboTests
2018-02-01 14:37:25 -08:00
Beverly
c5ae162768 Zen Condition text and primary click changes
- Zen condition in settings has same secondary text as dnd qs tile
- Zen condition's primary click brings user to DND settings instead of
ZenPanel

Test: manual
Change-Id: I0090c09e19376d3aafff45a893485d19cd7b91da
Fixes: 72570739
2018-02-01 17:24:49 -05:00
TreeHugger Robot
a03335e0b9 Merge "Hide "Phone number" from About page if not call enabled." 2018-02-01 21:08:51 +00:00
Fan Zhang
3d516e7607 Highlight row (instead of ripple) when come from search.
- Moved HighlightableAdapter to its own class
- Replaced ripple with blue background
- Bluebackground only stays for 5 seconds. After that it's replaced by
  ?attr/selectableBackground

Misc fixes.

- Fix NPE in UserSettings
- Update char limit on a new string

Change-Id: I4687e54e71fd7b9243f520b7630563df58be23d4
Fixes: 71715698
Fixes: 72761974
Test: robotests
2018-02-01 12:35:25 -08:00
TreeHugger Robot
b67375876c Merge "Enforce disallow switch user in user settings" 2018-02-01 19:47:44 +00:00
TreeHugger Robot
0186c9d223 Merge "Check icon tintable flag of the Suggestion." 2018-02-01 19:12:35 +00:00
TreeHugger Robot
12fd732b55 Merge "Handle the Settings.DEVICE_NAME_SETTINGS intent." 2018-02-01 18:24:51 +00:00
Alex Chau
ffae4c1a0e Enforce disallow switch user in user settings
Disallow the following actions which result in switch user when DISALLOW_USER_SWITCH is set
- Creating guest
- Showing user setup dialog for newly created user
- Clicking uninitialized user preference

Bug: 71694430
Test: CTSVerifier DeviceOwnerPositiveTest - DISALLOW_USER_SWITCH
Test: m -j ROBOTEST_FILTER=UserCapabilitiesTest RunSettingsRoboTests
Test: m -j ROBOTEST_FILTER=AddUserWhenLockedPreferenceController RunSettingsRoboTests
Test: m -j ROBOTEST_FILTER=UserSettingsTest RunSettingsRoboTests
Change-Id: Ia4c7e7b4947bfaf2ebeef4d32a473bdac542d6a6
2018-02-01 17:49:41 +00:00
TreeHugger Robot
3d8e2c44cb Merge "Enable the Advanced Connected settings." 2018-02-01 04:52:34 +00:00
Dmitry Shmidt
6e5c590d0c Merge "Fix dev settings crash when no OEM unlock service" am: 44cacaa8f1 am: f6d960ac31
am: 2ac3120a01  -s ours

Change-Id: I6df41d962d18ba21424dc408340f6eaaa239c095
2018-02-01 03:25:52 +00:00
jackqdyulei
dbaea5af63 Clean up WifiTetherPreferenceController
In previous code there are two main issues:
1. It listens to update from both WIFI_AP_STATE_CHANGED_ACTION and
ACTION_TETHER_STATE_CHANGED. It is unnecessary because they provides
same info(whether wifi hotspot is enabled, enabling...)

2. New API softApCallback already covers the
WIFI_AP_STATE_CHANGED_ACTION, so we don't need this broadcast anymore.

This cl fixes those two issues by cleaning up BroadcastReceiver and
update the tests.

Bug: 72702183
Test: RunSettingsRoboTests
Change-Id: I21c2818e0f0185172f34447a1716dc47ee065e23
2018-01-31 18:21:53 -08:00
Daniel Nishi
b4b448e9f5 Enable the Advanced Connected settings.
This allows the intent to work. Otherwise, the receiver isn't there.

Change-Id: I0005d451e9fa4565f5a27a83a5464a8db59ef5a8
Fixes: 72764649
Test: Predictive settings test spec manually ran
2018-01-31 17:47:33 -08:00
TreeHugger Robot
e333b46d2c Merge "Tweak searchbar padding" 2018-02-01 00:55:32 +00:00
Doris Ling
0e96107ddc Check icon tintable flag of the Suggestion.
- instead of checking the icon resource package, check the icon tintable
flag to see if we should tint the suggestion icon.

Bug: 72330968
Test: make RunSettingsRoboTests
Change-Id: I4767df05bebf815774dbd8e528c7ac0f5b902d44
2018-01-31 16:55:10 -08:00
Dmitry Shmidt
2ac3120a01 Merge "Fix dev settings crash when no OEM unlock service" am: 44cacaa8f1
am: f6d960ac31

Change-Id: I536daa3948be136524e35e35448df09eaa6ad9da
2018-02-01 00:29:23 +00:00
Dmitry Shmidt
f6d960ac31 Merge "Fix dev settings crash when no OEM unlock service"
am: 44cacaa8f1

Change-Id: Ica60f5411908a8edb34b9263ee8d6d6b4617587b
2018-02-01 00:19:30 +00:00
Dmitry Shmidt
44cacaa8f1 Merge "Fix dev settings crash when no OEM unlock service" 2018-01-31 23:46:54 +00:00
Jerry Zhang
240f8c14bf Merge "Add new USB details screen for Connected Devices 2.0" 2018-01-31 23:41:32 +00:00
TreeHugger Robot
644bea8e0e Merge "Use SystemUpdateManager to provide system update info." 2018-01-31 22:05:21 +00:00
Fan Zhang
49d82be744 Tweak searchbar padding
Change-Id: Ied7b803ae05eb8d69b478675c7c3e66fb39e4d1c
Fixes: 72317470
Test: visual
2018-01-31 13:35:46 -08:00
TreeHugger Robot
b832f737c3 Merge "Remove suggestion UI v1 codes." 2018-01-31 21:15:18 +00:00
Fan Zhang
74731f9fa6 Merge "Misc fixes for account/users fragments" 2018-01-31 21:13:31 +00:00
Fan Zhang
5c2699962b Use SystemUpdateManager to provide system update info.
Change-Id: I38b631cda8aa63e478c74625eba3d18f9a5723bd
Fixes: 36874007
Test: robotests
2018-01-31 12:16:17 -08:00
Jason Monk
8337ad3be6 Fix dev settings crash when no OEM unlock service
Test: Open dev settings, no crash
Change-Id: I028c52ee58d7262e9fbd015289d7848b397c82e3
2018-01-31 14:55:58 -05:00
TreeHugger Robot
295a55b2fd Merge "AR/FR: Keyboard challenge takes precedence." 2018-01-31 19:42:03 +00:00
Jerry Zhang
d18d6f1022 Add new USB details screen for Connected Devices 2.0
Also updated UsbBackend to use the new UsbFunctions
api.

Added new unit tests for UsbDetailsHeaderController
and UsbDetailsProfilesController.

Bug: 69333961
Test: make RunSettingsRoboTests
Change-Id: I133750190bb61dfe0e20b06f50e50ea13b347f1e
2018-01-31 11:23:08 -08:00
Doris Ling
a5d0c3e36e Remove suggestion UI v1 codes.
- remove the check for feature flag for suggestion UI v2 and switch to
use the v2 codes.
- remove all code related to v1 of suggestion UI

Fixes: 70573674
Test: make RunSettingsRoboTests

Change-Id: I99ab318c1c0192508a9c5e9e708e86319120d55b
2018-01-31 10:59:40 -08:00
Fan Zhang
dc2a3528d5 Misc fixes for account/users fragments
- Hide add user button when it's not functional
- Display "No accounts added" under accounts setting when there is no account.

Change-Id: Iefede9939d206eb3064fa22bdcfbcb1e826f29ab
Fixes: 72643060
Test: robotest
Test: 72713118
2018-01-31 10:55:40 -08:00