Menghan Li
2090748195
Merge "Fine tune Caption size and style preview height for tablet" into tm-dev
2022-04-21 13:06:13 +00:00
menghanli
d44da3b959
Fine tune Caption size and style preview height for tablet
...
Root cause: We introduce the material design illustration in Android S. The most of illustration preview height is 300dp, but the SubTitleView preview keep 200dp in the phone and 150dp in tablet. The value is defined in 2017.
Solution: Align material design illustration height which looks a lot closer to an actual video, without pushing too much content below the screen.
Bug: 227264630
Test: Manual testing
Change-Id: I1a9040f50dfb6fb95c1cadbe4e7e4d24ff8ab058
2022-04-21 17:24:37 +08:00
TreeHugger Robot
6e1d390e2f
Merge "[Settings] Code refactor for Lifecycle listening" into tm-dev am: a7e03159cb
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17859345
Change-Id: I56837b44d3a33b846fe1e44ea969cc3166081360
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-04-21 09:15:53 +00:00
Peter_Liang
7f67e278ca
Fine-tune the location and style of the reset button in the “Display size and text” page.
...
Bug: 222419452
Test: manual test
Change-Id: I9099f13c715ce29cce8d52f6ca9cc47a4fa22306
2022-04-21 17:09:10 +08:00
menghanli
0d47c548d9
Fix Live Caption does not follow caption size if caption is not enabled
...
Root cause: Changing captions style without turning on the preference WHILE Live Caption is running works when it shouldn't.
Solution: Turn on the show caption if users change caption size and style by UX suggestion.
Bug: 221051127
Test: Manual testing
1. Turning on/off Live Caption and Caption Manager
2. Changing styles when Caption Manager is off
Change-Id: Ie6cfb9e0b7325c2e469ac8b6a7d359b843cc173a
2022-04-21 17:01:15 +08:00
TreeHugger Robot
a7e03159cb
Merge "[Settings] Code refactor for Lifecycle listening" into tm-dev
2022-04-21 08:07:49 +00:00
Stanley Wang
2b7cadac12
Fix the problem that apps can read SIM card information through
...
screenshots.
Fix: 217377618
Test: manually test and review the UI
Change-Id: I645c4acc9943a17430889dfeee064a42178870ec
2022-04-21 14:02:11 +08:00
PETER LIANG
a70eecc2b3
Merge "Prevent cutting the thumb of the LabeledSeekBarPreference from different themes." into tm-dev am: e774a70cba
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17822266
Change-Id: Iad200b4be8e8f4e819f60e431f9b0cb7e35da1f4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-04-21 02:03:21 +00:00
PETER LIANG
50a6b46f51
Merge "Fix that the color of each option and subtext of Display size and text has the color difference." into tm-dev am: 62be1f278c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17822268
Change-Id: I2e7d352611f8ee628ec532fdda5e82431a2dca0d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-04-21 02:03:10 +00:00
PETER LIANG
e774a70cba
Merge "Prevent cutting the thumb of the LabeledSeekBarPreference from different themes." into tm-dev
2022-04-21 01:35:25 +00:00
PETER LIANG
62be1f278c
Merge "Fix that the color of each option and subtext of Display size and text has the color difference." into tm-dev
2022-04-21 01:28:10 +00:00
Abel Tesfaye
6cda44f810
Merge "Add accessibility string description for auto rotate" into tm-dev am: 3adc967449
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17835757
Change-Id: I2d2fe276a2d0841da10c15e6a3a7dada1dc69d9e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-04-20 21:36:44 +00:00
Abel Tesfaye
3adc967449
Merge "Add accessibility string description for auto rotate" into tm-dev
2022-04-20 21:31:23 +00:00
Menghan Li
caf42f2cc7
Merge "Fix quick settings tooltip changed when color correction fab clicked" into tm-dev am: ef9178146c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17799712
Change-Id: I7a88099ca0aac552e8608bf3d066ff1030f9f1d0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-04-20 21:27:14 +00:00
Menghan Li
ef9178146c
Merge "Fix quick settings tooltip changed when color correction fab clicked" into tm-dev
2022-04-20 21:05:29 +00:00
Bonian Chen
81d230b250
[Settings] Code refactor for BroadcastReceiver under Lifecycle
...
This is an implementation of BroadcastReceiver which supported by
LifecycleCallbackConverter.
Registration of BroadcastReceiver only take place when Lifecycle in
RESUME status.
Bug: 229689535
Test: unit test
Change-Id: Ia2af82d5cbb391034627e5259a9e0c8683a0c5a1
(cherry picked from commit c2030898ef
)
2022-04-20 16:54:41 +00:00
PETER LIANG
eff73403b7
Merge "Should popup the confirmation toast after clicking the reset button." into tm-dev am: 8cb0439d9c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17822267
Change-Id: I543d48929fffe3e7da4f218bcf99a7feeca143e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-04-20 15:01:57 +00:00
TreeHugger Robot
a02cd9a9a6
Merge "Check null BT profile to prevent crash" into tm-dev am: f792528a8f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17822265
Change-Id: I4da83ee7f9175771ae83660daacffd9528911e40
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-04-20 14:58:39 +00:00
Bill Lin
2f571e625b
Merge "Set IME_FLAG_NO_EXTRACT_UI for ImeAwareEditText" into tm-dev am: 426f8a58e1
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17799713
Change-Id: If52256798af1ea847e4106939a424695c8ca27e1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-04-20 14:56:37 +00:00
Bill Yi
1387d55ef6
[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev am: 052970997d
-s ours am: c88b882013
-s ours am: 2e39766a1f
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17801571
Change-Id: Idd019c9a58d2d6c6ae77e7cbb7fe49caab4a969c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-04-20 14:54:39 +00:00
Bill Yi
e40f48737c
[automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 442f62eb55
-s ours am: 5e99e584f5
-s ours am: a20fed1d1c
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17801571
Change-Id: Ifbbfd334549063018382a15eadf92793eefe1df1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-04-20 14:54:38 +00:00
Bill Yi
58b1768062
[automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 64a0937f54
-s ours am: 9d597ae5b0
-s ours am: cc6641c043
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17801771
Change-Id: I1a275c4accf1366db2fe012dc11202a1ab30bfb7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-04-20 14:51:11 +00:00
Xin Li
f6cf1a9647
[automerger skipped] Merge sc-v2-dev-plus-aosp-without-vendor@8433047 am: 99d834b0b8
-s ours am: 024fe4b39a
-s ours am: 39e1357748
-s ours
...
am skip reason: Merged-In I800f0f39a469a95eb36eeaaeb2aa60a39fd916d3 with SHA-1 d0a23dc840
is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17805671
Change-Id: I32af4fccfe0a22eeac73c78cf6420a2b0f5bc77d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-04-20 13:05:28 +00:00
Bonian Chen
3856ac4be9
[Settings] Code refactor for async Lifecycle listening
...
This is an extension of LifecycleCallbackAdapter.
A postResult(T) and a Consumer<T> is designed for supporting pass result
back to UI thread, and is invoked only when required.
Bug: 229689535
Test: unit test
Change-Id: I0ef5afc31cd23aa865a2dd1d05f9b212242c2e41
(cherry picked from commit 5d2a76cbb4
)
2022-04-20 12:47:39 +00:00
Bonian Chen
37a326bd3e
[Settings] Code refactor for Lifecycle listening
...
This is an abstract class for building a set of callback behavior
based on Lifecycle status change.
Through extending this class, the implemented methods are invoked
only when required.
Bug: 229689535
Test: unit test
Change-Id: I7534393546f821738a63ebde121a5a88ee03b23b
(cherry picked from commit 9a4c66d23b
)
2022-04-20 12:46:26 +00:00
PETER LIANG
8cb0439d9c
Merge "Should popup the confirmation toast after clicking the reset button." into tm-dev
2022-04-20 12:37:22 +00:00
menghanli
a9e6e8c811
Fix quick settings tooltip changed when color correction fab clicked
...
Root cause: Users click on color correction fab to make foreground activity recreate. When recreated, the ag/13472947 makes the MainSwitch updates to ON status and get the callback for #onPreferenceToggled. It pops up the direct-use style tooltip rather than the edit style tooltip.
Soluton: Reference #updateSwitchBarToggleSwitch to early returns if values are same.
Bug: 229167631
Test: Manual testing
Change-Id: I6781fd509db7538898ad6ff0ae47124c9b9e1bc5
2022-04-20 19:18:43 +08:00
Peter_Liang
c5551dc974
Fix that the color of each option and subtext of Display size and text has the color difference.
...
Change the android:selectable from false to true to avoid the title and summary impacted by color style.
Fix: 229560847
Test: manual test
Change-Id: Iec2ba560538a4f69f79198015bf6a24fb9a7caca
2022-04-20 16:29:36 +08:00
TreeHugger Robot
f792528a8f
Merge "Check null BT profile to prevent crash" into tm-dev
2022-04-20 07:43:49 +00:00
Peter_Liang
b833fe1bad
Should popup the confirmation toast after clicking the reset button.
...
Goal: Users may not notice what the change after resetting all settings configs in the Text and reading options. So we will use the toast to give nice feedback for them.
Fix: 220126995
Test: make RunSettingsRoboTests ROBOTEST_FILTER=TextReadingPreferenceFragmentTest
Change-Id: Ife42b0c9d8a0241d7b8c3e5dbe7f9f1e2a6d759a
2022-04-20 15:39:11 +08:00
Bill Lin
426f8a58e1
Merge "Set IME_FLAG_NO_EXTRACT_UI for ImeAwareEditText" into tm-dev
2022-04-20 06:17:35 +00:00
Bill Yi
2e39766a1f
[automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev am: 052970997d
-s ours am: c88b882013
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17801571
Change-Id: I2edb7f5be9795a90d85fe3a328c870df2278a761
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-04-20 06:12:31 +00:00
Bill Yi
a20fed1d1c
[automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 442f62eb55
-s ours am: 5e99e584f5
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17801571
Change-Id: I754ea0efc92ac2178e7d6b64773e46536109897f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-04-20 06:12:30 +00:00
Bill Yi
cc6641c043
[automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 64a0937f54
-s ours am: 9d597ae5b0
-s ours
...
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17801771
Change-Id: I7ecd596c4f3d96940cca64a5296acc451039d79c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-04-20 06:06:21 +00:00
Peter_Liang
3954a79773
Prevent cutting the thumb of the LabeledSeekBarPreference from different themes.
...
Add the attribute “clipChildren” as false to avoid cutting.
Bug: 219415822
Test: manual test
Change-Id: I0c565896279111e65600d1b41c576106a8de7136
2022-04-20 13:18:56 +08:00
Hugh Chen
76e230918f
Check null BT profile to prevent crash
...
Bug: 229802811
Test: build pass
Change-Id: Idf9f32ec08793784fbce05d34c53cdf53cddb312
2022-04-20 04:53:23 +00:00
Xin Li
39e1357748
[automerger skipped] Merge sc-v2-dev-plus-aosp-without-vendor@8433047 am: 99d834b0b8
-s ours am: 024fe4b39a
-s ours
...
am skip reason: Merged-In I800f0f39a469a95eb36eeaaeb2aa60a39fd916d3 with SHA-1 d0a23dc840
is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17805671
Change-Id: I129b65c2db67aa72a0f3d4de00b598e2fa64e09f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-04-20 04:47:34 +00:00
Menghan Li
88f77b41a0
Merge "Fix wrong glifLayout padding for tablet resolution" into tm-dev am: 4d1e327457
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17799717
Change-Id: Iba1caf88eff20ea946c5869a9f862c8dac7f3350
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-04-20 04:06:41 +00:00
Bill Yi
af08983841
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: I0334114d89432b00e1bd029ff6cf13c4f841c6de
2022-04-20 04:02:18 +00:00
Bill Yi
9896cc4089
Import translations. DO NOT MERGE ANYWHERE
...
Auto-generated-cl: translation import
Change-Id: I1f8f3afe70d6fddf885a37b9ba3cae0946d7d692
2022-04-20 03:47:49 +00:00
Menghan Li
4d1e327457
Merge "Fix wrong glifLayout padding for tablet resolution" into tm-dev
2022-04-20 03:36:56 +00:00
lbill
6a45659d7b
Set IME_FLAG_NO_EXTRACT_UI for ImeAwareEditText
...
Without IME_FLAG_NO_EXTRACT_UI, device launch ChooseLockPassword
in some cases, mPasswordEntry will go to extrac UI which is
not compliance UI/UX design.
Test: make and check visual of com.android.settings.password
ChooseLockPassword & SetupChooseLockPassword activities.
Bug: 222219535
Change-Id: I19777954b5edbc9064a8e930b84d2b4e8337c34a
2022-04-20 09:22:14 +08:00
Bill Lin
7acf8c21d8
Merge "Remove redundant margin from SudContentFrame" into tm-dev am: dc9df4db50
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17799709
Change-Id: Iaab47c22d99b09b861745f98d7daaf795c8e4637
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-04-20 01:17:12 +00:00
Arc Wang
5202c0db9e
Merge "Fix ManageStoragePreferenceController always consume click event" into tm-dev am: 96491e1ea9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17799722
Change-Id: I34d9dbd74d2c11fdd721bb0308920b706065ce9b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-04-20 01:16:54 +00:00
Bill Lin
dc9df4db50
Merge "Remove redundant margin from SudContentFrame" into tm-dev
2022-04-20 01:15:18 +00:00
Arc Wang
96491e1ea9
Merge "Fix ManageStoragePreferenceController always consume click event" into tm-dev
2022-04-20 00:54:15 +00:00
TreeHugger Robot
aed3b7950f
Merge "Remove config_showOperatorNameInStatusBar" into tm-dev am: 883f14f01a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17821437
Change-Id: Ib53561fb5d6ae2f92663b2262a3c5a178e882568
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-04-20 00:24:26 +00:00
TreeHugger Robot
50c155b5f5
Merge "Update auto-rotate strings/toggles for better accessibility" into tm-dev am: 07950adad9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17767144
Change-Id: I36122846bbb6146f1861f62420d5891c4e05c50d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-04-20 00:23:25 +00:00
Abel Tesfaye
c4c027a89d
Add accessibility string description for auto rotate
...
Bug: 221191444
Change-Id: Id82aed3dd648c2b116e831488a0c23fa3efe3ee3
2022-04-20 00:11:46 +00:00
TreeHugger Robot
883f14f01a
Merge "Remove config_showOperatorNameInStatusBar" into tm-dev
2022-04-20 00:03:18 +00:00