Commit Graph

142863 Commits

Author SHA1 Message Date
Matías Hernández
149bd0a5a4 Merge "Improve lifecycle of ZenModeFragment & friends" into main 2024-07-29 20:28:55 +00:00
Matías Hernández
a463b0af7b Fix a11y issues in the schedule editor
* Don't read start / end time as separate labels.
* Fix content description of day buttons (ToggleButton's stateDescription is textOn/textOff -- which are the same for this particular button, thus it wasn't possible to know whether a day was selected or not).

Fixes: 346396147
Test: manual, with Talkback
Flag: android.app.modes_ui
Change-Id: If73a791cf9bd62cf17e058c81a8051b3e7fd82ea
2024-07-29 18:11:34 +00:00
Matías Hernández
691c0c3f6a Fix unwanted animation when opening Modes list
Fixes: 356151158
Test: manual
Flag: android.app.modes_ui
Change-Id: Ibbc54c68c4bcbf75e908d4a36ef2d8f609b5b797
2024-07-29 18:11:17 +00:00
Matías Hernández
b8b897e552 Improve lifecycle of ZenModeFragment & friends
* Don't keep Settings observers longer than start-stop.
* Only call updateState() once on controllers during create->start->resume.
* Remove some duplicate controller update methods from ZenModesFragmentBase (we can directly call DashboardFragment's).
* Don't update controllers if unrelated modes were changed.
* Extract ZenSettingsObserver for use in the link tile later.
* Add tests.

Fixes: 353946788
Test: atest com.android.settings.notification.modes
Flag: android.app.modes_ui
Change-Id: I64b51714d699b5c3a592a76fcb615d2999998829
2024-07-29 20:10:03 +02:00
Alina Zaidi
441a202444 Merge "[dev_option] Update 'Desktop mode on secondary toggle' to be 'Freeform windows on secondary diplay'." into main 2024-07-29 17:49:54 +00:00
Diya Bera
c5e36291ab Merge "Hide background when identity check auth is requested" into main 2024-07-29 16:57:35 +00:00
Hakjun Choi
a0ba9182ad [Internal cleanup] remove warning message for resource ID
Currently we are seeing Drawable com.android.settings:drawable/ic_check_circle_24px has unresolved theme attributes! error
To address this, use Context.getDrawable(int) to provide theme info when using the icon

Bug: 356149221
Flag: EXEMPT bugfix
Test: manually run Satellite setting menu and check the log whether the waring is shown or not
Change-Id: I55fd1bd4cbaf07e7433cdd286e71f88dacc3e1b5
2024-07-29 16:46:38 +00:00
Yuanru Qian
cadfc0187d Merge "Do not cancel bonding during bt pairing when orientation happens." into main 2024-07-29 07:05:55 +00:00
Yuanru Qian
aab162f814 Do not cancel bonding during bt pairing when orientation happens.
Flag: com.android.settings.flags.disable_bonding_cancellation_for_orientation_change
Bug: b/349542301
Test: locally tested.
Change-Id: I56867eb39ca783b23853318c39e0f25ce1a80e6f
2024-07-29 05:42:17 +00:00
Treehugger Robot
224447b3cc Merge "Remove unecessary logs" into main am: 5e487ed591 am: 5079417396
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3191355

Change-Id: Icc26cb00766929916b02230bdabc573d6c95c530
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-29 02:32:49 +00:00
Treehugger Robot
5079417396 Merge "Remove unecessary logs" into main am: 5e487ed591
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3191355

Change-Id: Ifa53f9c0acf7e57ee6a2c1e2fad9e094612aea0b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-29 02:16:39 +00:00
Treehugger Robot
5e487ed591 Merge "Remove unecessary logs" into main 2024-07-29 01:43:55 +00:00
Treehugger Robot
8daa5e4f99 Merge "Migrate to onViewCreated in DataSaverSummary" into main am: 04ed8498ee am: 88f79fe29d
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3188139

Change-Id: Icba45da65537d4af2ad5e109ec5783a2d55ccafa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-28 21:18:22 +00:00
Treehugger Robot
88f79fe29d Merge "Migrate to onViewCreated in DataSaverSummary" into main am: 04ed8498ee
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3188139

Change-Id: Ib0e4725e3b490e70d9518a2f02c418de2216e638
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-28 21:06:34 +00:00
Treehugger Robot
04ed8498ee Merge "Migrate to onViewCreated in DataSaverSummary" into main 2024-07-28 20:52:34 +00:00
Joshua Mccloskey
3274acfc27 Merge "Update preferences after a fingerprint is removed." into main 2024-07-27 01:23:03 +00:00
Treehugger Robot
8c6cb9a011 Merge "Add setting illustration to notification cooldown" into main 2024-07-27 00:01:09 +00:00
Treehugger Robot
28ce355bf8 Merge "Remove unused resources since A11yServiceWarning is moved to framework" into main 2024-07-26 23:16:09 +00:00
Joshua McCloskey
1d9ea3fbe8 Update preferences after a fingerprint is removed.
Test: Manually verified preferences are removed.
Fixes: 355572367
Flag: EXEMPT bugfix
Change-Id: I14a09b67b8be3cbe0c5d46a959a29c333c46a872
2024-07-26 22:00:30 +00:00
Matías Hernández
e19b8743c8 Merge changes from topic "fix-weird-animation" into main
* changes:
  Fix jiggle when opening custom manual modes
  Allow turning off currently active modes
2024-07-26 20:58:15 +00:00
Treehugger Robot
dc8b74e343 Merge "Make adb team OWNERS of all Adb settings" into main am: 998787ffa8 am: ee6f5cf1ed
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3195878

Change-Id: Ifa37256b70cc3c1d7c6b22637cba040bce62ca3e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-26 18:39:33 +00:00
Treehugger Robot
ee6f5cf1ed Merge "Make adb team OWNERS of all Adb settings" into main am: 998787ffa8
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3195878

Change-Id: Idcd085b62b69bace7ddfda325b1645b6b89440ca
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-26 18:25:24 +00:00
Treehugger Robot
998787ffa8 Merge "Make adb team OWNERS of all Adb settings" into main 2024-07-26 18:01:59 +00:00
Fabien Sanglard
c7adef9634 Make adb team OWNERS of all Adb settings
Test: NA
Bug: 355088188
Flags: NA
Change-Id: I59c037765940a26509f1d312b4c8c2e0105a3580
2024-07-26 10:57:43 -07:00
Chun-Ku Lin
b5e4a01553 Remove unused resources since A11yServiceWarning is moved to framework
Bug: 303511250
Flag: EXEMPT pure cleanup
Test: Build succeed
Test: atest com.android.settings.accessibility
Change-Id: Ic1813b4489be617c006426056abae3876c77a727
2024-07-26 17:56:32 +00:00
Chun-Ku Lin
75db151f96 Merge "[Flag cleanup] edit_shortcuts_in_full_screen is always on now" into main 2024-07-26 17:46:52 +00:00
Matías Hernández
e8306014f0 Fix jiggle when opening custom manual modes
Looks like setting Preference visibility in updateState() is too late to avoid an animation, and isAvailable() should be used instead. This forces us to split ZenModeSetTriggerLinkPreferenceController (which handled the category and its two children) into separate controllers for the category and each child. Although untangling this code was annoying, the result is arguably cleaner, since the two child preferences deal with different things.

Fixes: 355623101
Test: atest com.android.settings.notification.modes
Flag: android.app.modes_ui
Change-Id: I5fb1b3cbe424973b852f820ecf948491c050421f
2024-07-26 17:44:53 +00:00
Treehugger Robot
c9433c2d52 Merge "Sync settingslib/datastore library" into main 2024-07-26 17:36:14 +00:00
Treehugger Robot
012f244c9f Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-07-26 17:23:29 +00:00
SongFerng Wang
b1ce525751 Merge "Can not reset the sim name in the onboarding sim flow" into main 2024-07-26 16:12:48 +00:00
Matías Hernández
a847a03a17 Merge "Add icons for segments in Mode page and (some) subpages" into main 2024-07-26 14:16:33 +00:00
Alina Zaidi
e85695f88c [dev_option] Update 'Desktop mode on secondary toggle' to be
'Freeform windows on secondary diplay'.

Make sure the toggles enables freeform support on devices. This remove
reliance on 'Enable freeform windows suppport' toggle when using this
toggle.

Also update strings for all toggles to just use term 'freeform windows'
instead of 'desktop mode' or 'freeform windowing experiences'.

Two toggles have the same name 'enable freeform windows', but users will
see only one of them at a time.

Test: Added new tests
Bug: 348193756
Bug: 348186127
Flag: EXEMPT minor change
Change-Id: Ic4528618e6902d084c58a6b5ddeb4b92d63386d6
2024-07-26 13:33:23 +00:00
Bill Yi
b3ebc1220b Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1fc93d95bece9f69984207b216055e7fac9f2d1e
2024-07-26 06:11:06 -07:00
Bill Yi
804ea88c6d Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-07-26 13:05:07 +00:00
Matías Hernández
69ce43462e Allow turning off currently active modes
Even if they don't allow manual invocation. The button will disappear afterwards -- maybe not perfect but good enough.

Fixes: 355613076
Test: atest ZenModeButtonPreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: I36cc96f7da78266be1a03e947304fc8e600899de
2024-07-26 14:47:07 +02:00
Edgar Wang
74fa4310c8 Merge "Fix Talkback focus on random position when launch Settings homepage" into main 2024-07-26 11:54:50 +00:00
Matías Hernández
6da822d228 Add icons for segments in Mode page and (some) subpages
Fixes: 341996820
Test: manual (only visual changes)
Flag: android.app.modes_ui
Change-Id: I8b8b1cb7cfe610da60b34b32b479b3ffd79a2ac7
2024-07-26 13:50:49 +02:00
Jacky Wang
5164cd8cbd Sync settingslib/datastore library
Bug: 325144964
Test: atest SettingsRoboTests:BatteryOptimizeUtilsTest
Flag: EXEMPT sync library source code
Change-Id: I3d980f1d36e9fce7633df23107fae612bc028b5e
2024-07-26 19:40:50 +08:00
songferngwang
9fb316de8b Can not reset the sim name in the onboarding sim flow
After the sim name has been changed, the user changed back to original one.
The map did not remove the sim item, so the onboarding flow change the
sim name.

Bug: 355138239
Flag: EXEMPT bugfix
Test: atest SimOnboardingServiceTest
Change-Id: If4276320c939604b48cf2ce8c1b6b553da699c28
2024-07-26 07:06:53 +00:00
Chelsea Hao
3e285680b3 Merge "Change text color for better contrast" into main 2024-07-26 06:46:59 +00:00
Edgar Wang
ec31852c7b Fix Talkback focus on random position when launch Settings homepage
- set default focus on Search

Bug: 350887106
Test: manual
Flag: com.android.settings.flags.homepage_revamp
Change-Id: Iae1f57fd573d9657bbe3c5397c86d35f9ceaf5b0
2024-07-26 06:30:48 +00:00
Chaohui Wang
87647c0de4 Merge "Fix race condition when requestNetworkScan" into main 2024-07-26 03:29:07 +00:00
Android Build Coastguard Worker
19f1485831 Merge cherrypicks of ['googleplex-android-review.googlesource.com/27918880', 'googleplex-android-review.googlesource.com/28027477', 'googleplex-android-review.googlesource.com/28326671'] into 24Q3-release.
Change-Id: Id237df0d96a112e47b00d5f9ba0884e99f935c86
2024-07-26 02:16:27 +00:00
yomna
a6149ddf36 Remove searchability of CellularSecuritySettingsFragment
Test: m & manual
Bug: b/335554085
Flag: EXEMPT bug fix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:62004763e1f131085b0e834b6c8b01b563f55b73)
Merged-In: Ia226b0848d70a307b80060049ec24b9714ee476a
Change-Id: Ia226b0848d70a307b80060049ec24b9714ee476a
2024-07-26 02:04:26 +00:00
Haijie Hong
8822907513 Add device to to cached device manager if it's not present
Bug: 346923808
Test: atest BluetoothDeviceDetailsFragmentTest
Flag: EXEMPT minor bug fix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a074f274991f6a172855e0253f49b0a6dd63c758)
Merged-In: Ia4987bc7ec93cb6b54d188922b7232d83d528f2f
Change-Id: Ia4987bc7ec93cb6b54d188922b7232d83d528f2f
2024-07-26 02:04:14 +00:00
Rambo Wang
a07738266b Fix Settings restart during Reset mobile nework settings flow
This CL avoids restarting Settings in the reset mobile flow when phone
process is restarted, by switching the usage of the stable content
provider connection to the unstable client.

The CL also arranges restarting phone process as the last reset
operation in the flow (later than RILD reset) to avoid any reset
operation get impacted by phone process restarting.

Since the permission to protect the TelephonyContentProvider has been
renamed, the CL also renames the requsted permision.

Bug: 347047105
Test: atest ResetNetworkOperationBuilderTest
Test: Reset mobile network feature test
Flag: EXEMPT resource update with minor refactoring
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:5ac9d9c8fa0005f787b75052010dcc9935efcb4f)
Merged-In: I7bfa79bc9d7451a4a03269704b0009a3730e287f
Change-Id: I7bfa79bc9d7451a4a03269704b0009a3730e287f
2024-07-26 02:03:55 +00:00
Yi Shiou (Les) Lee
ff6a1750bc Merge "wifi: fix ADB URI doesn't work" into main 2024-07-26 00:26:26 +00:00
Yining Liu
a8eda25cca Add setting illustration to notification cooldown
Add setting illustration to notification cooldown (also known
as adaptive notification, notification avalanche).

Fix: 354048938
Flag: com.android.server.notification.polite_notifications
Test: Manual, Settings - Notifications - Notification cooldown
try with both light and dark mode

Change-Id: If8f5d22116f90d151a285dee6423d82e0edea638
2024-07-25 23:30:24 +00:00
Chun-Ku Lin
919019ca56 [Flag cleanup] edit_shortcuts_in_full_screen is always on now
- Cleaned up the code that won't be executed when the flag is on
- Remove unused resources

Bug: 300302098
Test: Manually verify the user can change the shortcut type, and the
changes are saved
Test: atest com.android.settings.accessibility
Flag: EXEMPT removing com.android.settings.accessibility.edit_shortcuts_in_full_screen

Change-Id: I1e32b724ca3da909feda55e20fb1d51dc4680c09
2024-07-25 22:49:02 +00:00
Matías Hernández
e6198dea95 Merge changes Ibd89a826,I7e788b9b into main
* changes:
  Fixes to CircularIconsPreference & friends
  Update top of modes page
2024-07-25 22:03:15 +00:00