Commit Graph

65 Commits

Author SHA1 Message Date
Julia Reynolds
8126e93ff2 Remove explicit number from string
So it can be translated properly
Test: View notification history screen
Fixes: 222128037

Change-Id: I2d11dd4e427c19ef0c003b1fa2b6882267e2026e
2023-03-16 12:27:37 -04:00
Julia Reynolds
57a42d2a93 Fix settings crash
Test: post notification with an action with a null title, view
notification widget
Fixes: 250836823

Change-Id: I56707c628b3fcc7d6823e4b3736dd26e3d98dfa7
2023-02-27 16:24:21 -05:00
xinghailu
1637a3a10a Cleanup plurals format
Change <one> to <1> in string res file
Test: Update, existing tests still pass
bug: 199230342

Change-Id: Ic3a5259570cb52cd1664638f3b1058c87a631c04
2022-12-27 12:12:11 +08:00
Yining Liu
52ea5d8b7c Increase the number of notification items that can be shown in Notification history - Recently dismissed
Increase the max number of items shown in 'Notification history - Recently dismissed' from 6 to 50.

Bug: 255784319
Test: Manual: Dismiss 6 or more notifications, open Settings-Notifications-Notification History, the max item count under `Recently dismissed` should be 50.
Change-Id: Ia13158ae1ebca448d43bf4c6f6037758b3f40615
2022-11-01 20:20:41 +00:00
Julia Reynolds
688c5c900d Update the 'is valid contentIntent' check
Existing check required that the original request code be 0,
but that's not actually required for the intent to work on this
page

Test: tap on email notification in history, be brought to email
page and not main email list page
Fixes: 232495202

Change-Id: I120022535ddbde19003f2db6f1b81a983d00789d
2022-05-13 17:37:52 +00:00
Julia Reynolds
4d46dddbe7 Fix some history issues
- Work profile notifs not showing
- Work profile icon is too big

Fixes: 228397748
atest: manually view work profile notifs in history
Change-Id: I76f7ad37bcfcf4ee7c909516f456920b7e19c541
2022-04-12 11:14:30 -04:00
Chloris Kuo
c8d09d6844 Merge "Rename Ranking.visuallyInterruptive to isTextChanged" 2021-10-18 23:29:01 +00:00
Chloris Kuo
66c41511cd Rename Ranking.visuallyInterruptive to isTextChanged
Bug: 201087764
Test: manually tested on device
Change-Id: I28b416a4ab9cc74f985c7c7c5c72ca6f7e1b6065
2021-10-18 12:40:01 -07:00
Steven Moreland
0a412b4351 Merge "getBlobAshmemSize -> getOpenAshmemSize" am: 5d30c2de37 am: 90181319da am: 0fbe8bd395
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1856673

Change-Id: I33d698f384f9a75f09486867a9034e638c5e143f
2021-10-14 18:17:56 +00:00
Steven Moreland
519546ce3e getBlobAshmemSize -> getOpenAshmemSize
This API returns the total size of all ashmem memory that is in FDs that
is owned by a Parcel object. It was renamed a while ago, but the name
was never updated in Java.

Bug: 202029388
Test: N/A
Change-Id: Icc428063083110952cf3951721d69cbb919429b1
2021-10-13 11:01:10 -07:00
Julia Reynolds
faa7083c8b Shrink notification history views to fit
If an app hasn't posted many notifications, don't show extra whitespace
after its notifications

Test: manual, look at apps that have posted 1-3 notifications, and 10+
Fixes: 199944158
Change-Id: I8ed3e25cd35956eae9ce2fc5677710a34200bdfc
2021-09-16 21:01:43 +00:00
Julia Reynolds
717e3f6270 Remove unneeded NEW_TASK
To improve animations

Test: manual
Fixes: 197609584
Change-Id: I4cfbe7386014ba1fb6808bfeb283955101c7e1a7
2021-09-07 17:08:41 +00:00
Julia Reynolds
abe9246caa Limit the number of concurrent notifs appear on screen
To avoid an ANR in notification history

Test: Manual; with an app with 10k recent notifications
Bug: 183712803
Change-Id: Ia1340accadf43620c7b5a2c94ca1032cfe49ea59
2021-08-11 20:22:53 +00:00
Julia Reynolds
b61b739661 Properly set all data fields
So stale data doesn't stick around when the view is recycled

Test: manual:
- dismiss a notification
- set a short timer (a custom view notif)
- check history after timer expires (so there are 2 notifs in 'recently
dismissed')
- stop the timer and check history
- there are now 3 notifs and no stale text in any of them
Fixes: 192294011

Change-Id: I229a0388a703b9df0d92eec81066a9a2f67e183e
2021-06-30 12:59:28 -04:00
Jay Aliomer
225607b6eb Rounded ripple notification history snoozed list
currently the ripple has sharpe edges and outside the view bounds

Fixes: b/187868531
Test: Visual
Change-Id: Iedacc6b875fa3bc4319d5e81034777dd873f7e26
2021-05-26 11:55:56 -04:00
Yi-Ling Chuang
3e9c576bb8 Apply transition on the back arrow on NotificationHistory page
When clicking on the back arrow from the action bar in the Notification
History page, the shared x-axis transition won't work.

The onOptionsItemSelected() overriden in the parent activity was
removed, so onNavigateUp() will get called. In the
NotificationHistoryActivity, onNavigateUp() has been overriden, and so
it will just call finish without any transition applied.

Hence, remove the override and just use the one define in
CollapsingToolbarBaseActivity where finishAfterTransition() is called.

Test: rebuild and click on the back arrow to see the transition
Fixes: 188126675
Change-Id: I34ff38ffcfb37d0471d325f2c31b726809fbd91f
2021-05-14 16:11:03 +08:00
Jay Aliomer
dd5137ddfa Notif history Long tap functions as short tap
Test: manual
Fixes: b/175465501
Change-Id: I21602e87ca3d9260ba2e99006ac13d1358e4db0a
2021-04-20 17:14:29 -04:00
Julia Reynolds
9a238e5124 Restyle notif history to beter match shade
Test: manual
Fixes: 184695659
Fixes: 183949048
Fixes: 184695652
Fixes: 185271315
Change-Id: I79a937d7d64e6bdf0014ce3f939e6e96690556b9
2021-04-14 12:28:16 -04:00
Jay Aliomer
01af86409d Notif History Visual Buff
Bug: b/184885964
Test: visual
Change-Id: I390c01bd743ebed020cc8a1a05e8c70d4e9b4eb7
2021-04-12 20:40:43 +00:00
Jay Aliomer
5d10dbc732 Notification history UI buff
Fixes: 182155974
Test: visual test
Change-Id: I028381407504b3cf390987a6fa11c041fddf6198
2021-03-30 14:49:57 -04:00
Mill Chen
8d0de3da05 Add collapsing toolbar to Notification history page
On Android S, collapsing toolbar will be shown in each subsetting
pages. Notification history page doesn't have collapsing toolbar since
it's not a subsetting page. We changed the base activity for Notificatio
history page to eable the feature.

Bug: 178678690
Test: visual verified
1) Settings -> Notifications -> Notification history
2) Check if the collapsig toolbar is existig in this page

Change-Id: I51d66b64dc479bbe14274301c75da67600116772
2021-02-19 18:00:20 +08:00
Stanley Wang
b87ddba6cd Use SettingsLib's MainSwitchBar to replace SwitchBar in Settings.
To log Settings metrics, the MainSwitch extends MainSwitchBar and
replace the SwitchBar in SettingsActivity.

Bug: 175181773
Test: Run robotest and apply the widget in Settings and see the ui

Change-Id: I3add3702e9058ad9192b5172c7cf0e2ccfb55a70
2021-01-14 22:48:31 +08:00
John Li
ba55296a44 Haptic effect on swiping the notification item
Haptic once the swiping on the notification item is going to snap in either directions. The snap-in scenario is about the notification item when there is a "snap back point" i.e. if swiping the item back till a certain point it just snaps back to initial state but once it goes past a certain location it snaps into the new location.

- screenshot, https://screenshot.googleplex.com/6A8Gxs7yRwqAVk2

Bug: 175364588
Test: manual
Change-Id: I7e2ed19bfb7f863502e10233e3e23ee5d434b3b4
2020-12-17 03:31:18 +00:00
Lucas Dupin
56cb882b38 Use theme color instead of fixed one
Notifications don't have fixed background anymore, their colors
are themed based on a dynamic system palette.

Test: manual
Bug: 173561906
Bug: 173561901
Change-Id: Id0a41e04fe3e27d2ae59ab5c61a174211278c4a7
2020-11-21 00:09:51 +00:00
Julia Reynolds
3561ff6e4c Add missing PI flag
Test: manual
Fixes: 172214372
Change-Id: Ifaa07e39a7559448854c8d7c89bab227ecb015ba
2020-11-02 09:41:59 -05:00
Julia Reynolds
992ca635c8 Method name update
Test: make
Bug: 170705349
Change-Id: I83037d8eddaf62b542c79f1283f477d59f0dc6a8
2020-10-27 20:02:07 -04:00
Julia Reynolds
7afb1d7a2b Don't put a null in a spannablestringbuilder
Test: manual
Fixes: 162869220
Change-Id: Iad00ab417edf2dd5d1b83194c6ade2899fd1350c
2020-08-17 12:10:44 -04:00
Julia Reynolds
97894bcfb7 Fix pending intent links
Test: manual
Fixes: 154795795
Change-Id: Ia870bd0bfd90be852121b542100806cac5bac881
2020-08-13 13:21:01 +00:00
Julia Reynolds
3dd023f363 UX updates for notif history
- no relative time
- fix background color in dark theme
- fix text alignment in RTL

Test: manual
Bug: 160061165
Bug: 160388261
Bug: 154795795
Change-Id: I7d4c5a5f81ce5b5ce43fdaa3ee99184906753a76
2020-07-16 16:32:05 -04:00
Julia Reynolds
bfab43571d Increase expand/collapse tap target
Bug: 157160901
Test: manual with voice a11y service
Change-Id: Ic1cdd3ee4f22d66d76718fae11304a0d6128def2
2020-07-09 12:58:45 -04:00
Dan Sandler
9c3cb64e08 Add bubble and shortcut info to notification log debug
Bug: 159442644
Test: adb shell am start -n com.android.settings/.Settings\\\$NotificationStationActivity
Change-Id: I5c628ed52bfb44af1cc99ec9fd3dc436fe296344
2020-06-19 15:44:49 -04:00
Will Brockman
7f43530a15 Statsd UiEvent logging for notification history.
Events logged:
Notif history on/off/open/close
Notif click (recent/snoozed/older)
Notif delete (older)
Notif package history open/close

Additional background: There are 3 notif history sections: snoozed
notifs, recently dismissed notifs, and older notifs. In the snoozed &
recent sections we still know the notif SBN, so actions on those
events are logged with instance ID. The older-notifs section is
grouped by package, and we no longer know the instance ID.

This change depends on change 11692386 in frameworks/base, which adds
UiEventLogger support for the RankingSelected atom.

Bug: 155061525
Test: Manual (statsd testdrive)
Change-Id: If267fca97c40c1bbd8dfa785814c85927ab36c91
2020-06-02 13:07:05 -04:00
Julia Reynolds
e32e6cc981 Some text polish
- Update styles and alignment

Test: manual
Fixes: 157769522
Change-Id: I92113b5e7a918e1ec31acb64aa10457f4c762760
2020-06-01 14:57:30 -04:00
Julia Reynolds
ef4c044053 Some notification history fixes
- Update header count when item swiped away
- Clean up container when last notification is swiped away
- Long pressing on the top two section brings you to settings to
modify notification behavior
- Show more notification content

Test: manual
Bug: 157547283
Change-Id: I1d43cacca7a0f22f83cef9187cf288839e0d5795
2020-05-27 09:45:32 -04:00
Julia Reynolds
edca211a67 Merge "clean up layout & styling of notification history" into rvc-dev 2020-05-22 11:23:59 +00:00
Julia Reynolds
2679bf5af0 clean up layout & styling of notification history
Test: manual
Fixes: 157161601
Fixes: 157162238
Fixes: 157160265
Fixes: 157161125
Fixes: 157160611
Fixes: 157158944
Change-Id: I9853426987549898b7996e9db43f7767e4c41641
2020-05-21 14:55:51 -04:00
Julia Reynolds
39ceee9e00 Only show work profile notifs if enabled
Test: manual, turn off profile
Fixes: 157137055
Change-Id: Ic042300297c09d132e793d13fec18b23d24f2cc8
2020-05-20 12:29:39 -04:00
Julia Reynolds
a1c0269027 Map local context menu to the correct item
Since the position of the item might have changed
if ohter items were deleted

Test: manual: delete item 0/2, item 2/2, then 1/2
Fixes: 156716919
Change-Id: I989a064d3a3f89b5c2692d5a687d759c842e080c
2020-05-19 11:22:31 -04:00
Julia Reynolds
9a6e7329be Remove divider after last items
Fixes: 155890866
Test: manual
Change-Id: Ie0e3f7ad8c1868bda7623718dd60926c300fa353
2020-05-13 14:03:40 -04:00
Julia Reynolds
e4a04eccd8 Fix history task stack
Test: manual
Bug: 154721261
Change-Id: Ib39fff447d0d6571b4267700eaf39e425fa114d7
2020-04-28 19:11:47 -04:00
Julia Reynolds
03acb7a609 Mark work profile apps as such for voice a11y services
Test: manual with a11y service
Fixes: 152728558
Change-Id: I1b8a3efd2d34b3dda2229b8bae49f48d4d31f4d2
2020-04-23 14:59:41 -04:00
TreeHugger Robot
f11da4c787 Merge "Notification history a11y fixes" into rvc-dev 2020-04-21 21:22:44 +00:00
Beverly
4922aa006a Notification history a11y fixes
- When clicking the expand/collapse button to see the posted
notifications from an app in the last 24 hours, refocus accessibility on
the button so the entire button (contentDescription + clickability) are
announced. Previously only the contentDescription update was being
announced.

- Fix local context menu of NotificationHistory elements by calling the
super method in performAccessibilityAction

Test: manual
Fixes: 153396313
Fixes: 153518629
Change-Id: I3d847ec1f2b72dcf411c6c7c7fe2dc061ccfde26
2020-04-21 14:54:45 -04:00
Julia Reynolds
6c8451a89f Set explicit back target for history
Test: manual
Fixes: 153554906
Change-Id: Ic3198afae878e3cfbfbfa7e72b1c71a6f4e74a2e
2020-04-20 11:31:43 -04:00
Julia Reynolds
1845421ef8 Update flows for notification history
- Remove settings observer, since the switch is right here
- Add 'notifications will soon appear' whenever history is empty

Test: manual
Fixes: 153677280
Fixes: 152578971
Change-Id: Ia372fafb3688fe7d45a7634e379f022bcffea169
2020-04-14 13:16:04 -04:00
Julia Reynolds
ecb66ce790 Fixes for notification history
- Fix some crashes
- Fix layout in landscape
- Fix a11y readout

Test: manual
Fixes: 153510934
Fixes: 153554113
Fixes: 153407364
Fixes: 152728558
Change-Id: I6c6bb10d4a67ece61fbf109b4289c4f368206788
2020-04-10 15:34:19 -04:00
Julia Reynolds
94ad6a1959 Adjust tap targets in history
- Fix a crash if an app couldn't be launched
- Fix the height of tap targets and overlap of text

Fixes: 152977855
Fixes: 153199215
Change-Id: Id623f942c7663c977c61df3d1188fe498cab8acc
2020-04-06 19:44:40 +00:00
Julia Reynolds
c7a77f6065 Update history flow
So the screens are more clear when you don't have history
items yet

Test: manual
Fixes: 150211282
Change-Id: Icf1dded3e92ed2121e18bf9a35d570f9efcfda62
2020-04-03 21:00:58 +00:00
Julia Reynolds
6fb9669e44 Some more a11y fixes
Min height, and announcing button changes

Test: manual
Fixes: 152729661
Fixes: 152728211
Change-Id: I886ce046da3dd5b2b93673aee0cd5bdc37d5fc48
2020-04-01 12:05:25 -04:00
Julia Reynolds
eabc1904a7 Remove items from the 'last 24 hours' history on swipe
And make it resiliant to duplicate data from the backend.

Test: manual
Fixes: 148956400
Change-Id: I650c89242c257df1ec34b2879f544d9a5211019a
2020-03-27 17:13:22 -04:00