Commit Graph

418 Commits

Author SHA1 Message Date
Chun-Ku Lin
3aeabcc2c2 Replace ShortcutType with UserShortcutType to reduce duplicate
declaration.

Bug: 323686675
Test: atest
Flag: N/A. Not able to flag the refactor
Change-Id: If1fbe4236bc53f76f5e1af783932c469fc4c6838
2024-03-30 02:41:30 +00:00
Jason Chiu
1908551cc2 Merge "[Safer intents] System" into main 2024-03-27 02:02:26 +00:00
Chun-Ku Lin
4c9d268fdf Rename AccessibilityGestureNavigationTutorial to AccessibilityShortcutsTutorial
AccessibilityGestureNavigationTutorial is not only for displaying
tutorial for accessibility gesture shortcut. It's used for display the
tutorials for all the selected accessibility shortcuts. Renamed the
class to match it's responsibility.

Bug: N/A
Flag: EXEMPT Strict mechanical refactors
Test: build succeed locally

Change-Id: I1dd212abc660454e77f18f770c2ecc17be320eaa
2024-03-26 01:13:28 +00:00
Jason Chiu
d89fd5942f [Safer intents] System
To avoid implicit intents, make intents launch explicitly.

Bug: 323061508
Test: build
Change-Id: Iaf5466f3acd3293e738f450e0117e180b93d4e1c
2024-03-25 18:08:03 +08:00
Andy Wickham
cc10abe1c2 Merge "Allows for system navigation settings to be added dynamically." into main 2024-03-20 03:00:10 +00:00
Andy Wickham
07109c158a Allows for system navigation settings to be added dynamically.
This allows for controller-backed preferences to be added or
overridden via xml.

Similarly, if the controllers cause all of the preferences for
2 or 3 button nav to be unavailable, we hide the settings button.

Bug: 324036308
Test: Manual and unit tests
Flag: NA
Change-Id: I2371f3173076172489966728ac69c8767570cd56
2024-03-14 20:07:33 +00:00
Randy Pfohl
ea76c296d3 Setting content description when illustration is clickable
Test: Built and tested with other cls in topic and verified talkback works properly.

Flag: None

Bug: 319747547

Change-Id: I37cbcc9bc4c830c73913cdad0734a874bd0eac7c
2024-03-13 21:11:30 +00:00
Chun-Ku Lin
deba8599d8 Reflect QS shortcut changes in a11y pages.
Bug: 314843909

Test: manual (modify qs tiles in QS panel while the a11y page is open,
verify the a11y page reflect the qs changes)
Test: atest com.android.settings.accessibility
Test: atest com.android.settings.accessibility.shortcuts

Flag: ACONFIG android.view.accessibility.a11y_qs_shortcut

Change-Id: Ie5b46459faab902912a214ca131eb5d0b105a7ef
2024-03-12 01:32:00 +00:00
Daniel Norman
6c229865c9 Revert "Replace ShortcutType with UserShortcutType to reduce dup..."
Revert submission 25959129-chunkulin-replace-shortcutTypeConstant

Reason for revert: Reverting refactoring, to land after 24Q2 branches off of main. See b/323463488

Reverted changes: /q/submissionid:25959129-chunkulin-replace-shortcutTypeConstant

Change-Id: I323637727f4b642b3a6c626eae62bdaf0032eaf2
2024-02-03 00:23:15 +00:00
Chun-Ku Lin
c2d7daf645 Replace ShortcutType with UserShortcutType to reduce duplicate
declaration.

Bug: 317424693
Test: atest
Flag: N/A. Not able to flag the refactor
Change-Id: I20aea442cb08f047f98422176058acf4b344d2f1
2024-01-20 05:40:52 +00:00
Sunny Shao
076ed573eb Revert^2 "Nullability Annotations replacement"
This reverts commit 19d1d3d15d.

Reason for revert: revert it because this is not the root cause.

bug: 316867690
Change-Id: I0f168dbb64044aa720202af7b1040afd4f028c9c
2024-01-10 07:34:01 +00:00
Sunny Shao
19d1d3d15d Revert "Nullability Annotations replacement"
This reverts commit cf0501e4d7.

Reason for revert: b/317462033, it seems a flaky but revert it first.

Change-Id: Ie1d5e279cca6477fc17d8c27c1ecda8d7a6b2553
2023-12-29 02:28:24 +00:00
sunnyshao
cf0501e4d7 Nullability Annotations replacement
-- Replace the android.annotation.Nullable / android.annotation.NonNull
   with androidx.annotation.Nullable / androidx.annotation.NonNull

Bug: 316867690
Test: build pass
Change-Id: I0c1da55dfb09ece855151c47e0492d6f46538621
2023-12-20 08:50:09 +08:00
Chaohui Wang
08a1c9876e Revert^2 "Migrate to CompoundButton.OnCheckedChangeListener"
8979681a8d

Change-Id: I60edd3aabf49afbe4aa016af780baa68d928bddf
2023-11-07 14:17:15 +00:00
Sebastian Pickl
8979681a8d Revert "Migrate to CompoundButton.OnCheckedChangeListener"
Revert submission 25147565-onSwitchChanged-CompoundButton

Reason for revert: breaking builds 

Bug:309601476

Reverted changes: /q/submissionid:25147565-onSwitchChanged-CompoundButton

Change-Id: Ie746db87d9c642599593aa3d5e5baf6b7ba89c0e
2023-11-07 13:26:36 +00:00
Chaohui Wang
71d1f021af Migrate to CompoundButton.OnCheckedChangeListener
Switch and SwitchCompat are both CompoundButton.

Using CompoundButton in Java will helps migration in the future.

Bug: 306658427
Test: manual - check Settings pages
Change-Id: If2e08a9a9557ec66a3b31ef18cd2e15943098a59
2023-11-07 20:22:27 +08:00
Mill Chen
7e31ff431a Clean up the global action panel
The global actions panel has been renamed to power menu and there is a
new preference for power menu. The legacy perference for global actions
panel is unused. This CL is to remove the preference controller from
Settings.

Bug: 289967656
Test: manual test and robotest
Change-Id: If820f3fa8a188223703ebc6bc68120164108f483
2023-09-27 09:30:27 +08:00
Holly Jiuyu Sun
c2aa51aeae Merge "Update Gesture navigation page to support search." into udc-qpr-dev am: ef6ac74a15 am: 694c9db7f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24452189

Change-Id: I96ee86cee34f30f9f9cb734ba0adc39edf9100f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-23 19:28:17 +00:00
Holly Sun
e23520d520 Update Gesture navigation page to support search.
Make function public to be reused in SettingsGoogle. Add feature flag.

Bug: 294858168
Test: manual
Change-Id: I3c3ba6144303f21ae4f6da3a64e0208ab23a7382
2023-08-22 16:13:36 +00:00
Chaohui Wang
8e2ae547d6 Clean up FeatureFactory.getFeature()
Bug: 286764889
Test: m Settings
Change-Id: I7e472e6b0ca6b7a735c1b92742ddf06c545176fc
2023-08-08 08:41:48 +00:00
Kohsuke Yatoh
5e3cbc3fa6 Merge "Add @SearchIndexable to OneHandedSettings fragment" into main 2023-08-08 04:53:45 +00:00
Kohsuke Yatoh
dd376906de Add @SearchIndexable to OneHandedSettings fragment
Bug: 245267643
Fix: 245267643
Test: Queried "one-handed" and verified "Use one-handed mode" shows up
Change-Id: If752ed3827a9ea86b594c3e4ba5746567e4e43ee
2023-08-07 02:33:16 +00:00
Riley Jones
b4bfea5c54 Expanded accessibility search terms
Items with new keywords:
-Accessibility
-Accessibility Menu
-Autoclick
-Live Caption
-Hearing Aids/Devices
-3-button navigation
-Touch & Hold
-Accessibility Timeout

Bug: 278091482
Test: Build SettingsGoogle, change your system language a few times, then check that the search bar responds to the new terms
Change-Id: Iddaf4f378b63f13141c1c52fbb4daa20f90a5ff8
2023-08-02 17:56:06 +00:00
Chaohui Wang
99457e53a8 Clean up assist gesture from Settings
This one is replaced by "Press & hold power button".

Bug: 287566056
Test: m Settings
Change-Id: Ic9fe8ab29a0b72f1a47f05b18da99ccf68a7f766
2023-06-29 18:17:10 +08:00
Chaohui Wang
16cb921c47 Remove setAssistOnly() from GestureSettings
Fix issue that use(AssistGestureSettingsPreferenceController.class)
could be null.

Bug: 287566056
Test: manually - on System > Gestures page
Change-Id: Ifb78a787c34e2fd0e255a6473b8c514f2788f52e
2023-06-27 16:08:25 +08:00
Chaohui Wang
2e4141e4ab Clean up AwareFeatureProvider from Settings
Bug: 287566056
Test: m Settings
Change-Id: I7f7f57809c55bf8824b427f0d4a232cacdbe88a7
2023-06-25 16:52:34 +08:00
Randy Pfohl
f572cc569e Ensure we launch gesture tutorial as new task
test: built for two pane device and verified it opens full screen
bug: 278918583
Change-Id: Icee33cb4a931e3037eab8e0146eddca55a5fd09d
2023-04-21 16:53:04 +00:00
Pfohl
b094ed8e7d adding new animation to be used when gesture tutorial package is available
test: built and verified animation shows up and is clickable to gesture tutorial menu on handheld devices

bug:248342586
Change-Id: I29a68accf67c4efc6b94058c2702f106edfec0a8
2023-04-07 18:20:15 +00:00
Lifu Tang
caa1b51ef2 Revert "Remove duplicate strings."
Revert submission 19748582-settings_yesno

Reason for revert: Common strings in English could be translated into different strings in other languages.

Reverted changes: /q/submissionid:19748582-settings_yesno

Bug: 272603842
Test: build and open Settings app
Test: atest SettingsRoboTests
Change-Id: Iaad301c5513478fb95e40987ea3ccb4f923d71fa
2023-03-15 22:39:24 +00:00
Edgar Wang
0fd7e6e3e7 Merge "Update lottie illustration for tablet" into tm-qpr-dev am: b5215abde7 am: 366ed57197
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/21154459

Change-Id: I7ba454aa3a58ec6c8f848ac5d09ea2385fdb3a33
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-01 23:06:50 +00:00
Edgar Wang
2f5f6d4ee6 Update lottie illustration for tablet
Bug: 243889662
Bug: 243889643
Test: visual
Change-Id: Icac10e4401da3d704350aef6ef2723ff92ca34f8
2023-02-01 07:27:18 +00:00
jasonwshsu
ad6351d614 [Hearing device shortcut] Setup shortcut for hearing device
* Hearing aids page need to set restricted mode to DISALLOW_CONFIG_BLUETOOTH, so change AccessibilityShortcutPreferenceFragment to extend RestrictedDashboardFragment
* move ShortcutPreference under the device control category for the 1st order

Bug: 237625815
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AccessibilityShortcutPreferenceFragmentTest
Change-Id: I13da8d979694aeab76d8a10edf1348c0ee7810f6
2022-12-28 02:35:53 +08:00
Edgar Wang
37884e90b3 use SettingsEnums instead of MetricsEvent in TapScreenGestureSettings
Change-Id: I6811b954e67001e6cf9089b85c6a9124a5bcb087
Fix: 260076400
Test: rebuild
2022-12-19 04:58:33 +00:00
Kweku Adams
5949fccc7a Remove duplicate strings.
"Yes" and "no" were redefined many times with no clear benefit, so this
consolidates them into one definition.

Bug: 243843096
Test: Build, install, and open the Settings app
Test: atest SettingsRoboTests
Change-Id: I5f84d09f223efd478461ded93aeac82bf7b128d8
2022-08-26 00:07:08 +00:00
Menghan Li
dec32f804c Merge "Fix IllegalStateException to get tile content after device rotate" 2022-08-09 09:01:52 +00:00
menghanli
1ca385591a Fix IllegalStateException to get tile content after device rotate
Root cause: Race condition to get content after the onDetach()
Solution: Add protection to prevent this IllegalStateException

Bug: 239578655
Test: make RunSettingsRoboTests ROBOTEST_FILTER=OneHandedSettings
Test: Manual testing by rotating 100 times quickly
Change-Id: I0a03cf1c01cd34c8ae0b0e70c4ffc41168b18ab8
2022-08-09 02:36:59 +00:00
Chaohui Wang
0441f990f9 Merge "Remove the redundant constructor of SuggestionFeatureProviderImpl" 2022-08-08 06:47:18 +00:00
Peter Zhang
f0013da134 Improve the UI of Press & hold power button settings
The following changes has been made:
- The on/off toggle for Assistant now becomes two radio selectors ("Power Menu" and "Digital Assistant"). This is to make things clearer that Press & hold power button can be configured to power menu.
- The corresponding power menu animation will be shown when "Power Menu" is selected.
- The Assistant specific sensitivity settings and the foot notes are hidden when "Power Menu" is selected.
- Some minor wording updates according to the requests from Assistant / Settings UXW.

Bug: 229722937
Test: robotest, manual
Change-Id: Ib356fba861ad8c4a2626a0e0bd8cf3e4d90ce9a6
2022-07-22 16:07:52 +02:00
Chaohui Wang
80a11a251e Remove the redundant constructor of SuggestionFeatureProviderImpl
Fix: 175167313
Test: robotest
Change-Id: I7ebbaf92398a8300971d592e2ee7a6e0d82c1d2f
2022-07-13 03:44:26 +00:00
Jason Chang
f38cec326a Fix the description of one-handed mode doesn't change immediately in
Gestures page after users turn on/off in Quick Settings

Add ContentObserver URI for observing when settings key
"one_handed_mode_enabled" changes.

Bug: 230041450

Test: manually verified on System > Gestures >
One-handed mode item when turned  on/off in Quick Settings

Test: make RunSettingsRoboTests ROBOTEST_FILTER=
"com.android.settings.gestures.
OneHandedEnablePreferenceControllerTest"

Change-Id: Id6bb53692181dfc3c8a1006017b5a22462dc4ad9
2022-04-26 01:50:43 +08:00
Menghan Li
361d42afe5 Merge "Fix inconsistent shortcut strings on accessibility setting and edit dialog" into tm-dev 2022-04-15 04:00:11 +00:00
menghanli
50520c2d3f Fix inconsistent shortcut strings on accessibility setting and edit dialog
Root cause: Base class provides an override function for accessibility settings shortcut preference. But, it cannot update to the edit dialog.
Solution: Refine the resilience function and base class apply into accessibility settings shortcut preference and edit dailog.

Bug: 228830417
Test: Manual testing on all accessibility page and edit dialog
Change-Id: I84bc63a39cd9cfa7e12944dff20ee6b92879008d
2022-04-15 00:31:03 +00:00
Edgar Wang
257ebe4a5e Index the gesture options in System Navigation Settings page
Fixes: 167536360
Test: manual verify & robotest
Change-Id: Ie1a24a7206153dc1405f8a28369a6bade11ddd39
2022-04-11 21:05:37 +08:00
menghanli
99a9171108 Customized accessibility framework features quick setting tooltips content
- Lowercase for one-handed mode, color correction, color inversion, extra dim in quick settings tooltips if these words are not first words.

Bug: 220655084
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AccessibilityShortcutPreferenceFragmentTest ToggleFeaturePreferenceFragmentTest LaunchAccessibilityActivityPreferenceFragmentTest ToggleAccessibilityServicePreferenceFragmentTest
Change-Id: I309ca48cecb80942112c9d5adde5857c062706c8
2022-03-10 06:40:54 +08:00
menghanli
01d02d3d8e Show different tooltips for QS features auto-added and non-auto-added
There are 2 different kinds of auto-added / non-auto-added subtext in QS tooltips for framework features. Show animation in the settings page for full flow for non-framework services.

Bug: 218968108
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AccessibilityQuickSettingsTooltipWindowTest AccessibilityShortcutPreferenceFragmentTest
Change-Id: I462cfcece959df8b9d97fab8e28337bceca9e25e
2022-02-15 16:09:30 +08:00
menghanli
95eba64f85 Support OHM quick settings tooltips when feature on
Bug: 210356011
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AccessibilityShortcutPreferenceFragmentTest
Change-Id: I3b35d9bb347b7e516db94a4b801a4484f6f38ca8
2022-01-26 07:55:52 +08:00
Super Liu
65d46d6ee4 Set property based on gesture option changed.
System software could do the runtime configuration based on
this added property.

Bug: 193467627
Test: manual test.
Signed-off-by: Super Liu <supercjliu@google.com>
Change-Id: I1897320e1c5d5d446727899328363e6a714983f8
2021-12-02 09:47:02 +08:00
Jason Chiu
7f6b9e26c9 Merge changes from topic "slice-highlight" into sc-v2-dev am: 6821b6be32 am: 026b1b5df6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/16151654

Change-Id: If46903bb26371ea90075d1c6cc063af4d10a88d4
2021-11-02 02:43:42 +00:00
Jason Chiu
1e00dc9c9a Declare a highlight menu key for ButtonNavigationSettingsAssistController
Bug: 204695404
Test: manual
Change-Id: I787824d0a4ef79d697bb7cd254fca6fb9b64d16f
2021-11-01 15:32:39 +08:00
Jason Chiu
2989c50a23 Add highlight menu keys for all toggle pref controllers and custom slices
Bug: 204695404
Test: manual, robotest build pass, unit
Change-Id: Iad2e28ada8ddb766ffa7eff2c8dc581250cbd6f8
2021-11-01 15:00:18 +08:00