Commit Graph

6630 Commits

Author SHA1 Message Date
Treehugger Robot
8c6cb9a011 Merge "Add setting illustration to notification cooldown" into main 2024-07-27 00:01:09 +00:00
Matías Hernández
e8306014f0 Fix jiggle when opening custom manual modes
Looks like setting Preference visibility in updateState() is too late to avoid an animation, and isAvailable() should be used instead. This forces us to split ZenModeSetTriggerLinkPreferenceController (which handled the category and its two children) into separate controllers for the category and each child. Although untangling this code was annoying, the result is arguably cleaner, since the two child preferences deal with different things.

Fixes: 355623101
Test: atest com.android.settings.notification.modes
Flag: android.app.modes_ui
Change-Id: I5fb1b3cbe424973b852f820ecf948491c050421f
2024-07-26 17:44:53 +00:00
Matías Hernández
6da822d228 Add icons for segments in Mode page and (some) subpages
Fixes: 341996820
Test: manual (only visual changes)
Flag: android.app.modes_ui
Change-Id: I8b8b1cb7cfe610da60b34b32b479b3ffd79a2ac7
2024-07-26 13:50:49 +02:00
Chelsea Hao
3e285680b3 Merge "Change text color for better contrast" into main 2024-07-26 06:46:59 +00:00
Yining Liu
a8eda25cca Add setting illustration to notification cooldown
Add setting illustration to notification cooldown (also known
as adaptive notification, notification avalanche).

Fix: 354048938
Flag: com.android.server.notification.polite_notifications
Test: Manual, Settings - Notifications - Notification cooldown
try with both light and dark mode

Change-Id: If8f5d22116f90d151a285dee6423d82e0edea638
2024-07-25 23:30:24 +00:00
Matías Hernández
246960de0c Update top of modes page
* Show blurb based on mode type.
* Make the icon bigger and highlight it when mode is active.
* Increase spacing between elements.

Also eliminate some code duplication between header of mode page and header of icon picker.

Fixes: 355415875
Test: manual
Flag: android.app.modes_ui
Change-Id: I7e788b9b5920cedb791d1571b19b37e65ece6d0b
2024-07-25 21:28:27 +02:00
Oleg Blinnikov
2c2b7a5064 Merge "External display page is not searchable" into main 2024-07-24 22:23:44 +00:00
chelseahao
ee6b4bdc22 Change text color for better contrast
Test: atest
Bug: 354877223
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: Ibddd354dbe2838f105aa2ff6087cbcaa2371438d
2024-07-24 15:51:36 +08:00
Joseph Vincent
83b2d86ff5 Merge "Check config to Show/Hide Private space Hide Illustration" into main 2024-07-23 21:41:17 +00:00
Matías Hernández
6a5e7b9631 Merge "Changes to the trigger segment" into main 2024-07-23 20:02:56 +00:00
Matías Hernández
9e2ac046e4 Changes to the trigger segment
* Switch is always visible, even without a configuration activity
* Custom icon, title, and summary for some mode types (such as SCHEDULE_TIME, etc).
* Default texts in case of missing trigger description.
* Different icons for having/missing configuration activity.
* Move the section to the top of the screen.

Bug: 349376785
Test: atest ZenModeTriggerLinkPreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: I960318899cf4da20ffc5765818429d5790d05067
2024-07-23 18:14:34 +02:00
josephpv
f5d279c9a2 Check config to Show/Hide Private space Hide Illustration
Enable/disable the search tile content and hide illustration
in Hide Private Space Settings page based on the config value.
By default the config value is set to true which will be used in Pixel
to show the illustration and search tile content.

OEM can set value of config_enableSearchTileHideIllustrationInPrivateSpace in the device
overlay file to false to disable it and with this change it is taken
care to hide them if the config value is false

Screenshot:
go/ss/56WxtgXd5NSqVFm.png

Bug: 346612477
Test: Manual
Flag: android.multiuser.private_space_search_illustration_config
Change-Id: Ia9fbdebd9a220f4d995369d662a75989f07a2916
2024-07-23 10:25:20 +00:00
Chelsea Hao
7a01fb2679 Merge changes Ibb68252c,Ide20e07f,I5d2e2c70 into main
* changes:
  Add accessibility label for "QR code" scanner. Also added landscape mode.
  Add accessibility label for "QR code" image. Also added landscape mode.
  Add accessibility label for "QR code" button in Audio sharing page.
2024-07-23 02:52:11 +00:00
Alina Zaidi
9609216cb5 [Dev options] Conditionally show Freeform toggle: Only display when freeform is NOT available by default on the device.
Previously Freeform Toggle was a no-op when freeform was by default available on devices

On the other hand Desktop mode toggle is displayed only when freeform IS available by default on the device. (This is because desktop mode support is tied to devices with default freeform capability.)

Also update toggle strings for a clearer user experience

Test: Updated tests
Bug: 348193756
Bug: 348186127
Flag: com.android.window.flags.show_desktop_windowing_dev_option
Change-Id: I29e36a939db78010bb3153e756f95bb6c21a31f9
2024-07-22 18:11:14 +00:00
Oleg Blinnikov
df9b9abd4d External display page is not searchable
Page was moved to connnected devices
from connected devices->connection pref.
This makes the page non-searchable,
therefore must be dropped from
the search index.

Change-Id: I437b1310bedc5943041eb0baa73b2e3152eb9ebd
Bug: 294015706
Test: manual
Flag: EXEMPT bugfix
2024-07-22 15:35:47 +00:00
chelseahao
7299e0f6bd Add accessibility label for "QR code" image.
Also added landscape mode.

Test: atest
Bug: 354116021
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: Ide20e07f38660ef7f444fbe3b20d3364b9951e02
2024-07-22 10:27:08 +00:00
Matías Hernández
bc0b3342bd Merge "Show icons for apps bypassing DND" into main 2024-07-18 11:54:51 +00:00
Matías Hernández
0ebc865c5e Show icons for apps bypassing DND
(Several things pending, such as the +n icon and the correct pending icons, but it's a start).

Test: atest com.android.settings.notification.modes
Bug: 346551087
Flag: android.app.modes_ui
Change-Id: Ifd2ab6a8bb447739dc8ffe400c3960779d477fd6
2024-07-18 11:59:06 +02:00
Asmita Poddar
541038ebb7 Merge "Add Mouse keys A11Y settings to PK settings page" into main 2024-07-17 10:03:26 +00:00
Asmita Poddar
78b485a3bb Add Mouse keys A11Y settings to PK settings page
Add the mouse keys toggle in the Settings under
System > Keybord > Physical Keyboard > Mouse Keys.
The toggle is shown when a physical keyboard is connected.

DD: go/mouse-keys-android
Bug: 341799888
Flag: com.android.hardware.input.keyboard_a11y_mouse_keys
Test: manual
Steps:
1. Connect a physical keyboard
2. Toggle the mouse keys setting to switch on the feature.
3. Mouse keys is enabled.
4. Switch off the mouse keys toggle under the setting.
5. Mouse keys is disabled.

Change-Id: Ifda8c93fcc1f8b7c1fb2eccb7c91266360ff1fc8
2024-07-16 11:45:24 +00:00
Treehugger Robot
f1cd781ed1 Merge "Move PreferenceControllers to member variables to prevent memory leak" into main 2024-07-15 22:41:43 +00:00
Chun-Ku Lin
ec61f8bea3 Move PreferenceControllers to member variables to prevent memory leak
- Move PreferenceControllers to xml
- Clean up the PreferenceController so that it's less tied to a fragment
- Update and clean up the related robolectric test, so there are less
  mocks needed

Bug: 352606511
Test: manually check the Color Correction screen is shown correctly, and
choosing color correction options are reflected correctly
Test: atest DaltonizerRadioButtonPreferenceControllerTest
Test: atest ToggleDaltonizerPreferenceFragmentTest
Flag: EXEMPT (moving controller to xml can't be flagged)

Change-Id: I89b9366cfd7a398bb0572d34226d31d49373fd94
2024-07-15 21:34:14 +00:00
Pat Manning
c8c8c53760 Merge "Update Touchpad settings page to include mouse." into main 2024-07-15 10:52:10 +00:00
Weng Su
05b28d24c3 Show less secure warning in Network details settings
- Show warning when device connected to WEP protocol

Bug: 331973632
Flag: EXEMPT bugfix
Test: Manual testing
atest -c WepLessSecureWarningControllerTest

Change-Id: I54a9bafb2c672db44d47259d6acc49c02046cb81
2024-07-15 14:51:25 +08:00
Treehugger Robot
33549c6dc7 Merge "Add Settings for vector-specific PointerIcon stroke colors." into main 2024-07-12 02:04:21 +00:00
Pat Manning
620755c293 Add Settings for vector-specific PointerIcon stroke colors.
Bug: 305193969
Test: PointerIconLoadingTest
Flag: android.view.flags.enable_vector_cursor_a11y_settings
Change-Id: I72213e8806fed451a0edb16d497406ffae5c1a44
2024-07-11 15:40:03 +00:00
Treehugger Robot
c5e168c830 Merge "Remove leftover "all" option from zen mode Apps page" into main 2024-07-11 14:01:53 +00:00
Pat Manning
1257610b0e Update Touchpad settings page to include mouse.
Make each setting conditionally available based on touchpad or mouse
connected to device.

Bug: 269100659
Test: TrackpadBottomPreferenceControllerTest
Test: TrackpadReverseScrollingPreferenceControllerTest
Test: TrackpadTapToClickPreferenceControllerTest
Test: TrackpadSettingsControllerTest
Flag: android.view.flags.enable_vector_cursor_a11y_settings
Change-Id: I601c29e20d69227779481c0a491256e36cfd268f
2024-07-11 13:32:44 +00:00
Matías Hernández
f85290cbbf Remove leftover "all" option from zen mode Apps page
Bug: 308820027
Test: manual
Flag: android.app.modes_ui
Change-Id: I0b29b69a9544223eb8450ad59e528056ad429fbb
2024-07-10 19:30:51 +00:00
Matías Hernández
c56c2e0019 Merge "Add "rename" option to 3-dot menu" into main 2024-07-10 15:35:03 +00:00
Jason Chang
e37fca665b Merge "Fix the wording order of personal and work are different in the device unlock settings" into main 2024-07-10 10:48:06 +00:00
Matías Hernández
3cd8fc86e1 Add "rename" option to 3-dot menu
(And remove the segmented buttons).

Fixes: 346278854
Test: manual
Flag: android.app.modes_ui
Change-Id: I6d45ba91cc400e5f3f01245c315cc5f0322c3bb1
2024-07-10 00:44:32 +00:00
Julia Reynolds
f9ce78e87b Merge "Create a new link preference for priority modes entry" into main 2024-07-09 13:17:06 +00:00
Zoey Chen
21a54d0343 [Settings] Add pref key for metrics
Bug: 349749793
Test: manual
Flag: EXEMPT resource only update
Change-Id: I367a42d023b2a1b879130e63205e3f63365a4a86
2024-07-09 06:38:10 +00:00
Matías Hernández
bb41777f87 Merge "Add mode: Choose name and icon for new custom modes" into main 2024-07-09 02:20:07 +00:00
Jason Chang
f0bd2d38d4 Fix the wording order of personal and work are different in the
device unlock settings

Change the wording order of Face and Fingerprint for work profile.

Flag: EXEMPT bugfix

Bug: 342356302

Test: Build ABTD ROM and check the wording order of Face and
Fingerprint for work profile.

Change-Id: I7e68bfcb411f70d6dd9a2a2f7d3a6a976bb9dacf
2024-07-08 16:46:06 +00:00
Matías Hernández
574fcaf1b2 Add mode: Choose name and icon for new custom modes
This also unifies the "icon picker" screen with the new "add mode" screen since in both cases we want to edit name and icon together (and not save updates until the user confirms).

Bug: 326442408
Bug: 346278854
Test: atest com.android.settings.notification.modes
Flag: android.app.modes_ui
Change-Id: I8a9d07ba0b6c55f3abc1b9884f278d51d178dc83
2024-07-06 22:12:58 +00:00
Julia Reynolds
4fd34aa386 Create a new link preference for priority modes entry
Test: ZenModesSummaryHelperTest
Test: manual. Successfully search for both 'event' and 'priority'
Flag: android.app.modes_ui
Bug: 341726633
Change-Id: Ib7bd1a5c2f7b06b1728a66f7a9cef53cd45acc0b
2024-07-03 16:22:20 -04:00
Fan Wu
ec5df5cd1e Remove Use on-screen keyboard preference from Physical Keyboard page
Bug: 304460009
Flag: EXEMPT removing preference from xml
Test: on device
Change-Id: Ibb0517c5ffa4addb52f1b0469f30c5126bd5828a
2024-07-03 06:29:54 +00:00
Julia Reynolds
ce4f2e9db6 Merge "Show bundles separately from other channels" into main 2024-07-03 00:02:33 +00:00
Alina Zaidi
50e0a53b1c Merge "[Dev option] Add a dev option to enable DW." into main 2024-07-01 19:54:09 +00:00
Alina Zaidi
d98058c4b7 [Dev option] Add a dev option to enable DW.
Default value of this dev options solely depends on
enable_desktop_windowing_mode, which is intended

Toggle is shown only if DW is eligible on device

Currently this option only overrides features guarded by
enable_desktop_windowing_mode, later on it will be used to override a
few other DW features

Test: Added tests. Locally tested CUJs
Bug: 348186127
Bug: 348193756
Flag: com.android.window.flags.show_desktop_windowing_dev_option

Change-Id: I1c1f946b586a5ca0440b29879925ba1a624717aa
2024-07-01 17:23:20 +00:00
Julia Reynolds
2956baaf51 Show bundles separately from other channels
Fixes: 346612561
Test: BundleListPreferenceControllerTest
Flag: android.service.notification.notification_classification
Change-Id: I2371219822f6a777788147e8249ca1e3b29d40ba
2024-07-01 12:56:41 -04:00
Yuri Lin
c1a4abbc51 Migrate "duration for quick settings" to new modes page.
This mostly continues to use the existing dialogs in settingslib (ZenDurationDialog, SettingsEnableZenModeDialog) and creates a controller to read from the settings value.

Also updates the "turn on / turn off" button to respect the preferred duration.

Flag: android.app.modes_ui
Bug: 343444249
Test: ZenModeButtonPreferenceControllerTest, ManualDurationPreferenceControllerTest
Change-Id: I2fd49a79d9a5807fefdd7ec310a6cc60d70f9bb1
2024-06-27 12:48:27 -04:00
Julia Reynolds
aec909bd44 Merge "Move 'show hidden channels' option" into main 2024-06-26 13:30:48 +00:00
Julia Reynolds
477ebd25f2 Move 'show hidden channels' option
Make it more prominent to make it more clear what's happening
when you unblock an app

Test: DeletedChannelsPreferenceControllerTest
Test: ShowMorePreferenceControllerTest
Flag: com.android.server.notification.notification_hide_unused_channels
Bug: 322536537
Change-Id: I745b2037b4dc907a4307fa7f70ecc3a4c9db2dd2
2024-06-25 20:50:28 +00:00
Oleg Blinnikov
b3926bdf35 Merge "Added External Display settings page" into main 2024-06-25 15:01:01 +00:00
Pat Manning
d303afbbd7 Add Settings for vector-specific PointerIcon scale.
Bug: 305193969
Test: PointerScaleSeekBarControllerTest
Flag: com.android.systemui.enable_vector_cursor_a11y_settings
Change-Id: I2f344f1d5fc6d5c8eb7159570287b8ce6f9ac070
2024-06-25 13:55:59 +00:00
Oleg Blinnikov
a6016e6552 Added External Display settings page
Settings page to show rotation, resolution,
enable/disable display settings for
external and overlay displays. In case
persist.demo.userrotation.package_name
sysprop is set, then the virtual
display with this will also be shown.

In case there is only one allowed display
available, then this display will be
shown right away. When there are more
than 1 displays available, then the list
of displays will be shown.

Change-Id: I186667aaba94ed6befec3a98f4a87f2b2d1f1859
Test: atest ExternalDisplayUpdaterTest
Test: atest ExternalDisplayPreferenceFragmentTest
Test: atest ResolutionPreferenceFragmentTest
Test: atest ConnectedDeviceGroupControllerTest
Bug: 340218151
Bug: 294015706
Bug: 253296253
Flag: com.android.settings.flags.rotation_connected_display_setting
Flag: com.android.settings.flags.resolution_and_enable_connected_display_setting
2024-06-25 13:41:10 +00:00
Chaohui Wang
cfd401b04e Fix crash in RoamingPreferenceController
With new MobileDataRepository.isDataRoamingEnabledFlow() to provide
the data instead of MobileNetworkRepository.

Fix: 347224962
Flag: EXEMPT bug fix
Test: manual on Mobile Settings
Test: unit test
Change-Id: I2a994cb11c93296fb46558f566d6d4467ba4c846
2024-06-21 04:39:44 +00:00