Commit Graph

5137 Commits

Author SHA1 Message Date
Matías Hernández
a463b0af7b Fix a11y issues in the schedule editor
* Don't read start / end time as separate labels.
* Fix content description of day buttons (ToggleButton's stateDescription is textOn/textOff -- which are the same for this particular button, thus it wasn't possible to know whether a day was selected or not).

Fixes: 346396147
Test: manual, with Talkback
Flag: android.app.modes_ui
Change-Id: If73a791cf9bd62cf17e058c81a8051b3e7fd82ea
2024-07-29 18:11:34 +00:00
Chun-Ku Lin
b5e4a01553 Remove unused resources since A11yServiceWarning is moved to framework
Bug: 303511250
Flag: EXEMPT pure cleanup
Test: Build succeed
Test: atest com.android.settings.accessibility
Change-Id: Ic1813b4489be617c006426056abae3876c77a727
2024-07-26 17:56:32 +00:00
Chun-Ku Lin
75db151f96 Merge "[Flag cleanup] edit_shortcuts_in_full_screen is always on now" into main 2024-07-26 17:46:52 +00:00
Edgar Wang
74fa4310c8 Merge "Fix Talkback focus on random position when launch Settings homepage" into main 2024-07-26 11:54:50 +00:00
Edgar Wang
ec31852c7b Fix Talkback focus on random position when launch Settings homepage
- set default focus on Search

Bug: 350887106
Test: manual
Flag: com.android.settings.flags.homepage_revamp
Change-Id: Iae1f57fd573d9657bbe3c5397c86d35f9ceaf5b0
2024-07-26 06:30:48 +00:00
Chun-Ku Lin
919019ca56 [Flag cleanup] edit_shortcuts_in_full_screen is always on now
- Cleaned up the code that won't be executed when the flag is on
- Remove unused resources

Bug: 300302098
Test: Manually verify the user can change the shortcut type, and the
changes are saved
Test: atest com.android.settings.accessibility
Flag: EXEMPT removing com.android.settings.accessibility.edit_shortcuts_in_full_screen

Change-Id: I1e32b724ca3da909feda55e20fb1d51dc4680c09
2024-07-25 22:49:02 +00:00
Matías Hernández
246960de0c Update top of modes page
* Show blurb based on mode type.
* Make the icon bigger and highlight it when mode is active.
* Increase spacing between elements.

Also eliminate some code duplication between header of mode page and header of icon picker.

Fixes: 355415875
Test: manual
Flag: android.app.modes_ui
Change-Id: I7e788b9b5920cedb791d1571b19b37e65ece6d0b
2024-07-25 21:28:27 +02:00
Yiyi Shen
e980a145eb Merge "[Audiosharing] Use a11y compliant color for dialog buttons" into main 2024-07-25 10:21:37 +00:00
Yuchen Sun
01ecf76247 Add content description to QR code image for talkback.
- Rename string name for reuse purpose.

Test: Visual
Flag: EXEMPT bug fix
Bug: 350603175
Change-Id: Id5b1383c9cf1c2509a621bb9b225e0efeb58ca7f
2024-07-25 08:47:32 +00:00
Yiyi Shen
0395a8035a [Audiosharing] Use a11y compliant color for dialog buttons
Fix: 353907942
Test: manual
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: Ib034f66db0e3685458c51e0a9cbe9b534c205a69
2024-07-25 16:07:28 +08:00
Chelsea Hao
7a01fb2679 Merge changes Ibb68252c,Ide20e07f,I5d2e2c70 into main
* changes:
  Add accessibility label for "QR code" scanner. Also added landscape mode.
  Add accessibility label for "QR code" image. Also added landscape mode.
  Add accessibility label for "QR code" button in Audio sharing page.
2024-07-23 02:52:11 +00:00
Haijie Hong
8b2d520221 Merge "Update color of ring battery indicator" into main 2024-07-23 02:29:35 +00:00
Haijie Hong
11865236b0 Update color of ring battery indicator
Test: verify the color locally
Bug: 343317785
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: I96b7775dfca51c4304b413a9a56a6489d735f748
2024-07-22 20:26:59 +08:00
Yiyi Shen
1c5a04317e [Audiosharing] Make audio sharing dialog body scrollable
Fix: 353908196
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Test: atest
Change-Id: If18a5501d1afdd2a2cca7a4a5034ac7b0f9640a4
2024-07-22 19:10:00 +08:00
chelseahao
467bb26083 Add accessibility label for "QR code" scanner.
Also added landscape mode.

Test: atest
Bug: 354116021
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: Ibb68252c5de5b30bdcbb9e9f88127b26e767ef04
2024-07-22 10:27:31 +00:00
chelseahao
7299e0f6bd Add accessibility label for "QR code" image.
Also added landscape mode.

Test: atest
Bug: 354116021
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: Ide20e07f38660ef7f444fbe3b20d3364b9951e02
2024-07-22 10:27:08 +00:00
Matías Hernández
352100397f Show icons for allowed sounds
(Some icons are temporary, until we get the final assets)

Also some fixes/improvements to CircularIconsPreference:
* Show the correct placeholder and +N icons.
* Fix the displayIcons-before-measure case (global layout listener was incorrect).
* Properly cancel pending image load futures (field didn't point to the actual future).
* Don't reload icons if it's the same set (depends on equals() for the items, so unfortunately doesn't work for AppEntry yet).

Test: atest com.android.settings.notification.modes
Bug: 346551087
Flag: android.app.modes_ui
Change-Id: I9d029a5fdd785ada4e2ba4d8a90eba72b5fb9085
2024-07-19 15:30:45 +00:00
Matías Hernández
0ebc865c5e Show icons for apps bypassing DND
(Several things pending, such as the +n icon and the correct pending icons, but it's a start).

Test: atest com.android.settings.notification.modes
Bug: 346551087
Flag: android.app.modes_ui
Change-Id: Ifd2ab6a8bb447739dc8ffe400c3960779d477fd6
2024-07-18 11:59:06 +02:00
Angela Wang
e2c83caee9 Merge "Fix text cropping in pairing dialog" into main 2024-07-12 06:55:48 +00:00
Treehugger Robot
33549c6dc7 Merge "Add Settings for vector-specific PointerIcon stroke colors." into main 2024-07-12 02:04:21 +00:00
Pat Manning
620755c293 Add Settings for vector-specific PointerIcon stroke colors.
Bug: 305193969
Test: PointerIconLoadingTest
Flag: android.view.flags.enable_vector_cursor_a11y_settings
Change-Id: I72213e8806fed451a0edb16d497406ffae5c1a44
2024-07-11 15:40:03 +00:00
josephpv
20758d5cfe Fix RTL alignment issue in private space education
With this change the RTL mirroring issue is fixed in the private space
education screen where the icons are aligned to the right for languages
requiring mirror support.

Screenshot:
go/ss/7AuF2HYsmTVaW5w.png
go/ss/HazpLiDH92X2X26.png
go/ss/4TueVkQcKmKZrAL.png

Flag: EXEMPT resource only update

Bug: 351141472
Test: Manual
Change-Id: I33d30ad425ae17e7a8653bc6545f640ee5d09706
2024-07-09 17:33:35 +00:00
Haijie Hong
2e3d477a3f Merge "Add ring indicator for battery level" into main 2024-07-09 08:44:48 +00:00
Matías Hernández
bb41777f87 Merge "Add mode: Choose name and icon for new custom modes" into main 2024-07-09 02:20:07 +00:00
Matías Hernández
574fcaf1b2 Add mode: Choose name and icon for new custom modes
This also unifies the "icon picker" screen with the new "add mode" screen since in both cases we want to edit name and icon together (and not save updates until the user confirms).

Bug: 326442408
Bug: 346278854
Test: atest com.android.settings.notification.modes
Flag: android.app.modes_ui
Change-Id: I8a9d07ba0b6c55f3abc1b9884f278d51d178dc83
2024-07-06 22:12:58 +00:00
Haijie Hong
5d96249d6e Add ring indicator for battery level
Bug: 343317785
Test: atest AdvancedBluetoothDetailsHeaderControllerTest
Flag: com.android.settings.flags.enable_bluetooth_device_details_polish
Change-Id: Ib657db60be8d377ea990674c4d2438ea8a6854d0
2024-07-04 13:26:48 +08:00
Yuri Lin
900412914f Merge "Right-align "end time" portion of the schedule setter." into main 2024-07-03 15:07:09 +00:00
Tiger Huang
362a5f9450 Merge "Fix certificate manager UI (take 2)" into main 2024-07-03 06:23:53 +00:00
Yuri Lin
5d5a945fed Right-align "end time" portion of the schedule setter.
This is more like what the mocks show. To make it happen, this changes the layout to a ConstraintLayout with a guideline in the middle to make sure that the start and end time sections take up no more than half the screen.

Confirmed that it wraps rather than overlapping when the text becomes too large.

Flag: android.app.modes_ui
Bug: 346396147
Test: manual
Change-Id: I56adbd24594121a9cb5b4374f2eeecdfd40f61e4
2024-07-02 18:13:41 -04:00
Rubin Xu
0922f282d8 Fix certificate manager UI (take 2)
Change layout height so it does not obscure the floating
action buttons at the bottom.

Bug: 349518143
Flag: EXEMPT bug fix
Test: manual CTS Verifier run
Change-Id: Iaf82b2e6343790bbed9508a5dae9a66566760cac
2024-07-02 16:57:16 +01:00
Matías Hernández
45f1e819d3 Icon picker: Styling improvements
Instead of a the plain appearance of a EntityHeaderController, make the top icon bigger and use the same circled style as the choices in the list. Also highlight the current icon in the list as selected, even if it is the default for the mode type.

Also cleaned up controllers that don't need a ZenModesBackend to not receive it.

(Both of these changes also line up with the "new mode" fragment that is incoming).

Bug: 333901673
Bug: 326442408
Test: atest com.android.settings.notification.modes
Flag: android.app.modes_ui
Change-Id: I0c9f3e34019a1a6c48658933dde545ad8d7399ae
2024-07-02 12:12:02 +02:00
Angela Wang
2746c6015e Fix text cropping in pairing dialog
Eliminated child view margins, which were causing incorrect content height calculation within the parent ScrollView. Added padding to ScrollView to maintain visual spacing and ensure all text is visible.

Bug: 328519578
Test: manually, attach screenshots in bug
Flag: EXEMPT bugfix
Change-Id: If31c8a9b491ca3bee834ba470dbc1ec4e8a5e9bc
2024-06-27 10:28:10 +00:00
Edgar Wang
a1acf685d0 Change the text of the search bar in Homepage screen
Bug: 348069291
Change-Id: I35771e9a347715819e65e0d86f1cd38eaa5618ae
Test: visual
Flag: com.android.settings.flags.homepage_revamp
2024-06-21 04:51:11 +00:00
Edgar Wang
57fa134ade [Homepage revamp] Adjust the padding of Search bar in the homepage container.
Bug: 340773713
Test: visual
Flag: com.android.settings.flags.homepage_revamp
Change-Id: I3fc8a8f56ba8e8c401e907fbb45fc980eb335538
2024-06-20 17:21:32 +00:00
Treehugger Robot
45c36458ca Merge "Fix edge-to-edge issue in certificate manager UI" into main 2024-06-20 11:29:45 +00:00
Rubin Xu
c7eded46e1 Fix edge-to-edge issue in certificate manager UI
Bug: 348083996
Flag: EXEMPT bugfix
Test: maunally start the certificate manager UI via TestDPC
Change-Id: Id92897c81087febfdf02c8b90d69cd3e4270a22c
2024-06-20 10:27:34 +00:00
Matías Hernández
0bf4899f3e Support adding an automatic schedule to previously-manual system-owned modes
Bug: 342156843
Bug: 326442408
Flag: android.app.modes_ui
Test: atest com.android.settings.notification.modes
Change-Id: Ib7d15b8fc949fa73015537f03a882ef7eb6b4bcd
2024-06-19 15:06:08 +02:00
Matías Hernández
ec5b25eb48 Merge "Add icon picker for zen modes" into main 2024-06-10 22:38:36 +00:00
Yuri Lin
00c7a2c16b Merge "Add schedule setting page for time-based modes." into main 2024-06-10 20:50:57 +00:00
Matías Hernández
8d397f038f Add icon picker for zen modes
Bug: 333901673
Test: atest ZenModeIconPickerListPreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: Ib6faaac7c93b25423d18dbdcd0a2310de15fa86f
2024-06-10 19:37:49 +02:00
Yuri Lin
4203f311dd Add schedule setting page for time-based modes.
Creates new layout for setting the start & end time, and days of the week, for a schedule-based mode.

This is close to the mocks specified in https://screenshot.googleplex.com/8zmb7PAjjt73VkN, but with the following differences:
- the end time is left-aligned with the center rather than on the right side of the screen. This is a side effect of using LinearLayout to evenly space start & end times, and could in theory be fixed by using a ConstraintLayout, but that option seems to cause times to overlap instead of wrap when display size is cranked up. Could be fixed later.
- no icons yet on either side of the time display
- no Done button. Instead, has the "exit at alarm" switch that exists today.

Have not yet checked how this interacts with TalkBack, etc.

Flag: android.app.modes_ui
Bug: 332730302
Test: ZenModeSetSchedulePreferenceControllerTest, ZenModeExitAtAlarmPreferenceControllerTest, ZenModeSetTriggerLinkPreferenceControllerTest
Test: manual: interacting with UI in normal size, with font & display at minimum and maximum, and in locales (fr) where the first day of the week is a different day
Change-Id: I0b76f55891d6c12fc27720657c9eea6fe42fbafe
2024-06-10 13:26:06 -04:00
Treehugger Robot
87334e9c38 Merge "Add Settings for vector-specific PointerIcon fill colors." into main 2024-06-07 16:31:59 +00:00
josephpv
cbf3dad3f5 Fix to display text properly in PS education screen
This changes the style for text in private space education screen
bullet point to fix the text not displaying properly in unfolded mode of
Pixel fold.

Recording: b/340231182#comment4

Bug: 340231182
Test: Manual
Change-Id: I4da02da6ddf6b4f048cc58331d14cda389f13dec
2024-06-07 11:07:11 +00:00
Joseph Vincent
4885f1833c Merge "Remove temp GAIA education screen from PS setup code" into main 2024-06-07 02:47:30 +00:00
josephpv
d27f97393d Remove temp GAIA education screen from PS setup code
With this change the temp GAIA education screen is removed from private
space setup code and adds a new loading screen with "Just a sec" title
in the activity while the gms intent in launched to fix blank screen issue.

Screenrecording link:
b/336822960#comment7

Bug: 336822960
Test: Manual
Change-Id: I9ee41835b39c194fefb970321b7a9d5a30f87306
2024-06-06 17:18:55 +00:00
Pat Manning
577965f9c2 Add Settings for vector-specific PointerIcon fill colors.
Bug: 305193969
Test: PointerIconLoadingTest
Flag: com.android.systemui.enable_vector_cursor_a11y_settings
Change-Id: I84b4a6d5fde48309c2e3374963f92b8246167628
2024-06-06 14:41:00 +00:00
josephpv
b4054cb6a7 Add edu for apps being stopped when PS is locked
Changes made to Setup intro screen and private space settings dislaimer
that apps are stopped when private space is locked.

Screenshots:
go/ss/8YFWtjjC5pzhyyd.png
go/ss/5pvvo4YodaSiGzr.png
b/343166731#comment4

Bug: 343166731
Test: Manual
Change-Id: I46db598e1e94e210d904ade8b6b0cf498960cc2a
2024-06-05 10:01:19 +00:00
Haijie Hong
8ef3513f04 Merge "Fix battery talkback for advanced bt header" into main 2024-06-05 05:13:33 +00:00
chelseahao
4c94930ad5 [Audiosharing] Clean up unused code.
Test: atest -c com.android.settings.connecteddevice.audiosharing.audiostreams
Bug: 308368124
Change-Id: Iea1aede53aefe2034b5a083ff503bb21a4f546cb
2024-06-04 07:09:03 +00:00
Chun-Ku Lin
38236869ee Merge "Update a11y shortcut images" into main 2024-05-31 17:53:12 +00:00