Commit Graph

36532 Commits

Author SHA1 Message Date
jackqdyulei
52ccb49fbe Split BluetoothSettings into two pages
This cl splits the BluetoothSettings into paired device page and
pairing page, including small changes about:
1. Refactor the pages so they could get as much as static preference
from xml file rather than dynamically add/remove them everytime.
2. Remove creating method in BluetoothDeviceNamePreferenceController
and add it in xml file
3. Create BluetoothPairingDetail page, basically move the logic from
BluetoothSettings.
4. Make pairing preference clickable and jump to BluetoothPairingDetail
5. Add and update bunch of tests

Bug: 35877041
Test: RunSettingsRoboTests
Change-Id: Ief9e9690c612f7b46c58e866e5cecc511af642c8
2017-05-22 16:57:37 -07:00
Lei Yu
78684dc049 Revert "Add animation for battery asyncLoader."
This reverts commit a3c528f64d.

Test: Build
Change-Id: Ib50221873e39dee40c5cf8e4b41dcf7aa13f6134
Merged-In: Ib50221873e39dee40c5cf8e4b41dcf7aa13f6134
2017-05-22 16:49:55 -07:00
Lei Yu
210bf83cea Merge "Revert "Add animation for battery asyncLoader."" 2017-05-22 23:30:04 +00:00
TreeHugger Robot
a89b14e806 Merge "Remove lifecycle interfaces from settings." 2017-05-22 23:13:16 +00:00
Kevin Chyn
1c38d4bbe7 Merge "Queue events if enrollment sidecar listener is null" into oc-dev am: 32ad1c0db4
am: 35fb3302d7

Change-Id: I94cfe913b3e66ce27a0ee7ea439d3ed6a77942f3
2017-05-22 23:09:35 +00:00
Amit Mahajan
1eee1f8bbc Disallow adding/editing dun APNs unless allowed by carrier.
Test: WIP
Bug: 38186417
Change-Id: If1cc34ad979659a56a3886da2a02fdbf642739ac
2017-05-22 16:01:46 -07:00
Kevin Chyn
35fb3302d7 Merge "Queue events if enrollment sidecar listener is null" into oc-dev
am: 32ad1c0db4

Change-Id: I3fecd41dac6e4fb3b576a18bf46f1d9a25c1b9ca
2017-05-22 22:52:33 +00:00
TreeHugger Robot
32ad1c0db4 Merge "Queue events if enrollment sidecar listener is null" into oc-dev 2017-05-22 22:40:42 +00:00
TreeHugger Robot
e2878ff155 Merge "Use label instead of raw value for theme preference summary" 2017-05-22 22:37:42 +00:00
Fan Zhang
715d25f727 Remove lifecycle interfaces from settings.
They are already moved to settingslib.

Test: builds

Change-Id: I581bdaff492bdb1e75c66fb69c803eb222f68b8b
2017-05-22 14:48:06 -07:00
Lei Yu
e1441c63ee Revert "Add animation for battery asyncLoader."
This reverts commit a3c528f64d.

Test: Build
Change-Id: Ib50221873e39dee40c5cf8e4b41dcf7aa13f6134
2017-05-22 14:33:24 -07:00
Fan Zhang
c7d632d313 Use label instead of raw value for theme preference summary
Change-Id: I4dd1c156c8e68dd5567093c56d5e6846357fc2d6
Fix: 38470685
Test: make RunSettingsRoboTests
2017-05-22 13:52:32 -07:00
Kevin Chyn
a1b3ec5963 Queue events if enrollment sidecar listener is null
Fixes: 38102355

Test: manual
Change-Id: I98bd347ee98117f7489376abd94d276d20e7b762
2017-05-22 12:10:03 -07:00
TreeHugger Robot
78c89c4d50 Merge "Import translations. DO NOT MERGE" 2017-05-22 18:57:12 +00:00
TreeHugger Robot
7983dba5f6 Merge "Show aditional WiFi calling message." 2017-05-22 16:11:13 +00:00
Meng Wang
7cecf2d3ba Show aditional WiFi calling message.
Bug: 37624313
Test: manual - locally apply this setting and verify that the
               additional text is shown.
Change-Id: I8a15a9aeb71a0daab1ae4533f2c3b7d05c57bc5f
2017-05-22 15:46:31 +00:00
Geoffrey Pitsch
e18fd90524 Developer setting to enable notification channel warnings
Defaults to enabled for debuggable builds

Fixes: 37945054
Fixes: 38380608
Test: manual
Change-Id: I5d2101feffa7cf4433264eefc82b1b80f294d9f0
2017-05-22 11:29:18 -04:00
Hemant Gupta
40901478f9 Merge "Settings: Convert notifications to use NotificationChannel (2/2)" into oc-dev am: 860b608e41
am: 7eb5647656

Change-Id: I8d9c6e314a1b02cafc9523fae31a06dabfad4465
2017-05-20 01:39:52 +00:00
Hemant Gupta
7eb5647656 Merge "Settings: Convert notifications to use NotificationChannel (2/2)" into oc-dev
am: 860b608e41

Change-Id: If246a2f7d340b1d21c805322fa10f0c2fed8115c
2017-05-20 01:37:14 +00:00
TreeHugger Robot
860b608e41 Merge "Settings: Convert notifications to use NotificationChannel (2/2)" into oc-dev 2017-05-20 01:33:37 +00:00
Kevin Chyn
3795082c83 Merge "Fix settings crash due to enrolling error" into oc-dev am: 5ccc2fe242
am: 2ca8635a5e

Change-Id: I167959f2ef69bcda7fb604e3f3e85512799ce691
2017-05-20 00:01:59 +00:00
Kevin Chyn
2ca8635a5e Merge "Fix settings crash due to enrolling error" into oc-dev
am: 5ccc2fe242

Change-Id: I08fb0fd4826135f4b469e6516d2cea25cba0a679
2017-05-20 00:00:01 +00:00
TreeHugger Robot
5ccc2fe242 Merge "Fix settings crash due to enrolling error" into oc-dev 2017-05-19 23:56:12 +00:00
Hemant Gupta
7bec5bf895 Settings: Convert notifications to use NotificationChannel (2/2)
Test Setup:
===========
HW DUT: Pixel O
Remote: MecApp (PBAP Client, MAP Client, SAP Client)

Steps:
=====
1. Enable BT on DUT and bond with Remote.
2. Connect from MecApp for PBAP, MAP, SAP and observe if
   connection goes through fine.

Reproducibility:
===============
5/5

Observation:
============
MAP, PBAP and SAP cannot be connected.

Root cause:
In Android O, notifications are hidden by default.
This must be changed to use notification channels so that the
priority of the notifications can be updated.

Test: PBAP/MAP/SAP connection works fine with MecApp.

Bug: 38331825
Change-Id: I51de0ea303037bf88773352d99f092673acda2e3
(cherry picked from commit bd9f532013f0397879101f68f21ac8841fec344b)
2017-05-19 23:33:29 +00:00
Kevin Chyn
468a72aed3 Fix settings crash due to enrolling error
Test: There's a condition where FP enrollment fails and a fragment
transaction/commit occurs after onSaveInstanceState. We should be
using commitAllowingStateLoss() instead of commit()

I'm not able to repro this issue but from looking at the stack
trace this should fix the problem.


Fixes: 38432354

Change-Id: I56b9c8d2efc45e9d77f29b897280f5378c3a84a0
2017-05-19 13:04:08 -07:00
Adam Bookatz
17706e5777 Merge "Add aggregated partial wakelock time per uid" into oc-dev am: 11e7781b32
am: 069e8ab3cd

Change-Id: Iebcee8a80d79311f5c967b9db47928653822861f
2017-05-19 18:40:09 +00:00
Adam Bookatz
069e8ab3cd Merge "Add aggregated partial wakelock time per uid" into oc-dev
am: 11e7781b32

Change-Id: I17641683c8d6ec278070ebbafaefce35008248f0
2017-05-19 18:32:31 +00:00
Maurice Lam
f7db59d03f Merge "Align password requirement according to theme" 2017-05-19 18:26:49 +00:00
Adam Bookatz
11e7781b32 Merge "Add aggregated partial wakelock time per uid" into oc-dev 2017-05-19 18:24:45 +00:00
Lorenzo Colitti
991a273669 Merge "Raneme the wifi detail "Sign into network" button to "Sign in"." into oc-dev am: 7d045387e0
am: c2bd388bb9

Change-Id: I685c53a605572aa6cfc1e6082d7427a1febc4b40
2017-05-19 03:14:38 +00:00
Lorenzo Colitti
c2bd388bb9 Merge "Raneme the wifi detail "Sign into network" button to "Sign in"." into oc-dev
am: 7d045387e0

Change-Id: Ie329358b56b34a94bbf12d32b9829247e6a6bf3d
2017-05-19 03:10:14 +00:00
TreeHugger Robot
7d045387e0 Merge "Raneme the wifi detail "Sign into network" button to "Sign in"." into oc-dev 2017-05-19 03:01:29 +00:00
Maurice Lam
27b762c963 Align password requirement according to theme
Test: Manual
Bug: 38180862
Change-Id: I60f58b35c057352dd352ad847f69b1eb999f2f08
2017-05-18 18:48:34 -07:00
TreeHugger Robot
7aac5c5791 Merge changes Iaf92730e,I54eb30f2,Ib80827ae
* changes:
  Use entity header on AccountDetailDashboardFragment
  Move entity header controller out of application package.
  Clean up settings_entity_header layout.
2017-05-19 01:24:50 +00:00
TreeHugger Robot
5d20c1ab87 Merge "Fix bug where app list says "No app" in multi-window mode" 2017-05-19 01:04:06 +00:00
Matthew Fritze
87cb3c92bb Merge "Remove Language and Input duplicates" into oc-dev am: 6f4a6a737d
am: 5569e3a33f  -s ours

Change-Id: I09c9b357d77128623b179234bae28a2dba6abcb1
2017-05-19 00:56:39 +00:00
Matthew Fritze
5569e3a33f Merge "Remove Language and Input duplicates" into oc-dev
am: 6f4a6a737d

Change-Id: Id6639a9dc08c1a27cf1bc4ed7969cc54a4bd2df2
2017-05-19 00:49:41 +00:00
TreeHugger Robot
6f4a6a737d Merge "Remove Language and Input duplicates" into oc-dev 2017-05-19 00:41:04 +00:00
Fan Zhang
98289a887b Use entity header on AccountDetailDashboardFragment
Bug: 37669238
Test: make RunSettingsRoboTests
Change-Id: Iaf92730e8c6b5c44cb8eca4525fc931487ce9630
2017-05-18 16:36:32 -07:00
Fan Zhang
d7414259d0 Move entity header controller out of application package.
Bug: 37669238
Test: rerun robotests
Change-Id: I54eb30f28fa0a88a6f0b97b53f9f1408320b5ce0
2017-05-18 16:36:32 -07:00
Fan Zhang
f5bd885a1d Clean up settings_entity_header layout.
update layout view IDs, and controller variable names to be more
generic.

Fix: 36734470
Bug: 37669238
Test: make RunSettingsRoboTests
Change-Id: Ib80827ae3eae6d01a600068b4a8a44b239c32511
2017-05-18 16:35:27 -07:00
TreeHugger Robot
dd6483461f Merge "Remove Language and Input duplicates" 2017-05-18 22:37:27 +00:00
Daniel Nishi
838ec5d15b Merge "Make Storage settings title be "Storage"." into oc-dev am: c7299663e7
am: af1a66202f

Change-Id: I71309f8db92a72df913aa30e4664cabb69b2fcbb
2017-05-18 22:11:55 +00:00
Daniel Nishi
af1a66202f Merge "Make Storage settings title be "Storage"." into oc-dev
am: c7299663e7

Change-Id: I2873188fb073261695d79719c99617a355f17acc
2017-05-18 22:07:24 +00:00
Daniel Nishi
c7299663e7 Merge "Make Storage settings title be "Storage"." into oc-dev 2017-05-18 21:57:22 +00:00
Fan Zhang
462d852808 Fix bug where app list says "No app" in multi-window mode
Move updateUi logic from onPause/onResume to onStop/onStart.

Change-Id: Iebe38d201d531058472cd033a0408239d36d32e4
Fix: 36305836
Test: instrumentation test
2017-05-18 14:37:09 -07:00
jackqdyulei
5333ecd1fb Dupe BluetoothSettings and DeviceListPreferenceFragment
Create the obsolete version of the belowing fragments, so we could
flip between old page and new page.

BluetoothSettingsObsolete and DeviceListPreferenceObsoleteFragment
contains all the old logic but:
1. Logic about BluetoothPairingPreferenceController(ag/2239482),
since this preference shouldn't be checked in without the flag :(

This cl also adds logic in MasterSwitchPreferenceController to flip
these two pages.

Following cl will refactor these fragment to make it compatible
to new framework.

Bug: 35877041
Test: RunSettingsRoboTests
Change-Id: I1cc1bc2d49d8a3e11c3127e56f6409fbc84028d8
2017-05-18 14:12:02 -07:00
Matthew Fritze
742467ec9f Remove Language and Input duplicates
Change the keys in the Language and Input screen for the
gesture and tts-output settings so they can be disabled
in search. Then change the preference controllers to take
a key as input to avoid crashes on the other screens with
these settings.

Merge for: ag/2098173/

Test: make RunSettingsRoboTests
Bug: 33701673
Change-Id: I8bc0776131fcac5a6edf7e8271bc53252c2fc719
2017-05-18 13:57:54 -07:00
Juan Lang
96c413b5f2 Merge "Update FooterPreference's classpath in preference files." 2017-05-18 20:52:56 +00:00
Fan Zhang
daf95ed1b3 Merge "Log preference change as count (in addition to action)" into oc-dev am: 13bcf501dd
am: a3202a9a36

Change-Id: Ibf483af95630ca15d886e8ef83b96dbe1aefd55f
2017-05-18 20:44:33 +00:00