app_Settings

PawletOS/app_Settings

Fork 0

Commit Graph

Author	SHA1	Message	Date
Matías Hernández	227548d927	Make ZenIconLoader injectable (in SystemUI) In settings, reduce calls to getInstance(), and pass it to preferences and their controllers instead. Bug: 360399800 Test: atest ZenModesListItemPreferenceTest ZenModesListPreferenceControllerTest Flag: android.app.modes_ui Change-Id: I318320575e3bd32b5d13a385fa644f8032484e1c	2024-08-28 14:10:20 +02:00
Matías Hernández	b8b897e552	Improve lifecycle of ZenModeFragment & friends * Don't keep Settings observers longer than start-stop. * Only call updateState() once on controllers during create->start->resume. * Remove some duplicate controller update methods from ZenModesFragmentBase (we can directly call DashboardFragment's). * Don't update controllers if unrelated modes were changed. * Extract ZenSettingsObserver for use in the link tile later. * Add tests. Fixes: 353946788 Test: atest com.android.settings.notification.modes Flag: android.app.modes_ui Change-Id: I64b51714d699b5c3a592a76fcb615d2999998829	2024-07-29 20:10:03 +02:00
Matías Hernández	574fcaf1b2	Add mode: Choose name and icon for new custom modes This also unifies the "icon picker" screen with the new "add mode" screen since in both cases we want to edit name and icon together (and not save updates until the user confirms). Bug: 326442408 Bug: 346278854 Test: atest com.android.settings.notification.modes Flag: android.app.modes_ui Change-Id: I8a9d07ba0b6c55f3abc1b9884f278d51d178dc83	2024-07-06 22:12:58 +00:00

Author

SHA1

Message

Date

Matías Hernández

227548d927

Make ZenIconLoader injectable (in SystemUI)

In settings, reduce calls to getInstance(), and pass it to preferences and their controllers instead.

Bug: 360399800
Test: atest ZenModesListItemPreferenceTest ZenModesListPreferenceControllerTest
Flag: android.app.modes_ui
Change-Id: I318320575e3bd32b5d13a385fa644f8032484e1c

2024-08-28 14:10:20 +02:00

Matías Hernández

b8b897e552

Improve lifecycle of ZenModeFragment & friends

* Don't keep Settings observers longer than start-stop.
* Only call updateState() once on controllers during create->start->resume.
* Remove some duplicate controller update methods from ZenModesFragmentBase (we can directly call DashboardFragment's).
* Don't update controllers if unrelated modes were changed.
* Extract ZenSettingsObserver for use in the link tile later.
* Add tests.

Fixes: 353946788
Test: atest com.android.settings.notification.modes
Flag: android.app.modes_ui
Change-Id: I64b51714d699b5c3a592a76fcb615d2999998829

2024-07-29 20:10:03 +02:00

Matías Hernández

574fcaf1b2

Add mode: Choose name and icon for new custom modes

This also unifies the "icon picker" screen with the new "add mode" screen since in both cases we want to edit name and icon together (and not save updates until the user confirms).

Bug: 326442408
Bug: 346278854
Test: atest com.android.settings.notification.modes
Flag: android.app.modes_ui
Change-Id: I8a9d07ba0b6c55f3abc1b9884f278d51d178dc83

2024-07-06 22:12:58 +00:00

3 Commits