Commit Graph

18048 Commits

Author SHA1 Message Date
Daniel Sheng
20d5588a27 Added suggestions for gestures.
Bug: 30986021
Test: manual + make RunSettingsRoboTests + adb shell am instrument -w
com.android.settings.tests.unit /android.support.test.runner.AndroidJUnitRunner

Change-Id: I7aed110c81ca2fb6b90e2f359b4bb941c02bc1c3
2017-07-05 09:05:11 -07:00
Charles He
d5612408af Merge "Disable incorrect strong auth prompt strings." into oc-dr1-dev am: c619ad77bb
am: 3ae7bacff4

Change-Id: I6c0e42bc214d68628e65ea2c90852b282f935690
2017-07-03 15:38:13 +00:00
Charles He
3ae7bacff4 Merge "Disable incorrect strong auth prompt strings." into oc-dr1-dev
am: c619ad77bb

Change-Id: I6d4e95b63896365308c8acaa07699d53560d64b4
2017-07-03 15:34:45 +00:00
Charles He
c619ad77bb Merge "Disable incorrect strong auth prompt strings." into oc-dr1-dev 2017-07-03 15:32:09 +00:00
Charles He
701ac5cbee Disable incorrect strong auth prompt strings.
The prompt strings on the confirm credentials screen (pin, password,
pattern) are incorrect. They currently say strong auth is "required
after device restarts". But instead they should be "required for
additional security" because strong auth can be enforced not only after
device or profile restarts, but also after profile key eviction, for
example.

Unfortunately, we've already missed the window for string changes.
Therefore, as an alternative, we use generic prompt strings in this CL,
to avoid conveying the incorrect (and misleading) information. We'll
follow up with another CL in master with a proper string change to fix
the issue.

Bug: 36511626
Test: manual
Test: make SettingsRoboTests
Change-Id: I44f84420b88bb4933ad0afa6e8032af465de0cd3
2017-07-03 09:42:20 +01:00
Kevin Chyn
9fde3fe2ab Merge "Assist gesture setting should not be available on unsupported devices" into oc-dr1-dev am: 72a94e9f5a
am: 408efb26f0

Change-Id: I696511821f64f7bc09819cf1d45374125b7905c0
2017-07-01 03:11:52 +00:00
Kevin Chyn
408efb26f0 Merge "Assist gesture setting should not be available on unsupported devices" into oc-dr1-dev
am: 72a94e9f5a

Change-Id: I7748c0537a6eebb1fd460b3039a9a53dc070e19e
2017-07-01 03:06:52 +00:00
TreeHugger Robot
72a94e9f5a Merge "Assist gesture setting should not be available on unsupported devices" into oc-dr1-dev 2017-07-01 02:59:19 +00:00
TreeHugger Robot
d9f978af21 Merge "Code cleanup: DashboardAdapter.category is no longer a list" 2017-07-01 01:06:58 +00:00
Kevin Chyn
1db30b7749 Assist gesture setting should not be available on unsupported devices
Fixes: 63176246

Test: manual
Change-Id: I17cd338eafd2e1a86d1e82d81bc9817eaf18d57b
2017-06-30 16:27:49 -07:00
TreeHugger Robot
b35d7301d7 Merge "Remove animation from account detail page." 2017-06-30 22:49:31 +00:00
Fan Zhang
b487fae5d8 Code cleanup: DashboardAdapter.category is no longer a list
We only ever display a single DashboardCategory in homepaeg, so the
category doesn't need to be a list in DashboardData/Adapter

Change-Id: I57db02bb45cbc511f0fce1bf33043b51ef9db15c
Fix: 33861822
Test: updated robotests
2017-06-30 15:30:51 -07:00
Salvador Martinez
11a5b9bd4d Merge "Add BatteryInfo logging to settings" into oc-dr1-dev am: 9a3b115cc8
am: 97642af54d

Change-Id: Id4f7032e735067ab9a81476e83003c942eb4f826
2017-06-30 22:16:47 +00:00
Salvador Martinez
97642af54d Merge "Add BatteryInfo logging to settings" into oc-dr1-dev
am: 9a3b115cc8

Change-Id: I447d0d7689f77b12a0caf9374155883217ff330a
2017-06-30 22:05:53 +00:00
TreeHugger Robot
9a3b115cc8 Merge "Add BatteryInfo logging to settings" into oc-dr1-dev 2017-06-30 21:58:38 +00:00
TreeHugger Robot
283895c03b Merge "Sorting search results with TreeSet instead of Collection.sort" 2017-06-30 20:16:37 +00:00
TreeHugger Robot
a1bf76a69d Merge "Also tint the settings icon in DashboardAdapter.setCategory()." 2017-06-30 20:07:40 +00:00
Jason Monk
6434f44971 Allow clicking on guest user am: c1cc9fefa8
am: bc4df21ef7

Change-Id: I013a1c3eae74d34a05494d7a4a78f51e9ddd3470
2017-06-30 19:51:03 +00:00
Jason Monk
bc4df21ef7 Allow clicking on guest user
am: c1cc9fefa8

Change-Id: I828716ff982cd2f8bedc96b74c1abc44716cc753
2017-06-30 19:43:00 +00:00
Soroosh Mariooryad
cf66647a4e Sorting search results with TreeSet instead of Collection.sort
Benchmarking shows lower sorting latencies with with TreeSet, specially
with larger lists:

Average Latencies(ms):
                  list size in [0, 115]         list size in [40, 115]
Collection.sort   39.22                         77.57
TreeSet           30.23                         52.06

Test: RunSettingsRoboTests

Bug: 38197948
Bug: 37312700

Change-Id: I1dd7c77900e8e98e26a8417f2b77582532e1a5f3
2017-06-30 12:04:13 -07:00
Jason Monk
c1cc9fefa8 Allow clicking on guest user
This is needed since the user switch will be hidden by default in
QS and will show up once multi-user has been activated in some way.

Test: click on guest
Bug: 37152893
Change-Id: I351a5d95e9e8a5e47e388d9f0611924b077754da
2017-06-30 11:29:40 -04:00
TreeHugger Robot
afeb5e2d45 Merge "Settings app changes spell checker settings directly without TSM APIs" 2017-06-30 15:19:35 +00:00
Sundeep Ghuman
0a1003a8df Merge "Don't scroll when removing saved networks." into oc-dr1-dev am: 1e561edb45
am: b963c1190f

Change-Id: I389ffac52942e382e145de94c166578d6ead48ad
2017-06-30 00:12:41 +00:00
Sundeep Ghuman
b963c1190f Merge "Don't scroll when removing saved networks." into oc-dr1-dev
am: 1e561edb45

Change-Id: I9fa78596bdcbaeac90aaee55ddcde3f698ad907f
2017-06-30 00:04:37 +00:00
Sundeep Ghuman
1e561edb45 Merge "Don't scroll when removing saved networks." into oc-dr1-dev 2017-06-29 23:56:51 +00:00
Salvador Martinez
cc7c9603db Add BatteryInfo logging to settings
This Cl adds a few log statements to BatteryInfo to try
and determine what the bottleneck in the Battery Settings
Advanced page could be.

Test: robotests still pass
Bug: 62959645
Change-Id: I1ff712d97bc8be78873c63e187edbffa8e10cd21
2017-06-29 16:53:27 -07:00
Andrew Sapperstein
b2c69878d1 Merge "Fix robotests." into oc-dr1-dev am: db72caf3ea
am: 8e1c3b9b1b

Change-Id: I2990a108691e8123df1eeefc50f650d0b8d318a6
2017-06-29 23:42:57 +00:00
Andrew Sapperstein
8e1c3b9b1b Merge "Fix robotests." into oc-dr1-dev
am: db72caf3ea

Change-Id: I8893ca932f1cfcb20d72609eaf994bc7ddb9f143
2017-06-29 23:35:26 +00:00
Andrew Sapperstein
51e4a66446 Fix robotests.
Change-Id: Ia0615bfdd303a19b145ead44979a03ccdd29bf41
Fixes: 63141368
Test: robotest
2017-06-29 16:24:32 -07:00
Doris Ling
328e1466f3 Remove animation from account detail page.
Set the preference comparison callback to null for the account detail
fragment so that there won't be animation when the we insert the dynamic
tiles.

Change-Id: I35c9fcda500e58d0a18f6ad4ef6f0651166fd70a
Fix: 62365204
Test: visual
2017-06-29 14:46:09 -07:00
Fan Zhang
a29346bab8 Change the way we generate stable id for DashboardSummary
- The countItem() method generates id based on position of Tile. This is
not truely stable.
- Added stable id constants for static views, and use hash of title as
stable id for tiles.

Bug: 33861822
Test: robotests
Change-Id: Ibbc88c82655503dc3964cb0c430c779dc9c93d41
2017-06-29 14:21:43 -07:00
Shunta Sato
6d1bb15f3b Merge "Fix Wi-Fi list adds same AP repeatedly" into oc-dr1-dev am: 9638e020e5
am: 97419f8d52

Change-Id: I06a7a62ca94104bc0b108df1fa53660453a95375
2017-06-29 20:42:16 +00:00
Shunta Sato
97419f8d52 Merge "Fix Wi-Fi list adds same AP repeatedly" into oc-dr1-dev
am: 9638e020e5

Change-Id: I4c947cddb3ee000bc51dd8ea2f9eefbc54927824
2017-06-29 20:38:03 +00:00
TreeHugger Robot
9638e020e5 Merge "Fix Wi-Fi list adds same AP repeatedly" into oc-dr1-dev 2017-06-29 20:31:18 +00:00
Doris Ling
cf57e17791 Merge "Add account sync summary." into oc-dr1-dev
am: 5243d5dd85

Change-Id: I00eb5bae671c4e4427c8af04abb541b0f1e74d60
2017-06-29 19:02:29 +00:00
TreeHugger Robot
5243d5dd85 Merge "Add account sync summary." into oc-dr1-dev 2017-06-29 18:58:58 +00:00
jackqdyulei
82b7f4ae04 Merge "Change the type of "hours" from long to double" into oc-dr1-dev am: 1498e86530
am: 595def292b

Change-Id: I7a84119fc64b37c8d6ed32ee05e644f9f860a62e
2017-06-29 18:46:28 +00:00
jackqdyulei
595def292b Merge "Change the type of "hours" from long to double" into oc-dr1-dev
am: 1498e86530

Change-Id: I4bd802fa60da314a7997addbe2920b394d0e4209
2017-06-29 18:41:23 +00:00
TreeHugger Robot
1498e86530 Merge "Change the type of "hours" from long to double" into oc-dr1-dev 2017-06-29 18:38:39 +00:00
Guliz Tuncay
04ac51b23c Settings app changes spell checker settings directly without TSM APIs
Previously, Settings application was using TextServicesManager APIs to
update any of the spell checker settings (i.e., enabled/disabled, spell
checker, subtype). Since these APIs are used only by the Settings
application, there is no need to expose it to other services and the
Settings application can directly write them to secure settings since it
has the WRITE_SECURE_SETTINGS permission.

Bug: 62950392
Test: Manually as follows.
      1. Build and flash an OS image.
      2. Complete the setup wizard (if any).
      3. Make sure AOSP Keyboard (com.android.inputmethod.latin) is installed
      4. Install SampleSpellCheckerService
       4.1 tapas SampleSpellCheckerService
       4.2. make -j
       4.3. adb install -r out/target/product/generic/system/app/SampleSpellCheckerService/SampleSpellCheckerService.apk
      5. Go to spell checker settings in the system settings
      6. Select 'SampleSpellCheckerService' through Settings app
      7. Run
           adb shell settings get secure selected_spell_checker
         and make sure it returns the following value
           com.example.android.samplespellcheckerservice/.SampleSpellCheckerService
      8. Run
           adb shell settings get secure selected_spell_checker_subtype
         and make sure it returns '0'
      9. Select 'Android Spell Checker (AOSP)' through Settings app
     10. Run
           adb shell settings get secure selected_spell_checker
         and make sure it returns the following value
           com.android.inputmethod.latin/.spellcheck.AndroidSpellCheckerService
     11. Run
           adb shell settings get secure selected_spell_checker_subtype
         and make sure it returns '0'
     12. Tap 'Languages' on the spell checker settings to select 'French'
     13. Run
           adb shell settings get secure selected_spell_checker_subtype
         and make sure it returns '102517'
     14. Select 'SampleSpellCheckerService' again through Settings app
     15. Run
           adb shell settings get secure selected_spell_checker
         and make sure it returns the following value
           com.example.android.samplespellcheckerservice/.SampleSpellCheckerService
     16. Run
           adb shell settings get secure selected_spell_checker_subtype
         and make sure it returns '0'
Test: Manually as follows.
      1. Build and flash an OS image.
      2. Complete the setup wizard (if any).
      3. Make sure AOSP Keyboard (com.android.inputmethod.latin) is installed
      4. Install SampleSpellCheckerService
       4.1 tapas SampleSpellCheckerService
       4.2. make -j
       4.3. adb install -r out/target/product/generic/system/app/SampleSpellCheckerService/SampleSpellCheckerService.apk
      5. Set the current spell checker service to be AOSP SCS by
       adb shell settings put secure selected_spell_checker com.android.inputmethod.latin/.spellcheck.AndroidSpellCheckerService
      6. Run a test program that has TextView and tap on one of the
       TextViews and type some text.
      7. Observe that there is a connection to AOSP SCS by
       adb shell dumpsys textservices
      8. Set the current spell checker service to be
      SampleSpellCheckerService SCS by
adb shell settings put secure selected_spell_checker com.example.android.samplespellcheckerservice/.SampleSpellCheckerService
      9. Tap on the same TextView as in Step 6
      10. Observe that there is a connection to SampleSpellCheckerService
      SCS (for this TextView) by
       adb shell dumpsys textservices
Change-Id: I2f3d5282a342bcb42abf995d6e7834241e11cd4f
2017-06-29 18:28:29 +00:00
TreeHugger Robot
b5ef73ebcb Merge "Add ordering attribute to sound setting preferences." 2017-06-29 17:12:36 +00:00
Andrew Sapperstein
cc7adfd9e0 Merge "Reduce number of wallpaper results in search." into oc-dr1-dev am: 63c63ff640
am: 301dfdd8d1

Change-Id: Iab4d5c24b9ac7cee39af3bcc14631fa09bb455c5
2017-06-29 04:52:32 +00:00
Andrew Sapperstein
301dfdd8d1 Merge "Reduce number of wallpaper results in search." into oc-dr1-dev
am: 63c63ff640

Change-Id: I165409df28685c85ca2edc22971e4471d9ff549f
2017-06-29 04:48:30 +00:00
TreeHugger Robot
63c63ff640 Merge "Reduce number of wallpaper results in search." into oc-dr1-dev 2017-06-29 04:38:44 +00:00
Sundeep Ghuman
14cc864122 Don't scroll when removing saved networks.
Bug: b/62374459
Test: Open saved networks from WifiSettings. Remove a saved network.
Screen should not scroll to the top of the list.

Change-Id: Ia78fc0b5435f659c8fe31abee8b76006d7986b66
2017-06-28 20:27:15 -07:00
Shunta Sato
22080a1df5 Fix Wi-Fi list adds same AP repeatedly
When switch AP security mode, several same APs are shown.

To fix this issue, append security type to preference
key for avoiding different APs have same key.
git fetch

Cherrypick of:
https://partner-android-review.googlesource.com/#/c/799829/

Bug: 37558394
Test: runtest --path
packages/apps/Settings/tests/unit/src/com/android/settings/wifi/WifiSettingsUiTest.java

Change-Id: I39621636f14b29e45ba96ff76dc3c21a4996a136
2017-06-28 20:21:46 -07:00
Maurice Lam
21bd3994c4 Merge "Read theme for lock screen flows" into oc-dr1-dev am: 864d5c96d7
am: d3d1210fad

Change-Id: I6f689b5242b122eb2f4388de10acb7e4c7e3b81e
2017-06-29 02:07:19 +00:00
Maurice Lam
d3d1210fad Merge "Read theme for lock screen flows" into oc-dr1-dev
am: 864d5c96d7

Change-Id: I5b70f7ac6ff0c4598f3f409d682c9ff2dec42471
2017-06-29 02:00:33 +00:00
TreeHugger Robot
4ef813efdc Merge "Disable SmartSuggestion conditionally" 2017-06-29 01:55:52 +00:00
Maurice Lam
864d5c96d7 Merge "Read theme for lock screen flows" into oc-dr1-dev 2017-06-29 01:47:14 +00:00