Commit Graph

602 Commits

Author SHA1 Message Date
Bonian Chen
f9bf994ae0 Merge "[Settings] Code refactor for Wifi calling IMS API" 2020-02-12 06:14:31 +00:00
Thomas Devaux
3f0b74cf84 Merge "Auto-open Captive Portal when user clicks on open network." 2020-02-12 02:37:58 +00:00
Thomas Devaux
158d17fef6 Auto-open Captive Portal when user clicks on open network.
Rationale: many users are confused about what to do after tapping the captive
portal network in Settings, and since there is explicit user action to
connect to that network at that point, auto-opening the portal is
natural and makes it simpler.

Bug: 148538768
Test: manually with local AP with Captive Portal and:
> make RunSettingsRoboTests -j40
> atest com.android.server.ConnectivityServiceTest

Change-Id: I29573132cd3e46ff22e6f67bb3678516fabac47d
2020-02-12 00:45:46 +00:00
lesl
df450cc9f6 tether setting: fix test error: updateDisplay_shouldUpdateValue
ag/10257734 change band convert to general design.
Fix test to match new design

Bug: 149251992
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.wifi
Test: make RunSettingsRoboTests ROBOTEST_FILTER=CodeInspectionTest
Change-Id: I6f09d9d4f440515fb51a237d966327e232fe5928
2020-02-11 11:18:21 +08:00
Roshan Pius
93f6c463d6 Merge "Settings: Use new API for wifi wakeup feature toggle" 2020-02-11 00:36:17 +00:00
TreeHugger Robot
d4e2f78d9a Merge "[Wi-Fi] Fix failed test cases" 2020-02-10 13:34:35 +00:00
Arc Wang
1762a3ccad [Wi-Fi] Fix failed test cases
Fix IllegalStateException: Credential or HomeSP are not initialized
by setting credential to PasspointConfiguration.

Bug: 149180590
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.wifi
Change-Id: I14edefaa938f1aeb43b493d24aca3f810ab89593
2020-02-10 19:36:58 +08:00
TreeHugger Robot
d6f9b89061 Merge "tether setting: Remove dual mode check for band convert" 2020-02-10 09:06:57 +00:00
Hai Shalom
ae7d2cf99c [Passpoint] Fix broken test: com.android.settings.wifi.WifiSettingsTest
Fix broken test: com.android.settings.wifi.WifiSettingsTest.
PasspointConfiguration objects require both HomeSp and Credential
objects initialized, and since today it is enforced in the Wi-Fi API.
Updated the test mocks to initialize the Credential object which was
missing.

Bug: 149175146
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.wifi.WifiSettingsTest
Change-Id: I709a6bc104141ac88b2c88bdac4f3a9a3d296ec9
2020-02-10 04:14:12 +00:00
Bonian Chen
ced9489549 [Settings] Code refactor for Wifi calling IMS API
Replacing logics of
ImsManager#isWfcEnabledByPlatform() &
MobileNetworkUtils#isWfcProvisionedOnDevice()
into WifiCallingQueryImsState#isWifiCallingProvisioned().

Bug: 140542283
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingSliceHelperTest
Change-Id: I68462368669b81e10d09bbb93e74e23ea9a1f446
2020-02-10 00:56:51 +08:00
Roshan Pius
65291297a9 Settings: Use new API for wifi wakeup feature toggle
Bug: 148514485
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.wifi
Test: Verified wifi wakeup feature toggle in wifi settings.
Change-Id: I1e7c0b3ca053a9b7d6105cad16362df38517b51e
2020-02-07 12:33:18 -08:00
Edgar Wang
4af4f276bd Merge "Make the fragment title can’t searchable" 2020-02-07 08:07:01 +00:00
Edgar Wang
0934babbfc Make the fragment title can’t searchable
we shouldn't take users so deep into the settings IA because it's easy
to feel lost in settings after clicking on a result without additional
context.

Bug: 143055215
Test: robotest & manual
Change-Id: I337cb5ead31e1e4e7bf9be78132e90630f83ee43
2020-02-06 19:07:11 +08:00
lesl
561d041f7b tether setting: Remove dual mode check for band convert
Some conutries don't support 5G only hotspot. Thus band convert should
not only work for dual mode device. It should general design since it
will be country dependency.

Bug: 148924644
Bug: 148764406
Test: Manual Test, use command to force country
1. adb root && adb shell cmd wifi force-country-code enabled GB
2. Change Band Setting to 5G prefer

Turn on hotspot to check log and make sure it will enable succeed.
Test:make RunSettingsRoboTests ROBOTEST_FILTER=CodeInspectionTest

Change-Id: I7828c62ef399244531a72aa35c89b71549e0d623
2020-02-06 09:49:41 +00:00
Bonian Chen
a8f14cb11e [Settings] Apply ImsQueryProvisioningStat to WFC
1. Code refactor
2. Apply ImsQueryProvisioningStat class to WFC's use case

Bug: 140542283
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingPreferenceControllerTest
Change-Id: I8a09264f83b9fc4fce3f79ec3aeb6ae757b004e4
2020-02-05 16:55:17 +08:00
TreeHugger Robot
638b45e4f3 Merge "[Wi-Fi] Apply cache in WifiTracker to update the signal icon immediatelly." 2020-02-05 05:54:17 +00:00
TreeHugger Robot
bd64ff75b7 Merge "Fix failing test cases" 2020-02-04 12:38:46 +00:00
Tsung-Mao Fang
1361e89b29 Fix failing test cases
Test: Run robo test
Fix: 148200531
Change-Id: I73698515d6b6572b2d81eb4ca34a3dd7c370968a
2020-02-04 18:19:27 +08:00
govenliu
e88f5efeb9 [Wi-Fi] Apply cache in WifiTracker to update the signal icon immediatelly.
issue: Signal icon on the add wifi network feature need to wait for the scan result.
Solution: Apply the cache in the WifiTracker to update signal icon for
shortening the waiting time of new scan result.

Bug: 146842198
Test: Add following unit test cases to test signal level has been updated correctly:
      1. withOneSuggestion_whenScanResultChangedButWifiOff_uiListShouldHaveZeroLevel.

Change-Id: Id72e2b43e020f2cafa2af4af5ffb1c28529002bd
2020-02-04 10:40:55 +08:00
David Su
f38bff9e0b Merge "Rename WifiConfiguration.getHasEverConnected()" 2020-02-03 21:12:03 +00:00
David Su
7e7b59e46e Merge "Settings: remove usage of WifiConfig helper methods" 2020-02-03 21:09:52 +00:00
TreeHugger Robot
b7f0145c02 Merge changes I8194476e,I9d21909f
* changes:
  [Wi-Fi] Fix some test failures of com.android.settings.wifi.details2
  [Wi-Fi] Remove passpoint methods in WifiEntryShell
2020-02-01 05:24:09 +00:00
Arc Wang
41ff138c21 [Wi-Fi] Fix some test failures of com.android.settings.wifi.details2
WifiMeteredPreferenceController2 always has a non null mWifiEntry, remove redundant test case
testController_resilientToNullConfig

Bug: 146479774
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.wifi.details2
Change-Id: I8194476ea0f337e63b29ff73e9071f6df65d13af
2020-01-31 15:23:51 +08:00
David Su
fa6e9f7283 Rename WifiConfiguration.getHasEverConnected()
Renamed to hasEverConnected() to conform to API
guidelines.

Bug: 146046526
Test: make RunSettingsRoboTests -j40
Change-Id: Ie88945326977ea11a05721e40a81c338fee61cb6
2020-01-30 20:36:30 -08:00
David Su
59ab4ce478 Settings: remove usage of WifiConfig helper methods
These methods can be replaced with methods on
IpConfiguration itself. There is no need to expose
these as a @SystemApi, and they are being removed.

Bug: 146046526
Test: make RunSettingsRoboTests -j40
Change-Id: I592f277f5e23bf58e76b8c48a0f0370d53cc6b81
2020-01-30 10:53:48 -08:00
David Su
8ab62a8750 Migrate WifiManager.isDualModeSupported() to isStaApConcurrencySupported()
isDualModeSupported is being removed, replace it
with isStaApConcurrencySupported.

Bug: 144925765
Test: compiles
Change-Id: Ia3a0417a154ea401579a039113e96ba4578ffd80
2020-01-29 14:46:33 -08:00
Tsung-Mao Fang
fa00e245cd Ignore test cases for ListWithEntrySummaryPreferenceTest
We ignore the failing test cases temporarily.
And we will fix it soon.

Bug: 148200531
Test: Run robotest
Change-Id: Ie42e85be19d3ac1658065bd730a6d9ec7bb06a21
2020-01-24 22:07:01 +08:00
David Su
f56c4defc7 Merge "Settings: migrate usage of @hide NetworkSuggestion APIs" 2020-01-21 17:05:24 +00:00
Bonian Chen
2c0088be68 Merge "[Settings] apply WifiCallingQueryImsState" 2020-01-21 14:57:10 +00:00
Bonian Chen
a498eae245 [Settings] apply WifiCallingQueryImsState
1. Code refactor
2. Apply WifiCallingQueryImsState to more WifiCalling classes

Bug: 140542283
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingSettingsForSubTest
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingSliceHelperTest
Change-Id: Idd4935a6d8ceed77c15e90f96781014d1940a427
2020-01-21 19:33:16 +08:00
TreeHugger Robot
38403f465b Merge "Implement new design of Wi-Fi card" 2020-01-21 10:31:33 +00:00
Jason Chiu
fbf3d7574a Implement new design of Wi-Fi card
- always show Wi-Fi card
- collapse the card in the new UI session when connecting to a stable
  network
- hide toggle, show a level icon and subtext in the new collapsed mode
- show loading row when the AP list is not full

Test: robotest
Fixes: 147473096
Change-Id: I893064ef04d40d8e7cb8e62c1e72a2cb5e97f6ac
2020-01-21 17:26:29 +08:00
govenliu
7e1018c0d0 [Wi-Fi] Add Wifitracker mechanism to update the signal icon.
Signal icon on the add wifi network feature is constant, didn't change with real signal level.

Bug: 146842198
Test: Add following unit test cases:
      1. withOneSuggestion_uiElementShouldHaveInitLevel() to test init level.
      2. withOneSuggestion_whenScanResultChanged_uiListShouldHaveNewLevel() to test level should updated according to scan result.

Change-Id: I212a825da9455a09a5c7777f87c0a74ec030c890
2020-01-20 17:34:20 +08:00
David Su
453d88568f Settings: migrate usage of @hide NetworkSuggestion APIs
Settings uses @hide WifiNetworkSuggestion.
wifiConfiguration/passpointConfiguration.
Migrate to @SystemApi getters.

Removed call to PasspointConfiguration.validate()
as it is an @hide API, instead
WifiManager.addOrUpdatePasspointConfiguration()
will perform the required validation.

Bug: 138801922
Test: make RunSettingsRoboTests -j40
Change-Id: I748010b66634b1d24e89a175917492f638267cb1
2020-01-17 15:41:40 -08:00
govenliu
237290f854 [Wi-Fi] Refactor add wifi networks feature to use WifiNetworkSuggestion.
WifiConfiguration used in the feature of add apps Wi-Fi networks was Deprecated, need to be changed to use WifiNetworkSuggestion.

Bug: 136472483
Test: Refactor AddAppNetworksFragmentTest to apply WifiNetowrkSuggestion
Change-Id: I022d200905880f7f7bd367f5fa62fa88e785db02
2020-01-16 09:38:00 +08:00
David Su
8aeb6ce749 Merge "SettingsRoboTests: Remove @hide Wifi API usages" 2020-01-10 19:11:45 +00:00
TreeHugger Robot
c824ef4940 Merge "softap: Use set/getPassphrase to replace set/getWpa2Passphrase" 2020-01-10 08:47:44 +00:00
Lee Chou
30c453755e Disable Broken Settings Tests
Some Settings Tests are currently broken, disabling for now

Bug: 147464840
Test: make RunRoboSettingsTests
Change-Id: I7c00faa00ce91030e76b7d4d028f6a30e471738f
2020-01-10 16:16:17 +08:00
lesl
24a505c4eb softap: Use set/getPassphrase to replace set/getWpa2Passphrase
Bug: 142752869
Test: Manual, on/off/setting change for hotspot function
Test: make RunSettingsRoboTests ROBOTEST_FILTER=CodeInspectionTest
Change-Id: I22c89f15a6ef1c5366394431cc5aa7031a573d45
2020-01-09 19:23:41 +08:00
David Su
6768f057b0 SettingsRoboTests: Remove @hide Wifi API usages
Constructors are @hide, instead use Mockito to
create mock objects.

Bug: 138801922
Test: atest SettingsRoboTests
Change-Id: I3fb22ffd7b04fd62649b42f455230c6372beef26
2020-01-07 17:28:43 -08:00
TreeHugger Robot
1772ec0040 Merge "[Wi-Fi] Implement Wi-Fi Auto-connect feature" 2020-01-06 09:09:20 +00:00
Arc Wang
7dda07fe81 [Wi-Fi] Implement Wi-Fi Auto-connect feature
This feature allows users to specify if a Wi-Fi network
will be auto connected after disconnection.

Bug: 136472407
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiAutoConnectPreferenceController2Test
Change-Id: I8a7c02ba3fc4cbfbfb431fa99c42279ca29e9492
2020-01-06 10:19:30 +08:00
Arc Wang
d90eac593a [Wi-Fi] Fix SavedAccessPointsPreferenceController crash when editing Settings search box
In getAvailabilityStatus(), refresh mAccessPoints before using it.

Bug: 147096386
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SavedAccessPointsPreferenceControllerTest
Change-Id: Id6818bd7bab1effb2e4e1447b18d5f5f02d7cfca
2020-01-03 17:47:05 +08:00
Arc Wang
644b24ccf3 Merge "[Wi-Fi] Support disconnect button for connected Wi-Fi AP" 2020-01-03 01:45:45 +00:00
Tsung-Mao Fang
3fe3a1a47b Merge "Remove the @ignore flag in test file." 2020-01-02 03:04:56 +00:00
TreeHugger Robot
82c437128d Merge "[Wi-Fi] Support intent extra "wifi_enable_next_on_connect" in WifiSettings2" 2019-12-31 11:33:45 +00:00
Stanley Wang
c3abeb3c99 Remove the @ignore flag in test file.
- Remove the @ignore flag in WifiTetherApBandPreferenceControllerTest.
  All test cases should pass.

Fixes: 147031384
Test: robotest
Change-Id: Icf7d5063b001699c644d6666c79b6e81709d704d
2019-12-31 18:15:23 +08:00
Arc Wang
3971d4e0c4 [Wi-Fi] Support disconnect button for connected Wi-Fi AP
Connect button becomes Disconnect button if the Wi-Fi AP
is connected.

Bug: 135891885
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=WifiDetailPreferenceController2Test
Change-Id: I0e0d485385294658170da3d37bc1cc1f8748468f
2019-12-31 17:06:44 +08:00
Ahmed ElArabawy
8a9ad06570 Merge "Wifi: Fix rototests for wifi tethering" 2019-12-31 08:41:11 +00:00
Ahmed ElArabawy
2632c25f37 Wifi: Fix rototests for wifi tethering
This commit makes fixes to the wifi tethering rototests.
These fixes are done by using the proper encoding for the AP bands.

Bug: 146767071
Test: Run robotest
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.wifi
Change-Id: I4ddf6ea9328dabed09bc23d355efa188975316b6
2019-12-30 22:55:17 -08:00