Commit Graph

23965 Commits

Author SHA1 Message Date
Matthew DeVore
faa7bc846e Merge "Run body of applyTopology for all non-noop drags" into main 2025-02-07 12:20:19 -08:00
Yuhan Yang
7630d396a6 Add Autoclick cursor area size settings dialog
Replace Autoclick sliderbar with an alert dialog
and radio group to match the new UI requirement.

Screenshot:
 - Click area column:
   go/screenshot-5AfdF7FGghsdiXk
 - Alert dialog:
   go/screenshot-4dgtojcc6lvjtyy

Bug: 390460480
Test: ToggleAutoclickCustomSeekbarControllerTest
Flag: com.android.server.accessibility.enable_autoclick_indicator
Change-Id: Ic79f8833e69dde8d8eb3e945e5acd551d2ee9ff5
2025-02-07 19:58:53 +00:00
Matthew DeVore
83a1d4360f Show topology pane in per-display fragment
Some changes made to the UI, i.e. presence or absence of items, based on
feedback. There is some ambiguity because we are not fully v2 yet, hence
this change.

When all external displays are attached after opening the fragment, we
now show no preference items, whereas before we showed the pane with
built-in display options.

If only one external display is attached, we skip the "display list"
version of the fragment, and instead show the pane and other v2 items in
the per-display fragment.

If 2 or more external displays are attached, we do not show the pane
after selecting a display, which makes the rotation/resolution items
easier to find. I tried to get scrollToPreference to work but could not,
and it could be a little disorienting anyway.

To help manage the growing number of setOrder calls, keep the order
values as well as other pref data in a single spot. This also reduces
the amount of boilerplate around constants needed and makes uniform how
multiple preferences are built.

Flag: com.android.settings.flags.display_topology_pane_in_display_list
Bug: b/366056922
Bug: b/394361999
Test: TODO
Change-Id: Iaa33f6d9220a1658a372c0432fe159a69dbb88a5
2025-02-07 19:18:16 +00:00
Matthew DeVore
eeec7d0d66 Run body of applyTopology for all non-noop drags
In onBlockTouchUp, if DisplayTopology.rearrange happened to revert the
change made by the drag so that it matched the before-drag layout, the
blocks would not be moved, so the block would be in the dragged position
but not the normalized position.

This will happen when rearrange has a bug or is otherwise optimizing the
layout, which is dependent on the implementation of rearrange.

The test field mTimesReceivedSameTopology has been replaced with one
that represents an observable positive operation:
mTimesRefreshedBlocks, the validation of which has been added to some
existing tests.

Flag: com.android.settings.flags.display_topology_pane_in_display_list
Test: move display so that rearrange reverts the change, then exit and re-enter the external display fragment, and verify it matches the state when left
Test: DisplayTopologyPreferenceTest
Bug: b/394361999
Bug: b/394355269
Change-Id: Ic3028747d283db77f144831352b7687fe2706391
2025-02-07 12:58:06 -06:00
Aleksander Morgado
035a15ac37 Added unit test for MobileNetworkPhoneNumberPreferenceController visibility
The new test checks whether the item is available when the
SubscriptionUtil.isSimHardwareVisible() method returns true, i.e. if
the config_show_sim_info boolean flag is true on non-test runtime.

The default visibility status for all tests is defined in the test
setup() method, as this will also simplify the addition of new checks
later on.

Bug: 392808943
Flag: EXEMPT test only
Test: atest MobileNetworkPhoneNumberPreferenceControllerTest

Change-Id: Icedef190a8140fd8164dd8035ae93735a666b9f0
2025-02-07 14:53:25 +00:00
Aleksander Morgado
616fbc4f93 Added unit tests for PhoneNumberPreferenceController visibility
The tests check whether the item is available based on the result of
the SubscriptionUtil.isSimHardwareVisible() method, which is the one
allowing to check the value of the config_show_sim_info boolean flag
on non-test runtime.

Bug: 392808943
Flag: EXEMPT test only
Test: atest PhoneNumberPreferenceControllerTest

Change-Id: I2d1361ecef8a9c1083b4fd6fd4462c7815574827
2025-02-07 14:53:16 +00:00
Yiyi Shen
5732773031 [Audiosharing] Set temp bond metadata for just bonded lea buds in sharing
Test: atest
Flag: com.android.settingslib.flags.enable_temporary_bond_devices_ui
Bug: 392004799
Change-Id: I99e9955d00362125b7cbf54e2013c99dd2f9b457
2025-02-07 19:20:29 +08:00
YK Hung
fc86da0f6d Merge "Use BatteryOptimizeUtils to add packageName into PowerSaveWhitelistUserApps allowlist, which will force set app into Unrestricted Mode" into main 2025-02-06 22:44:33 -08:00
Kevin Liu
8384d162d0 Merge "Temp disable test that contains custom shadow within it" into main am: d1b8b3a7e1 am: 0db2f6c60f
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3479734

Change-Id: Ibb99bff0e14112bab302f89de9da40d4910c78a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-06 11:55:15 -08:00
Liefu Liu
9852033728 Merge "Update the sub title of SIM preference in Contacts Storage Setting, to be consistent with "Device-only" preference." into main 2025-02-06 10:52:40 -08:00
Angela Wang
6f0f6e7cf6 Merge "Hide ambient control when there's no valid control point" into main 2025-02-06 09:17:37 -08:00
Shawn Lin
6f4f66e5ed Support customization for biometrics SafeSourceIssue
Notify issue action launch when enrollment process is canceled

Bug: 370940762
Test: atest FaceEnrollTest FingerprintEnrollTest
Flag: com.android.settings.flags.biometrics_onboarding_education
Change-Id: I91e2dcf44ee8cfd3e7c74d05f51a1ef30ea6f8b2
2025-02-06 16:30:55 +00:00
Kevin Liu
a9e22be8a5 Temp disable test that contains custom shadow within it
We need proper support or Exception throw for this scenario

Test: atest SettingsRoboTests
Bug: 394813533
Change-Id: I8b552f7b2bff166643bdaa492dceff23679116ff
2025-02-06 14:48:43 +00:00
Shaowei Shen
086c8b7955 Merge "[Physical Keyboard] Move Dialog to DialogFragment" into main 2025-02-06 02:20:41 -08:00
Yuri Ufimtsev
ec78150e69 Merge "Allow the LockPatterUtils to be null" into main 2025-02-06 01:37:56 -08:00
mxyyiyi
c03e7ee9d6 Use BatteryOptimizeUtils to add packageName into PowerSaveWhitelistUserApps allowlist, which will force set app into Unrestricted Mode
Fix: 372831500
Fix: 393033745
Test: test manually by app "Baidu Cloud"> auto-backup settings > add into battery allowlist.
Test: atest RequestIgnoreBatteryOptimizationsTest
Flag: EXEMPT for simple fix
Change-Id: Ia0b232389b1c11b48724af750721e6af4313deaf
2025-02-06 15:49:28 +08:00
Treehugger Robot
b8958a73b5 Merge "Remove rolled out flag automatic_bt_device_type" into main 2025-02-05 23:25:39 -08:00
Chelsea Hao
88548e94cb Merge "Update audio sharing dialog text." into main 2025-02-05 23:18:14 -08:00
chelseahao
e7ccbf436e Update audio sharing dialog text.
Also add a radius to the qr code image.

Test: atest
Bug: 381775542
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Change-Id: I6b06b02f63bc46ec20b7a9e0aa236f2547a5f612
2025-02-05 22:08:59 -08:00
Shawn Lin
b15c923f45 Merge "[Biometric Onboarding & Edu] Update fingerprint settings page" into main 2025-02-05 19:43:32 -08:00
Chelsea Hao
c1ac5c11a9 Merge "Show "Stream paused" when hysteresis mode in UMO." into main 2025-02-05 18:50:40 -08:00
Liefu Liu
069f926bba Update the sub title of SIM preference in Contacts Storage Setting, to
be consistent with "Device-only" preference.

Bug:  394335832
Test: atest ContactsStorageSettingsTest and manually test
Flag: EXEMPTED (minor fix)

	modified:   src/com/android/settings/applications/contacts/ContactsStorageSettings.java
	modified:   tests/robotests/src/com/android/settings/applications/contacts/ContactsStorageSettingsTest.java

Change-Id: Ibf52d237da468d951211e9afa323d61fa72a1206
2025-02-05 17:23:41 -08:00
Vlad Popa
b136fcfe18 Remove rolled out flag automatic_bt_device_type
This flag has been rolled out in 24Q3 and can be removed.

Test: atest BluetoothDetailsAudioDeviceTypeControllerTest
Bug: 302323921
Flag: EXEMPT removing com.android.media.automatic_bt_device_type
Change-Id: I9997ef60f195b36298c36078eadf6c0a82bc662d
2025-02-05 16:04:50 -08:00
Liefu Liu
ce463e4142 Merge "Updated the Contacts Storage Settings' bottom line text." into main 2025-02-05 15:06:42 -08:00
Vitor Carvalho
4f4e2da16b Merge "Fix tests in Settings that break with the changes in ParentalControlsUtils introduced in ag/31121556." into main 2025-02-05 10:36:07 -08:00
Junchen Quan
74aefe07d3 Merge "Add PIN recovery entry in supervision PIN management page." into main 2025-02-05 10:07:45 -08:00
Liefu Liu
b197bfe8f2 Updated the Contacts Storage Settings' bottom line text.
Bug: 394335832
Test: unit test and manual test
Flag: EXEMPTED

	modified:   res/values/strings.xml
	modified:   tests/robotests/src/com/android/settings/applications/contacts/ContactsStorageSettingsTest.java

Change-Id: Ibde23352a6c64ff7ea546e2fd5ef9468398829f7
2025-02-05 08:49:17 -08:00
Angela Wang
11debff2be Hide ambient control when there's no valid control point
The preference will be accidentally shown if the device support HAP and
VCP. Make sure to hide the preference when the device doesn't have any
valid ambient control points.

Flag: EXEMPT bugfix
Test: manual test with real device
Test: atest BluetoothDetailsAmbientVolumePreferenceControllerTest
Bug: 388156028
Change-Id: I8162ce8e878baff414e4665c97aaf1c21aa51229
2025-02-05 15:55:41 +00:00
Yuri Ufimtsev
55b7b0613d Allow the LockPatterUtils to be null
In some tests it could inconsistently become a null, crashing with NPE, for the reason I can't understand (maybe there is a race condition somewhere between mocking and accessing the LockPatterUtils in such tests)
Let's accept it gracefully

Test: atest SettingsUnitTests
Bug: 382637173
Flag: EXEMPT bugfix
Change-Id: I35d5faa1a29307fc780207a816680a32b2796bc0
2025-02-05 14:38:46 +00:00
Ebru Kurnaz
1d71ed9d3d Merge "Add a preference for display size settings." into main 2025-02-05 03:12:11 -08:00
Shawn Lin
d40442c91f Merge "[Biometric Onboarding & Edu] Update face settings page" into main 2025-02-05 02:52:09 -08:00
Vitor Carvalho
a796ca497a Merge "Update EnterprisePrivacyFeatureProviderImpl to obtain the parental controls intent from SupervisionIntentProvider." into main 2025-02-05 02:47:01 -08:00
Shawn Lin
e2051d50e3 [Biometric Onboarding & Edu] Update fingerprint settings page
- Added a feature provider for fingerprint settings page in
  FingerprintFeatureProvider for customization
- When no fingerprint enrolled, disabled the settings buttons instead of
  hiding them.
- Update new UX style for add fingerprint button

Bug: 370940762
Test: manual - 1. Enroll a fingerprint
               2. Go Fingerprint Settings page and remove fingerprint
	       3. Enroll fingerprint again
Test: atest FingerprintSettingsFragmentTest
Flag: com.android.settings.flags.biometrics_onboarding_education

Change-Id: Ibe47bb241c4b20e8e0c5b4a9172aef90bf3727ea
2025-02-05 10:34:28 +00:00
Shawn Lin
d747235a4c [Biometric Onboarding & Edu] Update face settings page
- Added a feature provider for face settings page in FaceFeatureProvider
  for customization
- When face is deleted, disabled the settings buttons instead of hiding
  them.
- Updated new UX style for add/remove face button.

Bug: 370940762
Test: atest FaceSettingsEnrollButtonPreferenceControllerTest
            FaceSettingsFooterPreferenceControllerTest
Test: manual - 1. Enroll face
               2. Go Face Settings page and remove face
	       3. Enroll face again
Flag: com.android.settings.flags.biometrics_onboarding_education

Change-Id: I490e647523eeff2dd1a58aab07f638e3e5e0ffb8
2025-02-05 00:57:40 -08:00
yqian
4dfe488d8b [Cleanup] remove flag enable_bonded_bluetooth_device_searchable
the feature is enabled in prod already

Test: atest ConnectedDeviceGroupControllerTest
Bug: N/A
Change-Id: I7b2674bd42ed0a3bbe03c74ff52c3ccd830178dc
Flag: EXEMPT just cleanup
2025-02-04 21:35:12 -08:00
Hakjun Choi
be6525024d Merge "Clean up aconfig flag oem_enabled_satellite_flag" into main 2025-02-04 19:31:29 -08:00
Ben Lin
a20685eb3c Update DesktopMode API name.
Bug: 384568161
Test: Build
Flag: EXEMPT bugfix
Change-Id: Idc953d196ac7cf4ebcc82000d0c4be9fab893f9a
2025-02-05 02:53:30 +00:00
Yining Liu
b602e4b0fc Merge "Fix the toggle status for show sensitive content switches" into main 2025-02-04 15:26:44 -08:00
Riley Jones
a1e47ef860 Merge "Update strings again for refreshed High Contrast Text" into main 2025-02-04 15:17:23 -08:00
Julia Reynolds
d46bed9b13 Merge "Add app level settings for classification and summarization" into main 2025-02-04 12:56:49 -08:00
Ebru Kurnaz
fb9fdc951b Add a preference for display size settings.
Currently slider is not functioning.

Flag: com.android.settings.flags.display_size_connected_display_setting
Test: atest ExternalDisplayPreferenceFragmentTest
Bug: 392853666
Change-Id: Ibcb55bc939a38dad58451b2a0db4a59f5aa28e5f
2025-02-04 20:37:28 +00:00
juquan
26ea7df1d5 Add PIN recovery entry in supervision PIN management page.
Bug: b/390500290
Change-Id: I942fad663d0fb731215707d7c0b18359242aecb0
Test: atest SupervisionPinRecoveryPreferenceTest
Flag:android.app.supervision.flags.enable_supervision_pin_recovery_screen
2025-02-04 19:10:01 +00:00
Julia Reynolds
55441003d3 Add app level settings for classification and summarization
Test: AdjustmentKeyPreferenceControllerTest
Flag: android.app.nm_summarization
Flag: android.app.notification_classification_ui
Flag: android.app.nm_summarization_ui
Bug: 377697346
Bug: 390412878
Change-Id: I85b67b5c0376ee4cd962e26bf178aae6fa712212
2025-02-04 10:53:57 -08:00
Matthew DeVore
883070758b Merge "Show a category for each external display" into main 2025-02-04 10:38:14 -08:00
Liefu Liu
121036ee7e Merge "Minor UI string change in Contacts Storage Setting." into main 2025-02-04 08:35:56 -08:00
Jacky Wang
2e265d4a7a [Catalyst] Introduce SettingsContract file
The new file contains all contract constants for external usages (e.g.
slice, external Get/Set API). Also reuse existing constants in
SettingsSlicesContract.

NO_IFTTT=Catalyst only

Bug: 388061003
Flag: EXEMPT refactor
Test: atest
Change-Id: I449b7b6cf82e1e102f2c96a21835191605f09943
2025-02-04 18:24:46 +08:00
Treehugger Robot
1ecacd8a5a Merge "Add one more param to isChargingOptimizationMode() for flexibility" into main 2025-02-04 01:01:51 -08:00
Jacky Wang
ef0b28e415 Merge changes from topic "sound" into main
* changes:
  Fix IntentReceiver leaked on Sound & vibration
  Get rid of VolumeSeekBarPreferenceController.setCallback
2025-02-04 00:53:31 -08:00
Treehugger Robot
2d664f308d Merge "Cleaned up the flag enable_modem_cipher_transparency" into main 2025-02-03 23:26:36 -08:00
Jacky Wang
402e5bb38b Fix IntentReceiver leaked on Sound & vibration
The root cause is that PreferenceController migrated to Catalyst will be
removed by DashboardFragment and VolumeSeekBarPreferenceController
onPause() is not invoked.

NO_IFTTT=Controller only

Fix: 386162594
Flag: EXEMPT bugfix
Test: atest&manual
Change-Id: I13f8588c8259ed4ddb9895ffc60e209c99c05269
2025-02-04 15:08:38 +08:00