Commit Graph

51159 Commits

Author SHA1 Message Date
Fan Zhang
f2390512c1 Add null check in UserPreference
The comparator can get null objects according to bug report.

Fixes: 130144755
Test: manual
Change-Id: Ic8a332d390f411d2eb69c944fb7fd166d9961535
2019-04-08 13:55:58 -07:00
TreeHugger Robot
b93761d252 Merge "Delete carrier entry from mobile network details page." into qt-dev 2019-04-08 20:00:29 +00:00
Julia Reynolds
8a9e6cc9fa Move NAS selection to 'special app access'
Test: manual
Fixes: 130169253
Change-Id: I0e69b11c557bc153cee0073bb2e982e3ee36e721
2019-04-08 15:46:57 -04:00
Malcolm Chen
046419a92a Revert switchBar if enable / disable subscription fails.
Bug: 123321718
Test: build manual test
Change-Id: Ia7e8c762d91f81b67e0d0b11d36dfa78ec1e2d18
2019-04-08 18:42:06 +00:00
Sumit Deshmukh
c00e137a55 Settings: [BT] Wrong Pairing Popup is shown on new pairing request.
Usecase:
1. Start advertising from DUT (using BLE Smartertooth app).
2. Scan and connect from central device.
3. Now initiate bond from central and accept pairing request.
   (Consent Pairing Dialog will be shown on DUT)
4. Notification will be received for PASSKEY CONFIRMATION Dialog.
   Do not open notification and let it timeout.
5. Repeat steps 2 and 3. At step 3, Passkey Confirmation pairing
   dialog is show instead of Consent pairing dialog.

Issue:
Wrong Pairing Popup is shown. Passkey Confirmation pairing
dialog is show instead of Consent pairing dialog.

Reproducible Rate: 100%

Root Cause:
PendingIntent created for showing pairing notification are getting
reused as only FLAG_ONE_SHOT is used. This flag is not updating new
extra's in the pending intent.

Fix:
Use flag FLAG_UPDATE_CURRENT in pending Intent.

Test: Tested above mentioned testcase and pairing scenarios.

Fix: 129479787
Bug: 129456113

Change-Id: I46813f355cd796cee1b472774b494c8580b39784
2019-04-08 18:20:36 +00:00
TreeHugger Robot
5c28e42538 Merge "Fix 'Advanced' collapse point on Network & internet page" into qt-dev 2019-04-08 18:15:57 +00:00
Andrew Sapperstein
95c915d9dc Delete carrier entry from mobile network details page.
Followup CL will need to delete the backing code after we remove the feature flag.

Bug: 127540176
Test: robotests and visual inspection
Change-Id: I17e917b9726cf7f5470af09332ede38f8c253eed
2019-04-08 11:15:47 -07:00
TreeHugger Robot
f1cea95f3e Merge "Fix battery color tint issue." into qt-dev 2019-04-08 15:03:58 +00:00
Svetoslav Ganov
d5161f8d90 Merge "Update Settings to use the proper DeviceConfig API." into qt-dev 2019-04-08 14:54:03 +00:00
Arc Wang
63b4c1ab85 Remove the PreferenceGroup without title in WifiNetworkDetailsFragment
To remove the PreferenceGroup title space.

Bug: 129683066
Test: manual
Change-Id: I00bced8038a01c0ef7e8f4dfa0b82e36a275004e
2019-04-08 20:19:11 +08:00
tmfang
e9f11d6efc Improve launch time for app & notification screen
- We won't query recent apps in getAvailabilityStatus().
And then we do that in background thread.
So, we can launch app & notificatins screen as soon as possible.

- Create a RecentAppStatsMixin class which is responsible
for maintaining the recent apps data.

- Controllers and fragment update their UI after they got
onReloadDataCompleted callback from RecentAppStatsMixin.

Test: manual, robotest
Fixes: 128849426
Fixes: 126453868
Change-Id: I636d5878cb5d53496978fe613c625382d8d382bc
2019-04-08 16:40:33 +08:00
Svet Ganov
864765f8b4 Update Settings to use the proper DeviceConfig API.
Exempt-From-Owner-Approval: carry over approval from ag/6908306

bug:124769181

Change-Id: If18d0dc5e55dabf82b7c7a2b6df240fb8b24f736
2019-04-07 22:37:02 -07:00
cnchen
caf122bcb6 Fix fingerprint screens from "Anything else" screen not applying Stencil theme
Bug: 129788677
Test: RunSettingsRoboTests, manual test intent extra data has been passed
Change-Id: Icfae54061e5d87a8ba9c95263d840c456aac5bcb
2019-04-08 03:45:59 +00:00
TreeHugger Robot
6010c3a9a8 Merge "Don't allow CBRS subscriptions to be set as default for Calls/SMS" into qt-dev 2019-04-06 04:05:32 +00:00
Christine Franks
65b535f44a Merge "Use CDS display white balance getter and setter" into qt-dev 2019-04-06 01:25:41 +00:00
Amin Shaikh
95aeb373fd Fix battery color tint issue.
Added test to verify fix.

Bug: 128354921
Test: m RunSettingsRoboTests
Change-Id: I24cbb966e549eec783912e4e118c00425b971ad0
2019-04-05 23:52:59 +00:00
Antony Sargent
ed5c2a1b10 Don't allow CBRS subscriptions to be set as default for Calls/SMS
CBRS subscriptions (also known as "opportunistic" in the code base) are
data-only and it should not be possible to try to set them as the
default for Calls or SMS.

Fixes: 125855327
Test: make RunSettingsRoboTests
Change-Id: Ie20ef21ccc7b27315089f6a61cceb6e1512ec373
2019-04-05 16:48:53 -07:00
TreeHugger Robot
963ebf576a Merge "Clean up tts preference layout." into qt-dev 2019-04-05 23:36:07 +00:00
TreeHugger Robot
023fa7fdf9 Merge "Remove mainline module feature flag checks." into qt-dev 2019-04-05 23:33:16 +00:00
Linda Tseng
3d46fcd5b4 Merge "Remove divider above device switcher in panel" into qt-dev 2019-04-05 23:09:14 +00:00
Bill Yi
37f00b2fce [automerger skipped] Import translations. DO NOT MERGE
am: 83d678bdc4 -s ours
am skip reason: subject contains skip directive

Change-Id: I273e17ee6cf94e6a6b7a3f6ed2a9b22c5a7a9992
2019-04-05 15:47:28 -07:00
TreeHugger Robot
383baeae86 Merge "Update taskAffinity" into qt-dev 2019-04-05 21:39:05 +00:00
Christine Franks
84e67e1f72 Use CDS display white balance getter and setter
Bug: 123930917
Test: make ROBOTEST_FILTER="(DisplayWhite*)" RunSettingsRoboTests -j48
Change-Id: Iafc6ff9a61b69baf03efddd52687093c55d35178
(cherry picked from commit ebacc33852)
2019-04-05 21:36:34 +00:00
Fan Zhang
d8b316f816 Remove mainline module feature flag checks.
They are turned on for a while now.

Fixes: 123648279
Test: robotests
Change-Id: Ibec7a10d49387207697635190a237807f1807628
2019-04-05 14:31:04 -07:00
lindatseng
cf93c8bc92 Remove divider above device switcher in panel
Remove the divider above the media device switcher Slice per the request.

Do a little refactor in Panel View, to use DividerItemDecoration instead of adding
divider views in layout file as the recycler view items divider.

Since dividers should be shown in most cases, we are setting DividerCondition to
DIVIDER_CONDITION_BOTH and default true to allow divider.  For the slice we don't
need divider (media device switch in this case) we are setting the the target
direction of isDividerAllowed (above in this case) to false.  Since we have
DIVIDER_CONDITION_BOTH, if one of the item view set the divider not allow, the
divider won't be shown.

Test: Visual/Manual inspection
Fixes: 126205139
Change-Id: Ic857705c90819ef9375f877a44bb32987b5d4438
2019-04-05 14:15:16 -07:00
Fan Zhang
5bb4ef7c45 Clean up tts preference layout.
Deleted the custom tts layout and use preference_radio directly.

Fixes: 129994473
Test: visual
Change-Id: Ifc50e0cf9f805776e0529ffd5d672283f28a1d15
2019-04-05 13:44:37 -07:00
TreeHugger Robot
b8808e35a6 Merge "Fix sending broadcast with a qualified user in Settings" into qt-dev 2019-04-05 20:05:40 +00:00
Bill Yi
83d678bdc4 Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: I27c0efa466b676aafccb399704805959704fe165
2019-04-05 12:44:47 -07:00
Mill Chen
6b2bced1e6 Fix sending broadcast with a qualified user in Settings
Fixes: 118387886
Test: rebotests
Change-Id: I9e0bdd708b7c95f785f2b11d6d7e3f7818234ada
2019-04-05 10:35:54 -07:00
Lei Yu
e323b40f4e Merge changes Ib80d68d6,I0d57d5b2 into qt-dev
* changes:
  Init PowerWhitelistbackend to stop crash
  Create gitignore for Settings
2019-04-05 17:11:34 +00:00
TreeHugger Robot
41f0a69b76 Merge "Add Settings icons needed for theme overlaying." into qt-dev 2019-04-05 16:38:08 +00:00
TreeHugger Robot
208c21d2c1 Merge "Add bubble confirmation prompt" into qt-dev 2019-04-05 15:26:24 +00:00
Julia Reynolds
19e2473bed Add bubble confirmation prompt
@ the app level if the global level is off

Test: robotests
Bug: 129068779
Change-Id: I94acb334dc9879cd372a2a0dfa8e9508fbf1c316
2019-04-05 09:31:30 -04:00
Amin Shaikh
7b7d6888a2 Add Settings icons needed for theme overlaying.
- Refactor battery icons to remove private attributes to allow them to
be overlayed
- Add drawable icon in settings for back arrow
- Update a few GM2 icons

Bug: 128354921
Test: make; open Settings
Change-Id: I84151a4e7d787381b6c51f02bb45ce5f15fa37a2
2019-04-05 07:54:07 -04:00
TreeHugger Robot
f32d29b730 Merge "Update wifi p2p to direct user to enable location" into qt-dev 2019-04-05 07:59:44 +00:00
Kevin Chyn
13c1c27b8c Merge "Cache attention toggle in settings" into qt-dev 2019-04-05 06:33:37 +00:00
TreeHugger Robot
19626c24ec Merge "Match add network button width to master switch and tint it." into qt-dev 2019-04-05 05:35:05 +00:00
TreeHugger Robot
973eff2eb2 Merge "Add prompt to sign in at captive portal to Wi-Fi Slice" into qt-dev 2019-04-05 03:19:22 +00:00
TreeHugger Robot
83f60c81f5 Merge "Customized Wifi calling text" into qt-dev 2019-04-05 03:17:18 +00:00
TreeHugger Robot
576d601032 Merge "Update char limit for reset_esim_title." into qt-dev 2019-04-05 03:07:09 +00:00
Fan Zhang
b05af56a64 Merge "DND should be displayed on search as slice." into qt-dev 2019-04-05 02:53:12 +00:00
Stanley Wang
bae490bc85 DND should be displayed on search as slice.
Add ZenModeSoundSettingsPreferenceController extends ZenModePreferenceController,
and update availability status to AVAILABLE.

This is cherry-picked from ag/6897872

Change-Id: I8dcb6808cc21c4f5c06548a363c998e369646487
Bug: 129320642
Test: manual & robotests
2019-04-05 02:53:04 +00:00
TreeHugger Robot
02576b6e2e Merge "Update adaptive sleep setting with the latest copy" into qt-dev 2019-04-05 01:16:23 +00:00
Kevin Chyn
388295a80c Merge changes from topic "face-profile-qt-dev" into qt-dev
* changes:
  Settings should be per-profile
  Add face profile settings
2019-04-05 00:41:17 +00:00
TreeHugger Robot
f768b451c3 Merge "Add uri to custom slice PendingIntent." into qt-dev 2019-04-05 00:35:24 +00:00
TreeHugger Robot
a4ea8e94a0 Merge "Update strings" into qt-dev 2019-04-05 00:28:29 +00:00
Kevin Chyn
83f2836552 Cache attention toggle in settings
Bug: 129912479

Test: Builds
Change-Id: I23017f37d53e162c1a1ec35570355508276f90fa
2019-04-04 17:24:09 -07:00
Andrew Sapperstein
d8516430ce Match add network button width to master switch and tint it.
It's now tinted in colorAccent.

Created a new default 80dp minWidth for TwoTargetPreferences.

Fixes: 129007966
Test: visual inspection
Change-Id: Ie751fe685d25373c3aac001e6e0daee8e18b9314
2019-04-04 17:22:10 -07:00
Salvador Martinez
d25ba81028 Update wifi p2p to direct user to enable location
Location is required for Wifi Direct so if it is not enabled
we disable the preference. Additionally, this fixes some minor
update issues in Wifi Wakeup that was also affecting wifi p2p.
Basically they weren't updating when location settings changed
until you left the screen and came back. Now they do.

Test: robotests, manual
Bug: 120552223
Change-Id: Ibd386fcfbef881cae3d871152675f1cab5e4a041
2019-04-04 23:45:04 +00:00
Fan Zhang
459035a263 Add uri to custom slice PendingIntent.
Discovered flashlight slice sometimes does not work, throwing exception
similar as it b/117445451. Adding a data uri fixes it.

Bug: 129981692
Test: manual
Change-Id: I16bc19027dd342f85aaabbf1a2853bb55564f64f
2019-04-04 16:12:38 -07:00