Commit Graph

3346 Commits

Author SHA1 Message Date
Raff Tsai
896de3b48b Remove PreferenceCategory wrapper
- Avoid similiar issue in b/130396913

Bug: 124129485
Test: manual
Change-Id: I6f4698304210bacba5c76020c375dda49330d2cc
2019-08-14 12:31:06 +08:00
Raff Tsai
946441ca27 Learn mode link is not in footer text
Use wrong footerPreference key.

Change-Id: Ic88b4bf9cf336474231329aa2154242d3f95b91a
Fix: 139086150
Test: visual
2019-08-09 17:21:18 +08:00
Sunny Shao
af68c44ed4 Add start margin in the Screen usage item
Avoid the title and subtitle overlap while text length is long. So add the
start margin for subtitle.

Fixes: 136282569
Test: manual test
Change-Id: Id1728ae60904c654c4ffe95fae7fb5139f368092
2019-07-19 06:11:56 +00:00
TreeHugger Robot
1258c94f9d Merge "Increase height of edittext" 2019-07-17 09:38:56 +00:00
hughchen
7879047f65 Increase height of edittext
Bug: 131134021
Test: RunSettingsRoboTests
Change-Id: Ia85b99d2b1f7b730e66516e61a14979b0f68daa8
2019-07-17 14:34:00 +08:00
Jason Chiu
71e9f9147a Add a vertical padding to DND button
Button is too close to divider

Test: visual, robotest
Fixes: 134406305
Change-Id: I1c2d8d2fad78ea3068a61b8aaa1c255328cf084f
2019-07-16 14:08:31 +08:00
Goven Liu
a47265d028 Merge "[Wi-Fi] EAP method AKA' did not pronounced as AKA prime." 2019-07-11 03:22:35 +00:00
govenliu
41cdecca3d [Wi-Fi] EAP method AKA' did not pronounced as AKA prime.
Spinner did not use ttsspan to store the display string so AKA' just
pronounced as AKA.

To fix it, use charsequence array, which each specific array item have
the ttsSpan to store the string for TTS engine.

Bug: 119929832
Test: Set a 3-texts array and check if the specific array item
replacement mechanism work correctly or not.

Change-Id: I8e7d10da99a3f3503e1019687c45cf40070d0045
2019-07-11 09:31:15 +08:00
TreeHugger Robot
23fbf601a0 Merge "[Wi-Fi DPP] Improve TalkBack information for events" 2019-07-10 08:39:05 +00:00
Jason Chiu
ca2bbc0685 Set the max length of user name field in Profile info
Settings may crash when entering a very long user name.

Fixes: 136005061
Test: manual, robotest
Change-Id: Ica17297588fc6b84ef111ef00017afb27360acd3
2019-07-09 18:25:51 +08:00
Arc Wang
1df7f2d1c1 [Wi-Fi DPP] Improve TalkBack information for events
Title and summary may be changed after user operations or Wi-Fi Easy connect handshake,
setAccessibilityLiveRegion could specify accessibility services to announce these changes.

In WifiDppAddDeviceFragment, I set title before summary for correct TalkBack announce sequence.

Bug: 137069941
Test: manual
Change-Id: Id032cfcb86c350feeac808f070665ac26261ceb8
2019-07-09 17:30:01 +08:00
Raff Tsai
e8bd78e212 Add margin between password entry and error text
Fixes: 130664317
Test: visual
Change-Id: Iefdbd39b94a861736baf8e9a302fbf651a5b14d3
2019-07-05 10:56:15 +08:00
Julia Reynolds
6b0315fbc1 Merge "Move channel listing into a pref controller" 2019-07-02 18:10:12 +00:00
Julia Reynolds
a295d71c94 Move channel listing into a pref controller
And a hidden preference category. This makes
hiding/showing the list a lot cleaner and also allows more
of the code to be tested.

Also delete some unused code that no longer complied after
this refactor.

Fixes: 133443871
Test: atest
Change-Id: I4a5fe0e075019bae2df44a0a9dcec26a40ee6d12
2019-07-02 11:24:50 -04:00
tmfang
b981068248 Fix talkback issue about announcing wrong number of items
From hierarchical view, one of root cause is PreferenceCategory.
Looks like PreferenceCategory generates an invisible space when
we add a footerPreference as a child.

So, we remove PreferenceCategory directly, and declard "allow divider"
attribute for neccessary preferences.

Test: Visual
Fixes: 130396913
Change-Id: I6d56ac165633aa211e794e07417821066380d041
2019-07-02 02:33:05 +00:00
Yanting Yang
c200df360c Fix RTL issue of Deferred Setup card
Correct layout gravity to "start" to apply RTL layout.

Fixes: 131913172
Test: visual
Change-Id: I5935c5c1415070803141634ff4e92f1c65fc94f6
2019-06-27 21:26:16 +08:00
TreeHugger Robot
11e1d45c9c Merge "[Wi-Fi DPP] Fix UI defects" 2019-06-19 06:17:22 +00:00
TreeHugger Robot
ce7b012f9c Merge "[Wi-Fi DPP] Remove scanner button of unsaved WiFi network dialogs" 2019-06-19 04:55:24 +00:00
tmfang
c0b2d06501 Fix overlapping problem on popup window
When user clicks spinner widget, spinner creates a popup window.
So, we need to override clipToPadding and clipToChildren attributes
to prevent view from overlapping problem.

Fixes: 135030069
Test: visual
Change-Id: I4285e824437cb32ee0613961ffe417348d2538b4
2019-06-18 11:42:35 +08:00
Arc Wang
c7d32d1cc1 [Wi-Fi DPP] Fix UI defects
1. Set scan icon minWidth 64dp instead of 48dp
2. Show finish button after Wi-Fi Easy Connect handshake successfully

Bug: 129666609
Bug: 135490433
Test: manual visual
Change-Id: Ifcdbe61b314a9cce3043965e9e5b67406c4616f9
2019-06-18 09:52:25 +08:00
Mehdi Alizadeh
896b2c6e0e Show a dialog with a slider to set the back gesture's sensitivity am: 7d43125964 am: 2fbd41a326
am: d8220f8a46

Change-Id: Ib750883f7b0d3e634aa6b0bb5f2ea484748ac444
2019-06-14 17:35:34 -07:00
Mehdi Alizadeh
d8220f8a46 Show a dialog with a slider to set the back gesture's sensitivity am: 7d43125964
am: 2fbd41a326

Change-Id: Iafbfb63497ff9b207bae3695ef1f660292e89804
2019-06-14 17:20:45 -07:00
Mehdi Alizadeh
2fbd41a326 Show a dialog with a slider to set the back gesture's sensitivity
am: 7d43125964

Change-Id: I64cf3b8725efb8f8377e4f9dac545743066b2cbb
2019-06-14 17:11:54 -07:00
Mehdi Alizadeh
7d43125964 Show a dialog with a slider to set the back gesture's sensitivity
Bug: 131447780
Test: Manual test on device
Test: make RunSettingsRoboTests ROBOTEST_FILTER=RadioButtonPreferenceWithExtraWidgetTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationGestureSettingsTest

Change-Id: I9fcd1a50c77689118857326de0cf8082e835b491
2019-06-14 23:40:11 +00:00
Kevin Chang
2293d7b304 Remove redundant style in accessibility permission dialog
Remove the redundant style of allow and deny button in the dialog
since these styles don't have override bodies which indicates that
the style of these two buttons can be replaced by the parent style.

Test: Visual
Fixes: 135166860
Change-Id: I500963196e7afe52065b1b615b35d07f6a77037a
2019-06-14 09:30:29 +08:00
Arc Wang
838cbbf539 [Wi-Fi DPP] Remove scanner button of unsaved WiFi network dialogs
Romove it because we may not ensure the network of a QR code is
matching the selected one.

Bug: 134701332
Test: manual visual
Change-Id: I264e921c806f2b335d158fc4cffc48acf69f5c19
2019-06-13 16:17:03 +08:00
Kevin Chang
102d43b5c1 Merge "Add tutorial dialog for gesture navigation" into qt-dev 2019-06-10 00:57:14 +00:00
Kevin Chang
219349cb2b Merge "Add tutorial dialog for gesture navigation" into qt-dev-plus-aosp am: 52482edb2b
am: abee9d52e4

Change-Id: I91e8fb09ae80638f678408a7a19da58830473667
2019-06-06 02:22:26 -07:00
Kevin Chang
abee9d52e4 Merge "Add tutorial dialog for gesture navigation" into qt-dev-plus-aosp
am: 52482edb2b

Change-Id: Ifecf327f3cd13efe708e99c697afd44b13e24f74
2019-06-06 02:17:06 -07:00
Kevin Chang
52482edb2b Merge "Add tutorial dialog for gesture navigation" into qt-dev-plus-aosp 2019-06-06 09:04:42 +00:00
Kevin Chang
9ff00646d0 Add tutorial dialog for gesture navigation
Add new tutorial dialog for gesture navigation in order to teach
users how to use the gesture

Fixes: 133650388
Test: Manual
Change-Id: I7cc6a950af49044b27cf7ca41e3bcf67ef40b5fd
Merged-In: I7cc6a950af49044b27cf7ca41e3bcf67ef40b5fd
2019-06-06 06:20:49 +00:00
Kevin Chang
0e1f39fad8 Add tutorial dialog for gesture navigation
Add new tutorial dialog for gesture navigation in order to teach
users how to use the gesture

Fixes: 133650388
Test: Manual
Change-Id: I7cc6a950af49044b27cf7ca41e3bcf67ef40b5fd
2019-06-06 13:56:54 +08:00
Julia Reynolds
923263f5f7 Merge "Read the subtext of notif importance field on selection" into qt-dev am: 3f95fda1cf am: 9994b66974
am: 918fbfb364

Change-Id: Ibf4b20764cd8aa1d34600fc215836db15a78bd7a
2019-06-05 14:59:20 -07:00
Julia Reynolds
918fbfb364 Merge "Read the subtext of notif importance field on selection" into qt-dev am: 3f95fda1cf
am: 9994b66974

Change-Id: Ibbc9edc50bd13fc8c4e8a8f3cd819c3beea99881
2019-06-05 14:55:20 -07:00
Julia Reynolds
569732474e Read the subtext of notif importance field on selection
When using a11y services

Test: manual with Talkback
Bug: 133649570
Change-Id: Ic68a948ab5d55e68994e6b14456d25d438637886
2019-06-05 18:31:19 +00:00
Mehdi Alizadeh
793cb2c9c7 Merge "Disables the Gesture nav option if 3P launcher is default" into qt-dev am: cad67cdc0a am: c4be5512a7
am: ecf3028123

Change-Id: I90f792dd3f24533411deafd15988b70278a7fd27
2019-05-31 14:43:50 -07:00
Mehdi Alizadeh
c4be5512a7 Merge "Disables the Gesture nav option if 3P launcher is default" into qt-dev
am: cad67cdc0a

Change-Id: I9458cdbcc819e1d203266a8ff5b3b4ade1f3aeef
2019-05-31 14:26:04 -07:00
Mehdi Alizadeh
cad67cdc0a Merge "Disables the Gesture nav option if 3P launcher is default" into qt-dev 2019-05-31 21:08:08 +00:00
Mehdi Alizadeh
ffea2ae488 Disables the Gesture nav option if 3P launcher is default
Disables the Gesture navigation radio button if 3P launcher is set as
default for current user. Also shows an info icon on the right side that
opens a dialog explaining why it is disables.

Bug: 129532605
Test: Manual test with 3P launcher
Test: make RunSettingsRoboTests ROBOTEST_FILTER=RadioButtonPreferenceWithExtraWidgetTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationGestureSettingsTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SystemNavigationPreferenceControllerTest

Change-Id: I90000c74246699fa9391ac042c87d7f0ece03637
2019-05-31 12:26:28 -07:00
Julia Reynolds
42c33d0798 Merge "Change notification alert icon" into qt-dev am: 2821456995 am: f5afaffc2c
am: 71420a2209

Change-Id: Ifffa09d63f2ff782b199eb4f9ddd065d079b16e6
2019-05-30 14:33:38 -07:00
Julia Reynolds
71420a2209 Merge "Change notification alert icon" into qt-dev am: 2821456995
am: f5afaffc2c

Change-Id: I340a6394fece9fe398e92c219b3a186db341001c
2019-05-30 14:22:17 -07:00
Julia Reynolds
72182e1ffc Merge "Change notification alert icon" into qt-dev
am: 2821456995

Change-Id: I7b38e88e702ce91162f29592c69dcc4f8612181d
2019-05-30 14:11:52 -07:00
Christine Franks
2adf1f213d Merge "Add SIM color picker" into qt-dev am: b747c5c270 am: c1c4a0858d
am: 3ccc01ca18

Change-Id: I0e2c4d96df27e71d11b8a092f2cf86733d29727b
2019-05-30 14:09:41 -07:00
TreeHugger Robot
2821456995 Merge "Change notification alert icon" into qt-dev 2019-05-30 20:51:49 +00:00
Christine Franks
c1c4a0858d Merge "Add SIM color picker" into qt-dev
am: b747c5c270

Change-Id: Ia234bd596017cf98dd5a76202c6fe7af486562f4
2019-05-30 13:20:46 -07:00
Christine Franks
b747c5c270 Merge "Add SIM color picker" into qt-dev 2019-05-30 20:01:48 +00:00
Julia Reynolds
346c7f7081 Merge "Fix a11y readout of notification importance buttons" into qt-dev am: 1b25f986cb am: 9e865f88be
am: 9ae4df15fd

Change-Id: Ia4106b40535a25e3315f0e0466dd54b073931bd8
2019-05-30 12:31:03 -07:00
Julia Reynolds
9ae4df15fd Merge "Fix a11y readout of notification importance buttons" into qt-dev am: 1b25f986cb
am: 9e865f88be

Change-Id: Icd84f4b664f5aaa58cca23c2c89b9a4c3412981d
2019-05-30 12:16:41 -07:00
Julia Reynolds
0a4dce78c1 Merge "Fix a11y readout of notification importance buttons" into qt-dev
am: 1b25f986cb

Change-Id: Ia42d67cab34dfb380d5be909f22f717f8ecfd5b6
2019-05-30 12:09:22 -07:00
Julia Reynolds
eeefeebeff Change notification alert icon
Test: manual
Bug: 134054170
Change-Id: Ibd66a55a30ac9fbeb7a32638fe236067c6175bc4
2019-05-30 14:47:07 -04:00