Commit Graph

32269 Commits

Author SHA1 Message Date
TreeHugger Robot
abeb1a09fa Merge "Remove divider after last items" into rvc-dev 2020-05-13 20:01:52 +00:00
Nate Myren
8c7c22d4b9 Add null check for intent in AppPermissionPreferenceController
Sometimes, the App Info page can be reached without an intent in tests.
Add a null check to catch this

Bug: 154650244
Test: atest AppPermissionPreferenceControllerTest#handlePreferenceTreeClick_shouldStartManagePermissionsActivity

Change-Id: I514acda6b78d9e76b230aa945067bd7d6d9feff9
2020-05-13 13:00:53 -07:00
Julia Reynolds
9a6e7329be Remove divider after last items
Fixes: 155890866
Test: manual
Change-Id: Ie0e3f7ad8c1868bda7623718dd60926c300fa353
2020-05-13 14:03:40 -04:00
Bonian Chen
610a55556a [Settings] Avoid from redraw UI when first time onResume am: 17ad56b3fc
Change-Id: I975397eb10ad3b4b0435dcfb71288425a15717e8
2020-05-13 13:53:21 +00:00
Bonian Chen
17ad56b3fc [Settings] Avoid from redraw UI when first time onResume
Registration of subscription change lead to redraw.
However, entire UI is newly created where redraw is not required
when fragment first time created.

Therefore, remove first callback from SubscriptionManager to reduce some
time.

Bug: 141833767
Test: manual
Change-Id: I54a58dd8271bb2cd8cd531cc02ff7d64b3e4328c
2020-05-13 18:47:09 +08:00
TreeHugger Robot
09c4926e8a Merge "Update icon tint color when the user toggles Dark theme" into rvc-dev am: 8224a5ad3d
Change-Id: I50fc0c1cd70ad15388baa0f110955a2d9bee9573
2020-05-13 09:59:23 +00:00
TreeHugger Robot
8224a5ad3d Merge "Update icon tint color when the user toggles Dark theme" into rvc-dev 2020-05-13 09:37:37 +00:00
PETER LIANG
380e0dc235 Merge "Add the settings content observer for shortcut preference." into rvc-dev am: 31e6002ee8
Change-Id: I60a347a96d6192bfae9c0dbad8361c162def7b5e
2020-05-13 09:02:38 +00:00
PETER LIANG
31e6002ee8 Merge "Add the settings content observer for shortcut preference." into rvc-dev 2020-05-13 09:00:09 +00:00
TreeHugger Robot
1bf90b2243 Merge "Show the app pinning description after user enables it" into rvc-dev am: 0cc66ea23c
Change-Id: I2b877b72480498f79deb8cc97262eb0236c72747
2020-05-13 08:54:56 +00:00
TreeHugger Robot
0cc66ea23c Merge "Show the app pinning description after user enables it" into rvc-dev 2020-05-13 08:41:18 +00:00
Tsung-Mao Fang
232cfc4e76 Show the app pinning description after user enables it
By design, we still need to show app pinning description
after user enables feature.

Test: Rebuilt rom, and see description.
Fix: 151332926
Change-Id: Ic9a2d7baec865358471ac0210648642ebd9fd65a
2020-05-13 14:43:23 +08:00
Peter_Liang
b3d5df4989 Add the settings content observer for shortcut preference.
Root cause:
Didn't update the UI when settings value chagned.

Next:
Add the settings content observer.

Bug: 155837154
Test: manual test & Robo test & atest
Change-Id: I7be952a3a8824d00d3903d4a69beb8f992d638a1
2020-05-13 14:43:20 +08:00
TreeHugger Robot
991229fe6b Merge "Allows to launch only authenticator owned activities" into rvc-dev am: dfb3f561ea
Change-Id: I53a707f8ca9a2c8f0b416254ae205c38d25e07e4
2020-05-13 05:29:20 +00:00
TreeHugger Robot
dfb3f561ea Merge "Allows to launch only authenticator owned activities" into rvc-dev 2020-05-13 05:26:25 +00:00
TreeHugger Robot
ada7e82b72 Merge "Revert "Unable to select twilight scheduling after enabling location"" into rvc-dev am: 6d2ad68e1a
Change-Id: I4462a5c69184c5623527c095b98bf7845989bcdb
2020-05-13 05:20:43 +00:00
TreeHugger Robot
b726331702 Merge "Revert "Add the settings content observer for shortcut preference."" into rvc-dev am: 9ae5b47aee
Change-Id: I3804e1de067a494a22623ad2f56dbffc985d5986
2020-05-13 05:20:28 +00:00
TreeHugger Robot
6d2ad68e1a Merge "Revert "Unable to select twilight scheduling after enabling location"" into rvc-dev 2020-05-13 05:16:51 +00:00
TreeHugger Robot
9ae5b47aee Merge "Revert "Add the settings content observer for shortcut preference."" into rvc-dev 2020-05-13 05:05:08 +00:00
TreeHugger Robot
3a92145c27 Merge "[Wi-Fi] Quit worker thread of WifiPickerTracker" into rvc-dev am: 02b7b16c93
Change-Id: I0e802903266825f2286466421a6880fc7732e974
2020-05-13 04:36:32 +00:00
TreeHugger Robot
02b7b16c93 Merge "[Wi-Fi] Quit worker thread of WifiPickerTracker" into rvc-dev 2020-05-13 04:18:18 +00:00
Edgar Wang
782438347b Revert "Unable to select twilight scheduling after enabling location"
This reverts commit 9073b2f968.
Bug: 153115261
Reason for revert: this CL make Settings robolectric test fail at com.android.settings.display.darkmode.DarkModeScheduleSelectorControllerTest

Change-Id: I3f1ba35f55f2905b10ca97149268be6074780eda
2020-05-13 03:58:36 +00:00
Edgar Wang
7e70ef64d4 Revert "Add the settings content observer for shortcut preference."
This reverts commit 785af0c15a.

Bug: 155837154

Reason for revert: robolectric test fail at com.android.settings.accessibility.ToggleFeaturePreferenceFragmentTest

Change-Id: If8e5681b044171ad6941307489526cc3834f66b2
2020-05-13 03:45:39 +00:00
Betty Chang
f3740eec9d Merge "Add setPackage for PendingIntent in SliceHelper" into rvc-dev am: 0c821c7be2
Change-Id: I424c94eaa29752aa6bf54dd9a9c3356a0f54b05e
2020-05-13 03:08:40 +00:00
Sunny Shao
d6d8f98844 Allows to launch only authenticator owned activities
- 3rd party developers can define himself-authenticator
  and use the accountPreferences attribute to load the
  predefined preference UI.
- If a developer defines an action intent to launch the
  other activity in xml and it would return true due
  to the true exported attribute and no permission.
- To avoid launching arbitrary activity. Here allows
  to launch only authenticator owned activities.

Bug: 150946634
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.accounts
Test: PoC app
Change-Id: I5ce1a0b3838db7b3fbe48c6ea23d5f093d625cdb
2020-05-13 10:55:49 +08:00
Betty Chang
0c821c7be2 Merge "Add setPackage for PendingIntent in SliceHelper" into rvc-dev 2020-05-13 02:53:40 +00:00
TreeHugger Robot
42db36efbe Merge "Revert "Create QS media player setting"" into rvc-dev am: cd3cde6169
Change-Id: I20725949d542dd02b269ac84c12b691fa6e3679d
2020-05-13 02:37:47 +00:00
Arc Wang
a52782bc06 [Wi-Fi] Quit worker thread of WifiPickerTracker
Should quit worker thread when a fragment is about to
be destroyed.

Bug: 152454787
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AddAppNetworksFragmentTest
Change-Id: I809511b7f7c092cf9787e8f6bb7c7513c27c98c8
2020-05-13 10:34:51 +08:00
TreeHugger Robot
cd3cde6169 Merge "Revert "Create QS media player setting"" into rvc-dev 2020-05-13 02:20:05 +00:00
Jason Hsu
bea0e029a4 Merge "Fix the issue that title of Color inversion page is wrong" into rvc-dev am: 394f925729
Change-Id: Ie3757bf068ea020339518dcb8fa60b003e34db09
2020-05-12 18:24:51 +00:00
Jason Hsu
394f925729 Merge "Fix the issue that title of Color inversion page is wrong" into rvc-dev 2020-05-12 18:04:49 +00:00
Lucas Dupin
d207f1baee Revert "Create QS media player setting"
This reverts commit 665c36eae2.

Reason for revert: New media experience landed
Fixes: 156369996

Change-Id: Icb997a3508cec1e15f523b8ca5b923deacee66b4
2020-05-12 16:51:06 +00:00
Jay Aliomer
39065aece9 Merge "Unable to select twilight scheduling after enabling location" into rvc-dev am: a5e7d180f1
Change-Id: I84b08fc46ba0e41ce076e49b46f38a7d64121584
2020-05-12 15:58:06 +00:00
Jay Aliomer
a5e7d180f1 Merge "Unable to select twilight scheduling after enabling location" into rvc-dev 2020-05-12 15:42:49 +00:00
jasonwshsu
112cd4d6d1 Fix the issue that title of Color inversion page is wrong
* Title need to be set from getPreferenceScreenResId(), recover the xml file.

Bug: 156201719
Test: manual test
Change-Id: Ib8b79c320c6a48b1dd679738ddc7022ccaeaed86
2020-05-12 23:35:11 +08:00
Kholoud Mohamed
d3bd08653d Merge "String changes in the cross profile settings page" into rvc-dev am: 311ff0c1ea
Change-Id: Ic44752f686a0878ab05e8ccf7a2e4190fa153b26
2020-05-12 15:29:49 +00:00
Kholoud Mohamed
311ff0c1ea Merge "String changes in the cross profile settings page" into rvc-dev 2020-05-12 15:13:32 +00:00
Stanley Wang
4c5c80d421 Fix the search result "Free up space" doesn't work.
Can't find the target component if add the class name
and package name to the intent. So remove them.

Fixes: 152682394
Test: manual test the search result
Change-Id: I3b69486f6338b458c795860f7b3de9c119cb09de
2020-05-12 19:45:53 +08:00
PETER LIANG
99f1a37582 Merge "Add the settings content observer for shortcut preference." into rvc-dev am: a85f5dc80b
Change-Id: Ib3e57d67fd4870356ef672ee0d60489842b3e673
2020-05-12 11:42:56 +00:00
PETER LIANG
a85f5dc80b Merge "Add the settings content observer for shortcut preference." into rvc-dev 2020-05-12 11:29:11 +00:00
Jason Chiu
bee14256df Add metrics log for special cases
Support Wifi toggle, Smart storage toggle, Manage storage, Face unlock,
Pixel Imprint

Bug: 137559984
Test: robotest
Change-Id: I3e2e666a8bee1e54d6bd13349b5bedb48fbc42df
2020-05-12 18:06:22 +08:00
changbetty
0383d76a5e Add setPackage for PendingIntent in SliceHelper
Bug: 151645867
Bug: 151646375
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiCallingSliceHelperTest
      make RunSettingsRoboTests ROBOTEST_FILTER=Enhanced4gLteSliceHelperTest
Change-Id: I33c1333f9b5472cdb962b272f6be52a2d2959376
Merged-In: I33c1333f9b5472cdb962b272f6be52a2d2959376
2020-05-12 17:56:48 +08:00
Peter_Liang
785af0c15a Add the settings content observer for shortcut preference.
Root cause:
Didn't update the UI when settings value chagned.

Next:
Add the settings content observer.

Bug: 155837154
Test: manual test
Change-Id: Icee0bb50f88987ea6c8a0be59bd936628a32ca1e
2020-05-12 14:15:54 +08:00
Jason Chiu
8ac1e4d49d Update icon tint color when the user toggles Dark theme
- Reload theme in slice provider when Dark theme mode changes for slices
- Reload theme in onCreate of Panel activity for its non-slice header
- Remove applyTheme from individual slices

Test: robotest
Fixes: 153700819
Change-Id: I40a7d2817c4b9100d7b2f2962a69c8a9ce6f7906
2020-05-12 10:58:54 +08:00
Tim Peng
550fd3ef9a When only one device is selected in dynamic group, the device should be disabled
-Check if device id is in selected group rather than comparing client package name
-Add test cases

Bug: 154916764
Test: make -j50 RunSettingsRoboTests
Change-Id: I7364a9e3d807bbfc6b26b8212ab2da67ea329582
2020-05-12 01:44:56 +00:00
Nate Myren
fbe64a68da Merge "Add Auto Revoke log to the App Info page" into rvc-dev am: 0c6037af5f
Change-Id: I547a008b73764af371f27710c1f94348fb3d0644
2020-05-11 22:55:34 +00:00
Nate Myren
0c6037af5f Merge "Add Auto Revoke log to the App Info page" into rvc-dev 2020-05-11 22:37:04 +00:00
Kholoud Mohamed
bcbd9158d6 String changes in the cross profile settings page
Fixes: 155771527
Test: visually tested the string changes.
Change-Id: Idcde93e2035bb8d3d82213befb652aa29aa12efe
2020-05-11 18:38:05 +01:00
Jay Aliomer
9073b2f968 Unable to select twilight scheduling after enabling location
Test: run settings tests
Change-Id: I74945dd69f0da9733ee0a5e27ab63852df9544e9
Bug: 153115261
2020-05-11 16:31:42 +00:00
PETER LIANG
7057155390 Merge "Fix that the inconsistent accessibility content pages under Setup Wizard." into rvc-dev am: 7a31f2da60
Change-Id: I6ea0512098a8c55b21d79d5089a8505afbac2d25
2020-05-11 07:40:51 +00:00