Commit Graph

44261 Commits

Author SHA1 Message Date
Victor Chang
93e464564f Fix crash in time zone picker due to race condition on view updates
am: 201c629fcc

Change-Id: Icd55bf16959da9e67b75ec93c53ef21fdcb9014f
2018-03-27 09:42:04 +00:00
Victor Chang
201c629fcc Fix crash in time zone picker due to race condition on view updates
- Can't reproduce the race condition with manual test, probably the view
  updates are fast enough that only monkey test can reproduce the issue.
- Reproduced a similar stacktrace and IndexOutOfBoundsException with
  Robolectric test by assuming that the race condition happens after
  text filtering and view updates. Try to fix the bug with this assumption
- The fix is to bind the data (data position in adapter) with ViewHolder.

Bug: 75322108
Test: m RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.datetime.timezone
Change-Id: Ie5d932bce30590b8067e042c3380911c9608872f
2018-03-27 09:31:54 +00:00
yuemingw
5dc9faf1a0 Merge "Auto time should show dynamic subtext when restricted." into pi-dev am: d7ea524e81
am: 8c3bccda2c

Change-Id: Ifc207a8adb1ab1e976d540366c3d1ef29588ebfa
2018-03-27 08:44:30 +00:00
yuemingw
8c3bccda2c Merge "Auto time should show dynamic subtext when restricted." into pi-dev
am: d7ea524e81

Change-Id: I161487aff5d83975c6c0e647e8405fab89376f9e
2018-03-27 08:37:28 +00:00
TreeHugger Robot
d7ea524e81 Merge "Auto time should show dynamic subtext when restricted." into pi-dev 2018-03-27 08:30:20 +00:00
Wenhung Teng
17c93edb3c Merge "Fix issue "open battery settings, switch locale, apps are still in old locale" into pi-dev" into pi-dev am: 032b0454f8
am: 00bddd986e

Change-Id: Ie15b207e3d75ee862e58be72dc240da9f9d859df
2018-03-27 06:33:29 +00:00
Wenhung Teng
00bddd986e Merge "Fix issue "open battery settings, switch locale, apps are still in old locale" into pi-dev" into pi-dev
am: 032b0454f8

Change-Id: I4676626f12b340752bd867c73d45eda5d0124a1c
2018-03-27 06:26:57 +00:00
Wenhung Teng
032b0454f8 Merge "Fix issue "open battery settings, switch locale, apps are still in old locale" into pi-dev" into pi-dev 2018-03-27 06:13:53 +00:00
Adam Newman
61484db01d Merge "Observe NetworkCallback instead of polling" into pi-dev am: d2fb46eac4
am: 211535a10d

Change-Id: I440c17b8cf5670e40706f07832737927930de986
2018-03-27 06:01:17 +00:00
Adam Newman
211535a10d Merge "Observe NetworkCallback instead of polling" into pi-dev
am: d2fb46eac4

Change-Id: Id06fb42bf1144fa3f04d092718427d484557732f
2018-03-27 05:48:04 +00:00
Adam Newman
d2fb46eac4 Merge "Observe NetworkCallback instead of polling" into pi-dev 2018-03-27 05:23:21 +00:00
Fan Zhang
ec67075abc Merge "Use custom drawable for Battery saver condition icon." into pi-dev am: 74ac3b1f3a
am: b4c4d47e2e

Change-Id: Ib7d4ea27dae28192ce4e1a53324b9062a2e6948b
2018-03-27 05:20:19 +00:00
Jyun LuoLai
283e24a028 Merge "Update Bluetooth related string" into pi-dev am: 198a6495ad
am: 1c502210e3

Change-Id: Id6cdd7982d73835baec447076a49e184979e099d
2018-03-27 05:03:15 +00:00
Kevin Chyn
d017a1ff2c Merge "Don't show FP error canceled message" into pi-dev am: 2c6ea60711
am: 674902b537

Change-Id: I9fa98d943cafa514b4205a39feeeb07fd9dcbfcb
2018-03-27 04:47:36 +00:00
Fan Zhang
4b2c171288 Add string linter preupload check
Bug: 76097999
Test: repo upload
Change-Id: Ieb31c931d73a4325f605963b374ca7a2d568e08c
2018-03-26 21:38:34 -07:00
Fan Zhang
b4c4d47e2e Merge "Use custom drawable for Battery saver condition icon." into pi-dev
am: 74ac3b1f3a

Change-Id: I74be965dce1442a532c13590b105e43ec078c87c
2018-03-27 04:34:46 +00:00
Jyun LuoLai
1c502210e3 Merge "Update Bluetooth related string" into pi-dev
am: 198a6495ad

Change-Id: Icb0cdc09c6c0ccb1d359ff4b5e0887cab9f635d9
2018-03-27 04:28:56 +00:00
Fan Zhang
74ac3b1f3a Merge "Use custom drawable for Battery saver condition icon." into pi-dev 2018-03-27 04:25:15 +00:00
Kevin Chyn
674902b537 Merge "Don't show FP error canceled message" into pi-dev
am: 2c6ea60711

Change-Id: I3431a6be839f354ee0dc0e982162c894323271c2
2018-03-27 04:03:30 +00:00
TreeHugger Robot
198a6495ad Merge "Update Bluetooth related string" into pi-dev 2018-03-27 03:53:27 +00:00
TreeHugger Robot
2c6ea60711 Merge "Don't show FP error canceled message" into pi-dev 2018-03-27 03:28:27 +00:00
Jyun LuoLai
b71cb79a07 Update Bluetooth related string
Bug: 73960246
Test: Manual test
Change-Id: Ied2a45648e52a78abe3dc84647694dd68874ba5f
2018-03-27 03:09:32 +00:00
Felka Chang
39cfed5707 Merge "To update from "Data saver" to "Data Saver"" into pi-dev am: 135a7e9753
am: 5021c0c22d

Change-Id: Ie32dec259c8053d7745e052b81d69f686fe28606
2018-03-27 02:29:49 +00:00
Felka Chang
5021c0c22d Merge "To update from "Data saver" to "Data Saver"" into pi-dev
am: 135a7e9753

Change-Id: I95871ed90bfdc71a77569cb2f9fac9682d47d6ca
2018-03-27 02:13:31 +00:00
Felka Chang
135a7e9753 Merge "To update from "Data saver" to "Data Saver"" into pi-dev 2018-03-27 02:08:21 +00:00
Fan Zhang
f17216d29d Merge "Add more string for device muted condition" into pi-dev am: 2bc477959c
am: 3ca50d70ac

Change-Id: I884441946a5b64ea66e7cb9e0b8bf9463b80916a
2018-03-27 01:10:50 +00:00
Fan Zhang
3ca50d70ac Merge "Add more string for device muted condition" into pi-dev
am: 2bc477959c

Change-Id: I0d58d639444733484818a557f2c35e4955c75beb
2018-03-27 00:52:06 +00:00
Fan Zhang
0c8f8a8b46 Use custom drawable for Battery saver condition icon.
- Updated condition interface to use Drawable instead of Icon for icons.
- Converted all conditions to return drawable instead of Icon.
- Created a BatterySaverDrawable to draw a static battery saver icon.

Change-Id: Ie964f3439009c7658603a8ff352a05e964a0a795
Fixes: 76168403
Test: robotests
2018-03-26 17:50:27 -07:00
Lei Yu
68ffee1a7d Remove the old battery page
This CL removes PowerUsageSummaryLegacy and PowerUsageAdvancedLegacy
and their related layouts and strigns.

Also remove the isBatteryV2Enabled method in feature provider.

Change-Id: I1ec30f713d733ed24335a3e698fb515751232948
Fixes: 76027338
Test: robo test still pass
2018-03-26 17:40:10 -07:00
Fan Zhang
2bc477959c Merge "Add more string for device muted condition" into pi-dev 2018-03-26 23:55:07 +00:00
Fan Zhang
5088523c5d Add more string for device muted condition
Bug: 76022431
Test: build
Change-Id: Ib3801b2ecd18d094e4431aeb89d711a6c9e62689
2018-03-26 15:52:22 -07:00
Fan Zhang
607d63468a Merge "Fix text overlap issue when flinging in ManageApplication" into pi-dev am: 9f5849aaf4
am: a89fb2e6dd

Change-Id: I58c96bdace9c5a5cd2ff8d8e61c53e4f5f962495
2018-03-26 22:17:03 +00:00
Fan Zhang
a89fb2e6dd Merge "Fix text overlap issue when flinging in ManageApplication" into pi-dev
am: 9f5849aaf4

Change-Id: Ief196f8d521b5727d2535086ab18a844349ddf1c
2018-03-26 22:04:24 +00:00
Lei Yu
5dea982625 Merge "Use FIELD_ANOMALY_TYPE for anomalyType" into pi-dev am: 6f22cec26d
am: 13a40e76eb

Change-Id: Id996b022ac0c98226698469d5afc4b6aab4ba9cb
2018-03-26 22:03:30 +00:00
Lei Yu
13a40e76eb Merge "Use FIELD_ANOMALY_TYPE for anomalyType" into pi-dev
am: 6f22cec26d

Change-Id: I1e497fcc05faa582a1a5d9a9f958c1efad829a32
2018-03-26 21:56:16 +00:00
TreeHugger Robot
9f5849aaf4 Merge "Fix text overlap issue when flinging in ManageApplication" into pi-dev 2018-03-26 21:50:14 +00:00
Lei Yu
6f22cec26d Merge "Use FIELD_ANOMALY_TYPE for anomalyType" into pi-dev 2018-03-26 21:41:11 +00:00
yuemingw
3434e72f31 Auto time should show dynamic subtext when restricted.
Auto time preference should show dynamic subtext corresponding to
the current status of auto time when it's restricted, instead of
hard code "enabled by admin", as it could either be enabled or disabled
when disallow_config_date_time is set.

Bug: 73811933
Test: manually by TestDPC
Change-Id: Ia7181e8a67ccfe72117f95133e9081375c121fe3
2018-03-26 20:37:56 +00:00
Kevin Chyn
7319214db9 Don't show FP error canceled message
Test: manual test of SUW, error message doesn't show up when
      confirm credentials is complete

Change-Id: Ie0750629dcd5bb5d84df08c75e9c83384c299073
Fixes: 76400618
2018-03-26 12:38:21 -07:00
yuemingw
03b617bdea Merge "Remove account should show policy transparency dialog when DISALLOW_MODIFY_ACCOUNTS is set." into pi-dev am: 21926abed2
am: a3db549834

Change-Id: If7c967d8bf7eddf3a50bd3d629e3e79c85fac5e6
2018-03-26 18:51:49 +00:00
yuemingw
a3db549834 Merge "Remove account should show policy transparency dialog when DISALLOW_MODIFY_ACCOUNTS is set." into pi-dev
am: 21926abed2

Change-Id: Ie4130e88a3355bb91a63578bd889147da3dba726
2018-03-26 18:46:09 +00:00
Amin Shaikh
c685d0fe9b Show wifi status label in preference summary.
Bug: 74075761
Test: m RunSettingsRoboTests && manual
Change-Id: I286fac5d9390634facc0f04b845ef668c55d1331
2018-03-26 14:37:09 -04:00
TreeHugger Robot
21926abed2 Merge "Remove account should show policy transparency dialog when DISALLOW_MODIFY_ACCOUNTS is set." into pi-dev 2018-03-26 18:34:31 +00:00
Fan Zhang
de052eb2b9 Fix text overlap issue when flinging in ManageApplication
The issue is we have a background handler to find app size and set to
summary asynchronously. When flinging quickly, the view being request to
update by the background handler could be scrolled off screen already.
This change forces onPackageSizeChanged update to only happen when it's
not scrolling.

Change-Id: Ia7ccab776c3c789c8d4c0b55104b48e257b9cebf
Fixes: 76176014
Test: manually fling
2018-03-26 11:34:16 -07:00
Lei Yu
1785863b48 Use FIELD_ANOMALY_TYPE for anomalyType
Change-Id: I36d5d806f45df4153cdba3e398fa72ab89e5e082
Fixes: 76424026
Test: RunSettingsRoboTests
2018-03-26 11:31:22 -07:00
Rubin Xu
c48abe7795 Merge "Block simple numeric passwords in ChooseLockPassword" into pi-dev am: c3938f6f6e
am: d80739b276

Change-Id: I73ae8b22e3b1baec1ecca97a68210113fe08d758
2018-03-26 18:24:20 +00:00
Rubin Xu
d80739b276 Merge "Block simple numeric passwords in ChooseLockPassword" into pi-dev
am: c3938f6f6e

Change-Id: I8599fbcfc070842d7f4755cbcda5e1dcf80f91a5
2018-03-26 18:19:05 +00:00
TreeHugger Robot
c3938f6f6e Merge "Block simple numeric passwords in ChooseLockPassword" into pi-dev 2018-03-26 18:06:04 +00:00
Julia Reynolds
1de83b7c65 Update recently sent preferences am: 5c83f14d7e
am: 6a942f930b

Change-Id: I4088f66e3c798a30043ccb6e48685f3fa5f7700d
2018-03-26 17:50:47 +00:00
Julia Reynolds
6a942f930b Update recently sent preferences
am: 5c83f14d7e

Change-Id: I71d6da7beba2beecad671e296c76a127815fe241
2018-03-26 17:41:20 +00:00