Commit Graph

131410 Commits

Author SHA1 Message Date
Joshua McCloskey
9642d1e8cb Moving FingerprintSettings to Kotlin
This change is the first of many, it will

1. Change java -> kotlin
2. Use the MVVM architecture
3. Be feature flagged

This change in particular is focused on transitions to and from various activities.

Enable feature via
adb shell setprop sys.fflag.override.settings_biometrics2_fingerprint true

Bug: 280862076
Test: atest FingerprintSettingsViewModelTest
Change-Id: I8eb5c30e6f2e92c256ae7c257a9d560439ba418f
2023-06-28 18:09:35 +00:00
Ante
fdfe10f1a7 Fix Inline UWB toggle setting
In settings when searching for "uwb" the inline toggle doesn't work,
this change fixes the issue. This change won't fix the issue of
correctly displaying the UWB state in case when the UWB adapter state
changed after the inline toggle was already loaded, that issue is
tracked in b/287644073.

Bug: 280643766
Test: Manually verified
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:34ea9149906ac41396afbf3d1e153f4ed60dc1ed)
Change-Id: Iddb89220921a9af0e1d97bb3d648ca8b0f42fc65
2023-06-28 17:48:55 +00:00
Grace Cheng
25b489e212 Merge "Fix NPE in updateAddPreference" into udc-dev 2023-06-28 17:41:13 +00:00
Matías Hernández
143d105dc9 Merge "Settings: don't try to allow NLSes with too-long component names" into udc-dev am: 4d34eb2c7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23726247

Change-Id: I4ab7053bffc4268cf1d0d2be5e7dbec5ba5f65d7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 17:15:07 +00:00
Matías Hernández
aaddfd88e9 Merge "Settings: don't try to allow NLSes with too-long component names" into udc-dev am: 4d34eb2c7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23726247

Change-Id: If35fbb5c16a642b56de29012ce43ecd7f068d5b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 17:14:55 +00:00
Matías Hernández
57739acf63 Merge "Settings: don't try to allow NLSes with too-long component names" into udc-dev am: 4d34eb2c7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23726247

Change-Id: I4d187c9a398bf713519c8cc2c335ab1d2c2bd645
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 17:14:40 +00:00
Matías Hernández
0d21526217 Merge "Settings: don't try to allow NLSes with too-long component names" into udc-dev am: 4d34eb2c7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23726247

Change-Id: I1e1dbbdf2b1834da763835c1bbcd263cdb27eb09
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 17:10:34 +00:00
Matías Hernández
4d34eb2c7a Merge "Settings: don't try to allow NLSes with too-long component names" into udc-dev 2023-06-28 16:42:13 +00:00
Treehugger Robot
396653e8f3 Merge "[BiometricsV2] Fix intro overlap enrolling page" 2023-06-28 13:43:32 +00:00
Chaohui Wang
b17ef6f91e Fix cursor is empty in ApnEditor
If cursor.moveToFirst() returns false, the cursor is empty which cause
crash.

Check whether the curse is empty to fix.

Fix: 288716180
Test: manual - on ApnEditor page
Test: m RunSettingsRoboTests
Change-Id: If850cd3feca3d3d520a653c2490d1049a8a87fdc
2023-06-28 19:31:46 +08:00
SongFerng Wang
c123b2e5a8 Revert "Update the wording for LE Audio"
This reverts commit f4c5c8ef5e.

Reason for revert: at stage3, removing this summary.
Bug: 289184862
Change-Id: I6b18a7e2dee9d8fcfb331e53d7a57cc43574da54
2023-06-28 10:06:59 +00:00
Chaohui Wang
63eddc12dd Refactor FeatureFactory
Not use reflection, sets the FeatureFactoryImpl in SettingsApplication
instead.

Bug: 286764889
Test: m Settings
Test: m SettingsSpaUnitTests
Test: m RunSettingsRoboTests
Change-Id: I881bf1009a94222fc89578d14a6792a6e1507be2
2023-06-28 09:09:39 +00:00
Allen Su
e93f6cd9e6 [Panlingual]Log metrics for App's locale from the suggested
Bug: 258128535
Test: atest AppLocalePickerActivityTest
Change-Id: I007c0e76d8b88f08518ba2696d42bd1db194f5b7
2023-06-28 08:24:10 +00:00
Shawn Lin
a2e032bb8e Fix lock pattern is truncated during SUW in folded state
Remove the bottom margin of the header view.

Bug: 285290323
Test: 1. Go through SUW
      2. Select lock pattern
      3. Check if UI truncated
Test: m RunSettingsRoboTests ROBOTEST_FILTER=
      com.android.settings.password.SetupChooseLockPatternTest
Change-Id: I48ac3d897e6b876bd7a1c325cc4a5e797e140da2
2023-06-28 06:52:40 +00:00
Milton Wu
570b23e0a0 [BiometricsV2] Fix intro overlap enrolling page
Fix fragment overlapped if user rotates device on findSensor page, then
enter enrolling page and back again.

It is because the flag isFirstFragmentAdded is not saved and restored
after activity recreated

Bug: 288212767
Test: atest FingerprintEnrollmentActivityTest
Test: atest FingerprintEnrollmentViewModelTest
Test: atest biometrics-enrollment-test
Test: Manually test this scenario
Change-Id: I5b582582d97caac2488b787f551c50abec9f810c
2023-06-28 13:28:44 +08:00
Yanting Yang
a09fd45249 Merge "Support the about device warning message for tablets" 2023-06-28 03:57:08 +00:00
Yanting Yang
0818b82ecf Support the about device warning message for tablets
Move the related strings to res-product folder and add the string for
tablet.

Bug: 282233849
Test: visual
Change-Id: Ib93fd1a3e15600bd2278297645dadd176d99a083
2023-06-28 02:28:34 +00:00
Treehugger Robot
4dd2e56ddf Merge "[Panlingual] Add metric in Languages" into udc-qpr-dev am: 6b01e66545 am: fac986e071
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23783056

Change-Id: I31ce5d4e828d51c0d73711e3615ea1515edc30d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 18:55:55 +00:00
Treehugger Robot
fac986e071 Merge "[Panlingual] Add metric in Languages" into udc-qpr-dev am: 6b01e66545
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23783056

Change-Id: I15eb02f35ba2bad14edd6ef00374216aa8b5b4d3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 18:07:37 +00:00
Treehugger Robot
6b01e66545 Merge "[Panlingual] Add metric in Languages" into udc-qpr-dev 2023-06-27 17:35:26 +00:00
Kholoud Mohamed
0f61efb2e9 Merge "Migrate the setUsbDataSignalingEnabled api to the device policy engine." 2023-06-27 15:57:25 +00:00
Vania Januar
7936f53f8e Merge "Clarify that enabling Notes role requires reboot in preference summary" into udc-qpr-dev am: 0e8bdf2fc0 am: 4c281ab191
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23766165

Change-Id: If809d40cb2f0d5b42892011667f979477167bc52
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 15:45:29 +00:00
Zoey Chen
dab8f53e9b [Panlingual] Add metric in Languages
Bug: 279915462
Test: manual
Change-Id: I12dc7f8a0c594de88790e116c4b4f7ca9dc7253e
2023-06-27 15:40:36 +00:00
Vania Januar
4c281ab191 Merge "Clarify that enabling Notes role requires reboot in preference summary" into udc-qpr-dev am: 0e8bdf2fc0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23766165

Change-Id: I5937c756289f04916f366ec0acba6866b422ac50
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 15:00:48 +00:00
Vania Januar
0e8bdf2fc0 Merge "Clarify that enabling Notes role requires reboot in preference summary" into udc-qpr-dev 2023-06-27 14:14:58 +00:00
Yasin Kilicdere
2d3fed86d1 After deleting guest user, switch back to previous instead of user0.
In Setting, after deleting or exiting the guest user, or failure to
reset the guest user involves switching back to user0, which is not
possible with HSUM (headless system user mode). With this CL we're
now switching back to previous foreground user instead of system user.

Bug: 283106632
Test: manual
Change-Id: Id60063cca75d9fded7dfe0b7d7a4b871d67c4b0c
2023-06-27 12:59:16 +01:00
Treehugger Robot
ac00ec0b8a Merge "Correct Factory Reset activity protect permission" into udc-qpr-dev am: dd3e338823 am: 650a7e9298
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23467970

Change-Id: Ib3f2cc4ec57b7d5e613fdf42bb05bb9a4db63fad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 09:21:19 +00:00
Edgar Wang
abe00cabad Correct used size of Storage Settings. am: e52320e755 am: 88659e80d9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23483884

Change-Id: I34a0e0084c28c0c575ab0081e53e81e8a18f9b8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 09:20:29 +00:00
Treehugger Robot
0c021e70b2 Merge "Remove setAssistOnly() from GestureSettings" 2023-06-27 09:09:23 +00:00
Treehugger Robot
4600c0009f Merge "[BiometricsV2] Refactor EnrollingUdfpsFragment" 2023-06-27 09:03:29 +00:00
Treehugger Robot
650a7e9298 Merge "Correct Factory Reset activity protect permission" into udc-qpr-dev am: dd3e338823
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23467970

Change-Id: If91f7efe15ef7fffda7a87ab6a8c188ab2a404be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 08:58:05 +00:00
Treehugger Robot
dd3e338823 Merge "Correct Factory Reset activity protect permission" into udc-qpr-dev 2023-06-27 08:46:50 +00:00
Edgar Wang
88659e80d9 Correct used size of Storage Settings. am: e52320e755
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23483884

Change-Id: I4816569a8c5bee277121f15397adf7167ec944e0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 08:35:31 +00:00
Chaohui Wang
16cb921c47 Remove setAssistOnly() from GestureSettings
Fix issue that use(AssistGestureSettingsPreferenceController.class)
could be null.

Bug: 287566056
Test: manually - on System > Gestures page
Change-Id: Ifb78a787c34e2fd0e255a6473b8c514f2788f52e
2023-06-27 16:08:25 +08:00
Xin Li
84351db496 [automerger skipped] Merge "Merge Android 13 QPR3" am: 65c31baf7f -s ours am: c61819e807 -s ours am: 164acf327a -s ours am: bcc898dbed -s ours am: e849e3a643 -s ours am: 7a4625239f -s ours
am skip reason: Merged-In I11e6110ba0b640be8b373d9afd45f806c005b05f with SHA-1 45918b72bf is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2635192

Change-Id: Ic7eec29790f3bf176e23b59e55d261e0a0755f18
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 08:07:44 +00:00
Xin Li
bea3b18c7c [automerger skipped] Merge Android 13 QPR3 am: 3e6b213e75 -s ours am: ba9cb49565 -s ours am: e7ba843385 -s ours am: 8244a2aeb4 -s ours am: c9bfd995a9 -s ours am: 96633fda9a -s ours
am skip reason: Merged-In I11e6110ba0b640be8b373d9afd45f806c005b05f with SHA-1 45918b72bf is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2635192

Change-Id: I9e4fcaebf613902e54229e5c8523b40703731f00
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 08:05:59 +00:00
Xin Li
7a4625239f [automerger skipped] Merge "Merge Android 13 QPR3" am: 65c31baf7f -s ours am: c61819e807 -s ours am: 164acf327a -s ours am: bcc898dbed -s ours am: e849e3a643 -s ours
am skip reason: Merged-In I11e6110ba0b640be8b373d9afd45f806c005b05f with SHA-1 45918b72bf is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2635192

Change-Id: I190dc6e845ee9574e822ab9c357ed16282da8aa2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 07:27:29 +00:00
Xin Li
96633fda9a [automerger skipped] Merge Android 13 QPR3 am: 3e6b213e75 -s ours am: ba9cb49565 -s ours am: e7ba843385 -s ours am: 8244a2aeb4 -s ours am: c9bfd995a9 -s ours
am skip reason: Merged-In I11e6110ba0b640be8b373d9afd45f806c005b05f with SHA-1 45918b72bf is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2635192

Change-Id: I2ddc767f85a91245866149964e541c4313f026f3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 07:25:45 +00:00
Milton Wu
5f8620d571 [BiometricsV2] Refactor EnrollingUdfpsFragment
Refactor FingerprintEnrollEnrollingUdfpsFragment to kotlin and add
bindView() method for it

Bug: 286198032
Test: atest FingerprintEnrollmentActivityTest
Test: atest BiometricsMicrobenchmark:biometrics-enrollment-test
Test: Manually test enrollment as Udfps device
Change-Id: Ife1e14ffabc4716acc53b67f641ba9cf159319f2
2023-06-27 07:12:50 +00:00
Chaohui Wang
457993bc91 Merge "Clean up AwareFeatureProvider from Settings" 2023-06-27 06:52:13 +00:00
Edgar Wang
e52320e755 Correct used size of Storage Settings.
Since StorageManager rounded the totalBytes of device storage but
they don't do that rounding for freeBytes.
So in some cases the freeBytes can be greater than totalBytes.

We propose to get totalBytes of device storage directly to calculate
correct privateUsedBytes.

Test: robotest
Bug: 281955532
Change-Id: I4f137c20e7c2f54f4e037d50e81b3176edc1a83a
2023-06-27 06:29:00 +00:00
TreeHugger Robot
9c8456b242 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev am: 85a90ef00b -s ours am: 60f8d67f1d -s ours am: 48fa611907 -s ours am: f703764efd -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23788721

Change-Id: I29fd14a7769cb1b3524f2a34d2ad30effbc255d1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 06:20:10 +00:00
Bill Yi
9de9c82974 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 374a3112e3 -s ours am: 6cb8b3b00c -s ours am: f44874ca83 -s ours am: d6d923c325 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23788721

Change-Id: I9f0d7832c7bf8da5c66976153b77c8786fb4612d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 06:20:08 +00:00
Bill Yi
363b52e9ad [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: e2abc0ab7a -s ours am: 392e63d166 -s ours am: e4a787f1f0 -s ours am: dac919f41a -s ours am: e8993b5116 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23789283

Change-Id: I92f7ab877071cd4cdfb2621fac4dc502a804da74
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 06:18:58 +00:00
Hao Dong
1622d64cc1 Merge "Wait for systemui udfps overlay ready to show settings udfps enroll view. am: be823bc598" into udc-qpr-dev am: 0df79b1ccc am: ae04426d02
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23814463

Change-Id: If6f3e7ce9345128c61926e080fddc97af5cafc73
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 06:17:10 +00:00
Zoey Chen
d6d2a1d06b [Regional Preference] Add metric in Regional Preferences am: ca617d8612 am: c3bd5c2059
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23817103

Change-Id: Ic5bca6d4b2cc1507ca7e3d27d4b4797196dc7be5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 06:16:22 +00:00
Hao Dong
a7c94bfbcb Wait for systemui udfps overlay ready to show settings udfps enroll view. am: be823bc598 am: 93bcf8122c am: ed83c055df
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23814463

Change-Id: I93fe1f323682b2239bcf304a98a4018b16f53b3b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 06:15:45 +00:00
TreeHugger Robot
f703764efd [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev am: 85a90ef00b -s ours am: 60f8d67f1d -s ours am: 48fa611907 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23788721

Change-Id: I7083cb39af52fa39087d7735db2c7b3cd45cede5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 05:58:20 +00:00
Bill Yi
d6d923c325 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 374a3112e3 -s ours am: 6cb8b3b00c -s ours am: f44874ca83 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23788721

Change-Id: I56d347d8ef8a3076de90d6ab4c39c332b7d364a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 05:58:17 +00:00
Bill Yi
e8993b5116 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: e2abc0ab7a -s ours am: 392e63d166 -s ours am: e4a787f1f0 -s ours am: dac919f41a -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/23789283

Change-Id: I2ecd960decf8b10f7505f7625bb24d4ca6745bde
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 05:57:14 +00:00