Commit Graph

102645 Commits

Author SHA1 Message Date
TreeHugger Robot
fa3a25df06 Merge changes from topic "presubmit-am-1d3c2787da5b4d3c85f04dc64ca85922" into tm-mainline-prod
* changes:
  [automerge] Remove subtitle of system default 2p: 9ee9787dd3
  Remove subtitle of system default
2022-04-13 11:17:00 +00:00
tom hsu
ddbff186f3 [Panlingual] Make error message generic.
Bug: 226032712
Test: local
Change-Id: Ibfdc3d5807df4f8e5f1aa3fd37a8f361624c4129
2022-04-13 19:16:03 +08:00
TreeHugger Robot
55aba46fe9 Merge "Unchecked battery saver switch once it's 1st launch" into tm-dev 2022-04-13 11:15:46 +00:00
Xiao Ma
ce9b4447c4 Remove the legacy config_ethernet_iface_regex from Settings.
Bug: 214348333
Test: m Settings
Test: manually verify that device can access the Internet via Ethernet
Test: manually verify that device can share the Internet via Ethernet
      tethering
Test: make RunSettingsRoboTests ROBOTEST_FILTER=TetherEnablerTest
Change-Id: I822ff60ee8be63ff0c518d2972ad8b30dfacadcd
2022-04-13 18:37:26 +09:00
Calvin Pan
9f4b8691e2 [automerge] Remove subtitle of system default 2p: 9ee9787dd3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17742044

Bug: 226894987
Change-Id: I243580150c421ee8291cbddce1aacee150bd82ee
2022-04-13 09:16:21 +00:00
Calvin Pan
9ee9787dd3 Remove subtitle of system default
Bug: 226894987
Test: manual
Change-Id: Iaa5e680567f5bb1d52f9a3ea911f1b573ba5b238
2022-04-13 09:12:16 +00:00
Presubmit Automerger Backend
2885a43ddd [automerge] Unchecked battery saver switch once it's 1st launch 2p: d2ce1d9194
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17707388

Bug: 227725656
Change-Id: If2036f7792f3c9358e88061d5afd4873612fd3f9
2022-04-13 09:07:40 +00:00
Wesley Wang
d2ce1d9194 Unchecked battery saver switch once it's 1st launch
- Add low battery warning ack check to onSwitchChanged(), reset the
   switch to off once it's 1st time launch, the switch should be enable
   by battery saver change event at 1st instead of enable directly, will
   not check this state anymore after 1st launch

Bug: 227725656
Test: make RunSettingsRoboTests
Change-Id: I79f502f567fae5dd10166d8b24fd50d59c261001
2022-04-13 17:06:52 +08:00
TreeHugger Robot
c6594161e8 Merge "[Panlingual] Fix settings's crash." into tm-dev am: 4bc8231c71
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17730681

Change-Id: If106e9bb879f74d022b4978ba65e99ca9c0354d1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-13 09:01:33 +00:00
TreeHugger Robot
4bc8231c71 Merge "[Panlingual] Fix settings's crash." into tm-dev 2022-04-13 08:58:07 +00:00
TreeHugger Robot
1bc58cfe76 Merge changes from topic "presubmit-am-fbcb86dcb4cc4374ba5034829b6bb3db" into tm-mainline-prod
* changes:
  [automerge] [Panlingual] Fix settings's crash. 2p: 25dc3817a9
  [Panlingual] Fix settings's crash.
2022-04-13 08:58:07 +00:00
TreeHugger Robot
b9a673b31b Merge "Remove redundant WiFi tethering listener" into tm-dev am: dae29a84fa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17716525

Change-Id: Ibdf01f6d3730738045474089ce5b28983f0f7d25
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-13 08:51:40 +00:00
TreeHugger Robot
dae29a84fa Merge "Remove redundant WiFi tethering listener" into tm-dev 2022-04-13 08:07:45 +00:00
TreeHugger Robot
a1e10371ff Merge changes from topic "presubmit-am-470cc8509f0d4b8d8bcd9ac67434e185" into tm-mainline-prod
* changes:
  [automerge] Remove redundant WiFi tethering listener 2p: 37edbd33b8
  Remove redundant WiFi tethering listener
2022-04-13 08:07:45 +00:00
Presubmit Automerger Backend
d12e3daef6 [automerge] [Panlingual] Fix settings's crash. 2p: 25dc3817a9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17730681

Bug: 229044820
Change-Id: I4aef38ef2bf95c1aa83f60e5cfeb856b3a373bb9
2022-04-13 06:57:30 +00:00
tom hsu
25dc3817a9 [Panlingual] Fix settings's crash.
- fix crash due to no listview.

Bug: 229044820
Test: local
Change-Id: Ic3a15f9cfd89ff24ce1d764417de4686e10d3008
2022-04-13 14:56:23 +08:00
YK Hung
27ed1e679e Merge "[Security] Verify the permission first before querying installed apps" into tm-dev am: d3c3a2fdff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17730673

Change-Id: I797f3186b35a99886570770298d169b172914b10
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-13 06:21:25 +00:00
YK Hung
d3c3a2fdff Merge "[Security] Verify the permission first before querying installed apps" into tm-dev 2022-04-13 06:01:11 +00:00
YK Hung
0354a67716 Merge changes from topic "presubmit-am-57a4c6718ca64e5aa29f52e2a381bac4" into tm-mainline-prod
* changes:
  [automerge] [Security] Verify the permission first before querying installed apps 2p: 42d5979f69
  [Security] Verify the permission first before querying installed apps
2022-04-13 06:01:11 +00:00
Edgar Wang
9ea70fc349 Merge "Fix LaunchAnyWhere in AppRestrictionsFragment" into tm-dev am: a4a14e9bdc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17614846

Change-Id: I9ad7ed5623e93b22bc521465eca53c8897881c78
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-13 04:59:47 +00:00
Edgar Wang
ace3010e39 Merge "Index the gesture options in System Navigation Settings page" into tm-dev am: 5a539c5cb2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17684395

Change-Id: I99e3ee1a40d80446e01ddccd7023ca1ebc2cdc99
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-13 04:59:39 +00:00
Edgar Wang
43e8f350d1 Merge "Fix "Factory Reset" fails to reset the device" into tm-dev am: f797153708
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17684397

Change-Id: I3074f1d70b1301e3464d728975e58a32e0d57af1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-13 04:59:10 +00:00
Edgar Wang
019eb77224 Fix LaunchAnyWhere in AppRestrictionsFragment
If the intent's package equals to the app's package, this intent
will be allowed to startActivityForResult.
But this check is unsafe, because if the component of this intent
is set, the package field will just be ignored. So if we set the
component to any activity we like and set package to the app's
package, it will pass the assertSafeToStartCustomActivity check
and now we can launch anywhere.

Bug: 223578534
Test: robotest and manual verify
Change-Id: I40496105bae313fe5cff2a36dfe329c1e2b5bbe4
(cherry picked from commit 90e095dbe3)
2022-04-13 04:51:09 +00:00
Edgar Wang
f600c05a5a Fix LaunchAnyWhere in AppRestrictionsFragment
If the intent's package equals to the app's package, this intent
will be allowed to startActivityForResult.
But this check is unsafe, because if the component of this intent
is set, the package field will just be ignored. So if we set the
component to any activity we like and set package to the app's
package, it will pass the assertSafeToStartCustomActivity check
and now we can launch anywhere.

Bug: 223578534
Test: robotest and manual verify
Change-Id: I40496105bae313fe5cff2a36dfe329c1e2b5bbe4
(cherry picked from commit 90e095dbe3)
2022-04-13 04:50:33 +00:00
Edgar Wang
f8f45888e6 Fix LaunchAnyWhere in AppRestrictionsFragment
If the intent's package equals to the app's package, this intent
will be allowed to startActivityForResult.
But this check is unsafe, because if the component of this intent
is set, the package field will just be ignored. So if we set the
component to any activity we like and set package to the app's
package, it will pass the assertSafeToStartCustomActivity check
and now we can launch anywhere.

Bug: 223578534
Test: robotest and manual verify
Change-Id: I40496105bae313fe5cff2a36dfe329c1e2b5bbe4
(cherry picked from commit 90e095dbe3)
2022-04-13 04:50:03 +00:00
Edgar Wang
1b9da55a31 Fix LaunchAnyWhere in AppRestrictionsFragment
If the intent's package equals to the app's package, this intent
will be allowed to startActivityForResult.
But this check is unsafe, because if the component of this intent
is set, the package field will just be ignored. So if we set the
component to any activity we like and set package to the app's
package, it will pass the assertSafeToStartCustomActivity check
and now we can launch anywhere.

Bug: 223578534
Test: robotest and manual verify
Change-Id: I40496105bae313fe5cff2a36dfe329c1e2b5bbe4
(cherry picked from commit 90e095dbe3)
2022-04-13 04:49:26 +00:00
Edgar Wang
aeb36e5c28 Fix LaunchAnyWhere in AppRestrictionsFragment
If the intent's package equals to the app's package, this intent
will be allowed to startActivityForResult.
But this check is unsafe, because if the component of this intent
is set, the package field will just be ignored. So if we set the
component to any activity we like and set package to the app's
package, it will pass the assertSafeToStartCustomActivity check
and now we can launch anywhere.

Bug: 223578534
Test: robotest and manual verify
Change-Id: I40496105bae313fe5cff2a36dfe329c1e2b5bbe4
(cherry picked from commit 90e095dbe3)
2022-04-13 04:48:46 +00:00
Edgar Wang
b3eecdd13d Fix LaunchAnyWhere in AppRestrictionsFragment
If the intent's package equals to the app's package, this intent
will be allowed to startActivityForResult.
But this check is unsafe, because if the component of this intent
is set, the package field will just be ignored. So if we set the
component to any activity we like and set package to the app's
package, it will pass the assertSafeToStartCustomActivity check
and now we can launch anywhere.

Bug: 223578534
Test: robotest and manual verify
Change-Id: I40496105bae313fe5cff2a36dfe329c1e2b5bbe4
(cherry picked from commit 90e095dbe3)
2022-04-13 04:47:24 +00:00
Edgar Wang
a4a14e9bdc Merge "Fix LaunchAnyWhere in AppRestrictionsFragment" into tm-dev 2022-04-13 04:38:57 +00:00
Edgar Wang
b6582aa68c Merge changes from topic "presubmit-am-5513fca9a4904e75827e4e4077587542" into tm-mainline-prod
* changes:
  [automerge] Fix LaunchAnyWhere in AppRestrictionsFragment 2p: 90e095dbe3
  Fix LaunchAnyWhere in AppRestrictionsFragment
2022-04-13 04:38:57 +00:00
Edgar Wang
5a539c5cb2 Merge "Index the gesture options in System Navigation Settings page" into tm-dev 2022-04-13 04:34:04 +00:00
Edgar Wang
2c52db547b Merge changes from topic "presubmit-am-020809e13415452dbdf7bee571efa369" into tm-mainline-prod
* changes:
  [automerge] Index the gesture options in System Navigation Settings page 2p: 257ebe4a5e
  Index the gesture options in System Navigation Settings page
2022-04-13 04:34:04 +00:00
Edgar Wang
f797153708 Merge "Fix "Factory Reset" fails to reset the device" into tm-dev 2022-04-13 04:33:07 +00:00
Edgar Wang
e19f7f4222 Merge changes from topic "presubmit-am-d486feda52034c51a2dd75eb56afa2c2" into tm-mainline-prod
* changes:
  [automerge] Fix "Factory Reset" fails to reset the device 2p: f8739eda93
  Fix "Factory Reset" fails to reset the device
2022-04-13 04:33:07 +00:00
Presubmit Automerger Backend
cc44f71530 [automerge] [Security] Verify the permission first before querying installed apps 2p: 42d5979f69
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17730673

Bug: 227753723
Change-Id: I6d6e57e086a694b992d847eca7f91617be3ef4d0
2022-04-13 03:27:15 +00:00
ykhung
42d5979f69 [Security] Verify the permission first before querying installed apps
Verify the target app "REQUEST_IGNORE_BATTERY_OPTIMIZATIONS" permission first before querying installed apps information to avoid the exposed the installed apps information and improve the performance by applying the early return flow.

Bug: 227753723
Test: make RunSettingsRoboTests
Change-Id: Ib5826b8082f4bf14f93d5ff4d2d332dc395bf9a8
2022-04-13 03:27:06 +00:00
PETER LIANG
0d32cefec6 Merge "Fix that device isn't responding for a while when resetting all settings on “Display size and text” page." into tm-dev am: 8bd6647885
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17614845

Change-Id: I8337840a07930756098dcc2809a71141c38766fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-13 00:44:15 +00:00
PETER LIANG
8bd6647885 Merge "Fix that device isn't responding for a while when resetting all settings on “Display size and text” page." into tm-dev 2022-04-13 00:39:27 +00:00
Presubmit Automerger Backend
74dd53583b [automerge] Fix that device isn't responding for a while when resetting all settings on “Display size and text” page. 2p: 09a2a49bd3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17614845

Bug: 223747686
Bug: 220082104
Bug: 220070773
Change-Id: If66da507a1e49fa2abec0f4a36507cb73fb176b4
2022-04-13 00:38:51 +00:00
Peter_Liang
09a2a49bd3 Fix that device isn't responding for a while when resetting all settings on “Display size and text” page.
Goal:
Probably has the race condition issue between "Bold text" and  the other features including "Display Size", “Font Size” if they would be enabled at the same time, so our workaround is that the “Bold text” would be reset first and then do the remaining to avoid flickering problem.

Bug: 223747686
Bug: 220082104
Bug: 220070773
Test: make RunSettingsRoboTests ROBOTEST_FILTER=TextReadingPreferenceFragmentTest
Change-Id: If1425fe2579bec8dded69680ac73fbfb03c37321
2022-04-13 00:38:44 +00:00
TreeHugger Robot
628dd51d0d Merge "Add missing extra when launching apps" into tm-dev am: 14a3861f0b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17721989

Change-Id: I80b10681ce6d99697eacd905210e21b317edd4b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-13 00:34:23 +00:00
TreeHugger Robot
14a3861f0b Merge "Add missing extra when launching apps" into tm-dev 2022-04-12 23:27:14 +00:00
Weng Su
0a89ef862d [automerge] Remove redundant WiFi tethering listener 2p: 37edbd33b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17716525

Bug: 227719584
Change-Id: I5466de3a13ac0e9d2b1bb4c86904379bdb1b42ae
2022-04-12 21:07:09 +00:00
Weng Su
37edbd33b8 Remove redundant WiFi tethering listener
- WiFi tethering settings currently listeners two sets of WiFi tethering
  state from framework at the same time, There is a timing issue when
  the deprecated callback is sent earlier than the available callback,
  it will cause WiFi tethering settings to start tethering twice in a
  short period of time, causing the WiFi framework to respond with a
  startup error.

- Remove redundant obsolete WiFi tethering state listener to avoid
  WiFi tethering startup error.

Bug: 227719584
Test: manual test
make RunSettingsRoboTests ROBOTEST_FILTER=WifiTetherSettingsTest

Change-Id: I59cb5222acb763f630fb621250d7740a240bbd92
2022-04-13 05:04:47 +08:00
Julia Reynolds
3d8de3e21f [automerge] Add missing extra when launching apps 2p: 87bb1b34c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17721989

Change-Id: Ib37af2c92b1da8de0ce14f643db2e4ad1775408b
2022-04-12 20:21:07 +00:00
Julia Reynolds
87bb1b34c5 Add missing extra when launching apps
As promised in the api docs

Test: AbstractZenModeAutomaticRulePreferenceControllerTest, view
schedule DND page
Fixes: 221423986

Change-Id: I7ddc1b112950da225afa2ba13ebf5df481922177
2022-04-12 16:20:01 -04:00
Julia Reynolds
e2ef0bcdfc Merge "Fix some history issues" into tm-dev am: b28925ad48
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17710594

Change-Id: Ib20da3b6a4d75fab7fd4aef8b3acf35216c9643c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-12 17:43:45 +00:00
Julia Reynolds
b28925ad48 Merge "Fix some history issues" into tm-dev 2022-04-12 17:39:55 +00:00
Julia Reynolds
7ba6728cd8 Merge changes from topic "presubmit-am-1e7fa8f458a24c9bb07a3501870823fc" into tm-mainline-prod
* changes:
  [automerge] Fix some history issues 2p: 4d46dddbe7
  Fix some history issues
2022-04-12 17:39:55 +00:00
TreeHugger Robot
54f6f65f13 Merge "Apply only RING_VIBRATION_INTENSITY to ringtone vibrations" into tm-dev am: 7a4f6a5ba3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17474927

Change-Id: I15d78ec410d16d8e13e96a0ece2c583fa722010f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-12 17:28:52 +00:00