Commit Graph

64090 Commits

Author SHA1 Message Date
Bonian Chen
e18904daab Merge "[Settings] Avoid rename inactive subscription from NullPointerException" into rvc-dev 2020-04-10 12:37:42 +00:00
Bonian Chen
5941bb88bf Merge "[Settings] Avoid from crash when pull out SIM" into rvc-dev am: 866fa1061c am: dc6d9e53d1 am: fd86a33e6e
Change-Id: Ib0c22f98de481a2fca6af0be3e1ac4894dc04cf8
2020-04-10 12:23:20 +00:00
Bonian Chen
570eb70eb1 Merge "[Settings] Avoid from crash when pull out SIM" into rvc-dev am: 866fa1061c am: 369594d796 am: 1031a3156f
Change-Id: I3f721e4b3d336a2e1ee34c4833b12014c6623070
2020-04-10 12:23:05 +00:00
Bonian Chen
fd86a33e6e Merge "[Settings] Avoid from crash when pull out SIM" into rvc-dev am: 866fa1061c am: dc6d9e53d1
Change-Id: I9e3642cb2254918e6eeac768bfc55cde21e821d7
2020-04-10 12:14:26 +00:00
Bonian Chen
f407842d32 Merge "[Settings] Avoid from crash when pull out SIM" into rvc-dev am: 866fa1061c am: 369594d796
Change-Id: Idebedd7bb1ba4823b658aa0bc49413d014bb8c29
2020-04-10 12:14:25 +00:00
Bonian Chen
1031a3156f Merge "[Settings] Avoid from crash when pull out SIM" into rvc-dev am: 866fa1061c am: 369594d796
Change-Id: Ibd2e4ac878c48502f11a90faaad9a800b0ef3551
2020-04-10 12:12:52 +00:00
Bonian Chen
dc6d9e53d1 Merge "[Settings] Avoid from crash when pull out SIM" into rvc-dev am: 866fa1061c
Change-Id: I837ddd16902ad159d5f791c316ba4f962f754640
2020-04-10 11:51:45 +00:00
Bonian Chen
369594d796 Merge "[Settings] Avoid from crash when pull out SIM" into rvc-dev am: 866fa1061c
Change-Id: I9bbe02a684f97e50a66278b725814fc7cd9d4a7b
2020-04-10 11:50:17 +00:00
Bonian Chen
866fa1061c Merge "[Settings] Avoid from crash when pull out SIM" into rvc-dev 2020-04-10 11:30:42 +00:00
Jason Chiu
1766b3c01d Fix indexing error of mobile related controllers
There were several errors in indexing mobile related sliceable
controllers, which led them not able to display on Panel and as inline
controls in search result.

It's because indexing mechanism is running in a worker thread and trying
to construct each controller instance, but the failed controllers'
constructors need to initilize something in the main thread.

- Give the main looper to the classes which only can be initialized in
  the main thread to fix the indexing.
- Guard null pointer exception in SlicesIndexer after fixing the
  indexing.
- Use onStart/onStop in AirplaneModePreferenceController to start/stop
  listener.

Fixes: 149720345
Test: robotest
Change-Id: Ibe5a8d6cc713eeddf26eceaabc05e6d1faa45507
2020-04-10 10:56:31 +00:00
Bonian Chen
cad93df0a4 [Settings] Avoid rename inactive subscription from NullPointerException
1. Init instance before accessing it
2. Re-enable test case

Bug: 147321836
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=RenameMobileNetworkDialogFragmentTest
Change-Id: Ifc245bec739b4c81d2cee04b091bcdb54d567d4a
(cherry picked from commit 1b71b5e601)
2020-04-10 18:05:17 +08:00
TreeHugger Robot
689aab245a Merge "[Settings] Add more owner" into rvc-dev am: 6e50dfc6ec am: f702bb94d0 am: 907c0740d5 am: 7e107cac02
Change-Id: I129b81da1b6388356c55b8e89569b3378016f0e7
2020-04-10 09:16:06 +00:00
Arc Wang
e3212d65cd Merge "[Wi-Fi] Fix Hidden network option scrolls to bottom problem" into rvc-dev am: 57ff6599e7 am: 6253abc2ab am: a1dea55dda am: 5115d8bdb1
Change-Id: Iec0b2076c76be2e271d7410c6de3a642984f0f6a
2020-04-10 09:15:57 +00:00
TreeHugger Robot
798acd37cc Merge "[Settings] Add more owner" into rvc-dev am: 6e50dfc6ec am: c865eb04bc am: b93584c2c3
Change-Id: I4e70710f0eafd839f3feb54229a25d9a2ff151b7
2020-04-10 08:52:32 +00:00
Arc Wang
610d86ae3a Merge "[Wi-Fi] Fix Hidden network option scrolls to bottom problem" into rvc-dev am: 57ff6599e7 am: c41420bd4e am: b5595ac01e
Change-Id: I9c9a8b4b0d1ac5f94e27afec9c0ba16ec18b96bd
2020-04-10 08:52:26 +00:00
TreeHugger Robot
ff26d4501e Merge "[Settings] Add more owner" into rvc-dev am: 6e50dfc6ec am: f702bb94d0 am: adde699c99
Change-Id: Idf3490d6dfec62de5427bf61b330d6f406c3eef5
2020-04-10 08:52:19 +00:00
Arc Wang
a8cc148791 Merge "[Wi-Fi] Fix Hidden network option scrolls to bottom problem" into rvc-dev am: 57ff6599e7 am: 6253abc2ab am: 98d4d8a0d0
Change-Id: I2b620ceadd1accac477e8e252d3c31e502f3776a
2020-04-10 08:52:04 +00:00
TreeHugger Robot
7e107cac02 Merge "[Settings] Add more owner" into rvc-dev am: 6e50dfc6ec am: f702bb94d0 am: 907c0740d5
Change-Id: I876292d5d9a9cce81936cfb86a9bc28422f27ae6
2020-04-10 08:50:55 +00:00
Arc Wang
5115d8bdb1 Merge "[Wi-Fi] Fix Hidden network option scrolls to bottom problem" into rvc-dev am: 57ff6599e7 am: 6253abc2ab am: a1dea55dda
Change-Id: Ifcdc7a09ec0fa6e390fb2e68e47309ae641c1b1f
2020-04-10 08:50:47 +00:00
Bonian Chen
8dd1b0258d [Settings] Avoid from crash when pull out SIM
Avoid from crash when pull out SIM under SimStatusDialogController.

Bug: 153512823
Test: manual
Merged-In: I3869326bdfb65368827f25469ae83539a68e171f
Change-Id: I60500c058cf15bc432e46e27fe4b9fb1ae2989b7
2020-04-10 16:42:57 +08:00
TreeHugger Robot
b93584c2c3 Merge "[Settings] Add more owner" into rvc-dev am: 6e50dfc6ec am: c865eb04bc
Change-Id: Ia399a97aef2c348bdd2765631431c132f8b3fd2f
2020-04-10 08:31:12 +00:00
Arc Wang
b5595ac01e Merge "[Wi-Fi] Fix Hidden network option scrolls to bottom problem" into rvc-dev am: 57ff6599e7 am: c41420bd4e
Change-Id: Ia65e3e908cff4d521398eb7426ea6100c39f7c14
2020-04-10 08:31:06 +00:00
TreeHugger Robot
907c0740d5 Merge "[Settings] Add more owner" into rvc-dev am: 6e50dfc6ec am: f702bb94d0
Change-Id: If810045704a78e1693e8c16e99b69d03b2d0b6e1
2020-04-10 08:31:05 +00:00
Arc Wang
a1dea55dda Merge "[Wi-Fi] Fix Hidden network option scrolls to bottom problem" into rvc-dev am: 57ff6599e7 am: 6253abc2ab
Change-Id: Icb372c82cbcd4fe81db34f6c0a48b52b24107190
2020-04-10 08:30:59 +00:00
TreeHugger Robot
adde699c99 Merge "[Settings] Add more owner" into rvc-dev am: 6e50dfc6ec am: f702bb94d0
Change-Id: I003ad64464a044d1fbc39431db81a4e32bcaeb37
2020-04-10 08:29:28 +00:00
Arc Wang
98d4d8a0d0 Merge "[Wi-Fi] Fix Hidden network option scrolls to bottom problem" into rvc-dev am: 57ff6599e7 am: 6253abc2ab
Change-Id: I5d49798c339ec62bc6b22e3a552887b1d7f38356
2020-04-10 08:29:18 +00:00
Bonian Chen
0304e5f90c [Settings] Avoid from crash when pull out SIM
Avoid from crash when pull out SIM under SimStatusDialogController.

Bug: 153512823
Test: manual
Change-Id: I3869326bdfb65368827f25469ae83539a68e171f
2020-04-10 16:28:46 +08:00
TreeHugger Robot
c865eb04bc Merge "[Settings] Add more owner" into rvc-dev am: 6e50dfc6ec
Change-Id: I03b72c6027dcfe40e60363d17e7ccbf5e6f7f58a
2020-04-10 08:10:50 +00:00
Arc Wang
c41420bd4e Merge "[Wi-Fi] Fix Hidden network option scrolls to bottom problem" into rvc-dev am: 57ff6599e7
Change-Id: I5409c87391c8ec39bcdb1d9dcdf608b898d99cdf
2020-04-10 08:10:45 +00:00
TreeHugger Robot
f702bb94d0 Merge "[Settings] Add more owner" into rvc-dev am: 6e50dfc6ec
Change-Id: Ic6b440bafcb6f65dfe87f57fb5161b12c177923d
2020-04-10 08:09:20 +00:00
Arc Wang
6253abc2ab Merge "[Wi-Fi] Fix Hidden network option scrolls to bottom problem" into rvc-dev am: 57ff6599e7
Change-Id: Ia6e3dfe09548e0ec83eede9c041c6a71539629ff
2020-04-10 08:09:14 +00:00
TreeHugger Robot
6e50dfc6ec Merge "[Settings] Add more owner" into rvc-dev 2020-04-10 08:08:30 +00:00
Arc Wang
57ff6599e7 Merge "[Wi-Fi] Fix Hidden network option scrolls to bottom problem" into rvc-dev 2020-04-10 07:50:49 +00:00
Menghan Li
dd84a91612 Merge "Sets the scroll indicators for edit shortcut dialog." into rvc-dev am: 417011c6f7 am: e98d4b9971 am: 8a847e7d35 am: 0136af51df
Change-Id: I39a23b7e0c047306a112c875582c33542aed5a6f
2020-04-10 07:49:59 +00:00
Menghan Li
045e5a6cd8 Merge "Sets the scroll indicators for edit shortcut dialog." into rvc-dev am: 417011c6f7 am: e98d4b9971 am: e530a1f597
Change-Id: Ib5dbb1a480e14bc9f379aa3fe9b6fa455710345c
2020-04-10 07:16:28 +00:00
Menghan Li
0136af51df Merge "Sets the scroll indicators for edit shortcut dialog." into rvc-dev am: 417011c6f7 am: e98d4b9971 am: 8a847e7d35
Change-Id: I4712000b7b78c06b7da41eb3d157470db518ed4f
2020-04-10 07:15:15 +00:00
Menghan Li
0ed4426b51 Merge "Sets the scroll indicators for edit shortcut dialog." into rvc-dev am: 417011c6f7 am: 698b8f1f87 am: 534d5ca2b6
Change-Id: I5d97834fa949876dda0b8d852ed46d970471bf9e
2020-04-10 07:14:49 +00:00
Hiroki Sato
0e75d475ec Hide Bluetooth, Reset, Accessibility Settings in ARC
This is an upstreaming change of http://ag/8541963 and
http://ag/10296201 to hide some items from settings search.

This CL also adds javadoc to some settings classes to fix pre-upload
warnings.

Bug: 153704887
Test: Manual. In ARC build, "bluetooth" and "accessibility" no longer shows related settings.
Change-Id: Ic3e9217944251adbea1bdd67baf66d3a9e89583a
2020-04-10 16:00:57 +09:00
Menghan Li
e530a1f597 Merge "Sets the scroll indicators for edit shortcut dialog." into rvc-dev am: 417011c6f7 am: e98d4b9971
Change-Id: Idac70369ee057628ff4e833a8d6f84132d2dc2f5
2020-04-10 06:53:33 +00:00
Menghan Li
8a847e7d35 Merge "Sets the scroll indicators for edit shortcut dialog." into rvc-dev am: 417011c6f7 am: e98d4b9971
Change-Id: I71edc050ea03febb55bc4c98b11f88a7cdb23e49
2020-04-10 06:52:59 +00:00
Menghan Li
534d5ca2b6 Merge "Sets the scroll indicators for edit shortcut dialog." into rvc-dev am: 417011c6f7 am: 698b8f1f87
Change-Id: Ie2f01afbef5610e9ce3abfab0df48410647c9197
2020-04-10 06:52:54 +00:00
Menghan Li
698b8f1f87 Merge "Sets the scroll indicators for edit shortcut dialog." into rvc-dev am: 417011c6f7
Change-Id: I7c9d24b0d4377fac0e622bec05c1107db9050c9a
2020-04-10 06:33:20 +00:00
Menghan Li
e98d4b9971 Merge "Sets the scroll indicators for edit shortcut dialog." into rvc-dev am: 417011c6f7
Change-Id: I95f2bf776250c5b31e54b2ea6203b22ae1c315cf
2020-04-10 06:31:30 +00:00
Menghan Li
417011c6f7 Merge "Sets the scroll indicators for edit shortcut dialog." into rvc-dev 2020-04-10 05:21:54 +00:00
Arc Wang
d004dfc4b3 [Wi-Fi] Fix Hidden network option scrolls to bottom problem
Should not scroll to bottom since Hidden network option
is not at the bottom most.

Bug: 148036155
Test: manual
      Wi-Fi Setings -> Add network -> Advanced options ->
      click 'Hidden network' Yes -> should not scroll to bottom.
Change-Id: I6511f75441ebad62e2c28df76a39d702d78898a6
2020-04-10 13:19:30 +08:00
Bonian Chen
ce92b0efb7 [Settings] Add more owner
Add more owner for code review.

Bug: 0
Test: none
Change-Id: Idf49638e4599b95fe39fe127e5b965cf724f5d7c
2020-04-10 13:13:08 +08:00
Calvin Pan
158e2b4afe Merge "Check is5gEntryDisplayed in NETWORK_MODE_LTE_GSM_WCDMA mode" into rvc-dev am: 4e2e7bb734 am: 2b6e636673 am: 9bdf29f3cf am: 70c45ca6d6
Change-Id: Icb13ed43af9f37c7ba17d72cee7a88b21708c2a1
2020-04-10 04:15:27 +00:00
Arc Wang
f03ea9b4b7 Merge "[A11Y][Wi-Fi] Prevent data usage header spinner speak at onResume" into rvc-dev am: 341a7971f0 am: 4f70655963 am: 3ebc3f1ba4 am: a798d8a672
Change-Id: I0da50b761b077f0cde57c39aff50ddbda406ae10
2020-04-10 04:15:21 +00:00
Arc Wang
1e446c3414 Merge "[A11Y][Wi-Fi] Fix multiple Spinner selected speak out at once." into rvc-dev am: 0713c43bbb am: 873d9e019d am: e24c336285 am: d0f9f48baa
Change-Id: Ib3520688280c1beb90e538ce6eb5f04c973897f2
2020-04-10 04:15:08 +00:00
Calvin Pan
a6fea4d4c5 Merge "Check is5gEntryDisplayed in NETWORK_MODE_LTE_GSM_WCDMA mode" into rvc-dev am: 4e2e7bb734 am: f0a0d6e835 am: 26f239baae
Change-Id: I582a85c5e4a90292ca0d6139106c944d8d368ad9
2020-04-10 03:55:44 +00:00