Commit Graph

47056 Commits

Author SHA1 Message Date
Lei Yu
499f71988f Merge "Hook up anomaly active hour to BatteryTipPolicy" 2018-07-19 17:14:45 +00:00
TreeHugger Robot
29e99d2010 Merge "Move functions to settingslib for more code reuse" 2018-07-19 16:58:17 +00:00
TreeHugger Robot
a28a3cc2e4 Merge "Fixed data usage displaying problem" 2018-07-19 16:32:56 +00:00
Aarthi Balachander
d779db4009 Move functions to settingslib for more code reuse
Bug: 110376110
Test: Tested on device
Change-Id: I2bbb8d01f675fc254e783b97b44d16f36846a416
2018-07-18 20:05:24 -07:00
SunnyShao
abb3b1cf6a Fixed data usage displaying problem
- Changed "Data usage" to "Mobile data & Wi-Fi" in App info page
- Chageed the title "App data usage" to "Mobile data & Wi-Fi"

Change-Id: I7699465ca5c7b1786c6f9e33bc25a2dd70181ce6
Fixes: 34515307
Test: visual
2018-07-19 10:39:02 +08:00
TreeHugger Robot
ec7a9df676 Merge "Use the migrated injected setting code in settingslib. Manual merge to master from pi-car-dev Bug: 68198078 Test: Tested on device Change-Id: Iff767cd6bf7408b45ce9594628d3fd0a71744e9f" 2018-07-19 02:10:46 +00:00
Raff Tsai
0f4affb9a0 Merge "Fix AlertDialog corner and color accent" 2018-07-19 01:00:28 +00:00
TreeHugger Robot
4cbf887d94 Merge "Convert SavedAccessPoints to DashboardFragment (step 1)" 2018-07-19 00:25:14 +00:00
TreeHugger Robot
1d7ee9b997 Merge "Clean up saved network screen" 2018-07-18 23:32:10 +00:00
Fan Zhang
d5547c68bf Convert SavedAccessPoints to DashboardFragment (step 1)
Change-Id: I5d8fa8497e04c9314dead9af7534df4507ffd591
Bug: 64806699
Test: robotest
2018-07-18 16:21:24 -07:00
Fan Zhang
661049f4d9 Clean up saved network screen
Bug: 64806699
Test: rebuild
Change-Id: I4392809f08034c7c13575db2f5c41468fcea0987
2018-07-18 15:13:21 -07:00
TreeHugger Robot
ad2e828f57 Merge "Unrestrict SMS/PHONE app if it been set active" 2018-07-18 20:43:38 +00:00
Aarthi Balachander
d0f835981c Use the migrated injected setting code in settingslib.
Manual merge to master from pi-car-dev
Bug: 68198078
Test: Tested on device
Change-Id: Iff767cd6bf7408b45ce9594628d3fd0a71744e9f
2018-07-18 13:34:25 -07:00
jackqdyulei
f1213365fc Unrestrict SMS/PHONE app if it been set active
If an app been set default SMS/PHONE app, we need to unrestrict this
app. This CL extract a common function and invoke it when necessary.

Change-Id: Id29c5138438aa6f6f22cdd9c4ecf336de8481782
Fixes: 80305978
Test: robotests
2018-07-18 12:32:34 -07:00
TreeHugger Robot
cc65fbba9d Merge "Fix test cases broken" 2018-07-18 16:30:31 +00:00
TreeHugger Robot
9bd3687c8e Merge "Disable notification settings access from work apps." 2018-07-18 14:45:20 +00:00
Irina Dumitrescu
127fa65575 Disable notification settings access from work apps.
Fixes: 79241388
Test: the following command does not open the notification settings in
work profile user:
$ adb shell am start --user $USER -W -a android.settings.ACTION_NOTIFICATION_LISTENER_SETTINGS
Moreover, triggering the notifications from a sample app results in the
new toast being displayed.

Change-Id: I0a330a9cf22c813aea7600557660868263817e1e
2018-07-18 14:37:18 +01:00
tmfang
1d44acce67 Fix test cases broken
- AndroiX AlertDialog needs to use Theme.AppCompat.
- Create a ShadowAlertDialogCompat which can be compatible with AndroidX AlertDialog.

Fix: 111247403
Test: make RunSettingsRoboTests -j56 ROBOTEST_FILTER=com.android.settings.password.ChooseLockTypeDialogFragmentTest

Change-Id: I3e4bca285ecaefa5705c8d170050c21d1bc649e0
2018-07-18 19:39:39 +08:00
Raff Tsai
0810afee9b Fix AlertDialog corner and color accent
- Add some attributes in Theme.AlertDialog

Change-Id: Ifb9ca98ee11f6c82cda4a576d10b5fde54f788be
Fixes: 110917586
Test: mannual
2018-07-18 15:40:51 +08:00
TreeHugger Robot
5700ff5dde Merge "Remove LocalePickerWithRegion class in Settings." 2018-07-18 07:38:38 +00:00
Jackal Guo
7eea41f5af Merge "Change the order of preferences in a11y" 2018-07-18 05:37:08 +00:00
Jason Chiu
9b5020c1d2 Fix a test broken by fragment migration.
Change-Id: I68e4f9b53d3492817ea9416fd4127fbe15337ce6
Fixes: 111193572
Test: robotests
2018-07-18 10:53:28 +08:00
TreeHugger Robot
f878183582 Merge "Remove unused battery strings" 2018-07-18 00:59:41 +00:00
TreeHugger Robot
1fea2cbc48 Merge "Remove ListView from preference_list_fragment." 2018-07-18 00:25:26 +00:00
jackqdyulei
5977b1fe38 Remove unused battery strings
Change-Id: Ic463c353837078e6d5b960b458e210174b50fa37
Fixes: 36738738
Test: Build
2018-07-17 16:27:46 -07:00
Fan Zhang
fe93bd9c1e Remove ListView from preference_list_fragment.
As part of it, Use RecyclerView in PrintServiceSettingsFragment, which
still depends on the old preference_list_frag layout.

Also remove some unused pngs

Test: manual

Change-Id: I3189bd0dee5b6a74209eb1e707eb40427c96e312
2018-07-17 15:47:33 -07:00
Salvador Martinez
210ddd075a Fix dialogs in Theme.Settings
Theme.Settings was explicitly using a Light theme. This CL
changes it to DayNight so that it properly changes colors in
night mode.

Test: visual inspection, screenshot
Bug: 111397440
Change-Id: I20088a9021ddfe7d6e92c3b52ce4ca65ada07983
2018-07-17 15:45:29 -07:00
jackqdyulei
35015741b2 Hook up anomaly active hour to BatteryTipPolicy
So we can control it from server side.

Bug: 80192137
Test: RunSettingsRoboTests
Change-Id: Ic9a4db44029bdcd7e45f4f9fb6b7d71c8c07c429
2018-07-17 15:42:52 -07:00
TreeHugger Robot
203bb7e876 Merge "Fix the title mismatch bug of Languages sub-settings page." 2018-07-17 22:00:15 +00:00
TreeHugger Robot
d3e18dcf0a Merge changes from topic "rm_odr_anomaly"
* changes:
  Move anomaly code to BatteryTipUtils
  Remove the anomaly detection added in O-DR
2018-07-17 21:09:36 +00:00
jackqdyulei
5918cd5ff9 Move anomaly code to BatteryTipUtils
Then we could reuse it across settings.

Bug: 74529048
Test: robo test that cover each components still pass
Change-Id: Ied0bbc6e6a1dca9628c2c084c3284ffab2f85160
2018-07-17 12:42:57 -07:00
jackqdyulei
dd9b8af6b9 Remove the anomaly detection added in O-DR
1. Remove unused class and resources
2. Update function in AdvancedPowerUsageDetail since
we don't need pass in anomaly anymore

Change-Id: I96fbe5ddaae902b34b756c7aae0338e49afef1f3
Bug: 74529048
Test: 1. manual test in settings page. 2. robo test still pass
2018-07-17 12:42:43 -07:00
TreeHugger Robot
2e246bb66c Merge "Allow activity to delegate onActivityResult to fragments" 2018-07-17 19:30:39 +00:00
Yanting Yang
8086d15347 Fix the title mismatch bug of Languages sub-settings page.
- modify the title of Language sub-settings page.
- remove the unused string id, pref_title_lang_selection.

Change-Id: I445493f6769c9888a27b72471fc9282df3655406
Fixes: 111322494
Test: manual
2018-07-18 02:56:48 +08:00
Fan Zhang
af32e726e6 Allow activity to delegate onActivityResult to fragments
Change-Id: Iac388f1726269239313d666f3123f28348e0c90a
Fixes: 111531567
Test: rototests
2018-07-17 10:59:02 -07:00
jackqdyulei
c7867c80d4 Add scrollview for dns dialog
Also update dialog to appcompat to avoid the crash

Change-Id: Ide6483f1160713dae8111de533a8b3345a3420c2
Fixes: 111351793
Test: Manual
2018-07-17 10:47:32 -07:00
tmfang
c0ed614252 Remove LocalePickerWithRegion class in Settings.
This class is too complex, we can't afford maintaining this long term.
We need a new Activity that wraps the framework version of LocalePickerWithRegion.

Bug: 111373939
Test: manual test & make RunSettingsRoboTests -j56

Change-Id: I93c719246b84350d2eee4e8ce1ffd97cd168925b
2018-07-17 17:34:00 +08:00
Jason Chiu
baea63bf72 Fix a test broken by fragment migration.
Test: make ROBOTEST_FILTER=SettingsLicenseActivityTest RunSettingsRoboTests
Bug: 111194177
Change-Id: Ifd2d980bbf397ad9875b43d654ab4fc52c4627c2
2018-07-17 15:46:48 +08:00
Jackal Guo
6490923251 Change the order of preferences in a11y
Some preference items have the same order, and it makes these items
be sorted in different position per languages. Use unique order for
each items instead.

Bug: 77949267
Test: atest CtsAccessibilityTestCases
Test: manual check the order in different languages
Change-Id: Ibfcb316c4299266b053053d9d88819a7dcc158fa
2018-07-17 11:19:05 +08:00
TreeHugger Robot
0c605c80a7 Merge "Move non-theme styles to styles.xml" 2018-07-17 02:33:50 +00:00
Fan Zhang
a122be1c35 Move non-theme styles to styles.xml
1. Move SUW related themes into its own theme file.
2. Move non-theme styles into styles.xml
3. Move theme styles to themes.xml
4. Group all TextAppearence together in styles.xml
5. And remove some unused resources

Bug: 111454230
Test: manual
Change-Id: I1067a01cf1960bc72ec92528177ac5fcbd4faa3a
2018-07-16 17:59:07 -07:00
TreeHugger Robot
20f85d2a27 Merge "Remove more unused theme customization" 2018-07-17 00:23:46 +00:00
TreeHugger Robot
e64a75812e Merge "Add a back-up icon resource to icon-less Slices" 2018-07-17 00:21:23 +00:00
Fan Zhang
dec6b8cd38 Remove more unused theme customization
Bug: 111454230
Test: manual
Change-Id: I704247ffe1092165365f7604f17372c79afd46ed
2018-07-16 16:14:56 -07:00
Matthew Fritze
c38f7e1d0a Add a back-up icon resource to icon-less Slices
Currently, when a Settings Slice dosen't have an icon, we add an IconCompat
object with the resource 0x0 - which gives an empty icon. This is from the UX
direction that we should only have icons for Settings Slices when the
corresponding Settings have icons in the Settings UI.

However, this causes an issue with a recent change to SliceView, which crashes
the UI when a Slice is rendered without an icon. Previously, the icon code path
was only exercised when the Slice Shortcut view was being used, but after the
change, the icon path is always used and thus crashes when trying to fetch a
resource with id 0x0 from Settings or another provider.

About 2/3rds of Settings Slices do not have icons.

This change adds the Settings App icon as the back-up icon for any Slice which
would otherwise not have an icon.

The impact of missing this change is:
- Settings Slices cannot be shown in launcher spaces until a post-P update comes
from the support library.
- If Settings launches with the bug, Slices cannot patch the API which would require
all Slices to have a non empty icon (b/111438616)

Bug: 111082093
Test: Robotests, Settings Search UI testing, Slice browser testing
Change-Id: I6f326b6b41bf59011a211c6340dd639f68e754e1
2018-07-16 15:34:24 -07:00
TreeHugger Robot
cd489ea2d5 Merge "Clean up theme part 1: move attrs to attrs.xml" 2018-07-16 22:12:05 +00:00
Brad Ebinger
c30af9b8d1 Merge "IMS: Use the slot based ImsManager factory reset API." am: 9e4ff6fca6 am: 15ca33865c
am: aca1e304bd

Change-Id: I0b3b6198e895caf4c33354ffb2fc20b599540387
2018-07-16 14:21:57 -07:00
TreeHugger Robot
9eb270e15e Merge "Fix a incorrect type cast for alert dialog" 2018-07-16 21:08:21 +00:00
Fan Zhang
612fc1ea40 Clean up theme part 1: move attrs to attrs.xml
And remove unused theme and layouts.

Bug: 111454230
Test: rebuild
Change-Id: Iaf418a9a3dc014fc0eac096e60b0e4581c6ededb
2018-07-16 14:00:20 -07:00
Brad Ebinger
aca1e304bd Merge "IMS: Use the slot based ImsManager factory reset API." am: 9e4ff6fca6
am: 15ca33865c

Change-Id: I5fcdcb5b74a828d4377d2bc4e8e567f61ff9a899
2018-07-16 13:55:25 -07:00