Commit Graph

554 Commits

Author SHA1 Message Date
menghanli
c240b27862 Add back "Tapping Stop will stop x" dialog while turning off an accessibility service
Bug: 146539308
Test: make RunSettingsRoboTests2
Change-Id: Ic572f9245db016bd79a272030f97004a21f4b672
2020-02-03 19:17:34 +08:00
menghanli
8e881181a8 Fix "Cannot get activity context when service off".
1. Unify getPrefContext() usage in Accessibility Settings
2. Correct the dialog emuns order

Test: local test
Change-Id: Idc51f7b15b5813bbae7b32e1ae3c7f00c71cea50
2020-02-03 07:13:31 +00:00
menghanli
b82931520f Support accessibility shortcut secondary action (11/n)
Refactor current shortcut design to base fragment and provide
protected function to customize the legacy design,
magnification or no need shortcut app.

Bug: 142530063
Bug: 142531156
Test: make RunSettingsRoboTests2

Change-Id: I51c951ef8f819a1940ddfe33b009b40ed5ec0530
2020-02-02 10:51:44 +08:00
Menghan Li
8003ea4c4c Merge "Support accessibility shortcut secondary action (10/n)" 2020-01-21 10:55:53 +00:00
menghanli
b010a9f9fd Remove select-to-speak toogle button from Vision Settings.
Integrate with shortcut design to to make the UI of Select to
Speak consistent in SUW and general Accessibility settings.

Bug: 148042379
Test: local test
Change-Id: I53fdac604e717303fef9526230b20e9901d55915
2020-01-21 09:08:12 +00:00
menghanli
bf46032074 Support accessibility shortcut secondary action (10/n)
Integrate with Talkback enabled and change the behavior as below:
1. Show 3-finger swipe up from bottom summary
2. Show 3-finger icons for edit shortcut dialog
3. Dismiss the running the edit shortcut dialog

Bug: 142530063
Bug: 142531156
Bug: 147989432
Test: make RunSettingsRoboTests2
Change-Id: I2f34b8eebfdc5a385d72402e95a8b1d0bde4a428
2020-01-21 15:58:43 +08:00
menghanli
c53e60fb80 Remove magnification settings screen from Vision Settings.
Bug: 147468783
Test: local test
Change-Id: I39f8de5d4bc4feaf0f913c07fb802b350f969125
2020-01-20 14:01:21 +00:00
Menghan Li
9fbf51d450 Merge "Support accessibility shortcut secondary action (9/n)" 2020-01-20 13:51:13 +00:00
menghanli
756d819c42 Color correction improvement (5/n)
"Use Color correction" should be replaced by "Correct colors"

Bug: 145968068
Bug: 147988288
Test: make RunSettingsRoboTests2
Change-Id: I90ef36a99b34a82eb9f29f8b79d9aaa8d56441d1
2020-01-20 14:29:30 +08:00
menghanli
87147f55f0 Support accessibility shortcut secondary action (9/n)
Reorder layout and add title for each category block.

Bug: 142530063
Bug: 142531156
Test: make RunSettingsRoboTests2
Change-Id: I0f4067aaf9c42c3ce065eebd0e75ad4153f7e9dc
2020-01-18 00:24:20 +08:00
Menghan Li
8e3ea9d1cf Merge "Talkback shouldn't speak action for description." 2020-01-17 16:10:29 +00:00
Menghan Li
fa240f6cfc Merge "Support autoclick secondary action (1/n)" 2020-01-17 14:13:47 +00:00
ChenJean
7afc1fa6fb Support autoclick secondary action (1/n)
Added radio button preference and control to handle user update value.

Bug: 146019277
Test: Manual
Change-Id: Ie9136f942eec43fc378e7f39d8c2eb7534c531c9
2020-01-17 10:31:07 +00:00
menghanli
097472fc4a Talkback shouldn't speak action for description.
Fix for Select-To-Speak, Talkback, and Magify app.

Bug: 147793421
Bug: 147709365
Bug: 147708796
Test: Manual test
Change-Id: Id7b62c96df869cbd35f2ffbb442b0a4eb7e0393d
2020-01-17 16:10:21 +08:00
TreeHugger Robot
4a70204f51 Merge "Accessibility shortcut secondary action - fix permission dialog did not pop up" 2020-01-17 07:44:02 +00:00
TreeHugger Robot
846f739465 Merge "Support accessibility shortcut secondary action (8/n)" 2020-01-17 01:10:53 +00:00
Menghan Li
f70d04ea0a Merge "Create palette preview for color correction (2/n)." 2020-01-16 15:12:26 +00:00
menghanli
5d0f336fec Support accessibility shortcut secondary action (8/n)
Integrate with the multiple shortcut selections and change the behavior as below:
- Get the shortcut type from system provider or shared_prefs if this is first time to use.
- Update the shared_prefs for what user seen.

Bug: 142530063
Bug: 142531156
Test: make RunSettingsRoboTests2
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AccessibilityUtilTest
Change-Id: I58aeb960e2c4aa0bc2432be34c1372c0de89117a
2020-01-16 22:57:11 +08:00
TreeHugger Robot
bc6bd74228 Merge "Color correction improvement (4/n)" 2020-01-16 14:24:46 +00:00
TreeHugger Robot
7fd5b23da4 Merge "Accessibility shortcut secondary action - fix magnification triple tap logic" 2020-01-16 14:22:55 +00:00
jasonwshsu
c602ceb5ea Accessibility shortcut secondary action - fix permission dialog did not pop up
- Need to set EXTRA_CHECKED after shortcutPreference's checkbox is unchecked

Bug: 142530063
Test: manual
Change-Id: I7f1ea5a9d4b12ac958ac8a074cf7a267faddb4ad
2020-01-16 21:18:21 +08:00
TreeHugger Robot
244afa02d2 Merge "Revert "Settings search - Navigate user to exact page"" 2020-01-16 13:06:24 +00:00
jasonwshsu
620aec5f8c Accessibility shortcut secondary action - fix magnification triple tap logic
- triple tap in settings is boolean status, not string.

Bug: 142530063
Test: make RunSettingsRoboTests -j52 ROBOTEST_FILTER=ToggleScreenMagnificationPreferenceFragmentTest
Change-Id: Ieec9879f7ef55b694245c6f9143575ba933855e5
2020-01-16 18:21:48 +08:00
menghanli
35931974eb Create palette preview for color correction (2/n).
Limit the preview measure for one time to avoid unnecessary
measure and draw performance.

Bug: 145968068
Test: make RunSettingsRoboTests ROBOTEST_FILTER=PaletteListViewTest
Test: make RunSettingsRoboTests2
Change-Id: Ib8ea13e511351c71babcbd1376817cea3a47cac4
2020-01-16 17:55:52 +08:00
Edgar Wang
e19ee9a01f Revert "Settings search - Navigate user to exact page"
This reverts commit 08f2a58459.

Reason for revert: design changed, we decide to take the user to
the entry after clicking on a search result.
It's opposite with what we did, so we revert related CL first.

Test: robotest

Change-Id: Iadb9a94a7ef7838be34a54499e2d934d6396c336
2020-01-16 14:07:38 +08:00
menghanli
cb718d7d25 Color correction improvement (4/n)
Integrate with the multiple shortcut selections and change the behavior as below:
- Register a setting content observer to monitor the service on/off
status to update switch toggle UI.

Bug: 145968068
Test: make RunSettingsRoboTests2
Change-Id: Ib195aab720d965a7a3047070999783fe9525bfd9
2020-01-16 10:35:42 +08:00
jasonwshsu
4605005374 Accessibility shortcut secondary action - correct invisible type fragment checkbox logic
- checkbox logic need to follow shortcutPreference checked status

Bug: 142530063
Test: manual
Change-Id: Ibc079f116c16b6e1c32b573de693b4a23388858c
2020-01-15 20:29:23 +08:00
Minche Li
8b1bf8a477 Merge "Create settings for window magnification (3/n)" 2020-01-15 11:00:04 +00:00
mincheli
5b59e62ecb Create settings for window magnification (3/n)
This change is for internal test.
Add a switch preference for magnification enable mode.

Bug: 146019459
Bug: 146473544
Test: make RunSettingsRoboTests ROBOTEST_FILTER=MagnificationEnablePreferenceControllerTest -j64
Change-Id: I85fdbb5b0efc106d5301d95802b8d6b7dbe8145d
2020-01-15 16:11:38 +08:00
jasonwshsu
64426cc868 Accessibility shortcut secondary action - correct magnification shortcut logic
- correct magnification shortcut logic
- add magnification tests

Bug: 142530063
Test: make RunSettingsRoboTests -j52 ROBOTEST_FILTER=ToggleScreenMagnificationPreferenceFragmentTest
Change-Id: I15f8bccde63570e93e28399bc1730fb1afdb1242
2020-01-15 15:15:38 +08:00
Jason Hsu
d53cbefcc0 Merge "Accessibility shortcut secondary action - handle all preferred shortcut type key" 2020-01-14 05:53:38 +00:00
Jason Hsu
d5095abc91 Merge "Accessibility shortcut secondary action - legacy type fragment only have hardware shortcut" 2020-01-14 05:53:19 +00:00
Jason Hsu
d8e3fbc5f7 Merge "Accessibility shortcut secondary action - Settings view status link with checkbox" 2020-01-14 04:30:10 +00:00
jasonwshsu
fb576356aa Accessibility shortcut secondary action - handle all preferred shortcut type key
- save and restore all preferredShortcutType: SOFTWARE, HARDWARE, TRIPLETAP

Bug: 142530063
Test: manual
Change-Id: I7dd714d1516f49e89c42822241f9cb2b41ae2d2e
2020-01-14 12:15:14 +08:00
Jason Hsu
fd17fcbf11 Merge "Accessibility shortcut secondary action - Invisible type fragment need to handle AccessibilityServiceState" 2020-01-14 02:46:46 +00:00
jasonwshsu
802fad998e Accessibility shortcut secondary action - legacy type fragment only have hardware shortcut
- LegacyAccessibilityServicePreferenceFragment only allowed hardware shortcut, software shortcut appear is controlled by flagRequestAccessibilityButton

Bug: 142530063
Test: manual
Change-Id: I90c7246c83b5525613e22ff5f0ad03295288c53d
2020-01-13 16:28:50 +08:00
jasonwshsu
5469cffa58 Accessibility shortcut secondary action - Invisible type fragment need to handle AccessibilityServiceState
- InvisibleToggleAccessibilityServicePreferenceFragment need to set
AccessibilityServiceState according to ShortcutPreference checkbox's stauts.

Bug: 142530063
Test: manual
Change-Id: I9ff21b66ebf72a51e62a958e3e391624c7925c27
2020-01-13 15:22:50 +08:00
jasonwshsu
5fd157b404 Accessibility shortcut secondary action - Settings view status link with checkbox
Lets settings view auto enabled by checkbox click status.

Bug: 142530063
Test: make -j52 RunSettingsRoboTests ROBOTEST_FILTER=ShortcutPreferenceTest
Change-Id: I588d2ada85ae1169f439db9c6ce254c20119b2e5
2020-01-13 15:05:47 +08:00
Menghan Li
7ad9008ce9 Merge "Support accessibility shortcut secondary action (7/n)" 2020-01-13 06:13:10 +00:00
menghanli
334dc4f20b Support accessibility shortcut secondary action (7/n)
Implements sharedPreference to keep the user preferred shortcut for each
service.

Bug: 142530063
Bug: 142531156
Test: make RunSettingsRoboTests ROBOTEST_FILTER=ToggleFeaturePreferenceFragmentTest
Test: make RunSettingsRoboTests2
Change-Id: I2a7c54ddc32764f6d88f2efed87982d469acc183
2020-01-13 12:34:04 +08:00
Jean Chen
4ae8991222 Merge "Support caption second UI structure (3/n)" 2020-01-13 02:24:01 +00:00
Kevin Chang
ca149c7d04 Merge "Modify the code logic of OnLayoutChangeListener in Caption preferences" 2020-01-13 02:00:14 +00:00
Tsung-Mao Fang
7f5986b78a Add a RTT setting in A11y screen
- Add RTT setting in Accessibility screen.
- Create a controller for RTT setting preference.
- Create an array strings.

Test: Rebuild, and visual
Change-Id: I248654c822284473b8a8265de4a3938af89cdf7a
Fix: 146540478
2020-01-09 16:43:34 +08:00
ChenJean
2c37f45a35 Support caption second UI structure (3/n)
Removed unenable behovior when turn off Show captions.

Bug: 143502915
Test: Manual
Change-Id: Idb59172967872f4c8ba76e6cdcb83ba0a7faeadd
2020-01-09 14:45:54 +08:00
Kevin Chang
8416d8efd7 Modify the code logic of OnLayoutChangeListener in Caption preferences
Remove the listener and add statement to refresh the text when the caption turns on.

Bug: 142632389
Test: Manual
Change-Id: Ic5711309c5b8af9834e5439d825b4cb2ed55fe01
2020-01-08 18:44:58 +08:00
Menghan Li
65a0488e1b Merge "Maginfy Improvement" 2020-01-08 07:30:38 +00:00
menghanli
f3eb2de691 Maginfy Improvement
Implements the magnify new accessbility settings UI,
including the setupwizard and a11y settings

Bug: 146019459
Test: make RunSettingsRoboTests2
Change-Id: If11849a539c7841e2db495b63132e6d02b7285c0
2020-01-07 20:28:22 +08:00
PETER LIANG
69a9f26c7c Merge "Accessibility scary dialog for android R changed." 2020-01-07 11:56:16 +00:00
Peter_Liang
ec2fa7e872 Accessibility scary dialog for android R changed.
Show scary dialog only once when toggle shortcut preference and use
  service.

Fix: b/142532185
Test: manual test
Change-Id: Ic36fdd5eec8ec20ead79ce47cd5e5e19d2ef5768
2020-01-07 11:54:27 +00:00
Jasper Chang
875727c2ab Merge "Create palette preview for color correction." 2020-01-07 03:20:54 +00:00