Commit Graph

456 Commits

Author SHA1 Message Date
James.cf Lin
64ac0d4a74 [Settings] "Data during calls" in DDS SUB is still in advanced option.
The DataDuringCallsPreferenceController didn't listen the mobile data changed and update the preference.

Bug: 149344454
Test: make RunSettingsRoboTests ROBOTEST_FILTER=DataDuringCallsPreferenceControllerTest

Change-Id: I0121f06efb5257dccc05ad06b93a9db263f012b5
2020-02-27 17:52:47 +08:00
Bonian Chen
66a301bb12 Merge "[Settings] Replace isVolteEnabledByPlatform" 2020-02-19 01:17:31 +00:00
Lee Chou
5a65e2d5dd Authenticated confirmation before deletion of eSim
adds an authentication confirmation before deleting an eSim
this feature is turned on/off in the security page

Bug: 138861284
Test: mp settingsg
Change-Id: I32e0e3bff2091ec1097b3c37fa066d966e3373df
2020-02-18 11:33:22 +08:00
Zhen Zhang
370653a24b Merge "Update summary for AllInOneTetherPreference accordingly" 2020-02-17 05:50:55 +00:00
Bonian Chen
1716548685 [Settings] Replace isVolteEnabledByPlatform
Replace ImsManager#isVolteEnabledByPlatform() by ImsMmTelManager#isSupport().

Bug: 140542283
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gBasePreferenceControllerTest
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gLteSliceHelperTest
Change-Id: I656a00ad2c6120255e53d0b836945462258e01bb
2020-02-15 15:19:49 +08:00
Bonian Chen
64595f18d7 Merge "[Settings] Code refactor for IMS part" 2020-02-14 13:35:03 +00:00
Bonian Chen
4074e9aab7 [Settings] Code refactor for IMS part
Return boolean in method names starting with "is".

Bug: 140542283
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gBasePreferenceControllerTest
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gLteSliceHelperTest
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=VideoCallingPreferenceControllerTest
Change-Id: I2a9ca9ae829f0dcda478f3343cd50e61f441a9a7
2020-02-14 16:29:11 +08:00
Zhen Zhang
c2b9e5ef20 Update summary for AllInOneTetherPreference accordingly
The summary for AllInOneTetherPreference in NetworkDashboardFragment is
updated according to tethering state and tether interface chosen by
user.

Bug: 149256198
Test: AllInOneTetherPreferenceControllerTest, TetherEnablerTest,
CodeInspectionTest

Change-Id: I24ba4deabbb02b203e76d32048040d7ccf1b2d22
2020-02-14 00:14:23 -08:00
Zhen Zhang
31f1a34629 Add a Preference into "Network & internet" for new tethering UI
Adding a MasterSwitchPreference into "Network & internet" and create
corresponding controller. The preference is hidden by the feature flag.
It does NOT affect the existing UI.

Bug: 146147778
Test: CodeInspectionTest, TetherPreferenceControllerTest,
NetworkDashboardFragmentTest
Change-Id: Ida8e088efbb22d0c983acecbc420672206392dad
2020-02-12 23:55:02 -08:00
Bonian Chen
cf19596829 Merge "[Settings] Data roaming warning only when turn ON" 2020-02-12 06:14:20 +00:00
Zhen Zhang
2d7264eb75 Merge "Add tether preferences into AllInOneTetherSettings" 2020-02-11 23:34:55 +00:00
Bonian Chen
19135546a3 [Settings] Data roaming warning only when turn ON
handlePreferenceTreeClick() goes after setChecked() however
configuration may have been altered within setChecked().

Follow same design within MobileDataPreferenceController to fix this
issue. A boolean state will be maintained as the condition when warning
dialog is required when click.

Bug: 148491064
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=RoamingPreferenceControllerTest
Change-Id: I63c4e2149b0e9efa16fd9ee402652c67eb9c5a4d
2020-02-11 20:46:44 +08:00
Zhen Zhang
ec966cb7a3 Add tether preferences into AllInOneTetherSettings
These preferences are for user to toggle a specific tethering option,
like USB, BT or WIFI.

Bug: 147323306
Test: CodeInspectionTest, AllInOneTetherSettingsTest, TetherEnablerTest
Change-Id: I1229ffd2dd12b39e9c6e48dc29c6e46ce9ad7634
2020-02-10 23:04:37 -08:00
Bonian Chen
ae405030f7 Merge "[Settings] Apply ImsQueryProvisioningStat to WFC" 2020-02-07 06:49:16 +00:00
TreeHugger Robot
07d9557b29 Merge "Make tether preference controllers extend BasePreferenceController" 2020-02-06 06:56:21 +00:00
TreeHugger Robot
3de4dc273c Merge "Remove oneSelectableTwoDisabledPSimsOneAbsent_twoResults" 2020-02-05 22:18:25 +00:00
Malcolm Chen
dc1dd56b41 Remove oneSelectableTwoDisabledPSimsOneAbsent_twoResults
It's not needed as logic of detecting disabled pSIM is moved to
Telephony.

Bug: 147791865
Test: sanity
Change-Id: I158243bcf59e6c39fb55421632e7013ebc80ae80
2020-02-05 20:13:29 +00:00
Zhen Zhang
258fb7f672 Make tether preference controllers extend BasePreferenceController
These controllers extended AbstractPreferenceController, which is not
quite compatible with some of the present framework. Especially for
indexable keys of settings search.

TetherEnabler and AllInOneTetherSettings are refactored based on the
change. Tests are updated.

Bug: 147272749
Test: CodeInspectionTest and other tests of classes touched by this CL
Change-Id: Ic3ad13e735d133c0959a0a309319a6fd5165b015
2020-02-05 10:18:57 -08:00
Florian Mayer
32b25ec7b0 Merge "Revert "[Settings] Avoid rename inactive subscription from NullPointerException"" 2020-02-05 11:11:29 +00:00
Florian Mayer
18b1a84e9c Revert "[Settings] Avoid rename inactive subscription from NullPointerException"
This reverts commit 1b71b5e601.

Bug: 148924129

Reason for revert: Broke tests

Change-Id: I27da954a105bb28f3f8c5f18961073a59c4d820f
2020-02-05 11:10:29 +00:00
Bonian Chen
a8f14cb11e [Settings] Apply ImsQueryProvisioningStat to WFC
1. Code refactor
2. Apply ImsQueryProvisioningStat class to WFC's use case

Bug: 140542283
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingPreferenceControllerTest
Change-Id: I8a09264f83b9fc4fce3f79ec3aeb6ae757b004e4
2020-02-05 16:55:17 +08:00
Bonian Chen
8821654a91 Merge "[Settings] Apply ImsQueryProvisioningStat to VoLTE" 2020-02-05 08:49:05 +00:00
Bonian Chen
19b232f73e [Settings] Apply ImsQueryProvisioningStat to VoLTE
1. Code refactor
2. Apply ImsQueryProvisioningStat class to VoLTE's use case

Bug: 140542283
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gBasePreferenceControllerTest
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gLteSliceHelperTest
Change-Id: Ie5a56e9b768b9abe88c635e4e5532d72c9ddd1a2
2020-02-05 14:12:23 +08:00
Bonian Chen
1768669a4c [Settings] Test case failure - RenameMobileNetworkDialogFragmentTest
Ignore test case to avoid from blocking others

Bug: 148907677
Test: build pass
Change-Id: I99101acfc62f8cd247d1a727936638a0ba18cf70
2020-02-05 12:32:19 +08:00
Bonian Chen
2d29e935f7 Merge "[Settings] Add ImsQueryProvisioningStat for VT" 2020-02-04 12:18:49 +00:00
Bonian Chen
2cf0ba57f8 Merge "[Settings] Avoid rename inactive subscription from NullPointerException" 2020-02-04 10:04:18 +00:00
Bonian Chen
1b71b5e601 [Settings] Avoid rename inactive subscription from NullPointerException
1. Init instance before accessing it
2. Re-enable test case

Bug: 147321836
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=RenameMobileNetworkDialogFragmentTest
Change-Id: Ifc245bec739b4c81d2cee04b091bcdb54d567d4a
2020-02-04 10:47:33 +08:00
Bonian Chen
319cc7bc1c [Settings] Add ImsQueryProvisioningStat for VT
1. Code refactor
2. Add ImsQueryProvisioningStat class for VT's use case

Bug: 140542283
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=VideoCallingPreferenceControllerTest
Change-Id: I40ec5df00d02e71cb8ae78d4f81c71c5e354515a
2020-02-03 14:26:11 +08:00
SongFerngWang
5189dc3860 Mainline remove hide api SubscriptionInfo.getCardString
Bug: 147128878
Test: build pass
Change-Id: Idb44af6a01626013339f5ca05486dd11112a5867
2020-01-31 18:48:09 +08:00
Bonian Chen
5fcb8ee011 [Settings] Support default value for APN protocol
Add default value on APN (roaming) protocol based on configuration when user leave it empty during editing APN.

Bug: 142440775
Test: manual
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=ApnEditorTest
Change-Id: I3f1ca0ef17ceaaf2a94b21b6034cd74e56081b61
2020-01-23 03:38:29 +08:00
Josh Hou
b942769c2a Merge "Show/hide 5G preferred network type also consider allowed_network_type" 2020-01-22 01:27:51 +00:00
Josh Hou
0393bbcc85 Show/hide 5G preferred network type also consider allowed_network_type
1. The carrier or privileged apps will enable/disable network types on
the device, so Settings references the allowed network type to show/hide
5G preferred network type option.

2. For mainline, copy the getNetworkTypeFromRaf() from RadioFamily to
Settings.

Bug: 136730709
Test: Manual test & EnabledNetworkModePreferenceControllerTest
1. Enable allowed_network_type
2. Disable allowed_network_type
Change-Id: I493f2a2c7f4bc32b3fcb8ab2bace5839d8667bd5
2020-01-21 14:34:51 +00:00
Bonian Chen
4482de98ed Merge "[Settings] add VtQueryImsState for IMS" 2020-01-21 13:30:00 +00:00
Bonian Chen
16b9b8fac8 Merge "[Settings] add VolteQueryImsState for IMS" 2020-01-21 12:45:43 +00:00
Bonian Chen
1407d80f4c [Settings] add VtQueryImsState for IMS
1. Code refactor
2. Introduce VtQueryImsState and VolteQueryImsState for user enable/disable configuration

Bug: 140542283
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=VideoCallingPreferenceControllerTest
Change-Id: I72ec009a8808875fef144a24486b94ef4a7fd35c
2020-01-21 20:10:47 +08:00
Bonian Chen
bd9a04ceea [Settings] add VolteQueryImsState for IMS
1. Code refactor
2. Introduce VolteQueryImsState for user enable/disable configuration

Bug: 140542283
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gBasePreferenceControllerTest
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gLteSliceHelperTest
Change-Id: I9c18c8900ac01909030d9433935650c1581a0fb0
2020-01-21 19:39:29 +08:00
Bonian Chen
21f86f9f4d Merge "[Settings] add WifiCallingQueryImsState for IMS" 2020-01-21 11:25:12 +00:00
Bonian Chen
f63c6f9e4b [Settings] add WifiCallingQueryImsState for IMS
1. Code refactor
2. Introduce WifiCallingQueryImsState for user enable/disable configuration

Bug: 140542283
Test: m RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingPreferenceControllerTest
Change-Id: Ib337d6418fcc89f81b15b8cb464d03dccc583756
2020-01-21 17:02:01 +08:00
changbetty
e30517f9a5 [Mainline] Copy the method getSelectableSubscriptionInfoList from SubscriptionManager to Settings
Bug: 147206736
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=SubscriptionUtilTest
      make RunSettingsRoboTests -j ROBOTEST_FILTER=MobileDataSliceTest

Change-Id: I6d7e72a656723c0620d579e1e223945e2a3588af
2020-01-21 14:05:14 +08:00
Rajeev Kumar
840db3034a Merge "Use TetherEnabler in AllInOneTetherSettings to manage master switch" 2020-01-20 05:37:16 +00:00
Zhen Zhang
02dfed6846 Use TetherEnabler in AllInOneTetherSettings to manage master switch
In AllInOneTetherSettings, we use TetherEnabler to hanle all behavior
related to tethering switch on/off.
In TetherEnbler, add WifiManager.WIFI_AP_STATE_CHANGED_ACTION to cover
all possible tethering state change.
TetherEnablerTest is modified accordingly.

Bug: 147322704
Test: make RunSettingsRoboTests ROBOTEST_FILTER=CodeInspectionTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=TetherEnablerTest
Test: make RunSettingsRoboTests
ROBOTEST_FILTER=AllInOneTetherSettingsTest

Change-Id: I505b3825f79260983fff9d3935ba834ad8f9f690
2020-01-17 11:11:30 -08:00
Sarah Chin
de616afce0 Rename references to getLteOnCdmaMode
Use @SystemApi TelephonyManager#isGlobalModeEnabled()

Test: build
Bug: 147335742
Change-Id: Ie1b01a97cf163d68e4a5529f1718a9a782d44bb0
2020-01-16 12:38:59 -08:00
Lee Chou
ee4ffce3aa Ignoring SubscriptionUtilTest [Settings]
Changes in the framework ag/10100601 broke this test, ignoring for now

Bug: 147791865
Test: m RunSettingsRoboTests
Change-Id: If2568154c5a767baebf51f95956f499b748a55bd
2020-01-16 18:13:24 +08:00
Lee Chou
0d6e26a9b8 Merge "removed Network Operator Preference Test" 2020-01-16 08:19:17 +00:00
Lee Chou
80e89e1995 removed Network Operator Preference Test
the legacy UI was removed in ag/10050039
this commit removes the corresponding test file

Bug: 147784139
Test: m RunSettingsRoboTests
Change-Id: I2200fa407fe0e807338eb5da01a60c70016170a1
2020-01-16 13:57:40 +08:00
Xiangyu/Malcolm Chen
69a7e054f5 Merge "Remove logic to manually search inactive pSIM." 2020-01-16 04:24:34 +00:00
Malcolm Chen
640e56433f Remove logic to manually search inactive pSIM.
Nowe inserted inactive pSIM will be included in Telephony's get
available and get selectable subInfo list so that logic is no longer
needed.

Bug: 147128878
Test: unittest
Change-Id: Icd131f133e47dae0770a4da71c51de3c2a94b42b
2020-01-15 14:58:07 -08:00
SongFerng Wang
92e7009d8b Merge "Mainline: removed legacy UI for network selection mode." 2020-01-15 10:12:22 +00:00
Tsung-Mao Fang
d9ca17c315 Merge "Ignore failed test cases" 2020-01-15 01:35:27 +00:00
Tsung-Mao Fang
b45c47d42d Ignore failed test cases
Test: run robotest
Bug: 14746840
Change-Id: I28b8013512b93bb64aa6dfed7c4181f19e8c3cd7
2020-01-15 09:26:24 +08:00