Commit Graph

143757 Commits

Author SHA1 Message Date
Bill Yi
3c4b5e80c0 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import

Bug: 369418613
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d699a865846e7bd329f150e68b15b1e24108ae49)
Merged-In: I5c23ee62acecedef00383545188882d1694d8a8a
Change-Id: I5c23ee62acecedef00383545188882d1694d8a8a
2024-10-04 22:51:37 +00:00
Android Build Coastguard Worker
b88b8764e6 Merge cherrypicks of ['googleplex-android-review.googlesource.com/29590947'] into 24Q4-release.
Change-Id: Iae17a95aabc1bbeea4eedd04f7ffa70c0d31620e
2024-09-30 17:32:46 +00:00
Chaohui Wang
e9964f3c1f Fix Can't Able to Click Sims
The root cause is SubscriptionManager.OnSubscriptionsChangedListener
.onSubscriptionsChanged() not invoked in some cases.

Even the SubscriptionManager.addOnSubscriptionsChangedListener's doc
says the onSubscriptionsChanged() method will also be invoked once
initially when calling it, there still case that the
onSubscriptionsChanged() method is not invoked initially.
For example, when the onSubscriptionsChanged event never happens before,
on a device never ever has any subscriptions.

Adding a .onStart { emit(Unit) } to fix.

Also make the subscriptionsChangedFlow() a shared flow to mitigate the
extra emit cost.

Bug: 369276595
Flag: EXEMPT bug fix
Test: manual - factory reset & no any sim
Test: atest SubscriptionRepositoryTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:9969334647b4b9439f549c0c0b2543fb3dec8813)
Merged-In: Ic32a5666f14373926b5dfedb5dedadb4369acfc7
Change-Id: Ic32a5666f14373926b5dfedb5dedadb4369acfc7
2024-09-30 17:31:39 +00:00
Treehugger Robot
2c3fbda054 Merge "Add a check to ensure that intent data is available before proceeding." into main am: 9a0ba22e79
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3278732

Change-Id: I9964a5759041f686bfe905e10e013ff663c666b3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-27 10:13:07 +00:00
Treehugger Robot
9a0ba22e79 Merge "Add a check to ensure that intent data is available before proceeding." into main 2024-09-27 09:54:21 +00:00
Treehugger Robot
5c3c9cbdeb Merge "Use hasScrollAction in ApnEditPageProviderTest" into main am: 12f2e1cf4f
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3283218

Change-Id: I1d66aa2b883c0b8d6375b99b23fda25535820c01
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-26 11:13:22 +00:00
Treehugger Robot
12f2e1cf4f Merge "Use hasScrollAction in ApnEditPageProviderTest" into main 2024-09-26 10:54:50 +00:00
Treehugger Robot
840f5a573d Merge "Protect the Settings application from potential null pointer exceptions." into main am: 6a4fb45e38
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3282054

Change-Id: I1c6daaf44b7be4aeaa65fce50711d7e75f511e6c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-09-26 10:47:30 +00:00
Treehugger Robot
6a4fb45e38 Merge "Protect the Settings application from potential null pointer exceptions." into main 2024-09-26 10:30:43 +00:00
Chaohui Wang
bb1cadb916 Use hasScrollAction in ApnEditPageProviderTest
Instead of assuming a fixed tree structure in testing.

Fix: 369416630
Flag: EXEMPT gradle only
Test: atest ApnEditPageProviderTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:0b530fd405eb95dfedf51bc55bc24bd7d446ead8)
Merged-In: I0a50e7665d9049e089b5a0877f17d1f736ee3332
Change-Id: I0a50e7665d9049e089b5a0877f17d1f736ee3332
2024-09-26 10:20:38 +00:00
Abdelrahman Daim
996afd17a1 Protect the Settings application from potential null pointer exceptions.
Summary: The app bar is not available, causing a null pointer exception.

Test: Successful Build on master branch

Change-Id: I36849606f6587d6e7f004ae21e1a6e6a5206735a
Signed-off-by: Abdelrahman Daim <adaim@meta.com>
2024-09-25 17:02:37 -07:00
Abdelrahman Daim
3be2314fac Add a check to ensure that intent data is available before proceeding.
Summary: There are instances where intent data is absent, leading to a crash while trying to retrieve the schema. This change adds a null check to prevent attempted access when there's no data.

Test: Successful Build on master branch

Change-Id: Ie83bd3243f2c79102061d3fa43d809b3ef3c6c78
Signed-off-by: Abdelrahman Daim <adaim@meta.com>
2024-09-24 12:21:22 -07:00
Android Build Coastguard Worker
12db316e9d Snap for 12406339 from 658459de9b to 24Q4-release
Change-Id: I01b270ceb3f0850e5043a7401701c117a8766843
2024-09-24 17:55:15 +00:00
Treehugger Robot
658459de9b Merge "Fix for broken tests in Accessibility Settings" into main 2024-09-24 02:58:07 +00:00
Riley Jones
62449dd61b Fix for broken tests in Accessibility Settings
Updates tests that were broken by the rollout of the standalone_a11y_gesture_enabled flag

Test: atest com.android.settings.accessibility
Bug: 368704597
Flag: android.provider.a11y_standalone_gesture_enabled
Change-Id: Ie90e7495dd4a134538bae6e3e08eea0d02134b14
2024-09-23 23:24:25 +00:00
Android Build Coastguard Worker
2ab50ea80a Snap for 12404440 from 9cdd1108c3 to 24Q4-release
Change-Id: Iaf43ac3fd61ffff035ebf51289ef758f4ca42b47
2024-09-23 23:22:59 +00:00
Maryam Dehaini
6a6a3efe57 Merge "Change "Open by default" setting page selection to radio buttons" into main 2024-09-23 22:45:07 +00:00
Maryam Dehaini
11825b0bc7 Change "Open by default" setting page selection to radio buttons
Selection to open page in app or browser needs to be displayed via radio
buttons as discussed here: http://b/346622495#comment14

Bug: 359262490
Test: Open links in app and browser
Flag: EXEMPT small UI change
Change-Id: Ib23084bcc7f899b97b59019775584807e5b70d7e
2024-09-23 14:32:08 -07:00
Jacky Wang
9cdd1108c3 Merge changes from topic "catalyst-firmware-version" into main
* changes:
  Migrate "Build number" preference
  Migrate "Kernel version" preference
  Migrate "Baseband version" preference
2024-09-23 15:44:09 +00:00
Adam Bookatz
072d0d84ec Merge "OnDeviceRecognition shows only profile group" into main 2024-09-23 15:41:41 +00:00
Zoey Chen
bedfb69f67 Merge "[Settings] Fix crash" into main 2024-09-23 13:02:59 +00:00
Matías Hernández
a78f2b834c Merge "Don't add the "Events" mode anymore, and delete it if disabled" into main 2024-09-23 12:49:05 +00:00
SongFerng Wang
d514d15590 Merge "remove the DSDS dialog" into main 2024-09-23 12:37:01 +00:00
Zoey Chen
bc3f736162 [Settings] Fix crash
Bug: 366361808
Change-Id: I3f804685e215ed07b71a5efd51c9da9c5b978279
Test: manual
Flag: EXEMPT bugfix
2024-09-23 11:16:36 +00:00
songferngwang
6960464557 remove the DSDS dialog
If the sim onboarding on, then sim should use the sim onboarding flow.

Bug: 362289792
Test: manual test
Flag: EXEMPT bugfix
Change-Id: Ibe22309db9dea5737de5ad351825a046599e6744
2024-09-23 10:42:36 +00:00
Yiyi Shen
7a91f6e7bf Merge "Rename AudioSharingRetryDialogFragment" into main 2024-09-23 10:03:55 +00:00
Yiyi Shen
676ddc7e95 Merge "Rename AudioSharingLoadingStateDialogFragment and layout" into main 2024-09-23 09:17:49 +00:00
Jacky Wang
9cbb04c5e0 Migrate "Build number" preference
Bug: 365886251
Flag: com.android.settings.flags.catalyst_firmware_version
Test: Unit
Change-Id: Iee68b5414713118ad3d1b9b3ec04437729bb2d0b
2024-09-23 16:43:34 +08:00
Jacky Wang
fb349fad1a Migrate "Kernel version" preference
Bug: 365886251
Flag: com.android.settings.flags.catalyst_firmware_version
Test: Unit
Change-Id: Icb50e2d5200f7de40b6f8383c114982cd45d34b5
2024-09-23 16:43:34 +08:00
Jacky Wang
6fe2f89f7c Migrate "Baseband version" preference
Bug: 365886251
Flag: com.android.settings.flags.catalyst_firmware_version
Test: Unit
Change-Id: I8e4f946d01169e8008b8a336d308f5874ee918e6
2024-09-23 16:43:20 +08:00
Yiyi Shen
51fc7a8239 Rename AudioSharingRetryDialogFragment
Test: atest
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Bug: 362858894
Change-Id: I157b036541e9a7b21205ee45437bfd4562c49118
2024-09-23 16:20:48 +08:00
Yiyi Shen
322e153350 Rename AudioSharingLoadingStateDialogFragment and layout
Test: atest
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Bug: 362858894
Change-Id: I05e29b248541511daca355f1bbe4a13b17b4d20d
2024-09-23 15:46:27 +08:00
Chaohui Wang
7d22f66e48 Merge "Check canEnterMobileNetworkPage" into main 2024-09-23 07:03:35 +00:00
Yiyi Shen
de7ab402f9 Merge "[Audiosharing] Show retry dialog when error occurs in start sharing" into main 2024-09-23 06:48:39 +00:00
Tom Hsu
e91214d3c8 Merge "[Satellite] Hide BT switch in Settings search when started Satellite." into main 2024-09-23 05:21:20 +00:00
Chaohui Wang
7e364ed84d Merge "Check DISALLOW_CONFIG_MOBILE_NETWORKS when search" into main 2024-09-23 04:23:26 +00:00
Chaohui Wang
4ded4ac038 Check canEnterMobileNetworkPage
When startSimOnboardingActivity, so we enforce the
no_config_mobile_networks when insert psim.

Fix: 366370519
Flag: EXEMPT bug fix
Test: manual - set no_config_mobile_networks and insert psim
Change-Id: I0d4e85262924cc55a035ebeb2038ae08c0052ef6
2024-09-23 12:09:00 +08:00
Treehugger Robot
1a256c3f72 Merge "Update color-check-baseline.xml" into main 2024-09-23 03:58:58 +00:00
Arun Voddu
2f554f2655 Merge "Changed the token from 'Add satellite messaging' to 'Learn More'." into main 2024-09-23 03:27:46 +00:00
Chaohui Wang
73fb290969 Check DISALLOW_CONFIG_MOBILE_NETWORKS when search
If disallowed, not show mobile related search results.

Bug: 358238959
Flag: EXEMPT bug fix
Test: manual - search Mobile Settings
Test: atest MobileNetworkSettingsSearchIndexTest
Change-Id: I79b984f41f09dd9612bcd0c9942089756d5d365d
2024-09-23 11:17:55 +08:00
Yiyi Shen
302b26ff74 [Audiosharing] Show retry dialog when error occurs in start sharing
Errors including:
1. onBroadcastStartFailed
2. onSourceAddFailed

Test: atest
Flag: com.android.settingslib.flags.enable_le_audio_sharing
Bug: 362858894
Change-Id: I0fe13bd675672c57219d0f6f3e735515a7ed7a06
2024-09-23 11:07:20 +08:00
Jacky Wang
b6a64e9958 Update color-check-baseline.xml
`repo upload --verify` fails on HardCodedColor check and ag/29447250
did not fix the issue.

Bug: 269100659
Flag: EXEMPT lint only
Test: repo upload --verify
Change-Id: Ie5462c0956a436f6dd0d5eb95c7b8ec0d3262321
2024-09-23 11:06:20 +08:00
Treehugger Robot
d1ced23c7f Merge "Support customized summary in Channel Notification" into main 2024-09-23 00:10:43 +00:00
arunvoddu
a604a6cee8 Changed the token from 'Add satellite messaging' to 'Learn More'.
Flag: EXEMPT bugfix
Bug: 367377460
Test: Verified the UI Manually
Change-Id: Ieba6dc32dbedaea98fe39a8bb081f3562d8eeb6e
2024-09-22 15:57:47 +00:00
Android Build Coastguard Worker
a5a9fdafed Snap for 12399051 from 6faf7da877 to 24Q4-release
Change-Id: I63e0504ac16a1fa65e2ade7d7e7a5acc15c2657f
2024-09-21 21:21:42 +00:00
Android Build Coastguard Worker
7c48741fe6 Snap for 12397640 from a0e1262ecd to 24Q4-release
Change-Id: Ie65d770b154b85ebf0d40c6000b7fbc3ccefbb1c
2024-09-21 01:21:39 +00:00
Dongzhuo Zhang
6faf7da877 Merge "Add aconfig flag on contacts default account settings in the app settings page." into main 2024-09-20 23:03:30 +00:00
Dongzhuo Zhang
c047d1f275 Add aconfig flag on contacts default account settings in the app
settings page.

Test: m
Bug: 368126293
Flag: com.android.settings.flags.enable_contacts_default_account_settings
Change-Id: Id03fd406b4ee096ba0d08fe1f8f93e540b611f08
2024-09-20 21:48:10 +00:00
Adam Bookatz
f528660602 OnDeviceRecognition shows only profile group
Currently, if there are multiple users on the device, then the Settings
for OnDeviceRecognition show a chooser for all users on the device, with
only the users from the same profile group as the current user working.
It shouldn't even show the users from other profile groups; we fix that
here.

Bug: 361095700
Test: on a device with multiple users and profiles, made sure that only
users from the same profile group appeared
Flag: EXEMPT bugfix

Change-Id: I139e32a6a2cfede8d8a8abf573dcbaeede789f95
2024-09-20 13:20:17 -07:00
Treehugger Robot
a0e1262ecd Merge "Move identity check strings to framework" into main 2024-09-20 18:12:48 +00:00