Commit Graph

56925 Commits

Author SHA1 Message Date
Arc Wang
1f7d2dc54c [Wi-Fi] Refine code for saved AccessPoints
The change targets to refine SavedAccessPointsPreferenceController and
SubscribedAccessPointsPreferenceController

1. Remove feature flag check for saved Passpoint display.
2. They do not implements WifiManager.ActionListener.
3. Separate the code to collect saved AccessPoints data and the code to
   update preferences.
4. Let getAvailabilityStatus() returns result according to the saved
   AccessPoints data.
5. Update preferences at SavedAccessPointsWifiSettings#onStart()
   instead of life cycle onStart() of these 2 controllers.
   This is for the change of 2.
6. Do not use PreferenceGroupChildrenCache in
   SubscribedAccessPointsPreferenceController, this is for code
   alignment of SavedAccessPointsPreferenceController.
   Now these 2 controllers have very similar design, it will be easier
   to refine SubscribedAccessPointsPreferenceController as a child of
   SavedAccessPointsPreferenceController.

Bug: 127206629
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.wifi.savedaccesspoints
      Manual: Add and forget Wi-Fi accesspoints and observe UI display.

Change-Id: Id6f95d5b64e57a98c2c2e6ab09a4dec70a71b615
2019-10-09 08:56:36 +00:00
hughchen
b717295914 Fix talkback will not speak correct status
Update the UI in advance when user select any option. In this
CL before, the UI update in advance only when user select "USB tethering".

Bug: 141161849
Test: make -j42 RunSettingsRoboTests
Change-Id: I1fa4b20408a00b06d7c8fac6136c63df7406154d
2019-10-09 16:17:26 +08:00
hughchen
f5f167717f Update char limit to 28 for device detail title
Bug: 132684770
Test: manually
Change-Id: I0608b483eab2a8159c51c739e9b4d431a6aaf05a
2019-10-09 15:51:24 +08:00
Arc Wang
ccf9715464 Merge "[A11Y] Improve data usage chart TalkBack content" 2019-10-09 07:17:24 +00:00
govenliu
451bb0a85e [Wi-Fi] [Source] Character limit: Factory Wi‑Fi MAC address and Randomized MAC address, length limit issue
[CHAR LIMIT=30] is too short for translation.

Solution: Extend to 50 characters for both Factory Wi-Fi MAC address (require 40 characters), and Randomized MAC address (require 37 characters).

Bug: 142284108
Bug: 142283151
Test: None, just extend the string length for translation.
Change-Id: I41e99d2cd85ab527a1bd073cab83b4bf61234c98
2019-10-09 07:10:17 +00:00
Bonian Chen
fb8eca412d [a11y] Set "Settings version" as non-double-tap
Disable the selectable configuration on preference
to avoid TalkBack read "double-tap to activate".

Bug: 141588828
Test: Manual test
Change-Id: Icd666792e6d86998d11168b62ab99e3c3412d747
2019-10-09 14:29:26 +08:00
Bonian Chen
7775ec5d23 [Wording] Remove "incur" from roaming strings
Remove "incur" based on suggestion.

Bug: 141630288
Test: Manul test
Change-Id: Ic79abdfca238ef21730b5b941c570cfbffaae487
2019-10-09 12:35:09 +08:00
Arc Wang
351ee3a882 [A11Y] Improve data usage chart TalkBack content
1. Set null content description for all labels of the chart.
2. Set 2 parts in the content description of the chart:
  I.  Brief description of the chart.
  II. Stats of the data usage.

Bug: 141093026
Test: ChartDataUsagePreferenceTest
      Manually listen to TalkBack speaking
Change-Id: I82cefd9987793f40a5bba5bf3ea5f4017da37640
2019-10-09 10:20:15 +08:00
Bonian Chen
c625f62122 Merge "[RadioInfo] Remove from Settings (into Telephony)" 2019-10-08 10:20:34 +00:00
Bonian Chen
b7633cc59d [RadioInfo] Remove from Settings (into Telephony)
Moving RadioInfo and BandMode to Telephony app.

Bug: 123598192
Test: Manual test
Change-Id: Id62a2bf4b2c44efcd48319734d1cab6ed969ee06
2019-10-08 06:49:18 +00:00
Kevin Chang
2205b65637 Merge "Add content description in the tutorial dialog" 2019-10-08 06:09:45 +00:00
Chen Xu
409356c547 Merge "move CellBroadcastMessage from telephony-common to app" 2019-10-08 01:02:49 +00:00
Chen Xu
86a8e9b627 move CellBroadcastMessage from telephony-common to app
1. add slotIndex in SmsCbMesage(cellbroadcast can be received
when sim is absent)
2. move cellbroadcastMessage from telephony-common to app
next step, considering merging CellBroadcast to SmsCbMessage

Bug: 135956699
Bug: 141962867
Test: build & unit test
Change-Id: Iba5e727fc1a1adaf44a7fa1eebfefe34fa8644aa
2019-10-07 11:33:03 -07:00
Julia Reynolds
3ecbafd8fc Allow settings title to wrap
Test: manual
Fixes: 141290268
Change-Id: I4e64b693fa213aca6cab6307c4a9177bfa7d7bdd
2019-10-07 10:42:29 -04:00
Julia Reynolds
4c1bfdfe73 Merge "Handle multi-user in notif log" 2019-10-07 13:15:16 +00:00
Goven Liu
a4ef70fa22 Merge "[Wi-Fi] Un-relevant string flash then disappear in WiFi direct page." 2019-10-07 06:06:47 +00:00
govenliu
623e8570b9 [Wi-Fi] Un-relevant string flash then disappear in WiFi direct page.
The "PEER DEVICES" and "REMEMBERED GROUPS" two strings appear then disappear suddenly.

Solution: Set those two PreferenceGroups, which with empty preference
child, invisible before showing.

Bug: 141830944
Test: 1.Manual test. 2.Modify isAvailable() test case for make sure the
initial visible of empty group is invisible.
Change-Id: Ifb074ac758196096ca63b6f7fa1285f8148d98d4
2019-10-07 12:03:34 +08:00
Jason Chiu
92cd7b40f3 Merge "Refactor Settings for injection v2 inline toggle" 2019-10-07 03:46:05 +00:00
TreeHugger Robot
2f6fe971d0 Merge "Tethering shouldn't indicates on when SIM without tethering option" 2019-10-07 02:50:01 +00:00
Bill Yi
89ffd5a247 Merge "[automerger skipped] Import translations. DO NOT MERGE am: aa605a2ff8 -s ours am: 6fa03d4cad -s ours
am: eec9cc07ca -s ours
am skip reason: subject contains skip directive

Change-Id: Id87b7c4a4ed14c3a1810bf409f55442e1e05f4ad
2019-10-06 15:17:28 -07:00
Bill Yi
cd5c8c274e [automerger skipped] Import translations. DO NOT MERGE am: aa605a2ff8 -s ours am: 165a3e6152 -s ours
am: 8491c7fc2b -s ours
am skip reason: subject contains skip directive

Change-Id: Ied4ddf5cfdea7c3c6b402d7f57ea3e393ded01a3
2019-10-06 15:16:56 -07:00
Android Build Merger (Role)
eec9cc07ca Merge "[automerger skipped] Import translations. DO NOT MERGE am: aa605a2ff8 -s ours am: 6fa03d4cad -s ours am skip reason: subject contains skip directive" into qt-qpr1-dev-plus-aosp 2019-10-06 22:10:28 +00:00
Bill Yi
09a0ca8303 [automerger skipped] Import translations. DO NOT MERGE am: aa605a2ff8 -s ours
am: 6fa03d4cad -s ours
am skip reason: subject contains skip directive

Change-Id: I907eb3de51fb2427bc525282a87ceea97581815c
2019-10-06 15:10:17 -07:00
Bill Yi
8491c7fc2b [automerger skipped] Import translations. DO NOT MERGE am: aa605a2ff8 -s ours
am: 165a3e6152 -s ours
am skip reason: subject contains skip directive

Change-Id: I22a3b3c49c309e7ccd9424f16841722fd1a228b0
2019-10-06 15:10:15 -07:00
Bill Yi
165a3e6152 [automerger skipped] Import translations. DO NOT MERGE
am: aa605a2ff8 -s ours
am skip reason: subject contains skip directive

Change-Id: I8582fd40ccfab6c247144759b8eac47e021b3ee4
2019-10-06 15:03:16 -07:00
Bill Yi
6fa03d4cad [automerger skipped] Import translations. DO NOT MERGE
am: aa605a2ff8 -s ours
am skip reason: subject contains skip directive

Change-Id: I67820e45b4aceb3a9d3c141cc3be69e899551e2e
2019-10-06 15:03:16 -07:00
Bill Yi
9a111e77cb [automerger skipped] Merge "Import translations. DO NOT MERGE" into qt-qpr1-dev am: 42eff7e319 -s ours
am: e59984afb1 -s ours
am skip reason: subject contains skip directive

Change-Id: Id9145af1c1308c1ca5c63e6df66927b2778afbd6
2019-10-06 13:28:06 -07:00
Bill Yi
e59984afb1 [automerger skipped] Merge "Import translations. DO NOT MERGE" into qt-qpr1-dev
am: 42eff7e319 -s ours
am skip reason: subject contains skip directive

Change-Id: I35cc62652e4cb9c2a7448b1db141cbba125c6f04
2019-10-06 13:21:35 -07:00
TreeHugger Robot
42eff7e319 Merge "Import translations. DO NOT MERGE" into qt-qpr1-dev 2019-10-06 19:48:23 +00:00
SongFerngWang
d9ebbb93d0 Preferred network list add 5G item am: dd7f9b57f6
am: a72e1c4612

Change-Id: I734eb57e32fe51bdc1570da86fd66c3b16b99f7f
2019-10-06 09:26:02 -07:00
SongFerngWang
d060c6a648 RadioInfo network mode list and network mode string add 5G am: ec384c2f6f
am: ffc927f77d

Change-Id: Ida4180873e042097fb5fe17292b29d66f77de9ee
2019-10-06 09:25:58 -07:00
SongFerngWang
a72e1c4612 Preferred network list add 5G item
am: dd7f9b57f6

Change-Id: I70f89c6c5e5c43107788c58f1fc3ca44383b4ce5
2019-10-06 09:20:09 -07:00
SongFerngWang
ffc927f77d RadioInfo network mode list and network mode string add 5G
am: ec384c2f6f

Change-Id: I280fb1f3e0acddcb3a85eee876112e491bd4f8f4
2019-10-06 09:20:06 -07:00
Bill Yi
4c257b0ef8 Import translations. DO NOT MERGE
Change-Id: Ie4fdf91f299defd2a361d76455093db5a410d0d6
Auto-generated-cl: translation import
2019-10-06 07:50:11 -07:00
Bill Yi
aa605a2ff8 Import translations. DO NOT MERGE
Change-Id: I1af1cc81e5fffb4ead2146f8871efa5115f91be2
Auto-generated-cl: translation import
2019-10-06 07:36:10 -07:00
Bonian Chen
ae14e82c96 Merge "[Settings UX] Enlarge data usage clickable area" 2019-10-05 06:58:46 +00:00
TreeHugger Robot
4fd6f5c7a1 Merge "Fix a11y issue for the Preferences in the "Android version" Talkback should not speak "double-tap to activate"." 2019-10-05 03:40:34 +00:00
Kevin Chyn
da1438d0c4 Merge "Removed old settings device credential logic." 2019-10-05 02:37:26 +00:00
Alex Johnston
9ac78b32d5 Merge "Remove all biometrics data of a user when password is cleared." 2019-10-04 12:58:17 +00:00
Jason Chiu
1a1f9314b6 Refactor Settings for injection v2 inline toggle
Bug: 132808482
Test: robotest
Change-Id: I0b74e05bc26b97259a15859c669060ce3da7972a
2019-10-04 18:32:11 +08:00
Mill Chen
9915b14914 Merge "Fix overlapping in TrustedCredentialsSettings" 2019-10-04 10:26:56 +00:00
Fang Li
03bdf907ae Change Wi-Fi Calling text for SFR France
Change Wi-Fi Calling text according to SFR requirement.

Test: Checked that changing name correctly.
Bug: 141255919
Change-Id: I598f9d4a3cbca166fe3449ec425702360a104213
2019-10-04 18:30:27 +09:00
Stanley Wang
9d3f8c435f Fix a11y issue for the Preferences in the "Android version"
Talkback should not speak "double-tap to activate".

Set the preference selectable attribute to false.

Test: manual
Fixes: 139709914
Change-Id: If4d6dd480740f4225b1e2932e7838c14a01cf8e5
2019-10-04 17:18:29 +08:00
Yi-Ling Chuang
f8eb30800a Fix non responding slice toggling problem.
The issue happens when users are toggling slices. Sometimes the toggle
doesn't work as expected because the pending intent of the toggle action
seems to be canceled for some reasons.

Hence, we replace FLAG_CANCEL_CURRENT with FLAG_UPDATE_CURRENT to prevent from
getting PendingIntent.CancelExcpetion from SliceActionView when toggling
slices.

Note that this change would only apply on Wifi, MobileData, Flashlight
and Bluetooth Slices.

Bug: 140719905
Test: rebuild and switch toggles
Change-Id: Iddbb16ddcbcf97b6f6e680b43645c04fbc061f39
2019-10-04 17:17:19 +08:00
Bonian Chen
779abebc63 [Settings UX] Enlarge data usage clickable area
Orignal clickable area within data usage editor is too small.
Enlarge it through changing the configuration of layout.

Bug: 131268240
Test: manual testing following the steps provided in issue.
Change-Id: I2cb8dba635ec0bd74c837c2425895ff39ceed13c
2019-10-04 17:11:23 +08:00
TreeHugger Robot
ab1277f6a5 Merge "Fix the display abnormal of Tap & pay screen in landscape mode" 2019-10-04 08:33:20 +00:00
Raff Tsai
c303894040 Merge "Fix talkback issue" 2019-10-04 08:05:51 +00:00
hughchen
d6ec2ac7be Tethering shouldn't indicates on when SIM without tethering option
Before this CL, If SIM doesn't have tethering option then UI will not
back to previous option when press "USB tethering" in
[Default USB configuration].

This CL added receiver to observe USB state that get correct state
from UsbManager.

Bug: 138630479
Test: make -j42 RunSettingsRoboTests
Change-Id: I6cc8da508f6ab142142ca8c28460125bad93925b
2019-10-04 15:41:45 +08:00
SongFerngWang
dd7f9b57f6 Preferred network list add 5G item
Preferred network list add 5G item, and change "recommended" from 4G to
5G, and add summary for 5G.

Bug: 138544359
Test: 1.fake the device network type bitmask to 5G, UI show 5G list
2.atest EnabledNetworkModePreferenceControllerTest.java :pass

Change-Id: I4a78e2e7fbb067ce841df4aaf1d5161607fdcf90
2019-10-04 04:53:31 +00:00
SongFerngWang
ec384c2f6f RadioInfo network mode list and network mode string add 5G
Bug: 131888757
Test: 1.build pass 2.RadioInfo set network mode work.
Change-Id: I945d3c2fd175f45151bbeee475e388ccc2d67642
2019-10-04 12:39:59 +08:00