PETER LIANG
15d20efe43
Merge changes from topic "tutorial_improvement" into rvc-dev am: b6bf10ebbc
...
Change-Id: I9c6d550f6267d80aa7bd22894b81d4dade1f9189
2020-04-23 12:48:15 +00:00
PETER LIANG
b6bf10ebbc
Merge changes from topic "tutorial_improvement" into rvc-dev
...
* changes:
Tutorial improvement for Accessibility shortcut (3/n).
Tutorial improvement for Accessibility shortcut (2/n).
Tutorial improvement for Accessibility shortcut (1/n).
2020-04-23 12:37:15 +00:00
Bonian Chen
ec80b6da3a
Merge "[Settings] Fix CellDataPreferenceTest" into rvc-dev am: ef2e319347
...
Change-Id: Ibc821f8fba3f23ad6326012f4def600a1b81336e
2020-04-23 12:06:26 +00:00
Bonian Chen
29e37ceaa1
[Settings] Fix CellDataPreferenceTest
...
Fix CellDataPreferenceTest
Bug: 154562715
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=CellDataPreferenceTest
Change-Id: Ia0ee0f5cd802ca9b6827bddcaf189c619d268074
2020-04-23 17:51:14 +08:00
Bonian Chen
d68d156a80
Merge "[Settings] Move some work into background thread" into rvc-dev am: 7585e6ac1f
...
Change-Id: Iecc4b7665ebc977aa0e1fea33ab80fc5b0ba7d7f
2020-04-23 08:34:36 +00:00
Bonian Chen
148972e154
Merge "[Settings] Code refactor for data usage" into rvc-dev am: abdeadf85d
...
Change-Id: Id0749b00f602a6033aa67c5714fd32c4a3f70858
2020-04-23 08:34:22 +00:00
Bonian Chen
7585e6ac1f
Merge "[Settings] Move some work into background thread" into rvc-dev
2020-04-23 08:22:32 +00:00
Bonian Chen
abdeadf85d
Merge "[Settings] Code refactor for data usage" into rvc-dev
2020-04-23 08:22:00 +00:00
Bonian Chen
c2ea9a1fa4
Merge "[Settings] Code Refactor" into rvc-dev am: 921ed942c0
...
Change-Id: I7722ae2f971b68cca02d6fb0ed6dc64668857a5e
2020-04-23 06:01:53 +00:00
Bonian Chen
921ed942c0
Merge "[Settings] Code Refactor" into rvc-dev
2020-04-23 05:47:10 +00:00
Bonian Chen
3248d004d3
[Settings] Move some work into background thread
...
1. Move some work into backgroud thread when query data usage status.
2. Fix test case
Bug: 141833767
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsagePreferenceControllerTest
Change-Id: Ic1496323cd2bbaf794881394565d8d9bb0a89111
2020-04-23 12:55:53 +08:00
Peter_Liang
8cbb44d6f6
Tutorial improvement for Accessibility shortcut (3/n).
...
Add test cases for tutorial pages.
Bug: 148989018
Bug: 134640159
Test: manual test & run RoboTests
Change-Id: I9bb29f6e61e331c3f9a2408a1eebc3d5e9e16000
2020-04-23 12:18:26 +08:00
Peter_Liang
72aa60ae95
Tutorial improvement for Accessibility shortcut (2/n).
...
Update UI widgets to meet the new design.
Bug: 148989018
Test: manual test
Change-Id: Ife42995af193db6746135d29f6fa1ad452d265a6
2020-04-23 12:18:26 +08:00
Peter_Liang
cfe3e454ac
Tutorial improvement for Accessibility shortcut (1/n).
...
Because can't save the value into setting keys for the service before version R, and in order to let tutorial dialog can get the consistent value, using alternative that each fragment with shortcut to must implement the new abstract method.
Bug: 148989018
Test: manual test
Change-Id: Iba2a7daa70eb00f0bba37317c9355531fbb77628
2020-04-23 12:18:23 +08:00
Bonian Chen
048d9fe19e
[Settings] Code Refactor
...
Code refactor to provide the capability of method override
Bug: 141833767
Test: manual
Change-Id: I79647a7ff79f1f722bcfdf8190590df61bb3510a
2020-04-23 04:11:55 +00:00
Bonian Chen
761a13700f
[Settings] Code refactor for data usage
...
Code refactor
Bug: 151751844
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryPreferenceControllerTest
Change-Id: I22b323bae0b18cca26c62d047fdb504c012518b5
2020-04-23 11:01:34 +08:00
Bonian Chen
ea4fc4af4c
Merge "[Settings] Mobile data usage code refactor" into rvc-dev am: 673251973b
...
Change-Id: Ic7f2ef5a3de5399007ef6828cee712252db31588
2020-04-22 14:37:56 +00:00
Bonian Chen
673251973b
Merge "[Settings] Mobile data usage code refactor" into rvc-dev
2020-04-22 14:27:31 +00:00
Tom Hsu
5864a6ba23
Merge "Make ApnEditor can show the customized default value on UI." into rvc-dev am: 49b82f8532
...
Change-Id: I46f5143cde953050041a7b238cb0fa9a856978d7
2020-04-22 12:23:04 +00:00
Tom Hsu
49b82f8532
Merge "Make ApnEditor can show the customized default value on UI." into rvc-dev
2020-04-22 12:16:09 +00:00
tom hsu
fa3c931ab6
Make ApnEditor can show the customized default value on UI.
...
- Edittext on edittextpreference
- Summary on edittextpreference
Bug: 142440775
Test: make RunSettingsRoboTests ROBOTEST_FILTER=ApnEditorTest -j
Test: Sanity test pass with customized carrier data
- data in summary and text of edittext preference correctly correctly
display on.
Change-Id: I3162de19659df79c5873c730d7d32e4ed998bcbe
2020-04-22 12:15:50 +00:00
PETER LIANG
c9be2d385c
Merge "Uniform the settings enum proto for accessibility tutorial." into rvc-dev am: a83a8e29c3
...
Change-Id: I888e91c98097372c041a073cafffc5fe2df6bab3
2020-04-22 12:02:02 +00:00
PETER LIANG
a83a8e29c3
Merge "Uniform the settings enum proto for accessibility tutorial." into rvc-dev
2020-04-22 11:42:27 +00:00
Bonian Chen
2538b62bea
Merge "[Settings] Adopt TelephonyBasePreferenceController to data usage" into rvc-dev am: a4efeb7a0a
...
Change-Id: I66ef842df28850e193ce81756b2b8a75e6bef27c
2020-04-22 10:25:59 +00:00
Bonian Chen
0fef82fbd1
[Settings] Mobile data usage code refactor
...
Code refactor
Bug: 151751844
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsagePreferenceControllerTest
Change-Id: Ie1870523ce83e6a1fc56fe9bc4c61708e0e745c4
2020-04-22 18:22:35 +08:00
Bonian Chen
a4efeb7a0a
Merge "[Settings] Adopt TelephonyBasePreferenceController to data usage" into rvc-dev
2020-04-22 10:12:24 +00:00
Bonian Chen
b17c7f9606
Merge "[Settings] Mobile data usage code refactor" into rvc-dev am: 7db5840dfe
...
Change-Id: I4880420c6d6b539662ea2f7e557184058d6c633f
2020-04-22 07:45:43 +00:00
TreeHugger Robot
11f9c5bcf8
Merge "Incorrect checkbox icon in dynamic group panel" into rvc-dev am: 766e060c75
...
Change-Id: I80a5a31ce703e0ed8d42c280eeff23763df65f0c
2020-04-22 07:45:36 +00:00
Bonian Chen
78b9a0c406
Merge "[Settings] To avoid from crash when callback" into rvc-dev am: af05f6303d
...
Change-Id: Id17529753ddc58ba458c952f455dac8ef4e896ce
2020-04-22 07:44:32 +00:00
Bonian Chen
7db5840dfe
Merge "[Settings] Mobile data usage code refactor" into rvc-dev
2020-04-22 07:17:22 +00:00
TreeHugger Robot
766e060c75
Merge "Incorrect checkbox icon in dynamic group panel" into rvc-dev
2020-04-22 07:16:42 +00:00
Bonian Chen
af05f6303d
Merge "[Settings] To avoid from crash when callback" into rvc-dev
2020-04-22 07:00:12 +00:00
Jason Chiu
2fee6f3d1e
Merge "Fix the incorrect title of Panel" into rvc-dev am: 1f91111c3a
...
Change-Id: I4e7cbf75be6aca6a3573c42c32c27d7338d6b677
2020-04-22 06:46:45 +00:00
Jason Chiu
1f91111c3a
Merge "Fix the incorrect title of Panel" into rvc-dev
2020-04-22 06:30:12 +00:00
Jason Chiu
4bbc85eb54
Fix the incorrect title of Panel
...
Since panel activity is singleInstance, a newer panel will reuse the
same fragment as the previous panel when they are displayed one after
another.
Panel fragment has two kinds of exclusive header layout which shouldn't
be showed at the same time, so we have to reset their visible states
when creating panel content.
Fixes: 154668079
Test: robotest
Change-Id: I701a7cde4b43322fbc63ae1cb74c41dd23b37c0c
2020-04-22 06:29:57 +00:00
Tim Peng
55ce33fbe7
Incorrect checkbox icon in dynamic group panel
...
-Mutate icon to prevent modifying the original resource
Bug: 154673054
Test: build pass
Change-Id: I0e1a6506cb951f80f316649d27c7728132c05be6
2020-04-22 13:50:46 +08:00
TreeHugger Robot
6bb86dc6ea
Merge "Fix breadcrumb of search results provided by Settings" into rvc-dev am: d2291d447e
...
Change-Id: I03245f81a8e5d9be4d369d8b673791b1940956ce
2020-04-22 05:31:20 +00:00
TreeHugger Robot
d2291d447e
Merge "Fix breadcrumb of search results provided by Settings" into rvc-dev
2020-04-22 05:18:34 +00:00
Bonian Chen
6ea4727eb4
[Settings] Mobile data usage code refactor
...
Code refactor
Bug: 151751844
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsagePreferenceControllerTest
Change-Id: If85207ebe2edb8c547bb6dac0c55bbd146b62361
2020-04-22 13:13:33 +08:00
Bonian Chen
63cf333e34
Merge "[Settings] Fix DataUsageSummaryPreferenceControllerTest" into rvc-dev am: 8f26e88bd9
...
Change-Id: I6e50d38fe30bc09a2f52fc89b08ad6f955d6de86
2020-04-22 04:40:43 +00:00
Bonian Chen
1a8d501d7d
[Settings] Adopt TelephonyBasePreferenceController to data usage
...
Adopt TelephonyBasePreferenceController in order to better support DSDS.
Bug: 151751844
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryPreferenceControllerTest
Change-Id: I502b93f01b289b72989ad3167131cc0c598b1583
2020-04-22 12:38:11 +08:00
Bonian Chen
8f26e88bd9
Merge "[Settings] Fix DataUsageSummaryPreferenceControllerTest" into rvc-dev
2020-04-22 04:27:43 +00:00
Zhen Zhang
274a4006e1
Merge "Add ethernet tether option into AllInOneTetherSettings" into rvc-dev am: 92340eb89e
...
Change-Id: Ia473326843cbc08ecdfde45887a9c0618d08d4d1
2020-04-22 03:05:45 +00:00
Zhen Zhang
92340eb89e
Merge "Add ethernet tether option into AllInOneTetherSettings" into rvc-dev
2020-04-22 02:52:58 +00:00
Bonian Chen
61b9714a34
[Settings] Fix DataUsageSummaryPreferenceControllerTest
...
Fix test case of DataUsageSummaryPreferenceControllerTest
Bug: 154562264
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=DataUsageSummaryPreferenceControllerTest
Change-Id: I0b3366c86b0a621b9dda88bbcde6e118d37995b7
2020-04-22 10:39:42 +08:00
tim peng
2cbd7526fc
Merge "The volume slider should not show for the unselected device" into rvc-dev am: 24205d4632
...
Change-Id: I68dcbd00f3a24c568baeb4c28ffd2e14bcb38c5f
2020-04-22 01:18:39 +00:00
tim peng
24205d4632
Merge "The volume slider should not show for the unselected device" into rvc-dev
2020-04-22 01:00:33 +00:00
TreeHugger Robot
8f474aa504
Merge "Notification history a11y fixes" into rvc-dev am: f11da4c787
...
Change-Id: Id03d0c217ecc9b49e343f65f0f808efc863546dd
2020-04-21 21:36:58 +00:00
TreeHugger Robot
f11da4c787
Merge "Notification history a11y fixes" into rvc-dev
2020-04-21 21:22:44 +00:00
Beverly
4922aa006a
Notification history a11y fixes
...
- When clicking the expand/collapse button to see the posted
notifications from an app in the last 24 hours, refocus accessibility on
the button so the entire button (contentDescription + clickability) are
announced. Previously only the contentDescription update was being
announced.
- Fix local context menu of NotificationHistory elements by calling the
super method in performAccessibilityAction
Test: manual
Fixes: 153396313
Fixes: 153518629
Change-Id: I3d847ec1f2b72dcf411c6c7c7fe2dc061ccfde26
2020-04-21 14:54:45 -04:00