Commit Graph

26324 Commits

Author SHA1 Message Date
Quang Luong
75264b0a28 Merge "Fixed Passpoint network "Not in range" issue and forget button" into qt-dev
am: 7af19fcb86

Change-Id: I2096086e4463279d426896c774f3c4e00945a216
2019-04-17 12:20:44 -07:00
Joel Galenson
db516d98c5 Only get apps with permission granted.
The subtitle gives the number of apps that can access location, but it
currently collects all apps that request location, including those
that are denied.  Ensure that we only count granted apps.

Bug: 129296799
Test: Open Settings, see the count is much lower.
Change-Id: I9a18bbb62be742731205dab9f5b8e9a703ea030c
2019-04-17 11:12:26 -07:00
Quang Luong
7af19fcb86 Merge "Fixed Passpoint network "Not in range" issue and forget button" into qt-dev 2019-04-17 17:57:39 +00:00
Yanting Yang
bdbca3399b Merge "Turn off debug logging flags" into qt-dev
am: ed9be192b6

Change-Id: Ib0b539172fdeff2eabb86033b10af1b811171e7f
2019-04-17 10:45:33 -07:00
Mill Chen
36c5e429fb Merge "Default to enable oem-unlocking preference" into qt-dev
am: c82a225c6f

Change-Id: Iabcddecee0b0b7d36e3868c617c46ec85867b7d4
2019-04-17 10:24:05 -07:00
TreeHugger Robot
ed9be192b6 Merge "Turn off debug logging flags" into qt-dev 2019-04-17 17:12:39 +00:00
TreeHugger Robot
c82a225c6f Merge "Default to enable oem-unlocking preference" into qt-dev 2019-04-17 16:54:19 +00:00
Joel Galenson
6fd7aa77ea Merge "Do not special case the storage permission group." into qt-dev
am: 634b56cb17

Change-Id: I628009b969d2089151f723c233594cb919fd146d
2019-04-17 07:45:09 -07:00
TreeHugger Robot
634b56cb17 Merge "Do not special case the storage permission group." into qt-dev 2019-04-17 14:21:49 +00:00
Yanting Yang
118e7aee28 Turn off debug logging flags
Fixes: 130558346
Test: visual
Change-Id: Ie82bfe503f789435a3474697391fdfdeb94864ee
2019-04-17 19:55:54 +08:00
cosmohsieh
e6e4b4d78d [PasspointV2] Set summary of saved networks preference
Summary text of "saved networks" preference has number of both normal
networks and subscriptions

Bug: 130259573
Test: make RunSettingsRoboTests -j32 ROBOTEST_FILTER=com.android.settings.wifi.WifiSettingsTest
Change-Id: I8bdf41c1a85165298a2ccd9e688c30b0bd593bfa
2019-04-17 18:21:09 +08:00
Mill Chen
8350576f01 Merge "Add subtitle for Do not disturb" into qt-dev
am: cf9b3d2e87

Change-Id: I60ec7bc78b4cf6a429c6e0ccdb3b092431e0a72b
2019-04-17 02:16:51 -07:00
Mill Chen
bc8089527d Merge "Remove On/Off string from Night light slice" into qt-dev
am: 0ce66b9329

Change-Id: Ie39cc0e3bafe863ae1a200fbde13bca7b9da8961
2019-04-17 02:15:47 -07:00
TreeHugger Robot
cf9b3d2e87 Merge "Add subtitle for Do not disturb" into qt-dev 2019-04-17 09:08:17 +00:00
TreeHugger Robot
0ce66b9329 Merge "Remove On/Off string from Night light slice" into qt-dev 2019-04-17 09:03:07 +00:00
cosmohsieh
4025c74f97 [Network Connection] Show full SSID on list item
Long SSID will be cut off, because ellipsized. Show full SSID to gain
better UX.

Bug: 130198869
Test: manual
Change-Id: I14376ff7fb922439a2d664433a94740cc06cd99a
(cherry picked from commit 151d5a3c83)
2019-04-17 06:20:00 +00:00
Arc Wang
0045e34d84 Merge "Hide 'Share' button and 'Add device' preference for a Passpoint Wi-Fi network" into qt-dev
am: a713243db4

Change-Id: Iec84dd7af890457fee7b0209831abe6501545933
2019-04-16 19:30:54 -07:00
Alex Salo
7e3a9da21b Merge "Check for attention permissions" into qt-dev
am: e991b05b29

Change-Id: I52b699901bda983ebe7ec5f571443868ed0c083f
2019-04-16 18:42:44 -07:00
Arc Wang
a713243db4 Merge "Hide 'Share' button and 'Add device' preference for a Passpoint Wi-Fi network" into qt-dev 2019-04-17 01:07:12 +00:00
lindatseng
634d8b3ee4 Set max num of slices allowed in panel view
Setup a max allowed num for PanelSlicesAdapter to prevent too
many slices showing in single panel.

Test: Manual verify
Test: atest PanelSlicesAdapterTest
Fixes: 129358092
Change-Id: I7b72a29489e597b8309d74841eaeab0fe42aace6
2019-04-16 17:28:14 -07:00
Joel Galenson
2102faf3e3 Do not special case the storage permission group.
We are now not showing storage usages in Permission Controller,
including in the API Settings uses.  We can thus remove this code so
that Settings will reflect what Permissions Hub shows.

Bug: 130567526
Test: See the same graph here and in the dashboard.
Change-Id: Iaa7d95b05f4321543ed42833ac3a7babdb9914f0
2019-04-16 15:44:52 -07:00
lindatseng
4c9bf6de55 Merge "Enforce min value on panel slices slider" into qt-dev
am: cef4e42dc2

Change-Id: I5a483d30aeb489251d4917467af9a0faa656ba03
2019-04-16 15:07:26 -07:00
TreeHugger Robot
e991b05b29 Merge "Check for attention permissions" into qt-dev 2019-04-16 22:02:43 +00:00
Lei Yu
8f9c60652f Merge "Hide Mobile preference for secondary user" into qt-dev
am: ad06c36882

Change-Id: Ied33b1b8cef008dbca300d3809296ea81c123ce2
2019-04-16 14:48:35 -07:00
joshmccloskey
a104d290de Updated ConfirmDeviceCredential strings
Test: Verified with BiometricPromptdemo that pin/pattern/pass
show up correctly.
Fixes: 129797243
Change-Id: Ib075d6742f7e2ad03e491132ae9506dce67558fc
2019-04-16 14:19:29 -07:00
TreeHugger Robot
cef4e42dc2 Merge "Enforce min value on panel slices slider" into qt-dev 2019-04-16 21:18:05 +00:00
Linda Tseng
668055d8e5 Merge "Add entry animation to Settings Panels." into qt-dev
am: 71df263db9

Change-Id: I29a61b38bb5cebcb5b481f5a3df0ac627765666b
2019-04-16 13:51:55 -07:00
Lei Yu
ad06c36882 Merge "Hide Mobile preference for secondary user" into qt-dev 2019-04-16 20:47:17 +00:00
Quang Luong
0af9b83644 Fixed Passpoint network "Not in range" issue and forget button
Passpoint networks now correctly allow the user to connect and forget
from the saved networks network detail page.

Bug: 130373102
Test: atest WifiDetailPreferenceControllerTest

Change-Id: I6ed2817bb3a1ac657695272ceb9d5e3f3e944f16
2019-04-16 12:52:25 -07:00
Lei Yu
c53b29300a Merge "Disable Mobile settings in one condition." into qt-dev
am: 421ca22a58

Change-Id: I9798659adcbe48277abca54d424fa0916b245821
2019-04-16 12:24:50 -07:00
Salvador Martinez
5e44955e57 Merge "Change dark theme screen to toggle" into qt-dev
am: 3b8a0b82bf

Change-Id: I5d13eac9e99d47cc591eed30de6e739a826d4a54
2019-04-16 12:15:34 -07:00
Yi-Ling Chuang
95a850bc64 Merge "Hide filter spinner when data is loading." into qt-dev
am: 03c461b3ee

Change-Id: I966e020c6952322ec8c3967e363a4f6f2e72cd44
2019-04-16 12:07:59 -07:00
Linda Tseng
71df263db9 Merge "Add entry animation to Settings Panels." into qt-dev 2019-04-16 18:57:47 +00:00
TreeHugger Robot
421ca22a58 Merge "Disable Mobile settings in one condition." into qt-dev 2019-04-16 18:20:11 +00:00
TreeHugger Robot
3b8a0b82bf Merge "Change dark theme screen to toggle" into qt-dev 2019-04-16 18:16:54 +00:00
TreeHugger Robot
03c461b3ee Merge "Hide filter spinner when data is loading." into qt-dev 2019-04-16 18:07:24 +00:00
Alex Salo
c821ae1ee6 Check for attention permissions
If attention package does not have sufficient permissions - disable the
setting.

Bug: 130246574, 130350903
Test: make RunSettingsRoboTests and manually confirmed
Change-Id: Ia7a86c940522e72f7e895d6aec7500f1ef6f9889
2019-04-16 17:43:15 +00:00
Yanting Yang
18e0119391 Merge "Clean up NotificationChannelSlice" into qt-dev
am: 1fa45975eb

Change-Id: I26f2b0423f60e42a6e34e115426961037abe7768
2019-04-16 10:25:53 -07:00
Raff Tsai
fbab258c8b Merge "Tint battery fix icon" into qt-dev
am: 77c56714ed

Change-Id: I83eb7c34907ebe1b0d4fa953a04bd85b374330b2
2019-04-16 10:13:51 -07:00
TreeHugger Robot
1fa45975eb Merge "Clean up NotificationChannelSlice" into qt-dev 2019-04-16 16:31:22 +00:00
lindatseng
fadedb321c Enforce min value on panel slices slider
We did not set the min value on slider slices when converting them
from preference to slices, which makes the slices all have min 0.
However, there are some slider which should have min value greater
than 0, for example, call and alarm.

We should get the min value and apply it to slider slice to make it
consistent with what we have in settings pref.

Test: Manual verification
Test: make -j40 RunSettingRobotests
Test: atest VolumeSeekBarPreferenceControllerTest
Fixes: 130439216
Fixes: 130358208
Change-Id: Ib4399c36c7da3ac41a6d46a6c150f0ec1b9b0b0f
2019-04-16 16:30:08 +00:00
Matthew Fritze
b6fdd25c23 Add entry animation to Settings Panels.
Settings Panels as a dialog have a default animation for entering the
screen, but Slices complicate the animation. While the dialog enters the
screen, Slices begin to bind, thus changing the height of the dialog as
it enters, causing perceived bounce / jank in the animation.

This CL is cherry-picked/based on ag/6671083 but do the following modification:
(See the original commit message for the whole concept)

When trying to load all the Slices, there are few possible situations:
1. Slice starts loading slowly, starting at state LOADED_NONE
2. Slice is loading in progress, having state LOADED_PARTIAL
3. Slice is loaded, but there's error return from the Slice data (We don't
need to show the Slice in this case)
4. Slice is loaded, progress to state LOADED_ALL
5. Slice starts from state LOADED_NONE, but never progress to the next state
because it crashes at setting backend.

Notice that there are two cases that the state will stay at LOADED_NONE and
we can't distinguish them.

Hence, we decide to do the following:

If Slice is with error (case 3) we remove the slice from the list and mark it
loaded.

If Slice is loaded with LOADED_ALL (case 4, which is the ideal case), we mark
it as loaded.

In the other cases, we fire a handler to mark the slice loaded anyway after
250ms timeout.

When all the slices are marked loaded (which should happen after 250ms timeout,
we will animate the panel out.  Although there might be slices which are still
partial loaded, we can still have the slice in the panel once it is ready.
The panel might bounce/jank in this case, but at least it will still showing
correctly, and should show up smoothly in most cases.

The solution to this problem is twofold:
1. Load all Slices first
2. Create a custom animation to draw the panel once the recyclerview has
been laid out.

Test: Manual/Visual inspection
Test: make -j40 RunSettingsRobotests
Bug: 123942159

Change-Id: I639a707aa4ba3f906bd6f9752c92727aaba28142
2019-04-16 16:29:04 +00:00
TreeHugger Robot
77c56714ed Merge "Tint battery fix icon" into qt-dev 2019-04-16 16:25:34 +00:00
Fan Zhang
7f7b9e7736 Merge "Correct the state when prevent ringing page is launched." into qt-dev
am: 957da73a7d

Change-Id: I541d0c22788678fc0e9249e35f6aeae1f1ea0e0b
2019-04-16 08:33:30 -07:00
Amin Shaikh
900d8c9e12 Merge "Create TintDrawable in Settings." into qt-dev
am: c4e7cf594c

Change-Id: I8a04a3924d17712b17798109b418c0d4748cf737
2019-04-16 08:28:24 -07:00
Fan Zhang
957da73a7d Merge "Correct the state when prevent ringing page is launched." into qt-dev 2019-04-16 15:22:26 +00:00
TreeHugger Robot
c4e7cf594c Merge "Create TintDrawable in Settings." into qt-dev 2019-04-16 15:16:26 +00:00
Yanting Yang
ce3359f4d4 Clean up NotificationChannelSlice
- Remove unused variable.
- Change function interface.

Bug: 123065955
Test: visual, robotests
Change-Id: I39c0a92539d45cdbc11bd9090a3ab97a72482632
2019-04-16 23:08:40 +08:00
Lei Yu
65628c28a9 Merge "Add remote volume slider conditionally." into qt-dev
am: ee6825fd5b

Change-Id: I030b19ae8d2d843cdb2db93b8900de785bb28a40
2019-04-16 05:58:13 -07:00
TreeHugger Robot
ee6825fd5b Merge "Add remote volume slider conditionally." into qt-dev 2019-04-16 12:46:55 +00:00