Commit Graph

26324 Commits

Author SHA1 Message Date
TreeHugger Robot
7b571b7018 Merge "Update Model pref subtext to remove redundant prefix" 2019-03-29 06:11:33 +00:00
Cosmo Hsieh
e1b6d7d875 Merge "Show "Disconnect" on forget button for ephemeral network" 2019-03-29 03:18:00 +00:00
Arc Wang
dae6c695ca Hide Wi-Fi QR code scan button for unsupported Wi-Fi networks
Wi-Fi QR code scan button only shows for the Wi-Fi network which
supports Wi-Fi Easy Connect or ZXing Wi-Fi config format.

Bug: 128847959
Test: manual
Change-Id: If6460ce88748e7b06893bf62060418a8727d3134
2019-03-29 10:17:44 +08:00
cosmohsieh
03b8cd76ac [Network Connection] Correct canceling dialog behavior
Use setCancelable() rather than setCanceledOnTouchOutside() for better
code smell and consisting with general not canceling behavior.
The back key and touching outside will not cancel this dialog for better
UX.

Bug: 128877712
Test: atest NetworkRequestDialogFragmentTest
Change-Id: I19bc5637a7307610e34db15d54c1d80d5b7e379b
2019-03-29 10:15:21 +08:00
Arc Wang
3f2298c4fd Merge "Fix Wi-Fi Easy Connect QR code scanner problems" 2019-03-29 01:57:35 +00:00
lindatseng
b38e333535 Update Model pref subtext to remove redundant prefix
Remove "Model: " prefix from the description of Model pref in
About phone > Model & hardware > Model

Test: Visual veridication
Fixes: 128622275
Change-Id: I8fb077809e13fded0370271e899163a7f4103f98
2019-03-28 17:27:58 -07:00
Xiangyu/Malcolm Chen
84c5751ceb Merge "Correct name of PRIMARY_SUBSCRIPTION_LIST_CHANGED." 2019-03-28 22:39:54 +00:00
Linda Tseng
1b152872c3 Merge "Make the text appearance consistant in add vpn dialog" 2019-03-28 22:39:01 +00:00
TreeHugger Robot
d34b2a9697 Merge "Add SSID to Network Details page for Passpoint" 2019-03-28 22:12:33 +00:00
TreeHugger Robot
e2fb556618 Merge "Use better string in dialog asking which SIM to use for SMS" 2019-03-28 21:44:30 +00:00
Maurice Lam
7ccbf69390 Fix dark theme for screen lock settings
Test: atest [...]/SetupWizardUtilsTest.java
Bug: 36529801
Change-Id: I81581b4f73754ba6b0754c80a8f962e8f7ed6949
2019-03-28 14:26:48 -07:00
Julia Reynolds
4e48da99a9 Move bubble settings to their own page
To make room for graphics/longer descriptive text

Test: robotests
Bug: 129068779
Change-Id: Iac6ea43bd3a0cddc487ff3d1bbd8f35142294d01
2019-03-28 21:25:05 +00:00
Fan Zhang
860accbcd1 Merge "Add prepainting background while swiping to dismiss." 2019-03-28 21:11:25 +00:00
Salvador Martinez
70da69b0ac Merge "Update dark mode in accessiblity settings" 2019-03-28 20:56:27 +00:00
Julia Reynolds
bd2bb06567 Prevent oem locked and default apps from being blocked
Test: robotests
Fixes: 129358763
Change-Id: I999b017f9f7389424e499a44cfac43711acbbbea
2019-03-28 16:42:13 -04:00
TreeHugger Robot
23cb22a7f9 Merge "Added null pointer check for mWifiConfig.macRandomizationSetting" 2019-03-28 20:33:23 +00:00
TreeHugger Robot
0a214d31f4 Merge "When filtering permission usages by a single permission, default to last day." 2019-03-28 20:27:50 +00:00
Quang Luong
1859a19302 Added connect listener to startOsuProvisioning()
Updated AccessPoint.startOsuProvisioning() call to accept a connect
listener to display a toast on failure to connect.

Bug: 123697580
Test: build
Change-Id: I0f29b2f5ccc8f2d4b8137639725dca1bcb106b26
2019-03-28 13:09:37 -07:00
Quang Luong
a2297dc1d1 Add SSID to Network Details page for Passpoint
Added SSID to Network Details page under the Advanced portion only
when the network is for Passpoint, whose network title is not the
SSID of the underlying connected AP.

Bug: 129092023
Test: atest RunSettingsRoboTests

Change-Id: I13308d46e727fc01fec7a079d8e32ab9f1763e21
2019-03-28 11:54:19 -07:00
TreeHugger Robot
ce56bb73c5 Merge "Add tiebreak rules for bar chart permissions." 2019-03-28 18:40:17 +00:00
Quang Luong
9f0b00104e Merge "Disable Mac randomization setting for Passpoint networks" 2019-03-28 18:17:22 +00:00
lindatseng
e0f24e6f5e Make the text appearance consistant in add vpn dialog
Set the password fields text appearance programatically to get the
appearance consistant.

The style set in xml will be overriden if the field is set to password.

I set the text appearance programmatically in order to keep the
appearance consistent with the others.  The color of the text become
gray after setting the text appearance for some reason.

Note that I also do changes to the password field which is not mentioned
in the bug.

Test: visual inspection.
Bug: 127728228
Change-Id: Ie206f60877eb39addc1370ae4e2aee379597960e
2019-03-28 11:16:35 -07:00
Torne (Richard Coles)
185acfc5ae Remove WebView fallback package handling.
There is no longer a special "fallback package" state for WebView that
means it should not be able to have its enabled/disabled state
controlled by the user. Remove the code used to implement this in
Settings.

Bug: 129470358
Test: verify that WebView's enable/disable button is not greyed out
Change-Id: Ifc0921511a71282a77f239e5ff5955e60fab6e2c
2019-03-28 14:11:50 -04:00
Antony Sargent
85717d9f8d Use better string in dialog asking which SIM to use for SMS
Right now when you have a dual-SIM device but no default set for which
one to use for SMS, when you go to try and send an SMS you'll get a
dialog asking which SIM to use with the generic string of "Select a SIM
card". We recently added a more specific string for this in a separate
CL, which reads "Select a SIM card for SMS". This CL switches the code
to use that more specific string.

Bug: 129021763
Test: compile / manual
Change-Id: I7d12a7191de23366b0a6b6888021e57ff9ddced9
2019-03-28 10:31:36 -07:00
TreeHugger Robot
1cc5eef87f Merge "Launch correct tone picker for audio attributes" 2019-03-28 16:09:17 +00:00
Joel Galenson
9a2017ef57 When filtering permission usages by a single permission, default to last day.
The general link to the dashboard shows only the last day, but
clicking on an individual permission did not.

Fixes: 129471807
Test: Click on permission.
Change-Id: Ice3b5b1ac6e2cb5a49cabf3c56167c9d39d3c3a1
2019-03-28 16:07:54 +00:00
Joel Galenson
2512aa1ed6 Add tiebreak rules for bar chart permissions.
If multiple permissions have been used by the same number of apps, we
apply a stable tiebreak so we can be consistent in different places.
We prefer location, then microphone, then camera, and everything else
is alphabetical.

Test: View chart with ties.
Test: atest PermissionBarChartPreferenceControllerTest
Change-Id: I035ac19391788cc720e1c832bf8bd5a60d31e8ad
2019-03-28 08:38:30 -07:00
Edgar Wang
59d4681253 Handle When received intent extra in System settings need show dialog
Bug: 128853573
Test: visual, robotest
Change-Id: I92337e26f51c3f7ef4033d424ddcf07c6da6805d
2019-03-28 22:49:09 +08:00
Matt Pape
d65fee5ec7 Merge "Remove interface for Telephony." 2019-03-28 14:48:37 +00:00
Yanting Yang
2585d27573 Merge "Add condition to ignore invalid packages in NotificationChannelSlice" 2019-03-28 13:01:47 +00:00
Sumit Deshmukh
b4bbe9488a Settings: [BT] Wrong Pairing Popup is shown on new pairing request.
Usecase:
1. Start advertising from DUT (using BLE Smartertooth app).
2. Scan and connect from central device.
3. Now initiate bond from central and accept pairing request.
   (Consent Pairing Dialog will be shown on DUT)
4. Notification will be received for PASSKEY CONFIRMATION Dialog.
   Do not open notification and let it timeout.
5. Repeat steps 2 and 3. At step 3, Passkey Confirmation pairing
   dialog is show instead of Consent pairing dialog.

Issue:
Wrong Pairing Popup is shown. Passkey Confirmation pairing
dialog is show instead of Consent pairing dialog.

Reproducible Rate: 100%

Root Cause:
PendingIntent created for showing pairing notification are getting
reused as only FLAG_ONE_SHOT is used. This flag is not updating new
extra's in the pending intent.

Fix:
Use flag FLAG_UPDATE_CURRENT in pending Intent.

Test: Tested above mentioned testcase and pairing scenarios.

Bug: 129456113

Change-Id: I46813f355cd796cee1b472774b494c8580b39784
2019-03-28 11:11:38 +00:00
TreeHugger Robot
8f7eada87a Merge "Add implementation of homepage swipe to dismiss." 2019-03-28 10:36:24 +00:00
Yi-Ling Chuang
ab0bc669ae Add prepainting background while swiping to dismiss.
When users swipe the card, they will see a pre-painted background.
The dismissal view will appear in only after the swipe.

Bug: 126214056
Test: visual
Change-Id: I0eb308700cda2e6d72c718f3057775d3620267cd
2019-03-28 18:35:52 +08:00
Yanting Yang
b1d846cbbd Add condition to ignore invalid packages in NotificationChannelSlice
If all displayable notification channels of package are turned off,
stop showing notification channel slice of package.

Bug: 124480122
Test: robotests
Change-Id: I3ce9ebc4cca18dac3b4b6f15c28c697b72df81e3
2019-03-28 18:01:11 +08:00
TreeHugger Robot
0ba7a5fd2f Merge "Add search index into WallpaperSuggestionActivity" 2019-03-28 08:38:31 +00:00
cosmohsieh
e4b3844d0b Show "Disconnect" on forget button for ephemeral network
For app or carrier initiated wifi connections (i.e all "ephemeral networks"),
the detailed page of settings should show "Disconnect" instead of "Forget".

Bug: 123892605
Test: atest WifiDetailPreferenceControllerTest
Change-Id: I1ee7f45ea12fe2ab9ca35cab77de0b1d67efc1db
2019-03-28 14:35:42 +08:00
hughchen
43fcc7b829 Set accent color to COLOR_NOT_TINTED
Bug: 128570540
Test: Test: make -j42 RunSettingsRoboTests
Change-Id: I483542156bf6cd24ed7080fed45e9f8e4d87a079
2019-03-28 14:30:55 +08:00
Sunny Shao
61aaed450e Add search index into WallpaperSuggestionActivity
.Use the Indexable interface for WallpaperSuggestionActivity and implement the getRawDataToIndex
.Remove the search index in the WallpaperTypeSettings
.Add full class name of the WallpaperTypeSettings into grandfather_not_implementing_index_provider

Bug: 63117104
Test: robotest & Manual View
Change-Id: I73f43e4996efbe857d74df297ea0d08eb1b640ac
2019-03-28 14:30:12 +08:00
TreeHugger Robot
7c49d1505f Merge "Use explicit intent to broadcast grayscale state changed" 2019-03-28 05:34:59 +00:00
tmfang
e668924149 Disallow Package Installer to be disabled
Test: visual, robotest
Fixes: 128950485
Change-Id: Id50a62fe3288761f68a3588b154db24573418068
2019-03-28 13:29:03 +08:00
TreeHugger Robot
db1c8a5fed Merge "Update battery saver schedule to show warning" 2019-03-28 04:04:03 +00:00
Yi-Ling Chuang
eeea6676d4 Add implementation of homepage swipe to dismiss.
- Only enable swipe for slice full/half card.
- Add isPendingDismiss in ContextualCard to determine if we should show
dismissal view.
- Take out long press feature.

Bug: 126214056
Test: robotests
Change-Id: Ib03e605347b2f50d3c62fcd4f95875a21cc9ef1c
2019-03-28 11:59:45 +08:00
Pasty Chang
dee673b0d7 Merge "Copy extra of suw flow to the intent of lock screen pages" 2019-03-28 03:03:09 +00:00
hughchen
9d4b634535 Remove method that used to get rainbow bt icon
Move get rainbow bt icon method to settingsLib

Bug: 128570540
Test: RunSettingsRoboTests
Change-Id: Iee022bd1471f1da057b1852bb648e9c7ce334727
2019-03-28 10:58:55 +08:00
Mill Chen
2ef3dacad8 Use explicit intent to broadcast grayscale state changed
Query PackageManager for receivers that can handle the intent and send
an explicit intent to these receivers.

Change-Id: I06f500c20ae0a20d689cf0805b6a82247ea55e73
Fix: 118387886
Test: robotests
2019-03-27 18:47:19 -07:00
Hugh Chen
7b770d6a87 Merge "[Fix] Unable to show output device indicator after reboot" 2019-03-28 01:39:52 +00:00
Salvador Martinez
194abe94d0 Update dark mode in accessiblity settings
There was an entry point to dark mode that wasn't updated when the
display settings one was changed to point to a new screen. This
change makes it so that clicking dark mode in accessiblity also
opens the same screen.

Test: robotests pass
Bug: 129406772
Change-Id: I0ad830638e04e5520cdf7de6927764fa6b68a179
2019-03-27 18:29:40 -07:00
TreeHugger Robot
e5f8b74f38 Merge "Log RecyclerView click position" 2019-03-28 00:55:18 +00:00
Malcolm Chen
a05e6f8182 Correct name of PRIMARY_SUBSCRIPTION_LIST_CHANGED.
Correct name of PRIMARY_SUBSCRIPTION_LIST_CHANGED in manifest.
Also, make sure SimSelectNotification only listens to that intent.

Bug: 128645056
Test: manual
Change-Id: I008e5346ff1e015d1aa57ca31844426e33bd99b8
2019-03-27 17:53:22 -07:00
Salvador Martinez
c4d86b081b Update battery saver schedule to show warning
If a user tries to enable a battery saver schedule we want
to show them the battery saver warning if they haven't seen it.
This CL does that.

Test: robotests pass, manual verification
Bug: 128924009
Change-Id: I683279716ac7700043b1a01f88bdf2ae716eeece
2019-03-27 17:40:23 -07:00