Commit Graph

2911 Commits

Author SHA1 Message Date
Weng Su
6662a94c23 [RESTRICT AUTOMERGE] Revert "Add permission checking to WifiDialogActivity" am: 34b571612f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15959646

Change-Id: Ica11fe7e996e2e7ddf20572b4d84f1e5637a846c
2021-10-06 19:08:49 +00:00
Weng Su
34b571612f [RESTRICT AUTOMERGE] Revert "Add permission checking to WifiDialogActivity"
This reverts commit 71e728e934.

Reason for revert: rollback CLs to avoid compatibility risks

Bug: 185126813
Change-Id: I9251eb35ecba9bcc07eb3763c47c3ad7f55897f1
2021-10-04 07:29:56 +00:00
Weng Su
f603e671e7 [RESTRICT AUTOMERGE] Revert "Add permission checking to WifiDialogActivity"
This reverts commit 71e728e934.

Reason for revert: rollback CLs to avoid compatibility risks

Bug: 185126813
Change-Id: I9251eb35ecba9bcc07eb3763c47c3ad7f55897f1
2021-10-03 18:26:32 +00:00
Weng Su
cabcecb2e8 [RESTRICT AUTOMERGE] Revert "Add SafetyNet logging"
This reverts commit 199528d460.

Reason for revert: rollback CLs to avoid compatibility risks

Bug: 185126813
Change-Id: I5ed1782f1a35681ab6be4f74ea3156420b7dad5f
2021-10-01 15:06:20 +00:00
Weng Su
f1f0353ed7 [RESTRICT AUTOMERGE] Revert "Add SafetyNet logging"
This reverts commit 199528d460.

Reason for revert: rollback CLs to avoid compatibility risks

Bug: 185126813
Change-Id: I5ed1782f1a35681ab6be4f74ea3156420b7dad5f
2021-10-01 14:51:33 +00:00
Treehugger Robot
d2bb46dfc9 Merge "[Settings] backport missing CL" am: a8ee80e95a am: 15c0678ca8 am: da36a07df1 am: 577abc36f7 am: 7f24ff7dc9
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1836333

Change-Id: I1d5164ad4d378d493e8d711116ffc34b3501f49d
2021-09-24 11:28:48 +00:00
Treehugger Robot
7f24ff7dc9 Merge "[Settings] backport missing CL" am: a8ee80e95a am: 15c0678ca8 am: da36a07df1 am: 577abc36f7
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1836333

Change-Id: I2ce19df31bed53387b96a7a1104380a939994753
2021-09-24 11:13:57 +00:00
Treehugger Robot
577abc36f7 Merge "[Settings] backport missing CL" am: a8ee80e95a am: 15c0678ca8 am: da36a07df1
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1836333

Change-Id: I684ceac5e6c70a2766b0dc3e14f2c8b40e4ad806
2021-09-24 10:53:17 +00:00
Treehugger Robot
15c0678ca8 Merge "[Settings] backport missing CL" am: a8ee80e95a
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1836333

Change-Id: I09f384d8d7073270d4bf460e91a52021a69e3e19
2021-09-24 10:24:31 +00:00
Bonian Chen
dc3c1e8a4b [Settings] backport missing CL
aosp/1258356 got missing when merging several CLs of refactor code in
aosp/1281915.

Bug: 186543910
Test: local
Change-Id: I34287b22fec4da660c7b44b5953eb16591cfb2d7
2021-09-24 15:45:30 +08:00
TreeHugger Robot
24a1b8150b Merge "Fix QR code scanner layout in "Pair devices over Wi-Fi" page." into sc-qpr1-dev am: 85d20f5957 am: 1fc8de7343
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15854410

Change-Id: I62c2812fd8fc095bdf90ecf1595c62f1c42e953e
2021-09-22 09:31:12 +00:00
TreeHugger Robot
6b5973c48e Merge "Fix QR code scanner layout in "Pair devices over Wi-Fi" page." into sc-qpr1-dev am: 85d20f5957
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15854410

Change-Id: Ia5440a9db8bf15ced28fcca5de37e2a086cba41a
2021-09-22 09:22:02 +00:00
TreeHugger Robot
85d20f5957 Merge "Fix QR code scanner layout in "Pair devices over Wi-Fi" page." into sc-qpr1-dev 2021-09-22 09:08:25 +00:00
TreeHugger Robot
f396d920b6 Merge "Minor change to Wi-Fi WPA3 password length restriction" into sc-qpr1-dev am: 6263fd9471 am: 03f1947b2c am: b63f60f87d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15860293

Change-Id: I1de49fd6bce3bd2cbb25a7b8e2d6639e7f917ae6
2021-09-22 07:00:55 +00:00
TreeHugger Robot
b63f60f87d Merge "Minor change to Wi-Fi WPA3 password length restriction" into sc-qpr1-dev am: 6263fd9471 am: 03f1947b2c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15860293

Change-Id: I95aeac99a8c8da059dc3957f6fa488ba888c905e
2021-09-22 06:48:58 +00:00
TreeHugger Robot
c19d945d4a Merge "Minor change to Wi-Fi WPA3 password length restriction" into sc-qpr1-dev am: 6263fd9471
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15860293

Change-Id: I9654d63716d62d83244c96dfb08548623686fbc7
2021-09-22 06:36:58 +00:00
Weng Su
caa29d401b Minor change to Wi-Fi WPA3 password length restriction
- Change the maximum length limit to 128

Bug: 200305860
Test: manual test
make RunSettingsRoboTests ROBOTEST_FILTER=WifiConfigController2Test

Change-Id: Ia739dab35da75c73e28077ccc81979253def6128
2021-09-20 22:38:29 +08:00
Joshua Duong
c960e8973a Fix QR code scanner layout in "Pair devices over Wi-Fi" page.
The toolbar needs to be disabled to remove the empty space at the top
of the page. Also added the landscape layout xml.

Bug: 193602141
Test: atest SettingsUnitTests and manual

Change-Id: I30368835979b360a8f09e16f70adf57064784517
(cherry picked from commit fd009229e5)
2021-09-17 15:36:32 +00:00
Wilson Wu
395e839b10 Merge "Update settings PrimarySwitchPreference reference" 2021-09-07 02:51:20 +00:00
Pasty Chang
fa780e76e5 Merge "Fixed WiFi dialog force closed when physical window size is changed." into sc-v2-dev am: 25ff749e7b am: 6b3c1efab2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15734709

Change-Id: I4c176ed96a2ef7db5e07ec231ad42f500cdab179
2021-09-02 10:00:34 +00:00
Pasty Chang
25ff749e7b Merge "Fixed WiFi dialog force closed when physical window size is changed." into sc-v2-dev 2021-09-02 09:34:43 +00:00
Wilson Wu
9edf79741d Update settings PrimarySwitchPreference reference
To make InputMethodPreference support 2 target
reference, CL[1] move the PrimarySwitchPreference
into SettingsLib.

Change all PrimarySwitchPreference reference to
Settingslib one and remove the original one.

[1]: Idea3935d95b8d22b00ca89313e9eb3e979e4aa74

Bug: 197705032
Test: Presubmit
Change-Id: I95d111522344bb7cbdd380382e48fe60a5ebc9a2
2021-09-02 13:10:19 +08:00
pastychang
38c857bd60 Fixed WiFi dialog force closed when physical window size is changed.
When window size is changed, dialog should not be dismissed on the destroy. It will cause dialog to be shown from on create and then dismissed from on the destroy right away.

Bug: 190573335
Test: manual
Change-Id: I995c3cbf90a9ec3c5305ef57e655b0b0eb7cf5cc
2021-09-01 06:52:44 +00:00
Weng Su
1f6f807834 Don't show Wi-Fi icon if the level is -1
Bug: 195893448
Test: manual test
make RunSettingsRoboTests
ROBOTEST_FILTER=NetworkRequestDialogFragmentTest

Change-Id: Ifddc9aace42d1f024b7c861b1207f651061d790b
(cherry picked from commit 7e14668094)
Merged-In: Ifddc9aace42d1f024b7c861b1207f651061d790b
2021-08-30 22:55:26 +00:00
Joshua Duong
12f0a063ac Merge "Fix QR code scanner layout in "Pair devices over Wi-Fi" page." 2021-08-25 15:35:56 +00:00
Zoey Chen
2a87acf247 Merge "Add new ACTION_WIFI_DETAILS_SETTINGS to Settings" into sc-qpr1-dev 2021-08-25 06:04:30 +00:00
Weng Su
1fe8220afa Add new ACTION_WIFI_DETAILS_SETTINGS to Settings
- Need to export the interface to Quick Settings to launch Wi-Fi Network
details settings.

- Rename WifiNetworkDetailsFragment.class

Bug: 191475923
Test: manual test with the topic CLs.
make RunSettingsRoboTests
atest -c SettingsUnitTests:com.android.settings.wifi \
         SettingsUnitTests:com.android.settings.network

Change-Id: Id2fd8c9b3b113ffbb49168305b05c67392fa4d87
(cherry picked from commit e8a4e13a80)
Merged-In: Id2fd8c9b3b113ffbb49168305b05c67392fa4d87
2021-08-17 08:14:55 +00:00
changbetty
3043c87f98 Remove some attributes to move the dialog window up
Bug: 192815830
Test: Manual test
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiDialog2Test
Change-Id: Ia8ce6cfa19cd5d57695dc0092b1585d8cad5a8d7
Merged-In: Ia8ce6cfa19cd5d57695dc0092b1585d8cad5a8d7
2021-08-16 08:34:06 +00:00
changbetty
6871807a95 Set the attribute of the dialog window for overlay QS internet panel
Bug: 190460969
Test: Manual test
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiDialog2Test

Change-Id: I1acdfb09393163bb94824fe2b3bad0391ba4fb53
Merged-In: I1acdfb09393163bb94824fe2b3bad0391ba4fb53
2021-08-16 08:32:47 +00:00
Joshua Duong
fd009229e5 Fix QR code scanner layout in "Pair devices over Wi-Fi" page.
The toolbar needs to be disabled to remove the empty space at the top
of the page. Also added the landscape layout xml.

Bug: 193602141
Test: atest SettingsUnitTests and manual

Change-Id: I30368835979b360a8f09e16f70adf57064784517
2021-08-12 18:44:15 +00:00
Weng Su
7e14668094 Don't show Wi-Fi icon if the level is -1
Bug: 195893448
Test: manual test
make RunSettingsRoboTests
ROBOTEST_FILTER=NetworkRequestDialogFragmentTest

Change-Id: Ifddc9aace42d1f024b7c861b1207f651061d790b
2021-08-12 23:04:31 +08:00
Quang Luong
cbb0b73aed Remove NetworkScoreManager from WifiTrackerLib classes
NetworkScoreManager is being removed from WifiTrackerLib classes since
it was used for network scoring, which is being removed from the
Wifi picker UI. Remove the NetworkScoreManager argument from the
WifiTrackerLib constructors.

Bug: 194521441
Test: build
Change-Id: I60a1dcdc926f6494f1ef54b197e49992668f16ec
2021-07-26 11:10:27 -07:00
Weng Su
54b45141b5 Refactor InternetIconInjector to SettingsLib
- Plan to share the InternetIconInjector class to System UI.

Bug: 192923176
Test: manual test
atest WifiEntryPreferenceTest

Change-Id: I6c15e49478f4fff54fbbb62b04c0b371e5acd3d8
2021-07-21 20:43:42 +08:00
Weng Su
e8a4e13a80 Add new ACTION_WIFI_DETAILS_SETTINGS to Settings
- Need to export the interface to Quick Settings to launch Wi-Fi Network
details settings.

- Rename WifiNetworkDetailsFragment.class

Bug: 191475923
Test: manual test with the topic CLs.
make RunSettingsRoboTests
atest -c SettingsUnitTests:com.android.settings.wifi \
         SettingsUnitTests:com.android.settings.network

Change-Id: Id2fd8c9b3b113ffbb49168305b05c67392fa4d87
2021-07-19 09:29:33 +00:00
Bill Yi
7976c5bc51 Merge RQ3A.210705.001 to aosp-master - DO NOT MERGE
Merged-In: Ie37d07ed9cbce12b9dcd39b332ed2ae66f3edf6c
Merged-In: I777bae14ea865ecf1607e1d660fe3102a9b8fa6d
Merged-In: I777bae14ea865ecf1607e1d660fe3102a9b8fa6d
Change-Id: I0f793ed1ea64127903c6dc906c5afa1db15fff48
2021-07-12 11:08:29 -07:00
Betty Chang
3b725057fb Merge "Remove some attributes to move the dialog window up" 2021-07-09 08:31:11 +00:00
changbetty
cfb994c644 Remove some attributes to move the dialog window up
Bug: 192815830
Test: Manual test
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiDialog2Test
Change-Id: Ia8ce6cfa19cd5d57695dc0092b1585d8cad5a8d7
2021-07-09 03:59:14 +00:00
Bonian Chen
a415ecb608 Merge "[Settings] fix for Wifi calling settings page crash" into sc-dev 2021-07-06 15:46:37 +00:00
Bonian Chen
e530d93382 [Settings] fix for Wifi calling settings page crash
UI crash reported due to accessing telephony framework API with invalid
subscription ID from SIM. Which comes with multiple reason.

Besides of avoidance of crash, following updates are also required:
1. Close wifi calling settings UI when pSIM or eSIM not available or
inserted.
2. Keep the selection of tab (under multi-SIM) when screen rotate
3. Only show 1 SIM when multi-SIM are grouped together

Bug: 149190278
Test: local
Change-Id: Ied9a088b6ee5da66972f27649cc07f4a31304f17
(cherry picked from commit fbe1293a54)
(cherry picked from commit 05f29efe34)
2021-07-06 12:38:45 +00:00
Linus Tufvesson
59c0a7bc63 Make WifiDppEnrolleeActivity launches explicit
Bug: 180518134
Test: make RunSettingsRoboTests \
ROBOTEST_FILTER=WifiDppUtilsTest\|WifiDialogActivityTest
Test: Manually verified b/180518134 attack is no longer possible

Change-Id: I8c4e1e17117582c78671d0e4658bd87715a9a046
2021-07-06 12:09:10 +00:00
Bonian Chen
cdc38ae878 Merge "[Settings] Avoid from Exception breaks the rule" 2021-07-06 06:54:16 +00:00
Weng Su
c830e466f2 Add SafetyNet logging am: 199528d460 am: 7066e8a96c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15206403

Change-Id: Icf374bbec95cc23d0be593c1e183f5d46c142c69
2021-07-05 10:15:29 +00:00
Bonian Chen
05f29efe34 [Settings] Avoid from Exception breaks the rule
When querying subscription(s) which not supported by telephony framework
could lead to exception. Which will lead to incorrect control in code
flow when filtering subscriptions which support WiFiCalling out of all
subscriptions available.

Bug: 149190278
Test: local
Change-Id: I3b8bcea6c724cad83559159ed9435f0710594b83
2021-07-05 16:29:33 +08:00
Weng Su
199528d460 Add SafetyNet logging
- Add SafetyNet log if the calling package is no the permission for
result

Test: checked eventlog in the bugreport
Bug: 185126813
Change-Id: I1535f6f2ded2445702df0d723518b773cd094164
2021-07-05 16:02:40 +08:00
TreeHugger Robot
5432cf9eba Merge "Add permission checking to WifiDialogActivity" into sc-dev am: 27c928856e am: 48ddec81c9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15187819

Change-Id: I45a70c5bf9ad7fb24f4f51fb6dc4abde1db1c156
2021-07-05 03:21:35 +00:00
Weng Su
71e728e934 Add permission checking to WifiDialogActivity
- Use getCallingPackage() to get calling package.

- Check if the calling package has ACCESS_COARSE_LOCATION or
ACCESS_COARSE_LOCATION permission.

- Only set result data to permission granted callers

Bug: 185126813
Test: manual test
make RunSettingsRoboTests ROBOTEST_FILTER=WifiDialogActivityTest

Change-Id: If7ca069c842ed2bd1aed23f9d4041473c68a4dad
2021-07-02 23:10:11 +08:00
Betty Chang
ac621ef76c Merge "Set the attribute of the dialog window for overlay QS internet panel" 2021-07-01 10:13:19 +00:00
changbetty
767681812b Set the attribute of the dialog window for overlay QS internet panel
Bug: 190460969
Test: Manual test
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiDialog2Test

Change-Id: I1acdfb09393163bb94824fe2b3bad0391ba4fb53
2021-07-01 07:41:11 +00:00
TreeHugger Robot
49ab6f7ba5 Merge "Fix the multiple instences of NetworkProviderSettingsActivity issue" into sc-dev am: b121a52359 am: 87baaeb505
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15135727

Change-Id: I1d3fd2c6ded732e4815d0c5dc913fbd11a205a07
2021-06-29 13:39:08 +00:00
Weng Su
5796ebf67f Fix the multiple instences of NetworkProviderSettingsActivity issue
- Use the command "adb shell dumpsys window" to dump how many
activities/windows currently on the system.
  Then search for section like "Task display areas in top down Z order"

Bug: 191956700
Test: manual test
Use "adb shell dumpsys window" to check no more multiple instences

Change-Id: Ie9e04db3db601fbeee9beceedb81929cd6eba439
2021-06-29 17:15:55 +08:00