Commit Graph

3686 Commits

Author SHA1 Message Date
Tim Peng
aeabfc3050 Add a separate line at the bottom of list area in output switcher
-Bottom divider is not showed when there are more than 7 devices exist in output switcher
-Check panel type in isDividerAllowedBelow()
-Hide the Slice bottom divider of Output switcher panel
-Show divider in panel layout only for output switcher panel

Bug: 159177275
Test: make -j42 RunSettingsRoboTests

Change-Id: I49396a0ee0543b494a2b3d714ec248ebab08e7ba
2020-06-20 03:44:43 +00:00
Bonian Chen
97de75fa83 Merge "[Settings] Allow talkback to focus and select APN" into rvc-dev 2020-06-15 07:51:17 +00:00
Bonian Chen
723c251c13 [Settings] Allow talkback to focus and select APN
Change the focus area to help talkback focus on APN items.

Bug: 149794675
Test: manual
Change-Id: I5f391be89a5b22095d6f0d04b187ea18970f18d4
2020-06-15 03:08:31 +00:00
tim peng
7874c0fdc4 Merge "Refine layout for output switcher panel" into rvc-dev 2020-06-15 01:14:57 +00:00
TreeHugger Robot
d9a246c49e Merge "Explicitly request focus after button pressed" into rvc-dev 2020-06-13 00:19:44 +00:00
Beverly
258fd7c03b Explicitly request focus after button pressed
Don't use focusableInTouchMode, it was causing focus/clickability issues
when the device wasn't in touch mode.

Test: manually tap button (tap works first try)
Test: turn on talkback and toggle buttons, also try toggling QS tile
while on the Settings page - doesn't reannounce state
Fixes: 158717450
Change-Id: I785d0200dd61235aa3308a8588f9ee998e7cb6e5
2020-06-12 16:01:50 +00:00
Tim Peng
9bdeef43fd Refine layout for output switcher panel
1. only make the output switcher tall enough to show 6.5 devices
2. enlarge album art to 52*52 and keep same size on group panel
3. reduce panel header top padding
4. enlarge slice first item top padding
5. update slider bar right padding
6. update panel height
7. align slice title item left with panel title icon
8. enlarge slice end item right padding

Bug: 156045699
Test: manual test
Change-Id: I51321d98ef483665689b7e258d6071df76382759
2020-06-12 15:15:00 +08:00
tim peng
c21406a0a2 Merge "Output switcher panel requires large title icon for Slice slider style" into rvc-dev 2020-06-12 04:58:04 +00:00
Tim Peng
27b0ef6eb3 Output switcher panel requires large title icon for Slice slider style
-Add "VIEW_TYPE_SLIDER_LARGE_ICON" to be a new panel type which would enlarge its title icon
-Set "VIEW_TYPE_SLIDER_LARGE_ICON" to MediaOutputPanel and MediaOutputGroupPanel
-Extend slider style and add customized icon size
-Add test cases

Bug: 157208551
Test: make -j42 RunSettingsRoboTests
Change-Id: I9b4de4aa552e8b26e766411f7eff93ea1a2d1910
2020-06-12 11:22:17 +08:00
TreeHugger Robot
6647ac93d4 Merge "Add app icons to leasee view in shared data dev options." into rvc-dev 2020-06-10 07:35:36 +00:00
Varun Shah
8d5cb9a2d0 Add app icons to leasee view in shared data dev options.
Also disable clicking the header view and list items in the same view.

Bug: 156671006
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SharedDataPreferenceControllerTest
Test: manual (visual)
Change-Id: I2821bc6cdc523097283ab44b864088278850be53
2020-06-09 19:04:36 -07:00
TreeHugger Robot
eef7b5e7e3 Merge "Add blob size to shared data dev options screens." into rvc-dev 2020-06-09 06:36:21 +00:00
Varun Shah
c920a58d5f Add blob size to shared data dev options screens.
Bug: 156671006
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SharedDataPreferenceControllerTest
Test: manual (visual)
Change-Id: Ia98c3d9812f6225ee834b4d1b0f12a1a73a87598
2020-06-05 22:19:26 -07:00
Hiroki Sato
8870dcb421 Fix keyboard navigation work in Settings home page
Bug: 156196960
Bug: 156565546
Test: manually confirmed tab or arrow key moves input focus.
Change-Id: Ic2eb6395b490c97c8d82722ce1ba3a79d535ade2
2020-06-05 14:42:34 +09:00
TreeHugger Robot
56c820fb65 Merge "Some text polish" into rvc-dev 2020-06-01 22:58:03 +00:00
Robert Luo
42b884eb91 Merge "Fix RTL alignment issue in the "How it works" page of Contactless payment settings" into rvc-dev 2020-06-01 22:47:43 +00:00
Julia Reynolds
e32e6cc981 Some text polish
- Update styles and alignment

Test: manual
Fixes: 157769522
Change-Id: I92113b5e7a918e1ec31acb64aa10457f4c762760
2020-06-01 14:57:30 -04:00
Robert Luo
9851295961 Fix RTL alignment issue in the "How it works" page of Contactless
payment settings

Bug: 156717675
Screenshot: https://screenshot.googleplex.com/RpqdmjhmTaP.png
Test: make -j42 RunSettingsRoboTests
Change-Id: I12064adb2c510d281358f22e6ee1de9682079fcd
2020-05-31 13:41:54 +08:00
Andras Kloczl
106431e525 Improve multi user functionality for restricted users
- Restricted users can change their name
- Improved App&Content access screen
- Remove "Turn on phone calls" from restricted user detail page

Doc: http://shortn/_Prb3SJ3xJ3
Bug: 142798722
Test: Run robo tests with this command:
  make -j64 RunSettingsRoboTests
Change-Id: I2aadf32aef52ba5ad0db7aa0cd83bac9d9941589
(cherry picked from commit f4759e00d5)
2020-05-29 12:55:18 +00:00
Edgar Wang
1821ab5e5b Merge "[a11y] Fix Talkback speak "Edit box, Nickname" for "Select photo" button." into rvc-dev 2020-05-28 04:43:17 +00:00
Julia Reynolds
ef4c044053 Some notification history fixes
- Update header count when item swiped away
- Clean up container when last notification is swiped away
- Long pressing on the top two section brings you to settings to
modify notification behavior
- Show more notification content

Test: manual
Bug: 157547283
Change-Id: I1d43cacca7a0f22f83cef9187cf288839e0d5795
2020-05-27 09:45:32 -04:00
Edgar Wang
24ac9876d1 [a11y] Fix Talkback speak "Edit box, Nickname" for "Select photo" button.
In multi-user Profile info dialog, set labelFor will set the editbox
which serves as the label of the iconview represented by this info for
accessibility purposes.
But since both of views have different purposes, we should not set label
for icon.

Bug: 141455211
Test: manual
Change-Id: I6c7087fc7d2bcc75c388992c1a2b8ecc010cc279
2020-05-27 13:21:29 +08:00
Julia Reynolds
edca211a67 Merge "clean up layout & styling of notification history" into rvc-dev 2020-05-22 11:23:59 +00:00
Julia Reynolds
9e78ec75d1 Update conversation-related strings
Test: atest
Bug: 157215227
Change-Id: Iba279bb285e53918a1e1b43c04d6ec7576cd48a0
2020-05-21 20:49:53 +00:00
Julia Reynolds
2679bf5af0 clean up layout & styling of notification history
Test: manual
Fixes: 157161601
Fixes: 157162238
Fixes: 157160265
Fixes: 157161125
Fixes: 157160611
Fixes: 157158944
Change-Id: I9853426987549898b7996e9db43f7767e4c41641
2020-05-21 14:55:51 -04:00
Peter_Liang
f78e7f5976 Refine the banner view for accessibility features.
1. Replace the video with the gif for Magnification.
2. Replace the static image with the gif for Color Inversion.

Bug: 153293657
Bug: 155946967
Test: manual test & robo test
Change-Id: Ic51c0ec45c10a7fd2b9f1ffb63865ebc764846ba
Merged-In: Ic51c0ec45c10a7fd2b9f1ffb63865ebc764846ba
2020-05-18 19:04:28 +08:00
TreeHugger Robot
3370e0304f Merge "Add bottom padding of profile group on Bluetooth detail page" into rvc-dev 2020-05-18 08:54:39 +00:00
hughchen
1df322225b Add bottom padding of profile group on Bluetooth detail page
- This CL add a bottom padding preference to make UI consistency.
- Update test case

Bug: 146522686
Test: make -j42 RunSettingsRoboTests
Change-Id: I525d8a3b71535972755de92924a3c04768f68e63
2020-05-18 13:17:15 +08:00
Julia Reynolds
35a839a689 Merge "Fix jank on conversation screen" into rvc-dev 2020-05-16 02:30:09 +00:00
Julia Reynolds
f0c3245639 Fix jank on conversation screen
Onboarding should only appear if needed

Test: manual
Fixes: 156756305
Change-Id: I663677772806db9c80979cdac103c9fa657ee7e2
2020-05-15 19:41:12 +00:00
TreeHugger Robot
abeb1a09fa Merge "Remove divider after last items" into rvc-dev 2020-05-13 20:01:52 +00:00
Julia Reynolds
9a6e7329be Remove divider after last items
Fixes: 155890866
Test: manual
Change-Id: Ie0e3f7ad8c1868bda7623718dd60926c300fa353
2020-05-13 14:03:40 -04:00
Pasty Chang
e060311358 Merge "Set the text of accessibility description in suw to center" into rvc-dev 2020-05-13 03:03:50 +00:00
pastychang
ca42bd3efc Set the text of accessibility description in suw to center
Bug: 155509097
Test: manual
Change-Id: I774ec3b58b9ff9ac38d8063a72d309af70708c84
2020-05-12 19:50:26 +08:00
TreeHugger Robot
252b726d7b Merge "Single line for output switcher panel title" into rvc-dev 2020-05-08 07:22:56 +00:00
TreeHugger Robot
6ea346edfe Merge "Leverage the panel title font size of non-first row" into rvc-dev 2020-05-08 06:20:47 +00:00
Tim Peng
b549c0f615 Single line for output switcher panel title
Bug: 155956511
Test: manual
Change-Id: I2c33783d55c0ab5358b7fd1f4a0f405b3e25ff2b
2020-05-08 13:49:08 +08:00
Jason Chiu
65e08df980 Leverage the panel title font size of non-first row
The title of non-first row in a slice has smaller font size by default.

- Sync the font size with the one of the first row.
- Also rename the related styles in style.xml
- Let homepage slices has smaller font on non-first row based on UX
  design.

Bug: 152831413
Test: visual
Change-Id: I87c2008745adb68c031dc2d4e15b93bccfea12b0
2020-05-08 12:50:47 +08:00
Andras Kloczl
4d7d4effa5 Improve multi user settings screen
- Added switch and user delete functionality to details screen.
- Added robo tests.

Screenshots: http://shortn/_S6fbIMhAYO
Bug: 142798722
Test: Run robo tests with this command:
  make -j64 RunSettingsRoboTests ROBOTEST_FILTER="com.android.settings.users.*SettingsTest"
Change-Id: Ied67290e8fed87feb0a60a3f2c40eb91cc57988e
2020-05-07 22:01:33 +01:00
PETER LIANG
dd1e66c199 Merge "Refines the animated image to fit the screen display." into rvc-dev 2020-05-07 16:11:22 +00:00
Edgar Wang
e13919cf4b Merge "Revert "Improve multi user settings screen"" into rvc-dev 2020-05-07 09:28:23 +00:00
Edgar Wang
fff8c56de2 Revert "Improve multi user settings screen"
This reverts commit d19dc306dd.

Reason for revert: this CL made Settings the test cases called shadowUserManager.hasUserRestriction()
https://sponge.corp.google.com/target?show=FAILED&sortBy=STATUS&id=07150153-ccb7-4215-a9f8-eed31e44c66f&target=RunSettingsRoboTests1-test-output

Bug: 142798722

Change-Id: I3937a07ee35a472cadd6db8cd0177e08e63516a4
2020-05-07 09:24:47 +00:00
Peter_Liang
a87a7009b0 Refines the animated image to fit the screen display.
Root cause:
The width and height of animated image are wrap_content. It causes the gif or drawable which are non-transparent background to have a little weird display under dark mode.

Next:
1. Revise the width from wrap_content to match_parent, and add the fit center scale type.
2. Correct the function usage

Bug: 155946967
Test: manual test
Change-Id: I7470efb945a2b3bedb695e1b6f34475c6f190f9d
2020-05-07 08:06:20 +00:00
TreeHugger Robot
a49498f048 Merge "Fix the layout direction problem in RTL locale" into rvc-dev 2020-05-07 01:59:25 +00:00
Sunny Shao
fdf6273580 Fix the layout direction problem in RTL locale
Fixes: 153851006
Test: manual test
Change-Id: I46822b58b9584168e8b1fe2a3946fbdd3697b6f4
2020-05-06 19:53:03 +08:00
tim peng
4ed5c3aac4 Merge "Add 12dp padding above the first slice item" into rvc-dev 2020-05-06 05:00:36 +00:00
Tim Peng
2f47d771fb Add 12dp padding above the first slice item
-Add an extra padding in adapter for dedicated panels
-Add test cases

Bug: 154181365
Test: manual test
make -j50 RunSettingsRoboTests
"adb shell am start -a android.settings.panel.action.INTERNET_CONNECTIVITY"

Change-Id: I65bc26c23ca5a7f1b433c36ac7ddf1a658793719
2020-05-06 09:04:25 +08:00
Andras Kloczl
d19dc306dd Improve multi user settings screen
- Added switch and user delete functionality to details screen.
- Added robo tests.

Screenshots: http://shortn/_S6fbIMhAYO
Bug: 142798722
Test: Run robo tests with this command:
  make -j64 RunSettingsRoboTests ROBOTEST_FILTER="com.android.settings.users.*SettingsTest"
Change-Id: Id51c12c5470e30e2dffe93f3bd8c22380d8bdc1f
2020-05-05 13:45:01 +01:00
Arc Wang
032f77052b Merge "[Wi-Fi] Modify NetworkRequestDialog title & summary" into rvc-dev 2020-05-05 01:02:05 +00:00
Julia Reynolds
815ee670c9 Center text even if string is long
Test: manual in Armenian language
Fixes: 154930071
Change-Id: I61a84958a2043d36241b6fa5eff8dcb2c7ef0db0
2020-04-30 13:05:04 -04:00