Commit Graph

3671 Commits

Author SHA1 Message Date
Mill Chen
10829a2164 Merge "Clean up in-code preference controllers from accessibility" 2019-07-10 09:21:22 +00:00
Kevin Chang
4d609c0198 Merge "Add footer preference into caption preferences" 2019-07-10 01:05:31 +00:00
Mill Chen
6f3b222ca5 Clean up in-code preference controllers from accessibility
Bug: 135056871
Test: manual, robotests
Change-Id: I0c1358657d3f57ddae2b8f2b12ee610e7363f41f
2019-07-09 17:35:32 +08:00
Mill Chen
d2d1801e3b Separate long press timeout preference controller form accessibility
Bug: 135056871
Test: manual, robotests
Change-Id: If49e4336b3461ec2a9568b8652c5aab0ff64ecfe
2019-07-03 21:27:34 +08:00
Mill Chen
08c4c4aadd Separate shortcut preference controller form accessibility
Bug: 135056871
Test: manual, robotests
Change-Id: I1dc61d50f46dfbd9bbd6fa33ecbc03157427d0b1
2019-07-03 20:15:09 +08:00
Julia Reynolds
6b0315fbc1 Merge "Move channel listing into a pref controller" 2019-07-02 18:10:12 +00:00
TreeHugger Robot
08e3b42a28 Merge "Separate daltonizer preference controller form accessibility" 2019-07-02 17:13:15 +00:00
Julia Reynolds
a295d71c94 Move channel listing into a pref controller
And a hidden preference category. This makes
hiding/showing the list a lot cleaner and also allows more
of the code to be tested.

Also delete some unused code that no longer complied after
this refactor.

Fixes: 133443871
Test: atest
Change-Id: I4a5fe0e075019bae2df44a0a9dcec26a40ee6d12
2019-07-02 11:24:50 -04:00
TreeHugger Robot
74e5e4fd26 Merge "Fix talkback issue about announcing wrong number of items" 2019-07-02 07:46:23 +00:00
Stanley Wang
29a15fb7be Merge "Fix Settings search result 'add an account' does nothing." 2019-07-02 07:45:24 +00:00
Mill Chen
8d240c7f28 Separate daltonizer preference controller form accessibility
Bug: 135056871
Test: manual, robotests
Change-Id: Ibc730004f1a25a2e97abcc0bbad2dfc9b420d645
2019-07-02 15:08:17 +08:00
tmfang
b981068248 Fix talkback issue about announcing wrong number of items
From hierarchical view, one of root cause is PreferenceCategory.
Looks like PreferenceCategory generates an invisible space when
we add a footerPreference as a child.

So, we remove PreferenceCategory directly, and declard "allow divider"
attribute for neccessary preferences.

Test: Visual
Fixes: 130396913
Change-Id: I6d56ac165633aa211e794e07417821066380d041
2019-07-02 02:33:05 +00:00
TreeHugger Robot
422c953beb Merge "Add synonym for "Display over other apps"" 2019-07-01 11:52:24 +00:00
Mill Chen
7f995a609d Separate caption preference controller from accessibility
Bug: 135056871
Test: manual, robotests
Change-Id: Ibcc867f09b6b9cf8cd27b2d93241042b4f88c62d
2019-07-01 17:04:00 +08:00
Stanley Wang
1903470bfb Fix Settings search result 'add an account' does nothing.
Tap 'add an account' from search results will launch ChooseAccountFragment,
this way doesn't invoke AddAccountSettings and the add account service of gms
won't be triggered, so the items on the fragment will do nothing.

Move the key word to the search synonym of AccountDashboardFragment
and remove it from ChooseAccountFragment, the search result will invoke
AccountDashboardFragment.

Fixes: 133511289
Test: maunal
Change-Id: I67fa004c4965da37c59cada6ca27752e9fe7202b
2019-07-01 14:56:20 +08:00
Kevin Chang
8f4b8b9a74 Add footer preference into caption preferences
Add footer preference into caption preferences to tell users
that the setting doesn't support all apps.

Bug: 135888603
Test: Visual
Change-Id: I95e0aa301eba7343fbc798cc406c0242f4f4eb7e
2019-07-01 14:51:36 +08:00
Yi-Ling Chuang
992b8d00cd Add synonym for "Display over other apps"
Add "draw" to the search keyword list as this item was renamed from
"Draw over other apps".

Bug: 135665821
Test: robotests and search keyword draw
Change-Id: Ifdb35d021f5efa15ebc754ff18734c806e643c5e
2019-07-01 14:19:10 +08:00
TreeHugger Robot
eaddedae58 Merge "Separate vibration preference controller from accessibility" 2019-07-01 05:03:47 +00:00
tmfang
32600e06d1 Merge "Add summary for white balance feature" into qt-r1-dev am: 9cd8167bff
am: ef24931fd8

Change-Id: I9b205093afd8e9280b529fdc64e6b6c70cc94a77
2019-06-29 04:58:32 -07:00
TreeHugger Robot
9cd8167bff Merge "Add summary for white balance feature" into qt-r1-dev 2019-06-29 10:57:45 +00:00
Andrew Sapperstein
82ce229d4a Merge "Add UI for mainline modules licenses." into qt-dev am: 72aded338a am: 0c1f7da25a
am: 722f8c0ac1

Change-Id: Ib41961f01cfc6530a43e65e593a1248714f6143c
2019-06-28 11:07:18 -07:00
Andrew Sapperstein
722f8c0ac1 Merge "Add UI for mainline modules licenses." into qt-dev am: 72aded338a
am: 0c1f7da25a

Change-Id: I7e3ce8019cc4a411dec6ebf72b8518e1026ed73d
2019-06-28 10:47:58 -07:00
Andrew Sapperstein
647f685063 Merge "Add UI for mainline modules licenses." into qt-dev
am: 72aded338a

Change-Id: I93faf2c99489405fe82a75adf24f4d885bbe1558
2019-06-28 10:32:22 -07:00
Andrew Sapperstein
72aded338a Merge "Add UI for mainline modules licenses." into qt-dev 2019-06-28 16:56:04 +00:00
Mill Chen
5aa742bc00 Separate vibration preference controller from accessibility
Bug: 135056871
Test: manual, robotests
Change-Id: Ic309fd69b68bfa1c3290a696e0987de2621f6dc4
2019-06-28 11:38:13 +08:00
Mill Chen
79ce2c95f4 Separate mono audio preference controller from accessibility
Bug: 135056871
Test: manual, robotests
Change-Id: I839c07a3a61ae97f33b339d307734504c45a6622
2019-06-28 11:22:36 +08:00
TreeHugger Robot
1bcc2ff789 Merge "Separate auto click preference controller from accessibility" 2019-06-28 03:01:21 +00:00
Mill Chen
c786ae184b Separate power button preference controller from accessibility
Bug: 135056871
Test: manual, robotest
Change-Id: Ia3c2134bd9f88a39a796e4201f7bdf8c3015baa1
2019-06-27 22:59:55 +08:00
TreeHugger Robot
10fc07e72e Merge "Separate text contrast preference controller from accessibility" 2019-06-27 14:50:56 +00:00
Mill Chen
081ae31e7d Separate auto click preference controller from accessibility
Bug: 135056871
Test: manual, robotests
Change-Id: I5125fd79d0bc257ebf8108dd84d520d25a0ed669
2019-06-27 22:40:45 +08:00
Mill Chen
5da94319aa Separate text contrast preference controller from accessibility
Bug: 135056871
Test: manual, robotests
Change-Id: Ia28d8038f341a1a74385d168f78da8a10cca8fcd
2019-06-27 21:17:37 +08:00
tmfang
73ff438a86 Add summary for white balance feature
Create a string id for summary.
This string should be empty string for AOSP.

Test: visual
Bug: 134790233
Change-Id: I06b5d0b35ac08565d3496f8559f5bd85cd56c6b8
2019-06-26 17:57:48 +08:00
Mill Chen
d828275411 Separate large pointer preference controller from accessibility
Bug: 135056871
Test: manual, robotest
Change-Id: Id8e81f70d5121a97b6766b444298379f7ce062ea
2019-06-26 17:42:57 +08:00
TreeHugger Robot
01823a53af Merge "Separate disable animations preference controller from accessibility" 2019-06-26 08:42:03 +00:00
TreeHugger Robot
d5888bbf84 Merge "Separate a11y timeout preference controller from accessibility" 2019-06-26 08:38:11 +00:00
Mill Chen
223bf1b520 Separate a11y timeout preference controller from accessibility
Bug: 135056871
Test: manual, robotest
Change-Id: I00d40451b40c0a4d5e214b23d78139195d98e42b
2019-06-26 15:10:04 +08:00
Mill Chen
d2deb850d3 Separate disable animations preference controller from accessibility
Bug: 135056871
Test: manual, robotests
Change-Id: I14f322d91179779f2d758c58a2ed729efc0b45f5
2019-06-26 14:58:44 +08:00
Andrew Sapperstein
56a8c33c1b Add UI for mainline modules licenses.
Added a module licenses option that lives in Legal information settings.
Clicking that option opens module licenses page, which displays every
module by name, filtered to exclude modules without license files.
Clicking a module in the list opens HTMLViewer.

Created ModuleLicensesProvider, a new ContentProvider that serves as a
redirect for the Uris sent to HTMLViewer so that they open asset files.
In order to provide the redirect, the provider will write the license file
to a file in Settings' cache directory when the license does not exist
in the cache or is outdated. The provider then opens that cached file.

Fixes: 135183006
Test: robotests
Change-Id: I7d69da34780c8c4efb150d0c0411078c12bc80d8
2019-06-25 16:01:38 -07:00
Raff Tsai
50fca4ccdb Merge "Fix cannot switch between multiple TTS engines" 2019-06-25 15:32:15 +00:00
TreeHugger Robot
28b1277992 Merge "Use FooterPreference in xml explicitly" 2019-06-25 11:39:32 +00:00
tmfang
ec83f48e0d Use FooterPreference in xml explicitly
We don't rely on FooterPreferenceMixinCompat
to create footer preference in dashboard fragment.

Instead, declare a FooterPreference explicitly in
xml of screen.

Test: visual, robotest
Bug: 124129485
Change-Id: I4c5b60c3926583eb0d9f0d4cd6996bf169d6408c
2019-06-25 16:48:51 +08:00
Raff Tsai
a9fc062fd1 Fix cannot switch between multiple TTS engines
- We didn't reset reset radio button state when user click back
while dialog was popped. Change the UI, when user really accepts the
dialog content, then changes radio button state.
- Migrate TtsEnginePreferenceFragment to RadioButtonPickerFragment

Fixes: 135588938
Test: manual
Change-Id: Ia824e08d59c77a23e6590ff0f5b7d897a73a1ff8
2019-06-25 16:46:31 +08:00
Kevin Chang
5f5ac0b32f Merge "UI change in caption preferences in Settings" 2019-06-25 01:08:32 +00:00
Hai Zhang
089d734f35 Merge "Revert "Add special apps access settings page for financial app."" into qt-dev am: b39810f5ab am: 5f8c446f47
am: 3603e24840

Change-Id: I60a1cfb995b5511a9aeea19c851beec778472702
2019-06-24 14:37:31 -07:00
Hai Zhang
3603e24840 Merge "Revert "Add special apps access settings page for financial app."" into qt-dev am: b39810f5ab
am: 5f8c446f47

Change-Id: I4697c719c9274bd9a0ba5d4c8edf9e9a77454b7b
2019-06-24 14:32:28 -07:00
Hai Zhang
636920da48 Merge "Revert "Add special apps access settings page for financial app."" into qt-dev
am: b39810f5ab

Change-Id: Ia72e4fb5d1a7c930657ca26f15c58cd39220fe5e
2019-06-24 14:28:54 -07:00
Hai Zhang
71f2614736 Revert "Add special apps access settings page for financial app."
This reverts commit 43374eabb8.

Reason for revert: No longer needed because we are using whitelist for
SMS permission

Fixes: 135213238
Test: presubmit
Change-Id: I182be4a1136521f325866e70e875439c17816ef2
2019-06-24 21:11:36 +00:00
Kevin Chang
fd1f1c0f82 UI change in caption preferences in Settings
Move the switch after the caption preview and change the oreder of the
settings inside in caption preferences in Accessibility settings.

Bug: 130755332
Test: Visual
Change-Id: Icb4dabdef71be165a21d1bde474872ee0bb35bfa
2019-06-24 13:54:31 +08:00
Julia Reynolds
050f5da680 Remove dead code am: ab63fd3c25 am: bf35e5cc55
am: 25d55fb821

Change-Id: I45b62580c01cf5a81443d7043f65755bb3986245
2019-06-21 10:45:47 -07:00
Julia Reynolds
bf35e5cc55 Remove dead code
am: ab63fd3c25

Change-Id: I8d629b89f8b8145e8381301d888aeb8b050123c8
2019-06-21 10:15:12 -07:00