Commit Graph

28979 Commits

Author SHA1 Message Date
Evan Rosky
4ee5dccbb0 Merge "Add a developer option which allows non-resizables in freeform" 2019-11-15 17:32:15 +00:00
Yanting Yang
3996084a9e Remove redundent @VisibleForTesting annotation
There are many methods marked with @VisibleForTesting annotation but
they are overridden or used by child classes. So remove
@VisibleForTesting for readability.

Fixes: 73292660
Test: Rebuild and Robotests
Change-Id: Ie7fe8ac98deb3d050578552982ab523bd1694deb
2019-11-15 17:35:01 +08:00
Bonian Chen
c9db100d04 Merge "[Settings] Refactor PhoneStateListener" 2019-11-15 09:08:57 +00:00
Bonian Chen
21361e1f84 [Settings] Refactor PhoneStateListener
Remove Looper and update of mSubId

Bug: 144542981
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gBasePreferenceControllerTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=VideoCallingPreferenceControllerTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingPreferenceControllerTest

Change-Id: Ie6ae5b5914322644f2655e585b03a6b685bbc84a
2019-11-15 16:01:51 +08:00
Arc Wang
75dc89b122 [Wi-Fi] Create WifiNetworkDetailsFragment related version 2 files for WifiTracker2 development
Create below version 2 files for WifiTracker2 development, we can
check the feature flag only a few times and easily remove version 1
files in the future.

    src/com/android/settings/wifi/details2/
    src/com/android/settings/wifi/savedaccesspoints2/
    tests/robotests/src/com/android/settings/wifi/details2/
    tests/robotests/src/com/android/settings/wifi/savedaccesspoints2/

Bug: 143326832
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.wifi.details2
      make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.wifi.savedaccesspoints2

Change-Id: I4d2caf1ce313871605252395764b02747240f217
2019-11-15 14:41:23 +08:00
Arc Wang
8d2b9f2d7a Merge "[A11Y] Fix MasterSwitchPreference onClick not callback after TalkBack is enabled" 2019-11-15 06:16:37 +00:00
Sunny Shao
abcbc79d7d Add a dark theme slice
Fixes: 142476879
Test: make RunSettingsGoogleRoboTests -j ROBOTEST_FILTER=com.android.settings.homepage.contextualcards.slices.DarkThemeSliceTest
Change-Id: I4865c3c4a807bc4ac96762a882b193a3e2595019
2019-11-15 13:41:49 +08:00
tim peng
1d07f6e970 Merge "Battery icon is too large" 2019-11-15 05:22:47 +00:00
Raff Tsai
7d0e3a4929 Merge "Add dynamic injection item to site map" 2019-11-15 03:24:31 +00:00
Raff Tsai
178f8c9f10 Merge "Add take persistable permission for uri" 2019-11-15 03:23:22 +00:00
Bonian Chen
66d9e08e34 Merge "[Settings] Remove isWfcProvisionedOnDevice API" 2019-11-15 03:00:14 +00:00
Bonian Chen
43fa3a0140 Merge "[Settings] Replace VT and VOLTE provisioning API" 2019-11-15 02:57:29 +00:00
Bonian Chen
7f88b51851 Merge "[Settings] Remove PhoneStateIntentReceiver" 2019-11-15 02:57:01 +00:00
Evan Rosky
f55bd86185 Add a developer option which allows non-resizables in freeform
Bug: 138594779
Test: manual + pref test
Change-Id: I1620189799dc83cb1c255ca30c4ef29e73e73756
2019-11-14 17:00:35 -08:00
Kevin Lau Fang
a40bf2aec2 Merge "Revert submission" 2019-11-14 20:31:13 +00:00
Kevin Lau Fang
40dd1e2183 Revert submission
Reason for revert: This causes a boot issue on Taimen (b/144480969). It wasn't caught by TreeHugger due to Taimen tests being disabled due to a different lab outage (b/144350336).

Change-Id: I490dc6c933c08c3c83b962786df11bd2da66b28a
2019-11-14 20:07:38 +00:00
Sunny Shao
f3865e9264 Synced the code from master branch
Fixes: 144364245
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.deviceinfo.PhoneNumberPreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.deviceinfo.simstatus.SimStatusDialogControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.network.telephony.RenameMobileNetworkDialogFragmentTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.homepage.contextualcards.deviceinfo.DeviceInfoSliceTest
Change-Id: Ibb26f5a63a969b28915a226a0197bc4033c91346
Merged-In: I5dfb71ceb87a8f658ef7fbceacf460ef8d35593a
2019-11-14 21:57:12 +08:00
Rubin Xu
0008986ef1 Fix NPE in ChooseLockPattern
Since mChosenPattern can be null, guard against it.

Bug: 144452509
Test: manual
Change-Id: I2814e49ee2e63e19631e8415efcc50e9ae78d4fc
2019-11-14 10:53:43 +00:00
Bonian Chen
65817204e6 [Settings] Replace VT and VOLTE provisioning API
Replace isVtProvisionedOnDevice() and isVolteProvisionedOnDevice()
by android.telephony.ims.ProvisioningManager.

Bug: 140542283
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gBasePreferenceControllerTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=Enhanced4gLteSliceHelper
make RunSettingsRoboTests -j ROBOTEST_FILTER=VideoCallingPreferenceController

Change-Id: Ie92794b794a6b9f2d9e161ca5f328cd9fa01064a
2019-11-14 18:24:55 +08:00
Bonian Chen
2aafbd38e7 [Settings] Remove isWfcProvisionedOnDevice API
Replace isWfcProvisionedOnDevice() by IMS's ProvisioningManager.

Bug: 140542283
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingSettingsTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingSettingsForSubTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=WifiCallingSliceHelperTest
make RunSettingsRoboTests -j ROBOTEST_FILTER=MobileNetworkUtilsTest

Change-Id: Idb063bdab3d3b11c348804c1c0ecb268cca3068e
2019-11-14 18:22:02 +08:00
hughchen
7a2fb4011e Add take persistable permission for uri
Fixes: 144443382
Test: Manual
Change-Id: Iaec788982330355099d7e8551fed0f000377ce8a
2019-11-14 15:02:41 +08:00
James Mattis
90c23d2fe7 SoftApCallback using executor vs handler
Updating classes to support making SoftApCallback methods available to @SystemAPI including
the API for registration of a SoftApCallback which includes a change to
now use executor vs handler.

Bug: 143564153
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiTetherPreferenceControllerTest
Also tested manually on a Pixel 3.

Change-Id: I952ad10dd88b7d97b3cd86b269b8f67b00b1fa15
Merged-In: I952ad10dd88b7d97b3cd86b269b8f67b00b1fa15
2019-11-13 21:39:26 -08:00
Bonian Chen
5980b80adc [Settings] Remove PhoneStateIntentReceiver
1. Replace PhoneStateIntentReceiver by adopting PhoneStateListener
2. Replace TelephonyProperties.in_ecm_mode() by
TelephonyManager.getEmergencyCallbackMode()

Bug: 144331663
Test: Manual
make RunSettingsRoboTests -j ROBOTEST_FILTER=AirplaneModePreferenceControllerTest

Change-Id: I95c80d9857c9ca44deede7105e1c200d729fefd3
2019-11-14 04:37:12 +00:00
Raff Tsai
b22bbffe90 Merge "Modify preference_list_fragment to support tabLayout" 2019-11-14 04:04:31 +00:00
timhypeng
c71f996da9 Battery icon is too large
-sync layout from SystemUI

Bug: 141139595
Test: make -j42 RunSettingsRoboTests
Change-Id: I5e165e953682fcfdebf0d06475bb1abd171684d9
2019-11-14 10:55:54 +08:00
Arc Wang
d1ea136cb8 [A11Y] Fix MasterSwitchPreference onClick not callback after TalkBack is enabled
TalkBack service dispatches onClick event to the Switch component
instead of the LinearLayout wrapping it. Do all the onClick tasks
for the Switch component instead of the LinearLayout wrapping it.

Bug: 142570671
Test: MasterSwitchPreferenceTest
      Manual click the toggle button for both TalkBack enabled case and disabled case.

Change-Id: I4b2f9df309d03a477863445cd187384cdb61314b
2019-11-14 09:59:35 +08:00
Dianne Hackborn
cdf01bb144 Merge "Rework platform version to hide codenames." 2019-11-13 23:16:05 +00:00
Jason Chiu
21e8231523 Fix Settings creating too many threads unexpectedly
am: 48a0ff4304

Change-Id: I28068c2c68bffd0d97c1286df4f034a1f4a9825d
2019-11-13 09:40:13 -08:00
James Mattis
1a71177bc8 Merge "Support for hotspot client visibility." am: 2b7c8937de
am: 24546e531f

Change-Id: Ie04b18cbf7f9d640cf314f427381ebd102c40d5e
2019-11-13 08:58:40 -08:00
James Mattis
24546e531f Merge "Support for hotspot client visibility."
am: 2b7c8937de

Change-Id: Ib52bd8e9fa9a2affdd02771c1f64e86297c50458
2019-11-13 08:53:37 -08:00
TreeHugger Robot
d5bb245f99 Merge "Fix the NPE in the ScreenPinningSettings" 2019-11-13 14:15:04 +00:00
Bonian Chen
48d472583a Merge "[Settings] Remove access to getSimOperator() API" 2019-11-13 14:02:58 +00:00
Julia Reynolds
9540929cfe Merge "Add NLS specific screens for notification listener approval" 2019-11-13 14:02:39 +00:00
TreeHugger Robot
03964f34da Merge "Ignore all failed test cases" 2019-11-13 13:41:48 +00:00
Sunny Shao
56b7acd49e Fix the NPE in the ScreenPinningSettings
- move mFooterPreference and others init before the SwitchBar

Fixes: 144407413
Test: manual test
Change-Id: I80d86942f35d16e0460c5fa48bb127932d2086a1
2019-11-13 20:35:56 +08:00
Tsung-Mao Fang
6a2d48d158 Ignore all failed test cases
Test: Run all robo test
Bug: 144405844
Bug: 144407418
Bug: 144407438
Fix: 144406422
Bug: 144405885
Bug: 144408475

Change-Id: Ia94636632106206b062d35b2ca53a028d0cbc35d
2019-11-13 20:31:01 +08:00
Yi-Ling Chuang
e786ce000e Fix non responding slice toggling
The issue happens when users are toggling slices. Sometimes the toggle
doesn't work as expected because the pending intent of the toggle action
seems to be canceled for some reasons.

Hence, we replace FLAG_CANCEL_CURRENT with FLAG_UPDATE_CURRENT to
prevent from getting PendingIntent.CancelExcpetion from SliceActionView
when toggling slices.

This change only applies on those auto converted Slices.

Bug: 140719905
Test: toggle slices in Settings Search and NGA
Change-Id: Iff724ce5f6a1e6a7d9ca85b8ce76539a72e72964
Merged-In: Iff724ce5f6a1e6a7d9ca85b8ce76539a72e72964
(cherry picked from commit ddf6cefcac)
2019-11-13 10:30:26 +00:00
Raff Tsai
988a912237 Modify preference_list_fragment to support tabLayout
- Remove buttonBar because it is only used in PublicVolumeSettings
- Add tabLayout in preference_list_fragment.xml

Bug: 141601408
Test: manual
Change-Id: Ieb84ccf2e685a03abec7b07cb8f9f4b64ee475e0
2019-11-13 17:37:59 +08:00
Bonian Chen
bb53dd5f93 [Settings] Remove access to getSimOperator() API
Replace getSimOperator() by having SubscriptionInfo
from getAccessibleSubscriptionInfo().

Bug: 144263441
Test: Manual
make RunSettingsRoboTests -j ROBOTEST_FILTER=ApnEditorTest

Change-Id: I25cc9dc0912564b8d6f8b23b53f3eb20a51eea32
2019-11-13 17:33:08 +08:00
TreeHugger Robot
3af21959b5 Merge "Remove redundant code" 2019-11-13 06:58:46 +00:00
Bonian Chen
63f837e6dc Merge "[Settings] Replace getSimCount() API" 2019-11-13 06:45:55 +00:00
James Mattis
33379b361b Swap param order in registerSoftApCallback
Moving executor to be the first argument in registerSoftApCallback.

Bug: 144379300
Test: Manually on pixel 3

Change-Id: I5563c1059cc04014a0fd909e2508f7bf497d708e
2019-11-12 22:26:33 -08:00
TreeHugger Robot
e75f77d753 Merge "Don't use Lambda when register callback" 2019-11-13 05:08:01 +00:00
Tsung-Mao Fang
31dd22cc4c Remove redundant code
Don't need to define onResume and onPause again.

Test: Rebuild
Change-Id: I470ced021d1ffab13659335b54db0b01b5766940
2019-11-13 12:36:43 +08:00
hughchen
e487b00157 Don't use Lambda when register callback
This CL before, the lambda callback is different it cause
callback didn't unregister.
If you re-enter bluetooth detail page many times,
onDeviceAttributesChanged() will be called many times cause UI not
smooth.

This CL remove the lambda callback and show the UI when device
connected.

Fixes: 141583252
Test: Manual
Change-Id: Icd3e84b2d461d9b949f080269dfa2bb5b5d5cb73
2019-11-13 11:55:32 +08:00
David Su
6d2c28f22a Rename WifiSsid.NONE to WifiManager.UNKNOWN_SSID
Bug: 144311098
Test: compiles
Change-Id: Id75f4f9223142f5184db54a4d380a2967f28469e
2019-11-12 18:56:09 -08:00
Raff Tsai
d43163d429 Merge "Add a feature flag for controller loading enhancement" 2019-11-13 00:57:50 +00:00
Raff Tsai
a12aa853a7 Merge "Fix PendingIntent CanceledException exception" 2019-11-13 00:55:27 +00:00
Raff Tsai
a19e37a02d Merge "change screen pinning settings UI" 2019-11-13 00:54:42 +00:00
Sunny Shao
a4d2ab80fa Add a feature flag for controller loading enhancement
Bug: 137558156
Test: manual test
Change-Id: I4f2988ea889735e66bc227bb814707c5b01b770b
2019-11-13 08:47:43 +08:00