Commit Graph

28979 Commits

Author SHA1 Message Date
Sunny Shao
b54d2f90f2 Add whitelist in ResetAppsHelper
Add "com.android.systemui" into the whitelist and skip the clear data.

Fixes: 137037930
Test: manual test
Change-Id: Ie2f527309f9159babe79636a69ff13fe3ceb64d9
2019-07-12 15:43:18 +08:00
TreeHugger Robot
eb97f54928 Merge "Check FaceManager before get system service" 2019-07-12 07:24:32 +00:00
Andrew Sapperstein
f6219c0242 Merge "Fix erasing of eSIMs for some devices" into qt-dev am: 1f942d9857 am: 44f731c1c7
am: b07cee3139

Change-Id: I4e8deaf89a5cb0327e38866b9c205871057fdd92
2019-07-11 21:39:30 -07:00
Raff Tsai
b848474b91 Check FaceManager before get system service
Bug: 136788181
Test: adb shell am start -a android.settings.FACE_SETTINGS is not
      crashed

Change-Id: If727ab4aa3b4043fa2e4e8c13392e32d566b1bbb
2019-07-12 12:18:16 +08:00
Andrew Sapperstein
b07cee3139 Merge "Fix erasing of eSIMs for some devices" into qt-dev am: 1f942d9857
am: 44f731c1c7

Change-Id: I34bb2383b9f14e624ab93caa0108d2a2510f4439
2019-07-11 21:10:41 -07:00
Antony Sargent
8d2baf64c7 Fix erasing of eSIMs for some devices
Doing a factory data reset used to always erase eSIMs. Then a few months
ago we added a default-on checkbox to let users opt out of erasing the
eSIM during this process, but only had it show for some devices (ones
which support the "fastboot oem esim_erase" command) by adding a system
property named masterclear.allow_retain_esim_profiles_after_fdr.

When recently updating the strings shown in the factory data reset
screen and the confirmation dialog, we changed the code so that if that
the checkbox is hidden we'll pass false for the ERASE_ESIMS_EXTRA
parameter sent to the factory data reset confirmation dialog. This had
the unintended side effect of making devices that don't specify true for
masterclear.allow_retain_esim_profiles_after_fdr skip erasing the eSIM.

This CL fixes that by removing the "is the checkbox hidden" check, going
back to the previous behavior of just using the checkbox value, which is
on by default even if hidden.

Fixes: 135284765
Test: make RunSettingsRoboTests
Change-Id: Ia9f335920e4e3c4a90f0a6a49d1722a0c19ea83d
(cherry picked from commit 5f612a4b44)
2019-07-12 04:10:26 +00:00
Andrew Sapperstein
8c6b2bafb0 Merge "Fix erasing of eSIMs for some devices" into qt-dev
am: 1f942d9857

Change-Id: I04bc60ed040546a64ea157840b76d815169d32a3
2019-07-11 20:51:33 -07:00
Andrew Sapperstein
44f731c1c7 Merge "Fix erasing of eSIMs for some devices" into qt-dev
am: 1f942d9857

Change-Id: I44e11b7a63c329883b01dc03f820e807c15953cf
2019-07-11 20:51:32 -07:00
Andrew Sapperstein
1f942d9857 Merge "Fix erasing of eSIMs for some devices" into qt-dev 2019-07-12 03:13:39 +00:00
Vinit Nayak
f7d423d106 Remove Settings from recents after app uninstall
SettingsActivity now calls finishAndRemoveTask
instead of only finish() to prevent blank
recent task from showing in overview.

Test: Visually inspected bug doesn't exist. Wrote
Roboelectric tests

Fixes: 129733119

Change-Id: I5b73c1b611e6eb52bb6665c215276efdc85c19b2
2019-07-11 16:09:49 -07:00
joshmccloskey
c9e680edac Ensure feature is supported and enabled. am: a96a84e256
am: 00c05fc246

Change-Id: I524966c3163a9dff1c1d7f7a4da496e8a08fb66e
2019-07-11 15:06:11 -07:00
joshmccloskey
00c05fc246 Ensure feature is supported and enabled.
am: a96a84e256

Change-Id: I5a1870ed55326fb9e8a5616ffa279bccc42b04ff
2019-07-11 14:56:10 -07:00
joshmccloskey
a96a84e256 Ensure feature is supported and enabled.
Fixes: 137285390
Test: Verified that SecuritySettings no longer crashes.
Test: Verified that this PrefenceController no longer shows up
if the device does not support it.
Test: Verified that this PreferenceController no longer
shows up when the work profile is disabled.

Change-Id: I10f015e18491b203db6f942f07034d55f620cfe5
2019-07-11 21:31:31 +00:00
joshmccloskey
d670b80d84 Update FaceSlice to use correct pref & FaceManager am: 365beaebdb
am: 5dbcfc9d27

Change-Id: I290d6a89e372f6c70e25aa6c44c2308682ef1049
2019-07-11 14:17:00 -07:00
joshmccloskey
5dbcfc9d27 Update FaceSlice to use correct pref & FaceManager
am: 365beaebdb

Change-Id: I3762f68d4f16ad529ad7a1cc56891812daad7016
2019-07-11 14:08:02 -07:00
Joshua Imbriani
3a117e6771 Merge "Correcting sort order of languages for non en-us locales" 2019-07-11 20:28:21 +00:00
Antony Sargent
5f612a4b44 Fix erasing of eSIMs for some devices
Doing a factory data reset used to always erase eSIMs. Then a few months
ago we added a default-on checkbox to let users opt out of erasing the
eSIM during this process, but only had it show for some devices (ones
which support the "fastboot oem esim_erase" command) by adding a system
property named masterclear.allow_retain_esim_profiles_after_fdr.

When recently updating the strings shown in the factory data reset
screen and the confirmation dialog, we changed the code so that if that
the checkbox is hidden we'll pass false for the ERASE_ESIMS_EXTRA
parameter sent to the factory data reset confirmation dialog. This had
the unintended side effect of making devices that don't specify true for
masterclear.allow_retain_esim_profiles_after_fdr skip erasing the eSIM.

This CL fixes that by removing the "is the checkbox hidden" check, going
back to the previous behavior of just using the checkbox value, which is
on by default even if hidden.

Fixes: 135284765
Test: make RunSettingsRoboTests
Change-Id: Ia9f335920e4e3c4a90f0a6a49d1722a0c19ea83d
2019-07-11 20:23:58 +00:00
tmfang
58dcca9844 Improve Settings launch performance
From traces analysis, we found getFreeBytes
was taking a long time to return.

getFreeBytes was used when storage controller
tried to get storage information.

In order to prevent this case, we put the action
which takes too much time in background thread.

Test: I can't reproduce it locally. From code view,
this is a reasonable root cause.
Fixes: 136268875

Change-Id: I78e42cde88553c003f198cffb5747b352055f59a
(cherry picked from commit 0c37f019f6)
2019-07-11 19:50:02 +00:00
joshmccloskey
365beaebdb Update FaceSlice to use correct pref & FaceManager
Fixes: 137137134
Test: Manual.
Change-Id: Idc707a7d2009975f81902867e4c37a8ee5775700
2019-07-11 16:28:21 +00:00
Josh Imbriani
7d6263a38d Correcting sort order of languages for non en-us locales
Test: Manually tested
Fixes: b/78125395
Change-Id: I1b370d4ae4995cc7d9f05409be97d4ecf9104241
2019-07-11 15:17:28 +00:00
Yanting Yang
974d986bb7 Merge "Fix the clicking issue of restricted info icon" 2019-07-11 14:56:42 +00:00
Yanting Yang
dfeb1f07bb Fix the clicking issue of restricted info icon
When the switch controller was disabled by admin, we will show the
restricted info icon on it and when user click this icon, it should pop
a dialog to notify user current action not allowed.

This issue was caused by the solution of fixing the a11y view focus
issue b/124334500, it has been disabled the focusable and clickable
attributes of icon then to block the dialog showing.

Recover the focusable and clickable of restricted info icon to fix it.

Fixes: 136439565
Test: visual, robotests
Change-Id: I227add696870e07feca288073e90afa8e76954ee
2019-07-11 10:05:41 +00:00
tmfang
6ed2484766 Improve Settings launch performance am: 496d3f6f9c
am: 49d575b91c

Change-Id: I544556c17a56dd1e36efded7ae565fa7d97fa8ba
2019-07-11 01:12:18 -07:00
tmfang
49d575b91c Improve Settings launch performance
am: 496d3f6f9c

Change-Id: I16eb11d8850cbd75dd3571d16fce5758e5280bfd
2019-07-11 00:54:14 -07:00
tmfang
edd86364f5 Improve Settings launch performance
am: 496d3f6f9c

Change-Id: I5256fa0c04af07108b76cf21e9558b03d499e883
2019-07-11 00:54:14 -07:00
TreeHugger Robot
c43a7b99fe Merge "Fix Settings crash" 2019-07-11 05:56:07 +00:00
TreeHugger Robot
5a871b8c33 Merge "Remove deprecated code" 2019-07-11 05:17:31 +00:00
tmfang
496d3f6f9c Improve Settings launch performance
From traces analysis, we found getFreeBytes
was taking a long time to return.

getFreeBytes was used when storage controller
tried to get storage information.

In order to prevent this case, we put the action
which takes too much time in background thread.

Test: I can't reproduce it locally. From code view,
this is a reasonable root cause.
Fixes: 136268875

Change-Id: I78e42cde88553c003f198cffb5747b352055f59a
(cherry picked from commit 0c37f019f6)
2019-07-11 04:19:42 +00:00
Raff Tsai
a99a85fdf3 Fix Settings crash
Fixes: 136788181
Test: adb shell am start -a android.settings.FACE_SETTINGS will not
      crash

Change-Id: I10168ce83ceb8646dce5d5e086b14ca2e3ed8284
2019-07-11 11:29:37 +08:00
Goven Liu
a47265d028 Merge "[Wi-Fi] EAP method AKA' did not pronounced as AKA prime." 2019-07-11 03:22:35 +00:00
Raff Tsai
5fe166075f Remove deprecated code
Fixes: 137106225
Test: rebuild
Change-Id: If978f765fd1f6ec0fded1eb0f7e93e386c5d3163
2019-07-11 11:15:39 +08:00
govenliu
41cdecca3d [Wi-Fi] EAP method AKA' did not pronounced as AKA prime.
Spinner did not use ttsspan to store the display string so AKA' just
pronounced as AKA.

To fix it, use charsequence array, which each specific array item have
the ttsSpan to store the string for TTS engine.

Bug: 119929832
Test: Set a 3-texts array and check if the specific array item
replacement mechanism work correctly or not.

Change-Id: I8e7d10da99a3f3503e1019687c45cf40070d0045
2019-07-11 09:31:15 +08:00
Tarandeep Singh
13d4aec8ff Merge "Remove usage of PER_PROFILE_IME_ENABLED property in settings" 2019-07-10 18:06:39 +00:00
Mill Chen
10829a2164 Merge "Clean up in-code preference controllers from accessibility" 2019-07-10 09:21:22 +00:00
TreeHugger Robot
23fbf601a0 Merge "[Wi-Fi DPP] Improve TalkBack information for events" 2019-07-10 08:39:05 +00:00
Joshua Mccloskey
2fbcb76a31 Merge changes I5e0a72a1,Iefcbf498 into qt-r1-dev am: 0839185647
am: d82eedde6d

Change-Id: I9e6ff72dd79390c01aea23392093f94d099079cf
2019-07-09 19:55:42 -07:00
Joshua Mccloskey
d82eedde6d Merge changes I5e0a72a1,Iefcbf498 into qt-r1-dev
am: 0839185647

Change-Id: I5cc4c3393403bf8c299b415be81bc9b80fb93ca9
2019-07-09 19:46:38 -07:00
Joshua Mccloskey
0839185647 Merge changes I5e0a72a1,Iefcbf498 into qt-r1-dev
* changes:
  Favor setup face in search settings.
  Remove highlighting for work profile
2019-07-10 02:29:45 +00:00
joshmccloskey
582ac25006 Merge "Diversity extra no longer gets overwritten." into qt-r1-dev am: 007a1aee1b
am: 235405d66e

Change-Id: I9bd28728f6c8700209324d879d0eb6e7b7aa47ad
2019-07-09 16:03:48 -07:00
joshmccloskey
235405d66e Merge "Diversity extra no longer gets overwritten." into qt-r1-dev
am: 007a1aee1b

Change-Id: Ic5d286f40b36c2b745b9d1168e60234015184b6a
2019-07-09 15:51:45 -07:00
joshmccloskey
8bbbe545f2 Favor setup face in search settings.
Test: Manual.
Fixes: 137135217
Change-Id: I5e0a72a117e2af6d9262d07616cc539ee7a7e55e
2019-07-09 22:41:33 +00:00
TreeHugger Robot
007a1aee1b Merge "Diversity extra no longer gets overwritten." into qt-r1-dev 2019-07-09 22:24:00 +00:00
joshmccloskey
85081a4f7e Remove highlighting for work profile
Test: Manual.
Fixes: 137126517
Change-Id: Iefcbf498cc0805cd130981e522177a7c16b7adfc
2019-07-09 15:23:37 -07:00
Tarandeep Singh
54c2af9213 Remove usage of PER_PROFILE_IME_ENABLED property in settings
PER_PROFILE_IME_ENABLED is default enabled in Q. We no longer need to
have this property.

Bug: 135775619
Test: atest CtsInputMethodTestCases CtsInputMethodServiceHostTestCases
Change-Id: I1ba4fab361b77b1ec23b1773a66dccb76667e95c
2019-07-09 14:59:18 -07:00
TreeHugger Robot
9acfbdbe04 Merge "Avoid oem-unlock preference controller crash" 2019-07-09 21:00:04 +00:00
TreeHugger Robot
2ab371b13a Merge "TODO about BatteryStats.STATS_SINCE deprecation" 2019-07-09 19:41:54 +00:00
joshmccloskey
97a95798ac Diversity extra no longer gets overwritten.
Test: Manual.
Fixes: 136963876
Change-Id: Ia62e7ac1ff942fa078a2fd5f1d7efc339132aaa3
2019-07-09 18:59:20 +00:00
TreeHugger Robot
d9f680fc92 Merge "[Wi-Fi DPP] Add a parent class for WifiDppConfiguratorActivity and WifiDppEnrolleeActivity" 2019-07-09 11:15:28 +00:00
Mill Chen
6f3b222ca5 Clean up in-code preference controllers from accessibility
Bug: 135056871
Test: manual, robotests
Change-Id: I0c1358657d3f57ddae2b8f2b12ee610e7363f41f
2019-07-09 17:35:32 +08:00
Arc Wang
1df7f2d1c1 [Wi-Fi DPP] Improve TalkBack information for events
Title and summary may be changed after user operations or Wi-Fi Easy connect handshake,
setAccessibilityLiveRegion could specify accessibility services to announce these changes.

In WifiDppAddDeviceFragment, I set title before summary for correct TalkBack announce sequence.

Bug: 137069941
Test: manual
Change-Id: Id032cfcb86c350feeac808f070665ac26261ceb8
2019-07-09 17:30:01 +08:00