Commit Graph

28979 Commits

Author SHA1 Message Date
Bonian Chen
6472d299e9 Merge "[Owner] Add allenwtsu into Settings Telephony part" 2019-09-26 03:33:14 +00:00
joshmccloskey
a72663926a Added mandatory scrolling for FaceIntroduction am: af1e831ab7
am: ab5bf98c03

Change-Id: Ifc33c6e4f34f1f66bd48cc0f2e5f4e7c7e164e55
2019-09-25 12:43:03 -07:00
joshmccloskey
ab5bf98c03 Added mandatory scrolling for FaceIntroduction
am: af1e831ab7

Change-Id: I1877ce4650fd393d08e2ff1c15944df8fbd4d6d7
2019-09-25 10:58:00 -07:00
Bonian Chen
2d41dbf141 [Owner] Add allenwtsu into Settings Telephony part
Add allenwtsu into owner list of Telephony part within Settings apk

Bug: 0
Test: none
Change-Id: Ic2820bc113bc26fc0d162c42c7925477177127ae
2019-09-25 21:26:44 +08:00
Bonian Chen
cbb446e38a [Manual Network Selection] UX improvement
Original design abort a network scan when screen off and restart scan
when screen on.

Under the situation of network scan time longer than screen off time,
user may not get any result but keeping in scanning screen.

This CL improve this situation by avoiding stop and rescan for the case
user didn't leave this UI and previous scan is in progressing.

Bug: 140448617
Test: Manual testing leave and back to UI, and screen off-on.
Change-Id: I74ffa574dac932ca7fcd76411cad4ec0cc88f25f
2019-09-25 18:45:09 +08:00
Raff Tsai
966fa01423 Use SettingsLib Indexable
- Use SettingsLib Indexable
- Directly use resource id in getPreferenceScreenResId

Bug: 135053028
Test: roboletric
Change-Id: I05f493b55e8b6e2091301e9231ba5615215618e6
2019-09-25 18:24:56 +08:00
TreeHugger Robot
0102d98dc9 Merge "Error handler for start dialog from adb command" 2019-09-25 08:27:51 +00:00
Bonian Chen
b18061c305 Merge "[Settings Telephony] Carrier name API replacement" 2019-09-25 06:45:50 +00:00
hughchen
283ae5d1bb Error handler for start dialog from adb command
This CL added null check for the case that dialog
is started from adb command.

Bug: 129783237
Test: manually
Change-Id: I47d47cb5ddfe3487e2d616d1cf2ed08bd11d215d
2019-09-25 14:19:55 +08:00
TreeHugger Robot
1f8eee5798 Merge "Fix highlight animation" 2019-09-25 05:33:44 +00:00
Tsung-Mao Fang
f4e3f78fa0 Fix highlight animation
Set correct from-to color for highlight animation

Fixes: 141535322
Test: visual
Change-Id: I1cec8d57fca1435922ad196a4b314d8cee2be9f0
2019-09-25 11:35:28 +08:00
joshmccloskey
af1e831ab7 Added mandatory scrolling for FaceIntroduction
Test: Verified in SUW/Settings user must scroll through contents in
order to go to the next screen.
Bug: 141380294

Change-Id: I483ab6ae6a282c81ba2f2c4d1d9d1f21c6cb9453
2019-09-25 00:23:59 +00:00
Bonian Chen
ed332c0829 Merge "[ManualNetworkSelect] Improve error handling" 2019-09-24 10:05:23 +00:00
TreeHugger Robot
818ad60218 Merge "Do not block UI when this page didn't have slice" 2019-09-24 09:57:50 +00:00
Daniel Huang
202b84b8df Merge "In sim1 APN settings interface and hot plug out/in sim2, APN information change to sim2's" am: 51cb777530 am: f28625bcf1 am: 1fec213233
am: f7b4dc1dc7

Change-Id: Iacb97f589587a06212591ce9a83f5eadba7b59f7
2019-09-24 02:51:19 -07:00
Daniel Huang
f7b4dc1dc7 Merge "In sim1 APN settings interface and hot plug out/in sim2, APN information change to sim2's" am: 51cb777530 am: f28625bcf1
am: 1fec213233

Change-Id: Ifed2aeb3759051ce1ddc490fb695b50642b76402
2019-09-24 02:45:00 -07:00
Daniel Huang
1fec213233 Merge "In sim1 APN settings interface and hot plug out/in sim2, APN information change to sim2's" am: 51cb777530
am: f28625bcf1

Change-Id: Ie151d421eae8321dc684f7d4a684f582fb60c3ac
2019-09-24 02:39:02 -07:00
Daniel Huang
f28625bcf1 Merge "In sim1 APN settings interface and hot plug out/in sim2, APN information change to sim2's"
am: 51cb777530

Change-Id: I7d6675734eed90cbfb0ccda46c047883e460962f
2019-09-24 02:32:29 -07:00
Daniel Huang
51cb777530 Merge "In sim1 APN settings interface and hot plug out/in sim2, APN information change to sim2's" 2019-09-24 09:21:51 +00:00
Raff Tsai
b722db9d41 Merge "Directly use BaseIndexableProvider" 2019-09-24 09:10:56 +00:00
Bonian Chen
7a4c679790 [Settings Telephony] Carrier name API replacement
Replacing TelephonyManager.getNetworkOperatorName() by
Obtaining carrier name from SubscriptionInfo.getCarrierName().

TelephonyManager.getNetworkOperatorName() only be used when there's no
SubscriptionInfo can be found.

Bug: 140443508
Test: Manual testing
  atest MobileNetworkUtilsTest
  atest OpenNetworkSelectPagePreferenceControllerTest

Change-Id: I7a86395c86d31fe2ba54c04ac16b1a0ebfc843f3
2019-09-24 07:59:56 +00:00
Bonian Chen
1b64578f3c [ManualNetworkSelect] Improve error handling
1. [batch mode] Support graceful app stop behavior
   Avoid thread crash when UI abort the request.
2. [incremental mode] Stop search UI earlier when error during API access
   Generate error instead of keeping UI in progressing
   when fail to access Telephony API

Bug: 139398483
Bug: 140448617
Test: atest NetworkScanHelperTest
Change-Id: I429f3aa2ef692c27100514faa413b16dbd2459d7
2019-09-24 07:58:42 +00:00
hughchen
d49de61f96 Do not block UI when this page didn't have slice
This CL before, if controller have UIBlocker interface
will going to blocker condition to make whole page
invisible for a certain time until slice is fully loaded.

This CL add the check condition that if the controller
have UIBlocker inferface but didn't have slice uri will
not go to blocker condition.

Bug: 141292712
Test: make -j42 RunSettingsRoboTests ROBOTEST_FILTER=DashboardFragmentTest
Change-Id: I79daae131654f8fd823a9c8f1be46ad6c7921908
2019-09-24 10:30:49 +08:00
TreeHugger Robot
1e36a02406 Merge "Remove enum logic from callers of requestbugreport()" 2019-09-23 17:10:51 +00:00
Raff Tsai
ac3e0d0988 Directly use BaseIndexableProvider
- Add function getXmlResourceId, Fragments don't need to write
xml resource id twice.
- Remove getPreferenceControllers from Indexable.java. Because it will
move to SettingsLib later for other apps which don't need this function

Bug: 135053028
Test: robolectric
Change-Id: I1e74519aecdea3dde64a5aea79f08d766dbc0003
2019-09-24 00:35:52 +08:00
TreeHugger Robot
5ff9517f23 Merge "Developer option off must not affect laser sensor" 2019-09-23 15:07:13 +00:00
Abhijeet Kaur
d7e44c7b3a Remove enum logic from callers of requestbugreport()
Make callers use wrapper functions in ActivityManagerService.java.

The code to send broadcast to trigger API workflow (after checking the API
flag) is added in requestBugreport() in ActivityManagerService.java.
Remove that logic from this file.

Bug: 137825297
Bug: 141355059
Test: builds and full/interactive bugreports work as expected

Change-Id: Ibc305e4aca7d38fd4878b60f3f7f8c3274719c13
2019-09-23 13:47:20 +00:00
Yi-Ling Chuang
fe790ec76d Merge "Enable dismissal feature on legacy suggestions." am: ee39335edc am: 8d8c3e19b5 am: b26711944b
am: 3b8a14e86f

Change-Id: I97bcdc54f908db6f5895d99f284ee24fb4015433
2019-09-22 20:23:28 -07:00
Yi-Ling Chuang
3b8a14e86f Merge "Enable dismissal feature on legacy suggestions." am: ee39335edc am: 8d8c3e19b5
am: b26711944b

Change-Id: I0edf1eff42cf54e644e60a11ba97219c38891e93
2019-09-22 20:16:25 -07:00
Yi-Ling Chuang
b26711944b Merge "Enable dismissal feature on legacy suggestions." am: ee39335edc
am: 8d8c3e19b5

Change-Id: I8fae05f98c2ad04e0d7fba7a2aa409c08f781c0b
2019-09-22 20:09:51 -07:00
Yi-Ling Chuang
8d8c3e19b5 Merge "Enable dismissal feature on legacy suggestions."
am: ee39335edc

Change-Id: Ibce2403de032bd3d7fce750f6cd80191a8b14441
2019-09-22 20:03:21 -07:00
Arc Wang
44fa9d579d [Wi-Fi] Improve UX when there is no user certificate to choose for WPA-Enterprise 192-bit
Show error message when a user does not specify a user certificate
for WPA3-Enterprise 192-bit.

Bug: 138417816
Test: visual
Change-Id: Ifc519d484dbf78dad37ad7047e8b9bb40685d54c
2019-09-23 09:39:20 +08:00
Edgar Wang
18839c1fbc Merge "Handle Aware sensor status for Always On" into qt-qpr1-dev
am: 07ea1dc815

Change-Id: Ia7f62e46c3c9d7c9b7a55686be911891764ff75d
2019-09-21 02:07:52 -07:00
Edgar Wang
07ea1dc815 Merge "Handle Aware sensor status for Always On" into qt-qpr1-dev 2019-09-21 08:54:47 +00:00
Yi-Ling Chuang
83ac0efd81 Enable dismissal feature on legacy suggestions.
Add back the close button for legacy suggestions.

Fixes: 140786274
Test: robotest
Change-Id: Iaf0376bd482db4c4ff7d04a68131071c29c01ced
2019-09-20 18:03:10 -07:00
Edgar Wang
0f8c7a71d0 Handle Aware sensor status for Always On
- "Always On" preference will be hiden when aware
sensor is available
- Extract NavModeCandidateInfo from SystemNavigationGestureSettings

Bug: 136610131
Test: robotest & manual
Change-Id: If58c70549339b66116f19df7193d85bb04e3f1b7
2019-09-21 07:19:35 +08:00
Edgar Wang
c3a9fff980 Handle Aware sensor status for Always On
- "Always On" preference will be hiden when aware
sensor is available
- Extract NavModeCandidateInfo from SystemNavigationGestureSettings

Bug: 136610131
Test: robotest & manual
Change-Id: If58c70549339b66116f19df7193d85bb04e3f1b7
2019-09-21 02:08:36 +08:00
Emilian Peev
78db757cad Developer option off must not affect laser sensor
Turning developer settings to on or off must not
change the current laser sensor preference.

Bug: 140016130
Test: mma ROBOTEST_FILTER=CameraLaserSensorPreferenceControllerTest,
manual using Settings application

Change-Id: Ieb30527e5df97abcb00a6624e1ced93f9198c713
2019-09-20 09:01:06 -07:00
TreeHugger Robot
0aec85c8c1 Merge "Update notification log" 2019-09-20 14:24:24 +00:00
苗苗 (Miao Miao)
9f4a65c893 In sim1 APN settings interface and hot plug out/in sim2, APN information change to sim2's
STEPS TO REPRODUCE:
1. Insert two sim into device, sim1 is CUCC, sim2 is CMCC
2. Goto Settings-Network & Internet-sim1-MobileNetworkSettings-Access Point Names. It shows CUCC APN information
3. Hot plug out sim2
4. Hot plug in sim2, APN information changes to CMCC APN information

EXPECTED RESULTS:
When hot plug out/in sim2, sim1 APN settings interface should still keep its APN information instead of changing to sim2 APN information

Change-Id: I04c769f60ba1686b2c9bebcd07e3a04685979442
Bug: 141087659
Test:In sim1 APN settings interface, hot plug out/in sim2, it shows sim1 APN information all the time, test pass.
2019-09-20 18:13:30 +08:00
Tsung-Mao Fang
12155084d8 Hide a11y usage when there is no enabled a11y service
A11y usage still shows in privacy page after
user disable a11y with a11y usage dialog.

We need to check again whether there is any enabled a11y
after screen comes back to foreground.

Change-Id: Icf7aa7dc9d802765ec49df8651385397f454cd48
Fix: 140207216
Test: robotest
2019-09-20 17:32:19 +08:00
Stanley Wang
19afdba261 Mobile data should be non-indexable when the subscription id is invalid.
Return AVAILABLE_UNSEARCHABLE when the subscription id is invalid.

Fixes: 141289758
Test: manual and robotests
Change-Id: I86534182fca26bf7b56ee1ee7d6f573a142a6a3a
2019-09-20 02:34:06 +00:00
Stanley Wang
03d6dad7d4 Merge "Fix can't find the search result by input "4G Calling"" 2019-09-20 02:17:07 +00:00
Kevin Chang
ddc8440aad Merge "Change disable accessibility service dialog layout" 2019-09-20 02:14:26 +00:00
Bonian Chen
4ac6f1a781 Merge "[Help Page] Support help content under 2 CDMA SIM" into qt-qpr1-dev am: 20290d0451
am: 3cce668981

Change-Id: I16c4e2ef30bd62acec5d4b54fe57ac1ff25dbb90
2019-09-19 13:32:01 -07:00
Bonian Chen
3cce668981 Merge "[Help Page] Support help content under 2 CDMA SIM" into qt-qpr1-dev
am: 20290d0451

Change-Id: I0b3cb958eff31ede7daa3292987684c26e9111d5
2019-09-19 13:25:31 -07:00
Bonian Chen
20290d0451 Merge "[Help Page] Support help content under 2 CDMA SIM" into qt-qpr1-dev 2019-09-19 20:07:20 +00:00
Stanley Wang
9cbca4bcee Fix can't find the search result by input "4G Calling"
Add indexable raw data for type 4G_CALLING or ADVANCED_CALL and
set the volte to non-indexable if current type is not volte.

Fixes: 137155154
Test: manual

Change-Id: I0992f9fb95e0b1cc23fb4f38f356ee0569f3b5b1
2019-09-19 19:21:16 +08:00
Kevin Chang
f8c360febf Add content description in the tutorial dialog
Add content description in the message of tutorial dialog in
accessibility button mode. It prevents Talkback speaking out "%s",
which is not the content we want.

Bug: 135497450
Test: test with TalkBack
Change-Id: If7ce8a957cbb44a12124bc3436d8e32ef0f0da83
2019-09-19 15:04:42 +08:00
joshmccloskey
3786016993 Removed old settings device credential logic.
Bug: 140128468
Test: Verified with biometricpromptdemo that confirm device credential
still works correctly.
Change-Id: I0f608ba1256c696317402f56549452bf6933066b
2019-09-18 15:57:22 -07:00