TreeHugger Robot
8870591ab3
Merge "Restore original importance when unblocking notif channel" into rvc-qpr-dev am: 8fca94f56c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12139829
Change-Id: I3a2a93b4cc2f0e5630f51635cc9313845bb05015
2020-07-13 23:46:24 +00:00
Julia Reynolds
2700b83c48
Restore original importance when unblocking notif channel
...
Test: atest
Fixes: 62355992
Change-Id: I5d764d0ade68b2ce5708ae79e9ef488ab57bb141
(cherry picked from commit e2a8266328 )
2020-07-13 20:13:43 +00:00
Lucas Dupin
82c3503d1e
Merge "Delete media feature flag" into rvc-dev am: 9b01b8510a am: 91ba077612 am: 162d505e14
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12108974
Change-Id: I7734d178ac6cbd93a76d258c7edc22434d76ad19
2020-07-13 17:26:32 +00:00
Lucas Dupin
162d505e14
Merge "Delete media feature flag" into rvc-dev am: 9b01b8510a am: 91ba077612
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12108974
Change-Id: Iebc0844230afdb44868f4f1a6245808aee291dfb
2020-07-13 17:13:42 +00:00
Lucas Dupin
ffda931026
Merge "Delete media feature flag" into rvc-dev am: 9b01b8510a am: 03edb83f56
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12108974
Change-Id: Id71cee5d2db2623b3d66203075d4c34405322bed
2020-07-13 17:13:39 +00:00
Lucas Dupin
03edb83f56
Merge "Delete media feature flag" into rvc-dev am: 9b01b8510a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12108974
Change-Id: I4fc62150f05b1d59bcd77fe7566dd334f1d8931d
2020-07-13 16:55:39 +00:00
Lucas Dupin
91ba077612
Merge "Delete media feature flag" into rvc-dev am: 9b01b8510a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12108974
Change-Id: Ie6859a17ba1f1d420f231ba6d9385a48ce442923
2020-07-13 16:55:38 +00:00
Lucas Dupin
9b01b8510a
Merge "Delete media feature flag" into rvc-dev
2020-07-13 16:44:15 +00:00
TreeHugger Robot
b8a8fef548
Merge "Increase expand/collapse tap target" into rvc-qpr-dev am: 35e0d32d0e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12130259
Change-Id: I4998fdace936dc05a40a80ee0602a2c0568607e7
2020-07-10 22:12:12 +00:00
Julia Reynolds
0bdffb98c3
Increase expand/collapse tap target
...
Fixes: 157160901
Test: manual with voice a11y service
Change-Id: Ic1cdd3ee4f22d66d76718fae11304a0d6128def2
(cherry picked from commit bfab43571d )
2020-07-10 19:34:06 +00:00
Sunny Shao
eb0e0be13f
Fix toggle widget can be switched under overlapped view am: 4794b798c4 am: cfffebd5c4 am: 749dabb46c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12124562
Change-Id: I27c053df7935a917ea80a1f31edb617fc20b7b05
2020-07-10 07:33:59 +00:00
Sunny Shao
a4afb4742a
Fix toggle widget can be switched under overlapped view am: 4794b798c4 am: cfffebd5c4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12124562
Change-Id: I3d40e9a076e79bbf55eb81a616cfb9a583a8ea8c
2020-07-10 07:22:04 +00:00
Sunny Shao
749dabb46c
Fix toggle widget can be switched under overlapped view am: 4794b798c4 am: cfffebd5c4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12124562
Change-Id: Ie99be59204c03dcac32aeb29dd2a9c05a95309b9
2020-07-10 07:21:44 +00:00
Sunny Shao
1c7d1dfba6
Fix toggle widget can be switched under overlapped view am: 4794b798c4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12124562
Change-Id: I7d6b33b80c948337b1526fd0becfbe87d535895b
2020-07-10 07:09:48 +00:00
Sunny Shao
cfffebd5c4
Fix toggle widget can be switched under overlapped view am: 4794b798c4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12124562
Change-Id: I767f72eae29753c9936c505b6c6348650ef6b3c6
2020-07-10 07:09:34 +00:00
Sunny Shao
4794b798c4
Fix toggle widget can be switched under overlapped view
...
- ag/11612781 added filterTouchesWhenObscured to toggle widget
can't prevent the click behavior pass through the overlapped view.
- Due to click events was handled by SwitchPreference instead of the
toggle widget.
- Enable the filterTouchesWhenObscured attribute on all
SwitchPreferences in all pages of the special app access.
Bug: 155288585
Test: manual test
Here is the test steps
1.Create an overlapped view's app and launch it to overlap the
other apps.
2.Launch Settings
3.Goto Apps & notification > Advanced > Special app access
4.Click any toggle under Special app access to monitor it can be
switched or not. It must be not switched.
Change-Id: I9c9cf4719153292ed03f55a6eb9d3a308677aee3
2020-07-10 06:11:24 +00:00
Lucas Dupin
42219fb395
Delete media feature flag
...
The feature will always be available, even for users who disabled it
on Beta 1.
Bug: 160826507
Test: manual
Test: MediaControlsParentPreferenceControllerTest
Test: MediaControlsPreferenceControllerTest
Change-Id: Ia2835e7c8156d753a8f8fbf248f2509003309fd2
2020-07-09 11:57:27 -07:00
TreeHugger Robot
81239defba
Merge "Guard against SecurityException of accessing to slice uri" into rvc-dev am: 28a5c00429 am: ad90366eef am: 76c4de9b32
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12042286
Change-Id: Ibf5541ee46d1465a941e80d5a25e9e553322429c
2020-07-08 18:46:24 +00:00
TreeHugger Robot
e7061f6436
Merge "Guard against SecurityException of accessing to slice uri" into rvc-dev am: 28a5c00429 am: ad90366eef
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12042286
Change-Id: I7f637520c29177dbd60fabbef6c27f0eb195c51f
2020-07-08 18:33:51 +00:00
TreeHugger Robot
76c4de9b32
Merge "Guard against SecurityException of accessing to slice uri" into rvc-dev am: 28a5c00429 am: ad90366eef
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12042286
Change-Id: I68fc9122aa6ae1f98f57ef41503aee9be46d2269
2020-07-08 18:33:46 +00:00
TreeHugger Robot
ba3131d923
Merge "Guard against SecurityException of accessing to slice uri" into rvc-dev am: 28a5c00429
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12042286
Change-Id: I5a022bd9d9b9485f9caf10c42f7146d35660da0a
2020-07-08 18:22:18 +00:00
TreeHugger Robot
ad90366eef
Merge "Guard against SecurityException of accessing to slice uri" into rvc-dev am: 28a5c00429
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12042286
Change-Id: I1319699912f7b7d332c0680670598179b5f8b522
2020-07-08 18:22:00 +00:00
TreeHugger Robot
28a5c00429
Merge "Guard against SecurityException of accessing to slice uri" into rvc-dev
2020-07-08 18:09:09 +00:00
Jason Chiu
eaf1564d9f
Guard against SecurityException of accessing to slice uri
...
- Sometimes unregistering a Slice callback will have no permission to
unpin the Slice uri and throw an exception.
- Guard against the exception as the first solution.
Bug: 159722324
Test: robotest
Change-Id: Ic227331fef64c3fa6fe3e4442fba2a9b754d520d
2020-07-08 11:28:33 +00:00
Zhen Zhang
d3b7566f29
Merge "Fix bug: "Hotspot & Tethering" preference doesn't get updated" into rvc-dev am: 05ae65b7b0 am: c570eb8c9a am: 29433c163d
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12052065
Change-Id: I51fa6971340d4f91ccf75491def670e41c45277f
2020-07-06 19:28:06 +00:00
Zhen Zhang
f2c65caa4c
Merge "Fix bug: "Hotspot & Tethering" preference doesn't get updated" into rvc-dev am: 05ae65b7b0 am: c570eb8c9a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12052065
Change-Id: I20c9dc4af83fdf232db45990617c49d2283ad88f
2020-07-06 19:17:44 +00:00
Zhen Zhang
29433c163d
Merge "Fix bug: "Hotspot & Tethering" preference doesn't get updated" into rvc-dev am: 05ae65b7b0 am: c570eb8c9a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12052065
Change-Id: If6b249b1a028de832228c146982e4397addac95c
2020-07-06 19:17:26 +00:00
Zhen Zhang
07edb930c2
Merge "Fix bug: "Hotspot & Tethering" preference doesn't get updated" into rvc-dev am: 05ae65b7b0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12052065
Change-Id: I375e6de0cfa3c6c0e2cbc0110194352885379e72
2020-07-06 19:04:54 +00:00
Zhen Zhang
c570eb8c9a
Merge "Fix bug: "Hotspot & Tethering" preference doesn't get updated" into rvc-dev am: 05ae65b7b0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12052065
Change-Id: I5b0fbdb7f52f6570f273bc4510cd0fdecf2f7a63
2020-07-06 19:04:48 +00:00
Zhen Zhang
05ae65b7b0
Merge "Fix bug: "Hotspot & Tethering" preference doesn't get updated" into rvc-dev
2020-07-06 18:54:47 +00:00
TreeHugger Robot
0642f08479
Merge "Fix sketchy bubble preference button" into rvc-qpr-dev am: 031b9fe646
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12061236
Change-Id: Ia0e5c226bab8a632bc8c499ae64df24fff41d8a1
2020-07-06 13:57:02 +00:00
TreeHugger Robot
031b9fe646
Merge "Fix sketchy bubble preference button" into rvc-qpr-dev
2020-07-06 13:43:52 +00:00
Jason Chiu
0e23f24b93
Merge "Fix the exception of accessing an ArrayMap" into rvc-dev am: 98eedf79d5 am: 6417468179
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12042287
Change-Id: I3a6e119e5ac02b1149e546f1669dba3ea68f1f3c
2020-07-06 03:19:03 +00:00
Stanley Wang
561efd1e11
Merge "Fix the bug of showing the "Smooth display" item in the search result." into rvc-dev am: 6458ea872c am: 2af4f657bb
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12065563
Change-Id: I13ea37f868fef7c56613925b863e721a967e41b5
2020-07-06 03:18:43 +00:00
Jason Chiu
4334b51165
Merge "Fix the exception of accessing an ArrayMap" into rvc-dev am: 98eedf79d5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12042287
Change-Id: Ib2169fa737b0c6344b77860896a6f4fa5b98ef41
2020-07-06 03:03:56 +00:00
Jason Chiu
6417468179
Merge "Fix the exception of accessing an ArrayMap" into rvc-dev am: 98eedf79d5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12042287
Change-Id: I591401d5f239885d25ba43b99e962341f90bda1c
2020-07-06 03:03:50 +00:00
Stanley Wang
1e05cbb580
Merge "Fix the bug of showing the "Smooth display" item in the search result." into rvc-dev am: 6458ea872c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12065563
Change-Id: I1aecef654565cc8520a720a20cc5c3afb1a17378
2020-07-06 03:03:49 +00:00
Stanley Wang
2af4f657bb
Merge "Fix the bug of showing the "Smooth display" item in the search result." into rvc-dev am: 6458ea872c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12065563
Change-Id: Iac0ec59e405443bc1edcb142f6c0f6f194b8ca30
2020-07-06 03:03:37 +00:00
Jason Chiu
98eedf79d5
Merge "Fix the exception of accessing an ArrayMap" into rvc-dev
2020-07-06 02:48:31 +00:00
Wei Huang
012c5858c9
Fix mvno data field summary not update issue
...
With current code logic, whenever user changing
mvno type, it only updates mvno data field text,
but the summary is not get updated.
For example, there is an apn configured as mvno
type 'GID' and mvno data 'FF', and user changes
mvno type to:
1. 'none' then save, the APN is saved with mvno
type 'none' and mvno data 'FF' while it is
better to save mvno data as empty value.
2. 'imsi', although the APN can be saved with mvno
type 'imsi' and mvno data 'mcc + mnc + x',
the UI still display mvno data field as 'FF'
unchanged(until user edit mvno data then save)
while the mvno data text is already changed to
'mcc + mnc + x'. It is better to also update
mvno data summary as 'mcc + mnc + x'
With current patch, either adding new apn or edit
exist apn, the mvno data field summary is always
consistent with latest mvno data field text, which
won't make user feel confused.
Test: Build and manual test on device.
Change-Id: Ica72e246296c20a6d20283b315e6e6c46e80ac08
Signed-off-by: Wei Huang <hwbest.v@gmail.com >
Signed-off-by: Honggang Luo <luo.loky@gmail.com >
Signed-off-by: Chao Yuan <chaoyuanx@gmail.com >
2020-07-04 04:11:52 +08:00
vichang
56a24f9ac1
Merge "Move libcore.timezone to the i18n module - Final part" am: 268371c44e am: 7485036f53 am: bc7f639e15
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1348663
Change-Id: I8d99d5ce1a84db343dac195a38c47041b7bf66f3
2020-07-02 11:03:47 +00:00
vichang
bc7f639e15
Merge "Move libcore.timezone to the i18n module - Final part" am: 268371c44e am: 7485036f53
...
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1348663
Change-Id: I8e81b3d707bce016006bf0af1f75785ecd15648e
2020-07-02 10:50:06 +00:00
vichang
268371c44e
Merge "Move libcore.timezone to the i18n module - Final part"
2020-07-02 10:25:54 +00:00
Stanley Wang
61147df890
Fix the bug of showing the "Smooth display" item in the search result.
...
The controller can't be created when Settings Search gets the
non-indexable keys. So Settings Search can't get the correct value
from it.
The controller creates the Handler without the parameter in constructor
and causes the exception. It should use the main Looper of Context as
the parameter to create the Handler.
Fixes: 160179400
Test: run robotest and observe the search result
Change-Id: I6f9bf6de087ae776e8d531ff59d28966aee96b7b
2020-07-02 14:35:43 +08:00
Lyn Han
5de9b1e4f1
Fix sketchy bubble preference button
...
We were re-using the same "unselected" drawable for buttons with
different heights, which causes one height to override the other,
leading to unexpected drawable overlap and height/text-line mismatch.
Instead, use separate drawable per button.
Fixes: 154087375
Test: toggle between pref buttons in every font size
Change-Id: I5db6e1eb5150a72a0d8038b0840538a0982a5f67
2020-07-01 19:00:34 +00:00
Jason Chiu
ea689abbcd
Fix the exception of accessing an ArrayMap
...
- ArrayMap is not thread-safe.
- When accessing the map across threads at the same time, the map may
throw a ConcurrentModificationException.
- Convert the map to a synchronizedMap to avoid the exception.
Fixes: 159813482
Test: robotest
Change-Id: I3b8bdd435c7c546acf736fa8aafd2ceaed94d081
2020-07-01 10:42:25 +00:00
Zhen Zhang
222be02b34
Fix bug: "Hotspot & Tethering" preference doesn't get updated
...
Aissign the value of mPrefrence when displayPrefrence() being called.
This can fix the preference doesn't get updated bug. Added test to
ensure it.
Bug: 160169699
Test: make RunSettingsRoboTests
ROBOTEST_FILTER=AllInOneTetherPreferenceController
Change-Id: If0e7ce421cc46cff2b92837d2d07ea0ff4dc5fd9
2020-06-30 15:11:02 -07:00
Victor Chang
b07e53c1c8
Move libcore.timezone to the i18n module - Final part
...
Bug: 141747409
Test: atest CtsLibcoreTestCases CtsLibcoreTestCases
Change-Id: I48a1f383403a553639f525ef92996292fab84c5e
2020-06-30 14:35:09 +01:00
Stanley Wang
ca05c7fabd
Merge "Remove the prefix "Model:" from the summary of hardware." into rvc-d1-dev am: e86dd271da
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12034261
Change-Id: I132e88d5b1cb22db5042c0e66b6bc61ab30efcba
2020-06-30 10:41:41 +00:00
Stanley Wang
e86dd271da
Merge "Remove the prefix "Model:" from the summary of hardware." into rvc-d1-dev
2020-06-30 10:28:33 +00:00