Commit Graph

559 Commits

Author SHA1 Message Date
SongFerng Wang
10373c67c0 Merge "Modify the condition for showing DSDS dialog" into main 2024-10-28 02:59:18 +00:00
songferngwang
be68a15621 Modify the condition for showing DSDS dialog
Previous condition: there is the psim when the user enable esim
New condition: there is an active psim when the user enable esim

Bug: 362368874
Test: Test UI, atest SimOnboardingServiceTest
Flag: EXEMPT bugfix
Change-Id: I4260674794a961080b1f49e0f3d07ca9f2cf6ab6
2024-10-24 19:00:00 +00:00
songferngwang
8f6145c143 Add the condition to hide the MMS messages preference
If the carrier config KEY_MMS_MMS_ENABLED_BOOL is false, then the
settings hide the MMS messages preference

Test: atest MmsMessagePreferenceControllerTest
Bug: 371965435
Flag: EXEMPT bugfix
Change-Id: I93479bba28120f7b6cc5449f4a8277945d308e40
2024-10-22 10:28:13 +00:00
Chaohui Wang
44527db356 Fix PhoneNumberPreferenceControllerTest
Fix: 373247298
Flag: EXEMPT test only
Test: atest PhoneNumberPreferenceControllerTest
Change-Id: Ied4c46beca9130ea2db469e3f5dfe708c84b7373
2024-10-14 13:24:37 +08:00
songferngwang
8e6bc6f289 VideoCalling UI adds the init value
Bug: 367696228
Test: atest VideoCallingPreferenceControllerTest
Flag: EXEMPT bugfix
Change-Id: I1a1de9e3174a9211be619c96c104607f831b51a2
2024-10-03 14:29:05 +00:00
Chaohui Wang
9969334647 Fix Can't Able to Click Sims
The root cause is SubscriptionManager.OnSubscriptionsChangedListener
.onSubscriptionsChanged() not invoked in some cases.

Even the SubscriptionManager.addOnSubscriptionsChangedListener's doc
says the onSubscriptionsChanged() method will also be invoked once
initially when calling it, there still case that the
onSubscriptionsChanged() method is not invoked initially.
For example, when the onSubscriptionsChanged event never happens before,
on a device never ever has any subscriptions.

Adding a .onStart { emit(Unit) } to fix.

Also make the subscriptionsChangedFlow() a shared flow to mitigate the
extra emit cost.

Bug: 369276595
Flag: EXEMPT bug fix
Test: manual - factory reset & no any sim
Test: atest SubscriptionRepositoryTest
Change-Id: Ic32a5666f14373926b5dfedb5dedadb4369acfc7
2024-09-26 13:29:47 +08:00
Chaohui Wang
0b530fd405 Use hasScrollAction in ApnEditPageProviderTest
Instead of assuming a fixed tree structure in testing.

Fix: 369416630
Flag: EXEMPT gradle only
Test: atest ApnEditPageProviderTest
Change-Id: I0a50e7665d9049e089b5a0877f17d1f736ee3332
2024-09-25 10:26:47 +08:00
Chaohui Wang
73fb290969 Check DISALLOW_CONFIG_MOBILE_NETWORKS when search
If disallowed, not show mobile related search results.

Bug: 358238959
Flag: EXEMPT bug fix
Test: manual - search Mobile Settings
Test: atest MobileNetworkSettingsSearchIndexTest
Change-Id: I79b984f41f09dd9612bcd0c9942089756d5d365d
2024-09-23 11:17:55 +08:00
Treehugger Robot
4f6b56277c Merge "Fix crash when phone process has problem." into main 2024-09-19 13:04:54 +00:00
tomhsu
56ff329900 Fix crash when phone process has problem.
- Phone process may not exist in some situation. It shall catch the
   exception to avoid Settings crash.

Flag: EXEMPT bugfix
fix: 365669913
Test: build pass
Change-Id: I2b95f46b8887a9c8416fb4a5724537ad27e86850
2024-09-19 11:37:02 +00:00
Chaohui Wang
275fbccd47 Merge "Create MobileNetworkSummaryRepository" into main 2024-09-19 07:51:18 +00:00
SongFerng Wang
501bc72850 Merge "Add the awaitIdle" into main 2024-09-18 09:04:20 +00:00
Chaohui Wang
777a179bd6 Create MobileNetworkSummaryRepository
For MobileNetworkSummaryController to use, so it no longer use
MobileNetworkRepository.

Fix: 366097262
Flag: EXEMPT refactor
Test: manual - on Network & internet
Test: atest MobileNetworkSummaryRepositoryTest
Change-Id: I8a9d52af8e230fc407a4339c27f73ef79d512b24
2024-09-18 13:07:50 +08:00
songferngwang
0fae9c3492 Add the awaitIdle
To fix the "androidx.compose.ui.test.ComposeTimeoutException: Condition still not satisfied after 1000 ms"

Bug: 351915085
Test: atest SimOnboardingLabelSimTest
atest SimOnboardingSelectSimTest
Flag: EXEMPT bugfix

Change-Id: I61e192ab9e0518ed40823aa92609d2f9e753bdee
2024-09-18 02:57:21 +00:00
Chaohui Wang
958639b79c Merge "Create SimRepository" into main 2024-09-13 02:40:52 +00:00
Chaohui Wang
a6db1aabb6 Create SimRepository
Which unifies whether we should sim settings on some related pages.

Before this change, we check SubscriptionUtil.isSimHardwareVisible()
and / or Utils.isWifiOnly().

After this change, we unified logic to,
canChangeSimSettings() =
  packageManager.hasSystemFeature(PackageManager.FEATURE_TELEPHONY) &&
    userManager.isAdminUser

Fix: 365924140
Flag: EXEMPT bug fix
Test: manual - check Network & internet
Test: unit tests
Change-Id: Ibf83237e3d0088f78c96a1b39ee8f1e3a9c756ea
2024-09-12 08:59:26 +00:00
Chaohui Wang
ced86bf56d Create selectableSubscriptionInfoListFlow
Which can be used in MobileNetworkSummaryController in the future.

Bug: 366097262
Flag: EXEMPT refactor
Test: manual - check Network & internet
Test: unit tests
Change-Id: Ia74af993646c2e1d53817f1e9f8ac3ef0b8fa97a
2024-09-12 11:43:05 +08:00
Chaohui Wang
9b118faa3e Merge "Create NrRepository" into main 2024-09-10 03:36:02 +00:00
Chaohui Wang
9179ad5fc2 Create NrRepository
To unify the isNrAvailable logic.

Bug: 358000881
Flag: EXEMPT refactor
Test: manual - on mobile settings
Test: atest NrRepositoryTest
Change-Id: I60fed4be10f0cc7b8b1a942abd598e82c53d1473
2024-09-05 15:56:43 +08:00
Chaohui Wang
426cbd623d [Safer intents] App Time Spent Preference
Set package com.android.internal.R.string.config_systemWellbeing to the
intent.

Fix: 356117796
Flag: EXEMPT bug fix
Test: manual - on App info
Test: atest AppTimeSpentPreferenceTest
Change-Id: I2af7b53a75fe5c6915dd9781406039822789c18c
2024-09-04 11:18:28 +08:00
Chaohui Wang
355ee0a1ee Refine CrossSimCalling updating
Currently, this setting depends on whether wifi calling is supported,
since wifi calling could takes some time to provision after sim is
turned on, this state could be wrong when set cross sim calling.

Use wifiCallingReadyFlow() to retrieve the latest state, and update
setting when state changes.

Fix: 352736998
Fix: 348529996
Flag: EXEMPT bug fix
Test: manual - by turn on / off sim
Change-Id: Id4b099e0c5d7cf47b007f37e6f278d1c46e58659
2024-09-02 17:58:17 +08:00
Chaohui Wang
e9136c7817 Merge "New isSubscriptionVisibleFlow" into main 2024-09-02 05:04:08 +00:00
Chaohui Wang
1b3a315d06 New isSubscriptionVisibleFlow
Use this instead of mSubscriptionInfoEntity, so MobileNetworkSettings
not closed unexpectedly.

Bug: 358238959
Flag: EXEMPT bug fix
Test: force stop settings & settings search - mobile settings
Test: adb shell am start -a android.settings.NETWORK_OPERATOR_SETTINGS
Change-Id: I34286da808600d8b9faa0da85a59665707ecfde3
2024-08-30 15:55:44 +08:00
Chaohui Wang
5b4748919a Use simSpecificCarrierId for new apn
Currently in TelephonyProvider, it uses tm.getSimSpecificCarrierId() to
get the specific carrier id to retrieve the apns, update Settings to
match.

Fix: 360917123
Flag: EXEMPT bug fix
Test: manual - new apn
Test: atest ApnRepositoryTest
Change-Id: I982e0026acdf34ccec7508c41f83718894f7da57
2024-08-30 11:16:34 +08:00
Chaohui Wang
bb8199e8be Merge "Create VideoCallingRepository" into main 2024-08-29 06:52:50 +00:00
Chaohui Wang
f218f76221 Create VideoCallingRepository
Also support settings search for video calling.

Fix: 233327342
Flag: EXEMPT bug fix
Test: manual - on mobile settings
Test: manual - search video calling
Test: unit test
Change-Id: Ic4a25849f77f1759fa157931d428daa9e6854ff2
2024-08-29 03:37:50 +00:00
Chaohui Wang
f74e90787e Create EuiccRepository
Which also avoid calling from main thread.

Bug: 356684993
Flag: EXEMPT bug fix
Test: manual - on SIMs
Test: atest EuiccRepositoryTest
Change-Id: I0b11b0bd1e8a4b5754781e888fd220fa3080a212
2024-08-29 11:34:19 +08:00
Chaohui Wang
b3ee1d70c4 Settings search for Carrier settings version
Bug: 358238959
Flag: EXEMPT bug fix
Test: manual - search carrier
Test: unit test
Change-Id: I4c13d22a6b689273684ff44df8071789a7a78d6e
2024-08-20 13:22:04 +08:00
Chaohui Wang
37693f29f1 Create ImsFeatureRepository
To be shared with video calling and VoLTE features.

Bug: 233327342
Flag: EXEMPT bug fix
Test: manual - on Mobile Settings
Test: atest ImsFeatureRepositoryTest
Change-Id: Ic7bcb532c4bd32c6f7ac4af1eebdd8a70a86ff29
2024-08-19 17:16:07 +08:00
Chaohui Wang
6f9f6cff6b Merge "Settings search for app data usage" into main 2024-08-19 05:17:45 +00:00
Chaohui Wang
2c751d1671 Merge "Create UiccSlotRepository" into main 2024-08-19 05:17:04 +00:00
Chaohui Wang
6c6f3471c6 Reduce flaky of title_displayed
Bug: 355413226
Flag: EXEMPT test only
Test: atest InstantAppDomainsPreferenceTest
Change-Id: Id4ed656e462421c6bc59343eb541663c1aa49dfb
2024-08-19 12:12:01 +08:00
Chaohui Wang
6afa25df8b Encode SpaSearchLandingKey with Base64
To ensure the landing key is the same as the indexing key.

Bug: 358238959
Flag: EXEMPT bug fix
Test: manual - search roaming
Test: unit test
Change-Id: I26ce712feaa83e9e70a3eb39039e5c3527f24cca
2024-08-16 16:00:02 +08:00
Chaohui Wang
f2591b2968 Settings search for app data usage
Bug: 358238959
Flag: EXEMPT bug fix
Test: manual - search app data usage
Change-Id: Ie39a7f25b72f7b264f53329082fa34231c2aaa89
2024-08-16 14:02:24 +08:00
Chaohui Wang
1951412dbe Create UiccSlotRepository
Also fix crash when TelephonyManager.uiccSlotsInfo returns array
contains null.

Fix: 358215954
Flag: EXEMPT bug fix
Test: manual - on Mobile Settings
Test: atest UiccSlotUtilTest
Change-Id: I4f92c9a43a430e295b6e048aee059416c46a256b
2024-08-15 08:27:34 +00:00
Hakjun Choi
c887a26971 Filter out the satellite PLMNs from the current connected network
Filter out satellite PLMN if current connected network is satellite when user get into the manual select network menuIf Automatically select network is

Bug: 358429071
FLAG: EXEMPT bugfix
Test: manually test if satellite plmn is shown
Change-Id: I79aefc62e897319cae199985e9a63284086f6c2d
2024-08-15 04:23:59 +00:00
Chaohui Wang
f245b3e04f Create ProvisioningRepository
Also check if has IMS feature before calling ProvisioningManager.

Bug: 358000881
Flag: EXEMPT refactor
Test: manual - on Mobile Settings
Test: atest ProvisioningRepositoryTest
Change-Id: I5fffff6c63af8c67d666b0e855f026633bb36651
2024-08-12 05:43:57 +00:00
Chaohui Wang
fa28c7a636 Merge "Reduce flaky of AppNotificationPreferenceTest" into main am: 422770ed1e am: 6d09b136d5
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3212002

Change-Id: I7255b69e79f7a970c2488d4bcf700c43f13ce40a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-09 07:11:25 +00:00
Chaohui Wang
6d09b136d5 Merge "Reduce flaky of AppNotificationPreferenceTest" into main am: 422770ed1e
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/3212002

Change-Id: If04a3e903a7fd151dd07004eba283f41df044ebe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-08-09 06:55:52 +00:00
Chaohui Wang
7380359520 Reduce flaky of AppNotificationPreferenceTest
Bug: 355413226
Flag: EXEMPT test only
Test: atest AppNotificationPreferenceTest
Change-Id: I1dfe4c5ae764941acb78e8fad52518963d1dad74
2024-08-09 05:33:27 +00:00
Chaohui Wang
25d5816f5f Dual SIM search for Preferred network type
Bug: 358238959
Flag: EXEMPT bug fix
Test: manual - search preferred
Test: atest EnabledNetworkModePreferenceControllerHelperTest
Change-Id: Icb86d88eec3bcaaaf1db67f7008173a90957cbbc
2024-08-08 14:16:29 +08:00
Chaohui Wang
749c22b1c6 Refactor MobileNetworkSettingsSearchIndex
To support the case that MobileNetworkSettingsSearchItem could have
different key or title.

Bug: 358238959
Flag: EXEMPT refactor
Test: manual - search vo5g
Test: atest MobileNetworkSettingsSearchIndexTest
Test: atest MmsMessagePreferenceControllerTest
Change-Id: I18afc8a347566d50dd7969d2c906d0ae64be8a80
2024-08-08 14:14:56 +08:00
Chaohui Wang
e2f0a6b2d3 Fix the sorting order for restricted
Set the category for the restricted item to fix.

Fix: 357275199
Flag: EXEMPT bug fix
Test: manual - on DataUsageList
Test: atest AppDataUsageRepositoryTest
Change-Id: I63d3fd2ac85748d67ff6194cd60adeadae2aa984
2024-08-07 02:23:23 +00:00
Treehugger Robot
793253aaf2 Merge "Reduce flaky of BackgroundInstalledAppsPageProviderTest" into main 2024-08-05 03:11:39 +00:00
Chaohui Wang
210529efc4 Reduce flaky of BackgroundInstalledAppsPageProviderTest
Bug: 355413226
Flag: EXEMPT test only
Test: atest BackgroundInstalledAppsPageProviderTest
Change-Id: Iede656b7cf34bac82718f0aff12ee28cbaa9d8f8
2024-08-05 10:23:02 +08:00
Chaohui Wang
c311354d10 Show uncheck toggle when wep not supported
When wep not supported, wep is always not allowed, so we should show
unchecked toggle for "Allow WEP networks"

Bug: 356326814
Flag: EXEMPT bug fix
Test: manual - on Network preferences
Test: atest WepNetworksPreferenceControllerTest
Change-Id: I408434fbbf48e1010710ecf3bf9f7988e521b076
2024-08-02 11:43:20 +08:00
Chaohui Wang
b7f68b4a60 Merge changes from topic "MobileNetworkSettingsSearchIndex" into main
* changes:
  Fix search for MMS Message
  Show category when search "Mobile data"
2024-07-31 09:07:20 +00:00
Chaohui Wang
e15fcaa1cf Reduce flaky of InstantAppDomainsPreferenceTest
Also DeveloperOptionsControllerTest.

Fix: 355270127
Flag: EXEMPT test only
Test: atest InstantAppDomainsPreferenceTest
Test: atest DeveloperOptionsControllerTest
Change-Id: I80517988b8674ec4d717292da71454419762e65a
2024-07-30 16:29:09 +08:00
Chaohui Wang
30b9c3c1ae Merge "Create SubscriptionRepository.phoneNumberFlow" into main 2024-07-30 04:41:02 +00:00
Chaohui Wang
7009c008f9 Fix search for MMS Message
Also display multiple results when there are multiple MMS Message on
different SIMs.

When doing indexing, we not also log sub id as part of the key.
When user clicks the result, using SpaSearchLandingActivity to do the
redirection, set arguments to the fragment.

Fix: 352245817
Flag: EXEMPT bug fix
Test: manual - search mms
Test: unit test
Change-Id: Id47a1151cb418c18f68f97e3be33dcd21c5f5102
2024-07-30 11:34:24 +08:00