Commit Graph

1096 Commits

Author SHA1 Message Date
Bartosz Fabianowski
9290184ebf Hide potentially invisible DO Disclosures by default
Hiding/unhiding a pref triggers an animation. DO Disclosures that may
not be visible should be hidden by default so that they fade in if
applicable, not fade out if not applicable.

Also, the network and security logging disclosures should only be shown
if logging is currently on or was on in the past and a network log was
retrieved at least once.

Bug: 32692748
Test: m RunSettingsRoboTests

Change-Id: I8c85f2f66ba295f145e5f5e79febb1b1a9bc6ede
2017-03-24 14:37:01 +01:00
Denis Kuznetsov
0c88ff4ed9 Update List of apps on device string,
remove "XX apps" string.

Bug: 32692748
Test: m RunSettingsRoboTests
Change-Id: I64f833497b5362f95cfc56a1057d97d9539ff029
2017-03-24 13:00:49 +01:00
TreeHugger Robot
8bf18d7d3f Merge "Add test for UserSetting's summary provider." 2017-03-24 00:50:34 +00:00
TreeHugger Robot
775cb1479b Merge "Change "When in VR mode" to full screen radio button picker" 2017-03-24 00:47:37 +00:00
Fan Zhang
d53859df7d Set about phone subtext to device model string.
Also remove useless custom preference

Fix: 36395109
Test: robotests
Change-Id: I07297e6ade6991a8262473c9f59c21d914300244
2017-03-23 17:33:33 -07:00
TreeHugger Robot
4a35585197 Merge "Fix bug: UserPreference's gear icon got accidentally hidden" 2017-03-24 00:10:37 +00:00
TreeHugger Robot
af632ab6b2 Merge "Update string for Connected devices page." 2017-03-23 23:42:15 +00:00
Doris Ling
8f62b9e70a Add test for UserSetting's summary provider.
Change-Id: I5197c109f65f4049e27e704552a2206b19919df3
Fix: 36540644
Test: make RunSettingsRoboTests
2017-03-23 16:08:39 -07:00
Fan Zhang
abbe272e6f Fix bug: UserPreference's gear icon got accidentally hidden
Change-Id: I9715c3aff20ca8b7a324bd2f8629755690ddc119
Fix: 36545470
Test: make RunSettingsRoboTests
2017-03-23 15:37:42 -07:00
TreeHugger Robot
be716e423b Merge "Update text for Users & accounts page." 2017-03-23 21:23:53 +00:00
TreeHugger Robot
bc27c06c5b Merge "Refactor DefaultAppPicker to a general radio button picker" 2017-03-23 21:13:58 +00:00
TreeHugger Robot
7d2b05b26a Merge "Update the system info dialog." 2017-03-23 20:56:49 +00:00
Fan Zhang
a0c2c11bbf Change "When in VR mode" to full screen radio button picker
Change-Id: I619af85f9c4a2c32daca786f49e898fde9b593f8
Fix: 36557316
Test: make RunSettingsRoboTests
2017-03-23 13:44:23 -07:00
Daniel Nishi
3414a6904b Badge the icons for profile storage screen.
Fixes: 36224168
Test: Settings Robotest
Change-Id: I27f0540aaa639b1248347ad41c8f1b711fe65fe7
2017-03-23 13:36:20 -07:00
Doris Ling
fe768e9e22 Update string for Connected devices page.
- update Bluetooth summary text "Connected to" and "Not connected"
- update USB summary text "Charging" and "Supplying"
- update Printing summary to "... on" or "off

Change-Id: I39a809b560a5c6cc6a0e217315dfabb2c4d1a129
Fix: 36234108
Test: builds
2017-03-23 13:22:52 -07:00
TreeHugger Robot
4433c8ce3d Merge "Add page Settings->Security & lock screen->Lock screen preferences." 2017-03-23 20:05:33 +00:00
Doris Ling
81f22e88f9 Update text for Users & accounts page.
- add back the summary loader for UserSettings
- remove "configure" preference category
- add summary for Auto sync data and update the title

Change-Id: Ia00397f775f86d0e160a54783a8518847fce8de8
Bug: 36540644
Test: builds
2017-03-23 12:56:33 -07:00
Fan Zhang
a278962dbc Refactor DefaultAppPicker to a general radio button picker
Bug: 36557316
Test: make RunSettingsRoboTests
Change-Id: I52985e527e55697cf29f8d97d775d4bbed025beb
2017-03-23 12:41:31 -07:00
TreeHugger Robot
f7e9d46370 Merge "Finalize strings for enterprise privacy" 2017-03-23 19:39:24 +00:00
Doris Ling
93582995da Add page Settings->Security & lock screen->Lock screen preferences.
- add the new preference screen that contains configuration for lock
screen notification, add user when locked, and owner info.
- refactor SecuritySettings to use the new owner info controller.

Fix: 36163515
Test: make RunSettingsRoboTests

Change-Id: I3bada8f652f89ed0af7aebc03f0bf2f637296b4d
2017-03-23 11:35:20 -07:00
Bartosz Fabianowski
193e0bedac Finalize strings for enterprise privacy
A few more final string tweaks for the enterprise privacy page.

Bug: 32692748
Test: m RunSettingsRoboTests

Change-Id: Ib955aa5a6e756748ed7422021099234ad3fefa8b
2017-03-23 18:19:19 +01:00
TreeHugger Robot
b3f13f9f32 Merge "Update print setting summary to show number of services" 2017-03-23 17:16:20 +00:00
TreeHugger Robot
3fe93767cb Merge "Add double-tap & lift gestures to display settings" 2017-03-23 05:09:50 +00:00
Fan Zhang
01ece62faa Update print setting summary to show number of services
-Also some minor cleanup in print setting fragment (create pref using
correct context)

Change-Id: Ic05027ee53fd318da6ccd38c9ed98ce10ca49ba8
Fix: 36234108
Test: make RunSettingsRoboTests
2017-03-22 18:27:19 -07:00
TreeHugger Robot
b0967c8287 Merge changes from topic 'two_target_preference'
* changes:
  Update string character limit
  Convert BT preference to use TwoTargetPreference
  Refactor the layout for MasterSwitch to a 2 target pref
2017-03-23 01:26:48 +00:00
Andrew Sapperstein
6138f1ab31 Add double-tap & lift gestures to display settings
Now they're in both languages & input and display.

Change-Id: Ib0d9fa1aa39656662307e2fc8fda70443f1ae8ed
Fixes: 36415612
Test: robotests
2017-03-22 18:20:37 -07:00
TreeHugger Robot
7de6dbb2d5 Merge "Add test config to SettingsUnitTests" 2017-03-22 23:16:06 +00:00
Daniel Nishi
fda5d5a6a8 Update the system info dialog.
The string is updated as well as where the dialog shows up.

Change-Id: If1a3b17dca04fe81f52dbdc2353db34ce7adc49a
Fixes: 34857117
Test: Robotest
2017-03-22 16:12:55 -07:00
Fan Zhang
09c7f15b12 Convert BT preference to use TwoTargetPreference
Change-Id: I0b49af4afb4b782a6057060b2666f6528bc003b2
Fix: 36511169
Test: make RunSettingsRoboTests
2017-03-22 16:03:45 -07:00
Fan Zhang
fe292515d8 Refactor the layout for MasterSwitch to a 2 target pref
And move the layout to settingslib.

The new TwoTargetPreference is a preference object that has a vertical
divider between main panel and widget (if it exists).

Converted master switch, restricted preference, gear preference to use
the new style

Change-Id: Ia3848cebb06b8edc4e60abf9b0caf13cdb29c22c
Fix: 36511169
Test: make RunSettingsRoboTests
2017-03-22 16:03:40 -07:00
TreeHugger Robot
cb92917e1e Merge "Use fragment context in AppHeaderController" 2017-03-22 20:59:24 +00:00
jackqdyulei
abba040727 Use fragment context in AppHeaderController
The application context doesn't have the correct theme, use
fragment context instead

Fix: 36489386
Fix: 36516826
Test: RunSettingsRoboTests & Screenshot
Change-Id: I8285584220796264d85ea570df5b1df6ebeb275f
2017-03-22 12:42:39 -07:00
Dan Shi
41d96207e8 Add test config to SettingsUnitTests
Details about test configs changes are tracked in doc
https://docs.google.com/document/d/1EWUjJ7fjy8ge_Nk0YQbFdRp8DSHo3z6GU0R8jLgrAcw/edit#

Bug: 35882476
Test: local test
Change-Id: Ie9fdc4717a71cb0f472b004b704acf3c4f770267
2017-03-22 12:07:08 -07:00
TreeHugger Robot
ceb46ac8e7 Merge "Fix a monkey crash when it dismisses suggestion." 2017-03-22 18:34:56 +00:00
Doris Ling
422fc4a433 Merge "Update preference text for Network & internet screen." 2017-03-22 17:22:27 +00:00
Fan Zhang
8c8c4077fe Fix a monkey crash when it dismisses suggestion.
Change-Id: I300a49ed75381795b6532388f770847ed39a4c8c
Fix: 36509330
Test: make RunSettingsRoboTests
2017-03-22 10:04:39 -07:00
Lei Yu
679ed4c30c Merge "Make percentage add up to dischargeAmount." 2017-03-22 16:49:21 +00:00
Doris Ling
47ec3857a5 Update preference text for Network & internet screen.
- Add footer info to Hotspot & tethering
- Add summary text for Data usage -> Network restrictions
- Update summary for Hotspot & tethering -> Portable Wi-Fi hotspot
- Remove quotes from Wi-Fi summary

Bug: 36296257
Test: make RunSettingsRoboTests

Change-Id: Ibab61b089521a3339e660e9df0db0cd1b316712b
2017-03-21 18:00:59 -07:00
Fan Zhang
3a32ee6132 Move autofill app picker from advanced app to language page
Change-Id: I38979e17e51bda92179ca5b7ba4293677aa18a96
Fix: 36130404
Test: make RunSettingsRoboTests
2017-03-21 17:42:27 -07:00
Fan Zhang
3720e0c4f1 Update system setting page subtext
- Move android version from about phone subtext to system update
- Updates strings for autofill, keyboard & input, factory reset, swipe
  for notification
- Add a new pref category for spell checker and personal dictionary
- Display "None" if any default app is not selected
- Display current keyboard type as language subtext

Bug: 36395109
Test: make RunSettingsRoboTests
Change-Id: Id6ca94ea31e55f1c1ec04e47dcf657a25c35c7fe
2017-03-21 17:40:11 -07:00
TreeHugger Robot
ca3997d27e Merge changes I54360698,Ic8a3db21
* changes:
  Finish removing N/A DO disclosures from search index
  DO Disclosures: Combine personal and work CA cert
2017-03-21 23:04:08 +00:00
TreeHugger Robot
19449197e6 Merge "Delete the estimated time in battery usage graph" 2017-03-21 22:24:56 +00:00
jackqdyulei
da8d9fc3d0 Make percentage add up to dischargeAmount.
Refine it in PowerUsageAdvanced.

Bug: 35960502
Test: RunSettingsRoboTests
Change-Id: I46b06409102334e5e9eed4e540a27315a503f8b0
2017-03-21 15:18:44 -07:00
TreeHugger Robot
f38ad51d4e Merge "Fix some animation janks during code start." 2017-03-21 21:57:02 +00:00
jackqdyulei
3a03b722c6 Delete the estimated time in battery usage graph
Bug: 31012673
Test: RunSettingsRoboTests
Change-Id: Icac85a5fc523b70904e048d17eace30c91fe54ee
2017-03-21 13:39:21 -07:00
Fan Zhang
320d60f0ad Fix some animation janks during code start.
- Create a   summary placeholder for preferences with summary.
- Create a totally empty summary for prefernces without summary.
- For all dynamic prefs that has *no* SummaryLoader, add meta to set
their summary to empty.
- Other dynamic perfs has   as initial summary.

By doing this, all dynamic pref's height is fixed and will not change as
we update summaries, thus eliminating jank during cold start in each
page.

Also removed DashboardAlias for notification preference and default apps as a side fix.

Change-Id: Iec98b7ffef4e920bf573b2244ad04124c1c5d154
Fix: 36414481
Test: make RunSettingsRoboTests
2017-03-21 13:20:18 -07:00
Bartosz Fabianowski
b076e00c5e Finish removing N/A DO disclosures from search index
DO disclosures referring to actions that the admin did not actually
take are hidden in the UI, but still show up in the search index. This
CL switches the remaining PreferenceControllers from setting visibility
to implementing isAvailable() instead.

Bug: 32692748
Test: m RunSettingsRoboTests

Change-Id: I54360698f28b549b18cdc230e3b9087cf4e9ff4a
2017-03-21 15:01:02 +01:00
Bartosz Fabianowski
4a19625286 DO Disclosures: Combine personal and work CA cert
It was decided that rather than having two separate items for CA certs
in the personal and work spaces, we should have just one item that
lists the sum of installed certs.

Bug: 32692748
Test: m RunSettingsRoboTests

Change-Id: Ic8a3db214a07992e3970262c2ce91f3df8a87773
2017-03-21 15:00:53 +01:00
Bartosz Fabianowski
e39e8350a1 Finalize strings for enterprise privacy
A few more final string tweaks for the enterprise privacy page.

Bug: 32692748
Test: m RunSettingsRoboTests

Change-Id: Icf91a1188febb303fb1a9e9a5259a06c3b2324da
2017-03-21 11:24:04 +01:00
Winson Chung
5dea0774f6 Merge "Update picture-in-picture settings to match mocks." 2017-03-21 00:28:58 +00:00