Commit Graph

577 Commits

Author SHA1 Message Date
shaoweishen
90e70b15d7 [Physical Keyboard] Clean up old ui and flag
Change-Id: I9423d0e9debcef37338e5733aab56b98920621e3

Test: n/a
Bug: 330517633
Change-Id: I485848f67e0eb3ab207413a6ed8f7de809f80c5c
2024-04-16 05:21:30 +00:00
Jason Chiu
a18f9e5014 [Safer intents] Input method
To avoid implicit intents, make intents launch explicitly.

Test: build
Bug: 323061508
Change-Id: I8d9e8e2b70c3ef913087b72800cd40e0c3df8164
2024-03-28 02:44:09 +00:00
Treehugger Robot
b9895a2438 Merge "Touchpad: add metric for tap dragging setting changes" into main 2024-03-11 16:00:28 +00:00
Harry Cutts
f8ffe79669 Touchpad: add metric for tap dragging setting changes
Bug: 321978150
Bug: 324058706
Test: $ m statsd_testdrive
      $ ./out/host/linux-x86/bin/statsd_testdrive -e 97
      Then toggle the setting, press Enter in the terminal, and check
      the new actions are logged
Change-Id: I55b7cc3377e7b27e9570f3f1b79c1f300d5d5686
2024-03-05 16:59:33 +00:00
Harry Cutts
175a901f2c Merge "Touchpad: add Framework Input team as owners" into main am: a3a04112fd am: 3c1a5bb3c0
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2982053

Change-Id: Ifae971d2fd89374e8e0c1d3a147c6390a85dee46
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-05 12:45:49 +00:00
Harry Cutts
3c1a5bb3c0 Merge "Touchpad: add Framework Input team as owners" into main am: a3a04112fd
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2982053

Change-Id: Idf76ff1bf592de800d224052910927285c47c42e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-05 12:05:02 +00:00
Harry Cutts
01bd498503 Merge changes I0c0a76c7,Iccfbe842 into main
* changes:
  Touchpad: remove icons
  Touchpad: add tap dragging setting
2024-03-05 11:39:22 +00:00
Vaibhav Devmurari
d3dbe6ce23 Merge "Modify PK Settings page to make it more user friendly" into main 2024-03-05 10:53:48 +00:00
Vaibhav Devmurari
8754f114ac Modify PK Settings page to make it more user friendly
PK Settings page:
    - Show current PK layout selected for the current user profile and current IME language instead of a list of IMEs

PK layout mapping page:
    - Show IME name in header only if multiple active IMEs
    - Show the PK layout selection criteria (Automatic v/s User selected)

Bug: 325925410
Bug: 326195401
Test: manual
Change-Id: I93a2e169742a800fa116fa5d55e1a91e5548cebb
2024-03-04 10:55:47 +00:00
Shaowei Shen
624e1beca8 Merge "[A11y Setting] Add keyboard keys preferences under A11y page" into main 2024-03-01 13:37:03 +00:00
shaoweishen
a5f5ff4add [A11y Setting] Add keyboard keys preferences under A11y page
Bug: 325851068
Test: make RunSettingsRoboTests
Change-Id: Ic7eb1ec9e260a95d040bee784cbff479a4f087d0
2024-03-01 12:05:30 +00:00
shaoweishen
6c02c6ab25 [Physical Keyboard Setting] Update layout for one pane land screen
If device is one pane and is land orientation, set new layout for it to
match with UX markup, this change will not effect on tablet, which is
two pane setting.

Bug: 325878673
Test: verify on device
Screenshot: https://screenshot.googleplex.com/BkETMhqp9GXM3cc.png
Change-Id: I066c3d782a2de8993a3fe9632676b67c2203d638
2024-02-29 07:31:21 +00:00
Harry Cutts
cf1a34ab93 Touchpad: add tap dragging setting
Screenshot: go/ag-26012379-screenshot

Bug: 321978150
Bug: 324058706
Test: with the flag disabled, check the new entry doesn't appear
Test: with the flag enabled, toggle the setting and check that it
    enables and disables tap dragging (tapping then immediately putting
    your finger back on the touchpad and moving it)
Test: with the flag enabled, check the setting appears in search results
Test: atest SettingsRoboTests:com.android.settings.inputmethod
Change-Id: Iccfbe842ff655ea295edc764cfc400709948df7d
2024-02-28 14:40:35 +00:00
Harry Cutts
3715b07684 Touchpad: add Framework Input team as owners
Also replace references to
frameworks/base:/services/core/java/com/android/server/input/OWNERS with
ones directly to frameworks/base:/INPUT_OWNERS.

Bug: 324058706
Test: none
Change-Id: Ib8943ca749887da7d5eebae908516e86310f2077
2024-02-28 14:37:10 +00:00
Ben Murdoch
59a3ed3f38 Add settings search synonyms for touchpad.
Also fixes a bug in TrackpadTouchGestureSettings that used the wrong
preference ID for search indexing.

Bug: 300611520
Test: Verified on device
Flag: NA
Change-Id: I62ccf6d0b410be977f59f101edc5c42233d9474a
2024-02-21 11:38:45 +00:00
Vaibhav Devmurari
bd26b3a43e Add Slow keys A11Y settings to PK settings page
Test: manual
Bug: 294546335
Change-Id: I9e20973e648d04b907e4d2225bd49b78e42d2089
2024-01-22 21:52:48 +00:00
shaoweishen
ff74d9db0b [Physical Keyboard Setting] Add log and null check
update getParcelable api usage, add null check and logging.

Bug: 317416208
Test: Verified on device
Change-Id: I125a6c9cdb5c86be7582ad5102257efb1fa6a1a4
2024-01-11 03:48:07 +00:00
Sunny Shao
bee65b4109 Merge "Revert^2 "Nullability Annotations replacement"" into main 2024-01-10 08:35:06 +00:00
Sunny Shao
076ed573eb Revert^2 "Nullability Annotations replacement"
This reverts commit 19d1d3d15d.

Reason for revert: revert it because this is not the root cause.

bug: 316867690
Change-Id: I0f168dbb64044aa720202af7b1040afd4f028c9c
2024-01-10 07:34:01 +00:00
Vaibhav Devmurari
da30b549be Merge "Add A11Y settings for Bounce keys and Sticky keys" into main 2024-01-02 13:05:59 +00:00
Sunny Shao
19d1d3d15d Revert "Nullability Annotations replacement"
This reverts commit cf0501e4d7.

Reason for revert: b/317462033, it seems a flaky but revert it first.

Change-Id: Ie1d5e279cca6477fc17d8c27c1ecda8d7a6b2553
2023-12-29 02:28:24 +00:00
Vaibhav Devmurari
315f2546fc Add A11Y settings for Bounce keys and Sticky keys
Test: manual
Bug: 294546335
Change-Id: I943300c31d0c8e142f64f084f4c65e05249a72ec
2023-12-28 21:02:11 +00:00
sunnyshao
cf0501e4d7 Nullability Annotations replacement
-- Replace the android.annotation.Nullable / android.annotation.NonNull
   with androidx.annotation.Nullable / androidx.annotation.NonNull

Bug: 316867690
Test: build pass
Change-Id: I0c1da55dfb09ece855151c47e0492d6f46538621
2023-12-20 08:50:09 +08:00
shaoweishen
5446813ac5 [PK Setting] Refine layout for Keyboard review
1. add background for keyboard review
2. add text for showing selected keyboard's name

Test: Verified on device
Bug: 305588594
Change-Id: Icf0f2b7798cc5cbddefc1b3a95480b48271b276f
2023-12-19 09:41:17 +00:00
shaoweishen
c08aad0ab4 [PK Setting] add keyboard review under keyboard selection page
Demo video as attached in bug.
Add new image view for keyboard layout review.
Reuse NewKeyboardLayoutPickerController under
NewKeyboardLayoutPickerFragment when get update for keyboard layout, get
preview image from inputManager and set to the view.

This feature will be guided with keyboard_layout_preview_flag, if the
flag is off, preview image from InputManager will be null.

Bug: 305588594
Test: Verified on device
Change-Id: Ic6f8e469d3cf7114dab6935304706ad42bf83608
2023-12-14 06:44:07 +00:00
Josep del Río
1dde9a3aeb Merge "Sort keyboard layouts" into main 2023-12-05 12:53:20 +00:00
Josep del Rio
cdc4fb5559 Sort keyboard layouts
At the moment it's not easy to find a layout in the physical
keyboard layout list as they are not sorted; this CL will sort the
keyboard layout list before it is  presented to the user.

Bug: 279281653
Test: Flashed on device, confirmed the layout list is sorted
Change-Id: Ibc7e329190785cce9a8d9c33bc2fcaca6b8c169a
2023-12-05 11:16:04 +00:00
Shaowei Shen
9f03501179 Merge "[PK Setting] update searchable if page is not visible" into main 2023-11-30 07:17:47 +00:00
shaoweishen
365f55efc5 [PK Setting] update searchable if page is not visible
if PK setting is not available, also make it not searchable.

Test: verified on device
Bug: 301881819
Change-Id: I6e71634ce5ddc6d5db3d31f5614fef7ccabc6d3d
2023-11-29 09:02:08 +00:00
Edgar Wang
40cc58f5a1 Merge "Update SpellCheckerPreference layout to support divider" into main 2023-11-23 07:50:41 +00:00
Edgar Wang
523d39266c Update SpellCheckerPreference layout to support divider
Bug: 246499664
Test: robotest and visual
Change-Id: I96908f4b566820b20a57e0161d74dfed2c566ea5
2023-11-22 14:59:17 +08:00
shaoweishen
543a7589b1 [PK Setting] Add null check on NewKeyboardSettingUtils.getInputDevice()
return null if InputDeviceIdentifier is null in getInputDevice.

Test: n/a
Bug: 307109888
Change-Id: Ie2f951d97e0ff66833d74170e625fb0368d6de42
2023-11-22 05:02:49 +00:00
Treehugger Robot
ccf02dcb11 Merge "Fix crash when clicking Spell Checker" into main am: e4f376f7ef am: 8a2a127435 am: 1e4c05ef7c
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2828056

Change-Id: I4b6a924d4672cf4b101606a499c5f4f5143159d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-21 04:54:24 +00:00
Treehugger Robot
8a2a127435 Merge "Fix crash when clicking Spell Checker" into main am: e4f376f7ef
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2828056

Change-Id: Idb4ebe7592c2bdf2685fb20c95b57c20565c0dcd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-21 03:49:50 +00:00
Pingzhi Wang
42a7e4784a Fix crash when clicking Spell Checker
Some variants do not have the default Spell Checker (GBoard)
pre-installed (typically Mainland China variants). Disable the
Spell Checker settings for such variants, to avoid crashes.

Bug: 310751714
Test: Manual
Change-Id: I1fb5a9959cffd26f3921e32226605a38636871b6
2023-11-14 11:34:17 +01:00
Chaohui Wang
32d9280e97 Merge "Revert^2 "Migrate to CompoundButton.OnCheckedChangeListener"" into main 2023-11-08 09:05:22 +00:00
Sunny Shao
b0942b61ed Fix ListPreference title cutted off problem
- Remove the code of the setSingleLineTitle.
- Remove the additional code in the SpellCheckerPreference.

Fixes: 306795084
Test: manual test
Change-Id: Ib279496b9456cab9df9c542b8fee455d28ef01d9
2023-11-08 15:54:11 +08:00
Chaohui Wang
08a1c9876e Revert^2 "Migrate to CompoundButton.OnCheckedChangeListener"
8979681a8d

Change-Id: I60edd3aabf49afbe4aa016af780baa68d928bddf
2023-11-07 14:17:15 +00:00
Sebastian Pickl
8979681a8d Revert "Migrate to CompoundButton.OnCheckedChangeListener"
Revert submission 25147565-onSwitchChanged-CompoundButton

Reason for revert: breaking builds 

Bug:309601476

Reverted changes: /q/submissionid:25147565-onSwitchChanged-CompoundButton

Change-Id: Ie746db87d9c642599593aa3d5e5baf6b7ba89c0e
2023-11-07 13:26:36 +00:00
Chaohui Wang
71d1f021af Migrate to CompoundButton.OnCheckedChangeListener
Switch and SwitchCompat are both CompoundButton.

Using CompoundButton in Java will helps migration in the future.

Bug: 306658427
Test: manual - check Settings pages
Change-Id: If2e08a9a9557ec66a3b31ef18cd2e15943098a59
2023-11-07 20:22:27 +08:00
Daniel Huang
6b9d8c530f Revert "[PK settings] Remove metrics."
1. This reverts commit bdf89255a0.
2. Modify ACTION_USE_SPECIFIC_KEYBOARD to log vendor and product id.

Reason for revert: <Add metrics>
Test: atest

Change-Id: I187b990eec7dd0c0009f6c695f595d95420cb4ab
2023-11-02 17:10:21 +08:00
FanWu
187067647c Update SpellCheckerPreference to support multi-line title
Bug: 306060312

Test: Manual
Change-Id: I729e702b0a0adeb634caf03f4be816d5e097ecf4
2023-10-25 01:52:52 +00:00
Chaohui Wang
cfdb3b1f1b Migrate new() to SwitchPreferenceCompat
Bug: 306658427
Test: manual - on Settings pages
Change-Id: I258a8c63d5c46403c6d333a9d2f34c33cb35e27f
2023-10-24 14:05:34 +08:00
Chaohui Wang
15ca95a31b Migrate to TwoStatePreference
SwitchPreference and SwitchPreferenceCompat are both TwoStatePreference.

Using TwoStatePreference in Java will helps migration in the future.

Bug: 306771414
Test: manual - check Settings pages
Change-Id: I84e1d7b09451106797c2b23d127855c6976678ca
2023-10-23 09:28:57 +00:00
Manish Singh
6efc455f2c Show a separate tab for the Private Space
This covers all the known Settings pages using the tabbed view model.

https://docs.google.com/document/d/1CdjUjAE84-5ZEPRIfw5KYFjLVHtEZxc_sF0w95su8DA/edit?resourcekey=0-dAACT9HRexY1IyoxMmkVlw#heading=h.58jd58rmznte

Screenshots:
all apps
https://screenshot.googleplex.com/3E5Jm7Pi2JfN64r
with work tab:
https://screenshot.googleplex.com/8egk4yHK5jSENjR

PS Apps Special media management apps
https://screenshot.googleplex.com/BHHafqW7bgUwSGg
with work tab:
https://screenshot.googleplex.com/3cocdhruEmCCh5k

PS Location Services tab view
https://screenshot.googleplex.com/3DqJcT2BFTEpvYT
with work tab:
https://screenshot.googleplex.com/6Avpx6hxSrdGJw5

PS on screen keyboard tab view
https://screenshot.googleplex.com/4FzVNnBWwbUeJNw
with work tab:
https://screenshot.googleplex.com/8E8UhpWq8PL5nxU

PS password account tab view
https://screenshot.googleplex.com/6bDR4AKtth2S3EW
with work tab:
https://screenshot.googleplex.com/9msXV2TdHdJapch

PS storage tab view
https://screenshot.googleplex.com/5Nk2FTxwdmpEv3B
with work tab:
https://screenshot.googleplex.com/79tw2EaWZKfMsnC

PS appl_languages_work
https://screenshot.googleplex.com/3qrREeg3RQdHhhH

Bug: 302278487
Test: manual
Change-Id: I8cd39170827fbe251bc4075ef306206020b3a022
2023-10-11 12:32:17 +01:00
Treehugger Robot
c234e5a6a8 Merge "[PK settings] Remove metrics." into udc-qpr-dev am: ff791fa973
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/24526049

Change-Id: I6866aa3d71a9f891863fe0ccd273633a06daae19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-24 22:05:25 +00:00
danielwbhuang
90af0f0f26 [PK settings] Remove metrics.
Remove all metrics by the metrics concil team's comment.

Bug: 296544040
Test: manual
Change-Id: I6f5292c686d3eaac641c6e7f7631152b34a0085b
Merged-In: I6f5292c686d3eaac641c6e7f7631152b34a0085b
2023-08-23 23:08:02 +08:00
danielwbhuang
bdf89255a0 [PK settings] Remove metrics.
Remove all metrics by the metrics concil team's comment.

Bug: 296544040
Test: manual
Change-Id: I6f5292c686d3eaac641c6e7f7631152b34a0085b
2023-08-23 21:56:25 +08:00
Felix Stern
76707864e5 Merge "Adjusted Settings to use updated internal InputMethodManager methods" into main 2023-08-09 12:36:41 +00:00
Chaohui Wang
8e2ae547d6 Clean up FeatureFactory.getFeature()
Bug: 286764889
Test: m Settings
Change-Id: I7e472e6b0ca6b7a735c1b92742ddf06c545176fc
2023-08-08 08:41:48 +00:00