Commit Graph

38715 Commits

Author SHA1 Message Date
Bonian Chen
0726f263a8 [Settings] Rollback group UUID merging in SIM settings
Within origin design, subscriptions with same group UUID
are not merged together.

This is a fix which changing grouping by UUID part into a configurable
option which allows to be enabled in some other conditions.

Bug: 191228344
Test: local
Change-Id: I0101f4a51ec2342f059762f0e7d38bb4e93554cf
2021-07-12 14:59:28 +08:00
Bonian Chen
a229b29737 Merge "[Settings] Settings within each SIM not been displayed to the user" 2021-07-07 09:03:45 +00:00
Rubin Xu
0efe3ae03d Merge "Delay gargabe collection during onDestroy()" into sc-dev am: 3e84dd2783 am: 841a92e9dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15178137

Change-Id: I5ce115f3a382c7d53cbf8168e1c39ad3eb978618
2021-07-07 07:58:07 +00:00
Rubin Xu
3e84dd2783 Merge "Delay gargabe collection during onDestroy()" into sc-dev 2021-07-07 07:29:06 +00:00
Linus Tufvesson
c96f60e0cb Merge "Make WifiDppEnrolleeActivity launches explicit" 2021-07-07 07:18:59 +00:00
Bonian Chen
8e3ff612d2 Merge "[Settings] Hide subscriptions not existed within device" 2021-07-07 07:03:10 +00:00
Bonian Chen
75f1450bbf [Settings] Hide subscriptions not existed within device
For non-active subscriptions, the one inserted in slot
but turned off need to be visible to the user. However,
the one un-plugged need to be invisble.

Since SubscriptionUtil#getSelectableSubscriptionInfoList() didn't cover all the cases required. Create this one to fit into the criteria required here.

Bug: 191228344
Test: local
Change-Id: Ia68c23b007164b7520456cb6c7427ca142558b59
2021-07-07 07:02:55 +00:00
Zoey Chen
529c8e3f71 Merge "[Povider Model] Fix string in SIMs" 2021-07-07 02:27:47 +00:00
Bonian Chen
a415ecb608 Merge "[Settings] fix for Wifi calling settings page crash" into sc-dev 2021-07-06 15:46:37 +00:00
Zoey Chen
84073b9851 [Povider Model] Fix string in SIMs
Bug: 192058192
Test: make
Change-Id: I4314802840a4952acf7f090d81ca19ec28b793b2
2021-07-06 21:25:23 +08:00
Bonian Chen
e530d93382 [Settings] fix for Wifi calling settings page crash
UI crash reported due to accessing telephony framework API with invalid
subscription ID from SIM. Which comes with multiple reason.

Besides of avoidance of crash, following updates are also required:
1. Close wifi calling settings UI when pSIM or eSIM not available or
inserted.
2. Keep the selection of tab (under multi-SIM) when screen rotate
3. Only show 1 SIM when multi-SIM are grouped together

Bug: 149190278
Test: local
Change-Id: Ied9a088b6ee5da66972f27649cc07f4a31304f17
(cherry picked from commit fbe1293a54)
(cherry picked from commit 05f29efe34)
2021-07-06 12:38:45 +00:00
Linus Tufvesson
59c0a7bc63 Make WifiDppEnrolleeActivity launches explicit
Bug: 180518134
Test: make RunSettingsRoboTests \
ROBOTEST_FILTER=WifiDppUtilsTest\|WifiDialogActivityTest
Test: Manually verified b/180518134 attack is no longer possible

Change-Id: I8c4e1e17117582c78671d0e4658bd87715a9a046
2021-07-06 12:09:10 +00:00
Menghan Li
9e3f26eb29 Merge "Fix toggle display and preferen style old style and barely seen in “Vision Settings”" into sc-dev am: 5f0fe5e6c1 am: 1609504fa3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15207793

Change-Id: Id50be66c826b6fa8d4e910b07ecc1ef8d36dc305
2021-07-06 10:36:33 +00:00
Menghan Li
5f0fe5e6c1 Merge "Fix toggle display and preferen style old style and barely seen in “Vision Settings”" into sc-dev 2021-07-06 10:07:52 +00:00
Treehugger Robot
5dfa9cde19 Merge "Add a developer option to increase nfc stack log level" am: 9d7b0beb87 am: 4909b81006 am: b6e44d16ac am: 957ece6934
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1733952

Change-Id: I159684580a0f018e7d41dc2982c7d7001e88cf55
2021-07-06 09:15:20 +00:00
Treehugger Robot
b6e44d16ac Merge "Add a developer option to increase nfc stack log level" am: 9d7b0beb87 am: 4909b81006
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1733952

Change-Id: I257c6806afcef6211eedc8cf60829f90930a0d32
2021-07-06 08:52:25 +00:00
Treehugger Robot
9d7b0beb87 Merge "Add a developer option to increase nfc stack log level" 2021-07-06 08:05:47 +00:00
menghanli
e18c419f94 Fix toggle display and preferen style old style and barely seen in “Vision Settings”
Root cause: Apply ThemeHelper.trySetDynamicColor would overlay the
settings style.
Solution: Create SudDynamicColorThemeSettings.SetupWizard to support
dynamicColor and settings style.

Bug: 192410829
Test: manual test
Change-Id: Ic196dfe417e7f804c68ed4ea7bc05b4716999bcf
2021-07-06 15:32:34 +08:00
Jason Hsu
1cbac4bc53 Merge "Fix accessibility button footer preference did not announced correct by TalkBack" into sc-dev am: bf6af8ac92 am: 336cfe271f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15204641

Change-Id: I6a7e5b327e3931bef3af2a51cceb1003ef7758fb
2021-07-06 07:27:28 +00:00
Jason Hsu
bd9ed49b1d Merge "Fix accessibility button footer preference did not announced correct by TalkBack" into sc-dev am: bf6af8ac92
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15204641

Change-Id: I1320acb0410f5314f2c9b3aee71706d16927acc7
2021-07-06 07:17:18 +00:00
Jason Hsu
bf6af8ac92 Merge "Fix accessibility button footer preference did not announced correct by TalkBack" into sc-dev 2021-07-06 06:57:30 +00:00
jasonwshsu
3cb889fc78 Fix accessibility button footer preference did not announced correct by TalkBack
Root Cause: Description would be altered after displayPreference(), but getSummary() would be called after it.

Solution: Update title before displayPreference(), then it could be set correctly.

Fix: 192738520
Test: atest AccessibilityButtonFooterPreferenceControllerTest
Change-Id: I068994fca8202b166fedf43f9d9657b0c1a64c4e
2021-07-06 06:57:22 +00:00
Bonian Chen
cdc38ae878 Merge "[Settings] Avoid from Exception breaks the rule" 2021-07-06 06:54:16 +00:00
Arc Wang
04d2605dbb Merge "Remove no-used EntityHeaderController in Storage Settings" 2021-07-06 03:58:45 +00:00
Arc Wang
a0e7ce6cde Merge "Remove redundant spaces in ActivityPicker" 2021-07-06 03:58:02 +00:00
Weng Su
c830e466f2 Add SafetyNet logging am: 199528d460 am: 7066e8a96c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15206403

Change-Id: Icf374bbec95cc23d0be593c1e183f5d46c142c69
2021-07-05 10:15:29 +00:00
Weng Su
b1450e0d75 Add SafetyNet logging am: 199528d460
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15206403

Change-Id: Ifd347b8712042479a22c3c21663c4e3f7a23298a
2021-07-05 10:02:55 +00:00
Bonian Chen
05f29efe34 [Settings] Avoid from Exception breaks the rule
When querying subscription(s) which not supported by telephony framework
could lead to exception. Which will lead to incorrect control in code
flow when filtering subscriptions which support WiFiCalling out of all
subscriptions available.

Bug: 149190278
Test: local
Change-Id: I3b8bcea6c724cad83559159ed9435f0710594b83
2021-07-05 16:29:33 +08:00
Weng Su
199528d460 Add SafetyNet logging
- Add SafetyNet log if the calling package is no the permission for
result

Test: checked eventlog in the bugreport
Bug: 185126813
Change-Id: I1535f6f2ded2445702df0d723518b773cd094164
2021-07-05 16:02:40 +08:00
Bonian Chen
76bf6ff525 [Settings] Settings within each SIM not been displayed to the user
The display of content is in majority depending on the callback result
of SIM card (in order to display the content).

However, to reduce the number of access of SubscriptionManager and
improve performance, a proxy has been design in between to reduce the
traffic and the latency required.

Within this situation, content didn't get displayed when Activity get
restarted since Proxy avoid to reduce the traffic through reducing the
callback to the Activity and even not generating request for update when
Activity resume.

Bug: 188982508
Test: local & unit test
Change-Id: Ia3b946a853f87a469ce07a398f3811f605d38f1d
2021-07-05 15:12:39 +08:00
TreeHugger Robot
5432cf9eba Merge "Add permission checking to WifiDialogActivity" into sc-dev am: 27c928856e am: 48ddec81c9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15187819

Change-Id: I45a70c5bf9ad7fb24f4f51fb6dc4abde1db1c156
2021-07-05 03:21:35 +00:00
Arc Wang
9e7d132ab8 Remove redundant spaces in ActivityPicker
Bug: 182438726
Test: compile
Change-Id: I8f0440530fcd95cc352dbef7e2bbcc7cdce495b9
2021-07-05 11:09:30 +08:00
TreeHugger Robot
22e62eaac1 Merge "Add permission checking to WifiDialogActivity" into sc-dev am: 27c928856e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15187819

Change-Id: Ief440310d2599718d9fc99cbee45e9be1012f5d2
2021-07-05 03:06:32 +00:00
Arc Wang
c6d5dcfc6c Remove no-used EntityHeaderController in Storage Settings
The EntityHeaderController is a workaround to fix header
shadow, however, the header shadow does not exist and it's
safe to remove the EntityHeaderController.

Bug: 183078080
Test: manual visual
Change-Id: I5197ec62edbe7ab3ff981895ec7ff267caeb9448
2021-07-05 10:55:02 +08:00
TreeHugger Robot
27c928856e Merge "Add permission checking to WifiDialogActivity" into sc-dev 2021-07-05 02:54:05 +00:00
Rajeev Kumar
b1a82dde1d Merge "Show device admin warning dialog if force stop is not allowed" into sc-dev am: dc07fe1ad1 am: 43b16c4704
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15179293

Change-Id: Iab510479a2b4b7ecab8406e142a7c9853aab4400
2021-07-04 20:53:31 +00:00
Rajeev Kumar
cb6334ba99 Merge "Show device admin warning dialog if force stop is not allowed" into sc-dev am: dc07fe1ad1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15179293

Change-Id: I644fac2d129a2b4226263f5a9f2ffe268c31bbb3
2021-07-04 20:08:02 +00:00
Rajeev Kumar
dc07fe1ad1 Merge "Show device admin warning dialog if force stop is not allowed" into sc-dev 2021-07-04 19:14:33 +00:00
Ahaan Ugale
729dc283cb Merge "Password settings: use EM DASH as the pwd count placeholder" into sc-dev am: 83e4f3c658 am: 5025ca7695
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15177778

Change-Id: I7031bd97057b77a6005e66806f85aa0767766632
2021-07-03 00:18:03 +00:00
TreeHugger Robot
974abdc1aa Merge "Fix landscape to reverse landscape issue" into sc-dev am: 493db88bf4 am: e81e53e127
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15188505

Change-Id: Ie97b3811f03ab867dd38691c388663596d71daf6
2021-07-03 00:17:54 +00:00
Ahaan Ugale
0cc68e8510 Merge "Password settings: use EM DASH as the pwd count placeholder" into sc-dev am: 83e4f3c658
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15177778

Change-Id: I64edc40f8c59526707832dc7afb4e26cdb82d023
2021-07-03 00:07:27 +00:00
TreeHugger Robot
5adc2d8447 Merge "Fix landscape to reverse landscape issue" into sc-dev am: 493db88bf4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15188505

Change-Id: Iab537b422edbe98b94f90cb20a95d1ef8e09a61a
2021-07-03 00:07:16 +00:00
Ahaan Ugale
83e4f3c658 Merge "Password settings: use EM DASH as the pwd count placeholder" into sc-dev 2021-07-02 23:56:20 +00:00
TreeHugger Robot
493db88bf4 Merge "Fix landscape to reverse landscape issue" into sc-dev 2021-07-02 23:49:36 +00:00
TreeHugger Robot
524f4979f5 Merge "Ensure settings maintains its Bluetooth device inquiry state" into sc-dev 2021-07-02 23:02:30 +00:00
Rahul Sabnis
1e2b873a0e Merge "Ensure settings maintains its Bluetooth device inquiry state" am: bec574dca7 am: 3b68dd138c am: aa8275f8d3 am: 970df1c47d
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1716270

Change-Id: Ica2bae3a3f0c1a4133ede8f849faab03d5aade87
2021-07-02 22:45:26 +00:00
Mill Chen
7f2496219f Fix landscape to reverse landscape issue
Fingerprint enrollment page needs to display different types of layout
for both landscape mode and reverse landscape mode. However
onConfigurationChanged doesn't get called when landscape mode rotates to
reverse landscape mode directly, that causes it displays a wrong layout
in the both landscape and reverse landscape modes.

Trying to monitor rotation event and checking if the case that directly
turns landscape mode to reverse landscape mode happens, if so, reCreate
method will get called to re-lay out the page. There will be a flicker
problem happening in re-laying out the page but this solution still
works for users to have the correct layout.

Fix: 186372522
Test: manual test
1) Navigate to fingerprint enrollment page
2) Rotate the screen from landscape mode to reverse landscape mode
3) Observe the page and see if it has a correct layout

Change-Id: Ie94f43a6546f453c10ae9f1c3ba83e1178784950
2021-07-03 06:40:25 +08:00
Rahul Sabnis
aa8275f8d3 Merge "Ensure settings maintains its Bluetooth device inquiry state" am: bec574dca7 am: 3b68dd138c
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/1716270

Change-Id: I9c37ec40573808a91c6052e2d46cce28df7cfead
2021-07-02 22:31:25 +00:00
Rahul Sabnis
bec574dca7 Merge "Ensure settings maintains its Bluetooth device inquiry state" 2021-07-02 22:01:50 +00:00
TreeHugger Robot
9a85645574 Merge "Only launchHandoffToParent in SUW" into sc-dev am: 59b82fad2f am: 47cd5370f3 am: c1d6451625
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/15179572

Change-Id: I88462071799ef6b38627aac5c30c1792b2ccfc5f
2021-07-02 20:36:47 +00:00