Commit Graph

656 Commits

Author SHA1 Message Date
TreeHugger Robot
6217af3fe1 Merge "Improved UX when no debuggable apps are available." into rvc-dev 2020-06-19 12:32:52 +00:00
Amy Hsu
f9a021511e Merge "Add Smooth Display option to developer in Settings" into rvc-dev 2020-06-15 08:39:26 +00:00
Joshua Duong
63facb88bd Merge "[adbwifi] Handle tls port changes." into rvc-dev 2020-06-11 17:23:00 +00:00
Joshua Duong
76d2afb832 [adbwifi] Handle tls port changes.
Events such as adbd restarts can change the connection port. We need
to update the UI accordingly.

Bug: 158219145

Test: Manual.
1) Enable wireless debugging in Settings and validate port in UI via
> adb shell su 0 netstat -plnt | grep LISTEN
2) Restart adbd: > adb root
3) validate port again (may have changed)

Change-Id: I93339a6a258fbf69fa3f45186863a01126d279ce
2020-06-10 16:56:29 -07:00
Varun Shah
8d5cb9a2d0 Add app icons to leasee view in shared data dev options.
Also disable clicking the header view and list items in the same view.

Bug: 156671006
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SharedDataPreferenceControllerTest
Test: manual (visual)
Change-Id: I2821bc6cdc523097283ab44b864088278850be53
2020-06-09 19:04:36 -07:00
Varun Shah
c920a58d5f Add blob size to shared data dev options screens.
Bug: 156671006
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SharedDataPreferenceControllerTest
Test: manual (visual)
Change-Id: Ia98c3d9812f6225ee834b4d1b0f12a1a73a87598
2020-06-05 22:19:26 -07:00
Amy Hsu
b35b78b3b6 Add Smooth Display option to developer in Settings
Force to the highest refresh rate.

Bug: 137064289
Test:$ adb root
$ adb shell "echo 1 > /d/tracing/events/sde/enable"
$ adb shell "echo 1 > /d/tracing/tracing_on"
$ adb shell "cat /d/tracing/trace_pipe" | grep FPS

Change-Id: Ia1f804cbc7e297a85591e6b0f293ca1014301b74
2020-06-06 02:14:20 +08:00
Tim Peng
5a9e58372a “Bluetooth Audio Codec” is not getting listed while searching for it using “keywords” from settings search tab
-Implement PreferenceControllerMixin to decide nonIndexableKeys list according to isAvailable() status

Bug: 156337281
Test: make -j50 RunSettingsRoboTests
Change-Id: I8787acfd50ac351499781d016a3c806a1a6b4f9f
2020-06-04 14:25:31 +08:00
Tsung-Mao Fang
f6841ef548 Add a setting for allowing overlays on Settings app
In the past, we allowed non system overlays on user-debug rom.
Acoording to the user-debug guildline, we should not have differnt
behavior between the user build and user debug rom.

To maintain the consistency between user and user debug rom,
We're creating a new developer setting for allowing non-system overlay on
Settings. By default, we don't allow any non-system app overlays on
Settings app unless user turns it on explictly.

Test: Run robotest. Turn on setting, see the overlays on Settings.
Turn off setting, do not see the overlays on Settings.
Fix: 144989059

Change-Id: I87f00a2eda91de003c6e542e7ec45a066f46fbf7
2020-06-02 12:32:43 +08:00
Mathew Inwood
43f9adea62 Improved UX when no debuggable apps are available.
In AppPicker, add an extra to exclude the "Nothing" sentinel. This is
used when selecting a debug app, and makes sense in that context.
However it does not makes sense when choosing an app to modify
compatibilty options for, so exclude it.

Also update the AppPicker to return a new result code in the case that
there are no apps available which match the criteria given. This result
code can only be used when the new extra is defined which keep this
change low risk.

In PlatformCompatDashboard, use the new extra and handle the new result
code, showing a dialog to explain that only debuggable apps are shown in
user builds. This also results in the "Nothing" item being shown at the
top of the app list.

Bug: 157633308
Test: Manual
Change-Id: Ifb055dd7c030cda42556bca8a9d7e87606f0ff72
2020-06-01 14:46:46 +01:00
Edgar Wang
3c03f0a8a8 Change AppPicker theme from dialog to full screen
AppPicker used in devceloper options, it will show apps list with
package name in a dialog.
But sometimes it will mis-alignment with package name.
So we change theme from dialog to full screen and set widget_frame
visibility to GONE.

Bug: 151150544
Test: manual
Change-Id: I8f04ab7967288801e5e13ecccf037d6ed09ec71c
2020-05-26 10:49:50 +08:00
TreeHugger Robot
cd3cde6169 Merge "Revert "Create QS media player setting"" into rvc-dev 2020-05-13 02:20:05 +00:00
Lucas Dupin
d207f1baee Revert "Create QS media player setting"
This reverts commit 665c36eae2.

Reason for revert: New media experience landed
Fixes: 156369996

Change-Id: Icb997a3508cec1e15f523b8ca5b923deacee66b4
2020-05-12 16:51:06 +00:00
Marco Ballesio
97483a978a Merge "Developer option for the app freezer" into rvc-dev 2020-05-06 16:35:45 +00:00
TreeHugger Robot
18490b2dc8 Merge "Enable some settings pages to use paralleled-loading method" into rvc-dev 2020-05-05 09:23:13 +00:00
Marco Ballesio
cb96685c8f Developer option for the app freezer
The app freezer allows the system to suspend execution for cached apps.
Without it an app can receive CPU time even if cached, so this option
will allow developers to test their code when frozen while their apps
are cached.

The new developer option will present a list of alternatives for the
freezer operating mode:

"device default": use device/system settings to determine whether the
                  freezer is to be enabled or not. This is the current
                  behavior, and default value for the option.
"enabled": force freezer on
"disabled": force freezer off

A dialog prompting the user to reboot is presented upon freezer mode
change. The device is automatically rebooted if the user decides to
proceed.

Bug: 155465196
Change-Id: I857b77cc4fc1ad766e8d5825ada9b271d3e1ab3a
Test: manually verifued the option works as intendend when this patch is
applied with its companion CLs

Change-Id: I26450b7b7ea2b345fd3661d4869fbc74ae38c0c9
2020-05-04 11:29:10 -07:00
Lucas Dupin
7dc7252c15 Merge "Create QS media player setting" into rvc-dev 2020-05-04 03:59:28 +00:00
Sunny Shao
6d60248053 Enable some settings pages to use paralleled-loading method
- Here these pages include AppInfoDashboardFragment, ConnectedDeviceDashboardFragment,
  DevelopmentSettingsDashboardFragment, NetworkDashboardFragment, ConfigureNotificationSettings.
- The TimeSpentInAppPreferenceController use the LiveDataController.

Fixes: 135299529
Bug: 137558156
Test: compilation
Change-Id: I455a16536c9966184f1b2bd81d1f1217f3e09f9d
2020-05-04 10:34:23 +08:00
Lucas Dupin
665c36eae2 Create QS media player setting
Test: make RunSettingsRoboTests ROBOTEST_FILTER=QuickSettingsMediaPlayerPreferenceControllerTest
Test: manual
Fixes: 155315021
Change-Id: I2583b985710898d0480f599fc9b5a2451c8950a7
2020-04-30 12:04:23 -07:00
Blake Kragten
6fe60521d1 Merge "Remove enhanced connectivity switch for non-pixel" into rvc-dev 2020-04-30 03:24:52 +00:00
Blake Kragten
b0962e5dda Remove enhanced connectivity switch for non-pixel
Bug: 155027331
Test: using aosp build
Change-Id: Ifbb3a29515e60b592e91005459c27084ee3730c3
2020-04-28 16:30:52 -07:00
Julia Reynolds
6b2716fce0 Remove unused development setting
Test: atest
Fixes: 151821676
Change-Id: I59338340ac88873d20cd715c82723590af64acd3
2020-04-28 19:11:47 -04:00
Julia Reynolds
6585f79439 Merge "Bubble settings: feature, notification, app" into rvc-dev 2020-04-14 11:22:14 +00:00
Mady Mellor
409c3dfe68 Bubble settings: feature, notification, app
* Removed setting from developer options
* Removed bubble settings from normal notifications /
  channels

* Feature available via notification setting
* Feature screen with educational gif

* App level is now a tri-state choice of all / selected /
  none
* App level bubble controls are accessible top-level in
  app notifications

Test: make -j40 RunSettingsRoboTests ROBOTEST_FILTER="Bubble"
Bug: 138116133
Change-Id: Id103e9d3717fdc9b86a916be40c43cda9c35ac34
2020-04-13 10:15:38 -07:00
PO HUNG CHEN
bdcff696d5 Merge "Pathfind a way to Validate DSU before releasing GSI" into rvc-dev 2020-04-13 08:35:28 +00:00
Howard Chen
3562ec3196 Pathfind a way to Validate DSU before releasing GSI
Provide an alternative DSU portal for testing. It can be enabled or
disabled with the setprop command.

Test: Developer Settings -> DSULoader and check logcat
Bug: 152403883
Change-Id: Id1a7bb2a03d7243299f639e654a1c1a086b87545
2020-04-13 07:09:09 +00:00
Joshua Duong
0f3eba36f2 [adbwifi] Add qstile for wireless debugging.
Bug: 153275926

Test: make RunSettingsRoboTests ROBOTEST_FILTER=WirelessDebuggingTest
Change-Id: I6b381a7e29beec5c9c345b374e127caabdb674db
(cherry picked from commit 0c23d39f94)
Exempt-From-Owner-Approval: cherry-pick
2020-04-10 19:12:40 +00:00
Oscar Shu
a6eedbf350 Merge "Add dev option for enhanced mac randomization" into rvc-dev 2020-04-09 17:50:58 +00:00
TreeHugger Robot
e886ef9e9a Merge "Update display logic for no shared data." into rvc-dev 2020-04-08 15:11:37 +00:00
Joshua Duong
23040a3b2b Merge "[a11y] Fix TalkBack readback on adb qrcode fragment." into rvc-dev 2020-04-07 18:07:16 +00:00
Joshua Duong
5866463e16 [a11y] Fix TalkBack readback on adb qrcode fragment.
TalkBack was picking up the text in the action bar, so if we hide it,
it will read the first body of text it encounters which would be "Scan
QR code. Pair device over Wi-Fi by scanning a QR code."

Bug: 152461605

Test: Manual. Enable TalkBack in Settings > Accessibility > TalkBack.
Navigate to Developer options > Wireless debugging > Pair by QR code.
When QR code scanner fragment opens, it should say "Scan QR code. Pair
device over Wi-Fi by scanning a QR code."

Change-Id: Ia91bf4ea215e6a377335f2b9dcf2acf10afd268e
(cherry picked from commit bfd73c0d78)
Exempt-From-Owner-Approval: cherry-pick
2020-04-07 18:06:37 +00:00
Joshua Duong
2a85924977 [a11y] Set focus on "Pairing device" text once QR code is scanned.
Bug: 152462657

Test: Manual. Enable TalkBack in Settings > Accessibility. Navigate to
Developer options > Wireless debugging > Pairing device with QR code.
Scan a valid QR code, which should change to "Pairing device..." and
screen reader should say "Pairing device".

Change-Id: If467b56f787bda765fce1e5d46f8ab3c6210dc76
(cherry picked from commit 07ad841e2d)
Exempt-From-Owner-Approval: cherry-pick
2020-04-07 18:06:25 +00:00
Varun Shah
2aeedcde21 Update display logic for no shared data.
When there is no shared data, instead of showing an empty list view,
the developer option's summary is updated.

Additionally, for the two shared data screens, added the back button to
the action bar so that it matches the other screens in the Settings app.

Also, implemented PreferenceControllerMixin for the
SharedDataPreferenceController so that the dev option shows up in
settings search.

Bug: 153079829
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SharedDataPreferenceControllerTest
Test: manual (visual)
Change-Id: I6ec5c35fc262dc27a383af8e2593be5b349ee85f
2020-04-06 20:58:11 -07:00
Julia Reynolds
ae9060246b Add a developer setting for conversation enforcement
Test: Robo tests
Fixes: 152907434
Change-Id: I4e16faf817349993a98955601829d1ad22fa3921
2020-04-06 09:53:31 -04:00
Howard Chen
9266fe32f7 Add security patch level check in DSULoader
There's an enforced check enabled in locked devices. It requires
the installed DSU to have a security patch level equal or higher
than the device. This CL adds the SPL check in the DSULoader.

Bug: 151790609
Test: Developer Settings -> DSULoader
Change-Id: Ifef4175e846f58d8033cf161d7fec8481dc0532b
2020-04-05 06:21:09 +00:00
PO HUNG CHEN
9ba7fa975b Merge "Hide the DSULoader when DSU is running" into rvc-dev 2020-04-05 06:20:36 +00:00
Howard Chen
01871ab415 Hide the DSULoader when DSU is running
Bug: 151792130
Test: open developer settings and check the DSULoader
    make -j32 RunSettingsRoboTests
Change-Id: I8f82e0f7ddbfd2c50ac6e2a2d3f61f7715ba452c
2020-04-05 11:42:20 +08:00
Varun Shah
7efe9315ba Add a new developer options screen for shared data.
Add a new Storage section in the developer options menu which has a
new Shared Data preference. This preference screen shows all shared data
blobs on the device. There is also a new screen for each data blob which
shows all of the packages which currently have a leases on it. This
screen also has a button to delete the shared data blob.

Bug: 150626561
Test: make RunSettingsRoboTests ROBOTEST_FILTER=SharedDataPreferenceControllerTest
Test: manual (visual)
Change-Id: Id84a33dc7eeac493b2f81d3996ad24ee70557a07
2020-04-02 10:07:47 -07:00
xshu
d6506e8540 Add dev option for enhanced mac randomization
This toggle will affect client mode mac randomization only.
When toggled on, during association to networks that have MAC
randomization turned on, a more random MAC (as opposed to persistent
MAC per-network) would be used.

Bug: 151983183
Test: Manual
Change-Id: I4affade362644037e649ac6cf93e6871a81058bc
2020-03-30 18:01:51 -07:00
Joshua Duong
f5ff928958 Merge "Add visibility control to ADB QR code preference." into rvc-dev 2020-03-20 19:02:49 +00:00
Joshua Duong
56ad92c3b9 Add visibility control to ADB QR code preference.
The preference should be hidden if isAdbWifiQrSupported() is false.

Bug: 150163684
Bug: 149843499

Test: make RunSettingsRoboTests ROBOTEST_FILTER=AdbQrCodePreferenceControllerTest
Change-Id: I3e833440fb1a6f369ac97cec8db04f2b99dd4640
(cherry picked from commit 6178918653)
Exempt-From-Owner-Approval: cherry-pick
2020-03-20 15:09:53 +00:00
Joshua Duong
75ae058627 Add toast error message for no WiFi on wireless debugging.
Show a toast to connect to a WiFi network when the user tries to
enable wireless debugging while not connected to any Wi-Fi network.

Bug: 150139061
Bug: 149843499

Test: make RunSettingsRoboTests ROBOTEST_FILTER=WirelessDebuggingPreferenceControllerTest
Test: make RunSettingsRoboTests ROBOTEST_FILTER=WirelessDebuggingEnablerTest

Change-Id: I389f5fddc874f60e8156ecf6ef2f1c6eddc1d7a5
Exempt-From-Owner-Approval: LGTM
(cherry picked from commit 564f6ba770)
2020-03-20 15:08:30 +00:00
Michael Groover
0a189b3abe Merge "Add developer option to disable automatic adb grant revocation" into rvc-dev 2020-03-19 21:31:01 +00:00
atrost
74117346a6 Show only listUIChanges instead of all
Use the new method that filters out changes that shouldn't be in the
developer UI.

Exempt-From-Owner-Approval: Roll forward of unchanged reverted change previously approved.
Test: make RunSettingsRoboTests ROBOTEST_FILTER=PlatformCompatDashboardTest
Bug: 151299145
Change-Id: I5b461b33484a38d0c6a5b7bf7e928231dd662668
2020-03-19 09:30:15 +00:00
Michael Groover
3d8974723a Add developer option to disable automatic adb grant revocation
Android 10 introduced a security feature to automatically revoke
adb authorizations for systems that have not reconnected to the device
within 7 days. While this is helpful for consumers that enable adb for
a one time task and mistakenly select the 'always allow' option,
feedback has indicated having a developer option to disable this feature
would be beneficial.

Bug: 119510647
Test: make RunSettingsRoboTests ROBOTEST_FILTER=AdbAuthorizationTimeoutPreferenceControllerTest
Change-Id: I7eb123e8c69956aa02bb679784ac79650baf5dcb
2020-03-18 19:37:54 -07:00
Anthony Stange
95975931be Merge "Revert "Show only listUIChanges instead of all"" into rvc-dev 2020-03-18 21:52:29 +00:00
Anthony Stange
2012e6706a Revert "Show only listUIChanges instead of all"
Revert submission 10721220-hide

Reason for revert: Caused build breakage - b/151857606
Reverted Changes:
I7c725a1ec:Show only listUIChanges instead of all
Iec8755171:Introduce listUIChanges API for developer UI

Change-Id: I7753051b06faf1f48a818a134d1eda2500f817f8
2020-03-18 21:33:10 +00:00
Blake Kragten
75f0bdb400 Merge "Enhanced Connectivity Enabled Default" into rvc-dev 2020-03-18 21:25:11 +00:00
atrost
06da8b6ebc Show only listUIChanges instead of all
Use the new method that filters out changes that shouldn't be in the
developer UI.

Test: make RunSettingsRoboTests ROBOTEST_FILTER=PlatformCompatDashboardTest
Bug: 151299145
Change-Id: I7c725a1eca32e2d253b9671c789777b5422ed469
2020-03-17 20:37:49 +00:00
Blake Kragten
8881b110cd Enhanced Connectivity Enabled Default
Changed to enable enhanced connectivity by default

Test: On Device
Test: make RunSettingsRoboTests ROBOTEST_FILTER=EnhancedConnectivityPreferenceControllerTest
Test: On-device using developer option menu

Bug: 151633345
Change-Id: I8706f3a15af02214f4516503e685ff2b8f348a3a
2020-03-16 16:46:03 -07:00