Commit Graph

44671 Commits

Author SHA1 Message Date
jasonwshsu
b07754d178 Add pair button in bluetooth details page for hearing aid device
Root Cause: Users can not connect another ear again after they cancel
the pairing dialog in Accessibility -> hearing aids entry

Solution: Add pair button in bluetooth details page for hearing aid
device

Bug: 233038449
Test: make RunSettingsRoboTests
ROBOTEST_FILTER=BluetoothDetailsPairOtherControllerTest

Change-Id: I6a7af1c2c2263476b040233edb072cc64a2927b0
2022-08-09 18:06:27 +08:00
Zaiyue Xue
72b64f2515 New way to draw battery chart axis labels
Pairly draws axis labels from left and right side to middle. If the pair of labels have any overlap, skips that pair of labels.

https://drive.google.com/drive/folders/1tR4xfJsJGakuH5JRdn74kPD5GBH6u6CL?resourcekey=0-Ikp5CV0DpxllWv7n5-UHnw&usp=sharing

Test: manual
Bug: 236101166
Change-Id: Ib13d4c73b31ad86ac9e318d4315b5a1a0bb25814
2022-08-09 17:27:11 +08:00
Zaiyue Xue
5316bb71fe Fix b/241885070: Unexpected texts moving when going back to battery usage page
This bug is because two charts visibility were set to visible everytime
when entering the battery usage page. Only after loading the data and
refresh the UI, one of them could be hidden.

screen record after fix: https://drive.google.com/file/d/1zpynm8UX3XXunlD-WE1eyv6yenrVhAH5/view?usp=sharing&resourcekey=0-y79NYHcm8lgiNRbgy8SEfQ

Test: manual
Bug: 236101166
Bug: 241885070
Change-Id: I9c1dbf79a95dad2c3dece71af6d52f546d8a5808
2022-08-09 17:08:13 +08:00
Menghan Li
dec32f804c Merge "Fix IllegalStateException to get tile content after device rotate" 2022-08-09 09:01:52 +00:00
Zaiyue Xue
8d0030d874 Fix b/241872474 Battery usage page will crash when selecting the last hour chart bar, going to app detail page, and going back
This bug is because we always use mHourlyChartIndex to construct
every view model in mHoulyViewModels. However, mHourlyChartIndex could
be got from saved instance. So mHourlyChartIndex may be out of bound in
some hourly view model which has not many hours data.

This fix removes the selectedIndex in BatteryChartViewModel constructor. Suppose the selectedIndex should be set everytime the view model is used.

Test: manual
Bug: 236101166
Bug: 241872474
Change-Id: I0bb5568ac33fcc23c406fe3af308b8d2706c5542
2022-08-09 16:39:36 +08:00
Kuan Wang
8d88148036 Avoid NullPointerException when batteryLevelData is null.
Bug: 236101687
Bug: 241738105
Test: make RunSettingsRoboTests
Change-Id: Iee04f96083eff7ff5cd61a7c1f2eda20a6dc9149
2022-08-09 14:10:44 +08:00
Milton Wu
98239c0da6 Add FLAG_SECURE for ChooseLockPassword and Pattern
Prevent ChooseLockPassword and ChooseLockPatten being projected to
remote views, add FLAG_SECURE for these screens.

Bug: 179725730
Test: Check these 2 screens not projected to chromecast
Test: robo test for SetupChooseLockPatternTest ChooseLockPatternTest
      SetupChooseLockPasswordTest ChooseLockPasswordTest
Change-Id: I7449a24427c966c1aa4280a7b7e7e70b60997cca
2022-08-09 04:12:10 +00:00
TreeHugger Robot
68ed2fb752 Merge "[Settings] Data warning & limit UI should be configuable when running out of limit" 2022-08-09 03:47:33 +00:00
menghanli
1ca385591a Fix IllegalStateException to get tile content after device rotate
Root cause: Race condition to get content after the onDetach()
Solution: Add protection to prevent this IllegalStateException

Bug: 239578655
Test: make RunSettingsRoboTests ROBOTEST_FILTER=OneHandedSettings
Test: Manual testing by rotating 100 times quickly
Change-Id: I0a03cf1c01cd34c8ae0b0e70c4ffc41168b18ab8
2022-08-09 02:36:59 +00:00
TreeHugger Robot
248895db72 Merge "Use setting as base activity for fingerprint" 2022-08-09 00:05:45 +00:00
TreeHugger Robot
35f307b69d Merge "Fix slider bar is too close to bottom problem" 2022-08-08 14:51:00 +00:00
Sunny Shao
8b17025d71 Fix slider bar is too close to bottom problem
- Extend the bottom padding of the RecyclerView.

Fixes: 219849557
Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.accessibility
Change-Id: I197e837ad3d199b58d1c0ba46a08b0fa04277512
2022-08-08 20:25:44 +08:00
Zaiyue Xue
b9bf92f5ae Add margin between battery daily and hourly charts
screenshot: https://drive.google.com/file/d/1vXL4XO9HezZ4fTJ5wh6Fi13oXf54yc9q/view?usp=sharing&resourcekey=0--k4_Qk4e9ELyENeAySlYFw

Bug: 236101166
Test: manual
Change-Id: Ib4f5705661d2799cc74f6a957ce715ebb93b28b8
2022-08-08 17:44:39 +08:00
Chaohui Wang
0441f990f9 Merge "Remove the redundant constructor of SuggestionFeatureProviderImpl" 2022-08-08 06:47:18 +00:00
Milton Wu
84b39c3ed0 Use setting as base activity for fingerprint
Change to use FingerprintSetting as base activity when use launch
"Fingerprint Unlock" from Settings -> Security. And then we can prevent
that necesssary pop-up activites become full-screen.

Bug: 232874879

Test: manual test following cases on fp-only devices, and enable don't
      keep activity and test them again.
      1. fp enrollment on SUW
      2. fp add another on SUW
      3. add first fp on Security Settings
      4. add another fp on Security Settings
Test: atest FingerprintStatusUtilsTest BiometricsSafetySourceTest
Test: robo test for SetupFingerprintEnrollFindSensorTest
      SetupFingerprintEnrollFinishTest
      FingerprintEnrollFindSensorTest FingerprintEnrollEnrollingTest

Change-Id: Ib1c2ef9f93fb910eed2930f871c0c69bdb94bcbd
2022-08-08 03:59:03 +00:00
Kuan Wang
373390f660 Update usage data for EBS app usage list and App usage detail from 24
hours to last full charge.

Bug: 236101687
Test: manual + make RunSettingsRoboTests
Change-Id: I48097dcaaf7b4100fbd7802940aac7c5ef92ee0b
2022-08-08 03:29:12 +00:00
Thomas Nguyen
874e9def60 Merge "Provide useful hint when invalid SIM PIN is entered during changing SIM PIN" 2022-08-05 20:08:13 +00:00
TreeHugger Robot
52ac9bea7e Merge "Updates battery usage messages from last 24hr to last full charge. (Part2: non-V2 files)" 2022-08-05 18:34:48 +00:00
Zaiyue Xue
693711469d Updates battery usage messages from last 24hr to last full charge. (Part2: non-V2 files)
Test: manual
Bug: 236101166
Change-Id: Id5ad3e859a01d3288a950bf6288eafc6144a23d6
2022-08-05 10:52:38 +08:00
Omer Osman
cb075f9f53 Merge "Add support for selection of Opus in Developer Options" into tm-qpr-dev am: cb930bc0ff am: c0209a6e7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17901372

Change-Id: Id5a9bd7295c995b2e653480d86c6054763766303
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-04 20:03:56 +00:00
Omer Osman
c0209a6e7a Merge "Add support for selection of Opus in Developer Options" into tm-qpr-dev am: cb930bc0ff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/17901372

Change-Id: I5f3658d3d580858c502c8b44ff540723118c2021
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-04 19:00:13 +00:00
Thomas Nguyen
a2b0146d07 Provide useful hint when invalid SIM PIN is entered during changing SIM PIN
Bug: 241441049
Test: Manually tested with Pixel 6 Pro

Change-Id: Ie7239ad397dfeacd59f1483953392ee7935cfd07
2022-08-04 18:58:42 +00:00
TreeHugger Robot
1c3aeeae97 Merge "Revert "Refactor BiometricEnrollBase::onStop()"" 2022-08-04 18:49:20 +00:00
Xinyi Zhou
0e69d78c6f Merge "Revert "Delete Fast Pair Settings"" 2022-08-04 18:01:37 +00:00
Omer Osman
cb930bc0ff Merge "Add support for selection of Opus in Developer Options" into tm-qpr-dev 2022-08-04 17:40:21 +00:00
Sayak Dutta
2d00647cd6 Merge "Update back FooterButton visibility for navigation instead of back button" 2022-08-04 10:29:47 +00:00
Edgar Wang
63b0689171 Apply phrase based line breaking on most of preference. am: 7924108893 am: 300473cea1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/19394738

Change-Id: If72ecbe25be1a10003c4ea630d2fd73c6180c73f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-04 09:55:01 +00:00
TreeHugger Robot
85b03538d0 Merge "Update the selected period message in battery chart" 2022-08-04 09:51:07 +00:00
TreeHugger Robot
753888bed9 Merge "Show one SIM only for EAP-SIM when dual SIMs have the same carrier ID" 2022-08-04 09:50:27 +00:00
TreeHugger Robot
bc52343473 Merge "Updates battery usage messages from last 24hr to last full charge. (Part1: V2 files)" 2022-08-04 09:45:50 +00:00
Edgar Wang
300473cea1 Apply phrase based line breaking on most of preference. am: 7924108893
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/19394738

Change-Id: Id9c984d0d79c25e2b0bb87ab59e3b9642d325b66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-04 09:35:56 +00:00
Milton Wu
da7f6fca7a Revert "Refactor BiometricEnrollBase::onStop()"
This reverts commit 6b6d8c0d6d.

Reason for revert: Should use shouldFinishWhenBackgrounded() to
control the behavior during onStop()

Bug: 197717071
Change-Id: I6aeacd5fb0d4400911a2e3d1567db660a0f1798a
2022-08-04 09:29:26 +00:00
Zaiyue Xue
49e67c9f33 Updates battery usage messages from last 24hr to last full charge. (Part1: V2 files)
Test: manual
Bug: 236101166
Change-Id: I0aa9a1a4c902764bb9937e422e5e7f60b6e86859
2022-08-04 14:59:58 +08:00
Zaiyue Xue
e2087bb5f3 Update the selected period message in battery chart
screenshots: https://drive.google.com/drive/folders/1pxyrmaerZbD2FdEJohnsgqACXXno1Ve5?resourcekey=0-SXu6D9TLvmXDVgVKkZge8Q&usp=sharing
Next cl will change "last 24hr" to "last full charge".

Test: manual
Bug: 236101166
Change-Id: If850d65056add04f0b2ecb6aed418e799ae15fb6
2022-08-04 14:54:53 +08:00
sayakiitg
40e436ff3b Update back FooterButton visibility for navigation instead of back button
Bug: 201252175
Change-Id: I6c99b1173bd8ef90b89dedc49745fdb2bcf11318
2022-08-04 06:23:24 +00:00
Xinyi Zhou
6db89c73d6 Revert "Delete Fast Pair Settings"
This reverts commit 3438e20da1.

Reason for revert: Fast Pair Project is resumed

Test: loaded on device
Change-Id: I54f68794be9c527c5c873e301aada51bcdb6e298
2022-08-03 22:07:07 -07:00
Tiffany Nguyen
0e37ac8d7a Merge "Add Apps > Battery optimization page implementation." 2022-08-03 15:02:11 +00:00
TreeHugger Robot
8d1c50b4dc Merge "Support showing app usage list for two battery charts" 2022-08-03 11:49:26 +00:00
Kuan Wang
b6b6ae4ef0 Always do interpolation for battery level data in daily chart.
Bug: 236101687
Test: make RunSettingsRoboTests
Change-Id: I07ca512ceb7a74da4256f5d6fffed6d2432f89e0
2022-08-03 09:32:22 +00:00
Zaiyue Xue
ba6c435eff Support showing app usage list for two battery charts
Test: manual
Bug: 236101166
Change-Id: I29b4615bd5a967bcfd0a4ab378fec4e700dfc7f0
2022-08-03 08:57:48 +00:00
Edgar Wang
7924108893 Apply phrase based line breaking on most of preference.
Bug: 232992171
Test: manual
Change-Id: I5104e9d30f744f892bd921bffa168488e1c1e625
2022-08-03 04:40:23 +00:00
Weng Su
66922f4870 Show one SIM only for EAP-SIM when dual SIMs have the same carrier ID
- Because the wifiConfiguration save the carrier ID only for EAP-SIM authentication

- If multiple SIMs have the same carrier ID, the Wi-Fi framework will use the default data SIM for EAP-SIM authentication

- To avoid user confusion, show one SIM only when dual SIMs have the same carrier ID

Bug: 233765468
Test: manual test
make RunSettingsRoboTests ROBOTEST_FILTER=WifiConfigController2Test

Change-Id: I56f956d20053d314f082ba185d661d8e0a0ef3cb
2022-08-03 03:33:00 +00:00
Menghan Li
6fd05aa80a Merge "Unify the caption preference class naming" 2022-08-02 22:15:31 +00:00
Tiffany Nguyen
5ecb1a1d69 Add Apps > Battery optimization page implementation.
Moving the old restricted page to the new optimization page will happen
in a follow-up CL.

Test: Unit, manual
Bug: 238026672
Change-Id: I5fee9ebe03284a013da6bfca9ada8b166c6af91c
2022-08-02 18:43:53 +00:00
Eric Biggers
7b0c71fdbc Merge "UserCredentialsSettings: remove unneeded checks for locksettings keys" 2022-08-02 18:07:47 +00:00
Jason Chang
72a1fed542 Merge "Fix RTL issue on fingerprint setup screens in landscape mode" into tm-qpr-dev am: 7546b87a17 am: 0e7374b7ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/19337646

Change-Id: I822db7f74147805a6cd51cf236d2acf1279df023
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-02 08:44:09 +00:00
Jason Chang
0e7374b7ef Merge "Fix RTL issue on fingerprint setup screens in landscape mode" into tm-qpr-dev am: 7546b87a17
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/19337646

Change-Id: Icd787eea9cc845e7ce7a2a102fce09c8e6491fd0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-02 08:17:53 +00:00
Robert Luo
b7666d1eab Merge "Allow advanced VPN to manage connection status via its UI" 2022-08-02 07:24:34 +00:00
Arc Wang
79042f2d28 Merge "Crash happens if back button is pressed during "Format as Portable"" am: 671fa153e8 am: 6945e70c02 am: c80890c7dd am: 85768c5916 am: ee4c9b6a11
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2147940

Change-Id: Icfbb8218dcba3ad95d6d0ba8f9995c4cceb53f65
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-02 04:49:01 +00:00
Arc Wang
ee4c9b6a11 Merge "Crash happens if back button is pressed during "Format as Portable"" am: 671fa153e8 am: 6945e70c02 am: c80890c7dd am: 85768c5916
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Settings/+/2147940

Change-Id: I2ca9ead163513a72e73d10af44df5112c05b61b6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-02 04:30:17 +00:00